Re: Review Request 57981: EU/RU Auto-Retry does not reschedule task when host is not heartbeating before task is scheduled and doesn't have a start time

2017-03-28 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57981/#review170263 --- Ship it! Ship It! - Dmitro Lisnichenko On March 28, 2017, 5:

Re: Review Request 57902: AMBARI-20553 : Ambari script error for ams-hbase while writing to Amazon s3 on a cluster with no HDFS.

2017-03-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57902/#review170264 --- Ship it! Ship It! - Dmytro Sen On None, Aravindan Vijayan wr

Re: Review Request 57968: Prune files contained in jcepolicyinfo.jar to a minimal set

2017-03-28 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57968/#review170266 --- ambari-agent/pom.xml Lines 420 (patched)

Re: Review Request 57981: EU/RU Auto-Retry does not reschedule task when host is not heartbeating before task is scheduled and doesn't have a start time

2017-03-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57981/#review170273 --- Ship it! Ship It! - Nate Cole On March 27, 2017, 10:13 p.m.,

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57966/#review170274 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-28 Thread Balázs Bence Sári
> On March 27, 2017, 3:18 p.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/krb5-conf.xml > > Line 91 (original), 94 (patched) > > > > > > I'm not fami

Review Request 57985: Comparison for configs with list of hostNames doesn't show all hosts correctly

2017-03-28 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57985/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-20602 https://issu

Re: Review Request 57985: Comparison for configs with list of hostNames doesn't show all hosts correctly

2017-03-28 Thread Denys Buzhor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57985/#review170276 --- Ship it! Ship It! - Denys Buzhor On March 28, 2017, 8:50 a.m

Review Request 57986: Prune files contained in zkmigrator.jar to a minimal set

2017-03-28 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57986/ --- Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Laszlo Puskas, R

Re: Review Request 57986: Prune files contained in zkmigrator.jar to a minimal set

2017-03-28 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57986/#review170277 --- Ship it! Ship It! - Attila Doroszlai On March 28, 2017, 10:5

Re: Review Request 57986: Prune files contained in zkmigrator.jar to a minimal set

2017-03-28 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57986/#review170279 --- Ship it! Ship It! - Sebastian Toader On March 28, 2017, 10:5

Re: Review Request 57959: Add (optional) master_kdcs to kerberos-env and generated krb5.conf file

2017-03-28 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57959/#review170281 --- Ship it! Ship It! - Sebastian Toader On March 27, 2017, 4:54

Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1

2017-03-28 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/#review170286 --- Ship it! Ship It! - Pallav Kulshreshtha On March 27, 2017, 1

Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1

2017-03-28 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/#review170288 --- contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/

Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1

2017-03-28 Thread DIPAYAN BHOWMICK
> On March 28, 2017, 10:16 a.m., DIPAYAN BHOWMICK wrote: > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > > Lines 304 (patched) > > > > > > Take this out in a separate c

Review Request 57871: Referenced Kerberos identity definitions should be created and distributed only if the referenced service or component is installed

2017-03-28 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57871/ --- Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Laszlo Puskas, R

Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1

2017-03-28 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/ --- (Updated March 28, 2017, 11:02 a.m.) Review request for Ambari, DIPAYAN BHOWMIC

Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1

2017-03-28 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/#review170294 --- Ship it! Ship It! - Gaurav Nagar On March 28, 2017, 11:02 a.

Re: Review Request 57979: hive view 2.0 handling partition table statistics support added in hive server 2.1

2017-03-28 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57979/#review170295 --- Ship it! Ship It! - DIPAYAN BHOWMICK On March 28, 2017, 11:0

Re: Review Request 57922: Create ambari-infra module in Ambari (move solr modules out from ambari-logsearch)

2017-03-28 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57922/#review170296 --- Ship it! Ship It! - Andrew Onischuk On March 28, 2017, 10:44

Re: Review Request 57871: Referenced Kerberos identity definitions should be created and distributed only if the referenced service or component is installed

2017-03-28 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57871/#review170298 --- Ship it! Ship It! - Sebastian Toader On March 28, 2017, 12:5

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57966/ --- (Updated March 28, 2017, 11:46 a.m.) Review request for Ambari, Attila Doroszla

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57966/#review170300 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57966/ --- (Updated March 28, 2017, 12:14 p.m.) Review request for Ambari, Attila Doroszla

Review Request 57993: AMBARI-20603. Hadoop QA compiles trunk twice

2017-03-28 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57993/ --- Review request for Ambari, Jaimin Jetly, Laszlo Puskas, Sandor Magyari, Sumit Mo

Re: Review Request 57993: AMBARI-20603. Hadoop QA compiles trunk twice

2017-03-28 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57993/#review170307 --- Ship it! Ship It! - Laszlo Puskas On March 28, 2017, 12:15 p

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57966/ --- (Updated March 28, 2017, 12:24 p.m.) Review request for Ambari, Attila Doroszla

Re: Review Request 57993: AMBARI-20603. Hadoop QA compiles trunk twice

2017-03-28 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57993/#review170309 --- Ship it! Ship It! - Sebastian Toader On March 28, 2017, 2:15

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57966/#review170310 --- Ship it! Ship It! - Sebastian Toader On March 28, 2017, 2:24

Re: Review Request 57847: Ambari-server CLI to setup Database Options Broken

2017-03-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57847/ --- (Updated Март 28, 2017, 1:08 п.п.) Review request for Ambari, Alejandro Fernand

Re: Review Request 57981: EU/RU Auto-Retry does not reschedule task when host is not heartbeating before task is scheduled and doesn't have a start time

2017-03-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57981/#review170312 --- Ship it! Ship It! - Jonathan Hurley On March 27, 2017, 10:13

Re: Review Request 57922: Create ambari-infra module in Ambari (move solr modules out from ambari-logsearch)

2017-03-28 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57922/#review170313 --- Ship it! Ship It! - Miklos Gergely On March 28, 2017, 10:44

Re: Review Request 57986: Prune files contained in zkmigrator.jar to a minimal set

2017-03-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57986/#review170314 --- Ship it! Ship It! - Robert Levas On March 28, 2017, 4:54 a.m

Re: Review Request 57966: Validate HIVE dependency on MYSQL_SERVER on blueprint deployments based on the configuration

2017-03-28 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57966/ --- (Updated March 28, 2017, 2:26 p.m.) Review request for Ambari, Attila Doroszlai

Re: Review Request 57968: Prune files contained in jcepolicyinfo.jar to a minimal set

2017-03-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57968/ --- (Updated March 28, 2017, 11:20 a.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 57968: Prune files contained in jcepolicyinfo.jar to a minimal set

2017-03-28 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57968/#review170315 --- Ship it! Ship It! - Attila Magyar On March 28, 2017, 3:20 p.

Re: Review Request 57871: Referenced Kerberos identity definitions should be created and distributed only if the referenced service or component is installed

2017-03-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57871/#review170316 --- Ship it! Ship It! - Robert Levas On March 28, 2017, 6:53 a.m

Re: Review Request 57968: Prune files contained in jcepolicyinfo.jar to a minimal set

2017-03-28 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57968/#review170317 --- Ship it! Ship It! - Eugene Chekanskiy On March 28, 2017, 3:2

Re: Review Request 57847: Ambari-server CLI to setup Database Options Broken

2017-03-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57847/#review170322 --- Ship it! Ship It! - Alejandro Fernandez On March 28, 2017, 1

Re: Review Request 57980: There is a syntax error in install script hence ambari doesn't pick the python 2.7 if system python is not present

2017-03-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57980/#review170323 --- ambari-agent/conf/unix/install-helper.sh Line 92 (original), 92 (

Review Request 58000: Unable to scroll down collapsed navigation bar if it's higher that viewport

2017-03-28 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58000/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramania

Re: Review Request 57980: There is a syntax error in install script hence ambari doesn't pick the python 2.7 if system python is not present

2017-03-28 Thread Attila Doroszlai
> On March 28, 2017, 8:06 p.m., Alejandro Fernandez wrote: > > ambari-agent/conf/unix/install-helper.sh > > Line 92 (original), 92 (patched) > > > > > > This looks very unpythonic. Why isn't this a list of strings as

Re: Review Request 57980: There is a syntax error in install script hence ambari doesn't pick the python 2.7 if system python is not present

2017-03-28 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57980/#review170331 --- Ship it! Ship It! - Attila Doroszlai On March 28, 2017, 3:35

Re: Review Request 57902: AMBARI-20553 : Ambari script error for ams-hbase while writing to Amazon s3 on a cluster with no HDFS.

2017-03-28 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57902/#review170333 --- Ship it! Ship It! - Sid Wagle On None, Aravindan Vijayan wro

Review Request 58002: AMBARI-20592 ServicePresences check should also check for services dropped from a release

2017-03-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58002/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-20592 https://issues

Re: Review Request 58002: AMBARI-20592 ServicePresences check should also check for services dropped from a release

2017-03-28 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58002/#review170336 --- Ship it! Ship It! - Tim Thorpe On March 28, 2017, 8:04 p.m.,

Review Request 58003: Add disable security option to infra-solr-client

2017-03-28 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58003/ --- Review request for Ambari, Attila Magyar, Miklos Gergely, Robert Levas, and Robe

Re: Review Request 57980: There is a syntax error in install script hence ambari doesn't pick the python 2.7 if system python is not present

2017-03-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57980/#review170338 --- Ship it! Ship It! - Alejandro Fernandez On March 28, 2017, 1

Re: Review Request 57980: There is a syntax error in install script hence ambari doesn't pick the python 2.7 if system python is not present

2017-03-28 Thread Alejandro Fernandez
> On March 28, 2017, 6:06 p.m., Alejandro Fernandez wrote: > > ambari-agent/conf/unix/install-helper.sh > > Line 92 (original), 92 (patched) > > > > > > This looks very unpythonic. Why isn't this a list of strings as

Re: Review Request 58002: AMBARI-20592 ServicePresences check should also check for services dropped from a release

2017-03-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58002/#review170340 --- ambari-server/src/main/java/org/apache/ambari/server/checks/Servi

Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-28 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58006/ --- Review request for Ambari, Dmytro Sen, Robert Levas, Sumit Mohanty, and Sid Wagl

Review Request 58007: AMBARI-20613 - Host Filtering interaction is confusing and cumbersome to perform simple filtering

2017-03-28 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58007/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-20613 https://issues.ap

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-28 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58006/#review170345 --- Ship it! Ship It! - Sid Wagle On March 28, 2017, 10:03 p.m.,

Re: Review Request 58007: AMBARI-20613 - Host Filtering interaction is confusing and cumbersome to perform simple filtering

2017-03-28 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58007/#review170346 --- Ship it! Ship It! - Xi Wang On March 28, 2017, 3:14 p.m., Ri

Review Request 58009: Fetching running application logs results in 'java.io.IOException'

2017-03-28 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty

Re: Review Request 58009: Fetching running application logs results in 'java.io.IOException'

2017-03-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/#review170349 --- ambari-server/src/main/java/org/apache/ambari/server/serveraction

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58006/#review170350 --- Fix it, then Ship it! Ship It! ambari-common/src/main/python/

Re: Review Request 58009: Fetching running application logs results in 'java.io.IOException'

2017-03-28 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/ --- (Updated March 29, 2017, 12:06 a.m.) Review request for Ambari, Alejandro Ferna

Re: Review Request 58009: Fetching running application logs results in 'java.io.IOException'

2017-03-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/#review170351 --- ambari-server/src/main/java/org/apache/ambari/server/serveraction

Re: Review Request 58009: Fetching running application logs results in 'java.io.IOException'

2017-03-28 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/ --- (Updated March 29, 2017, 12:20 a.m.) Review request for Ambari, Alejandro Ferna

Re: Review Request 58009: Fetching running application logs results in 'java.io.IOException'

2017-03-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/#review170352 --- Ship it! Ship It! - Alejandro Fernandez On March 29, 2017, 1

Review Request 58016: Auto-Start Services Switch button broken

2017-03-28 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58016/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramania

Re: Review Request 58016: Auto-Start Services Switch button broken

2017-03-28 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58016/#review170355 --- Ship it! Ship It! - Richard Zang On March 29, 2017, 1:34 a.m

Re: Review Request 58009: Fetching running application logs results in 'java.io.IOException'

2017-03-28 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/#review170356 --- Ship it! Ship It! - Jayush Luniya On March 29, 2017, 12:20 a

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-28 Thread Aravindan Vijayan
> On March 28, 2017, 11:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > > > > > Maybe there should be a flag so that the caller

Re: Review Request 58006: AMBARI-20600 : AMS grafana restart fails with ssl error after upgrading from 2.4.2.0

2017-03-28 Thread Sid Wagle
> On March 28, 2017, 11:57 p.m., Robert Levas wrote: > > ambari-common/src/main/python/ambari_commons/network.py > > Lines 65-66 (original), 64-65 (patched) > > > > > > Maybe there should be a flag so that the caller