Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review188982 --- Ship it! Ship It! - Stephan Erb On Oct. 23, 2017, 4:14 p.m.,

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review188940 --- Ship it! Master (dbe9a52) is green with this patch. ./build-s

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-23 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/ --- (Updated Oct. 23, 2017, 2:14 p.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review188074 --- Ship it! Master (2aee90d) is green with this patch. ./build-s

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-14 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/ --- (Updated Oct. 14, 2017, 11:29 p.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-14 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review188068 --- Master (2aee90d) is red with this patch. ./build-support/jenkins

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-14 Thread Mauricio Garavaglia
> On Oct. 12, 2017, 8:08 p.m., Stephan Erb wrote: > > Looks good to me in general. > > > > We'll need to update the docs as well. Please: > > > > * Add a section to the RELEASE-NOTES to indicate that scheduler > > environments are now configurable on the scheduler side > > * Update the docs. I

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-14 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/ --- (Updated Oct. 14, 2017, 2:55 p.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-12 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review187857 --- Looks good to me in general. We'll need to update the docs as wel

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-12 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review187839 --- Fix it, then Ship it! src/main/java/org/apache/aurora/schedule

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-12 Thread Mohit Jaggi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review187829 --- Ship it! Ship It! - Mohit Jaggi On Oct. 12, 2017, 6:20 p.m.,

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review187828 --- This patch does not apply cleanly against master (519e3df), do you

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-12 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/ --- (Updated Oct. 12, 2017, 6:20 p.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-11 Thread Mohit Jaggi
> On Sept. 29, 2017, 5:38 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > > Lines 108 (patched) > > > > > > I would find this easier to read and more flexible: > > > >

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-11 Thread Stephan Erb
> On Sept. 29, 2017, 7:38 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > > Lines 108 (patched) > > > > > > I would find this easier to read and more flexible: > > > >

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-11 Thread Mauricio Garavaglia
> On Sept. 29, 2017, 5:38 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > > Lines 108 (patched) > > > > > > I would find this easier to read and more flexible: > > > >

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-05 Thread Mohit Jaggi
> On Oct. 3, 2017, 9:49 p.m., Stephan Erb wrote: > > Sorry for jumping in so late. > > > > We have had discussions and some work on this previously (see > > https://issues.apache.org/jira/browse/AURORA-319). I do therefore think it > > makes sense to change the scheduler side to a generic rege

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-03 Thread Stephan Erb
> On Sept. 29, 2017, 7:38 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > > Lines 108 (patched) > > > > > > I would find this easier to read and more flexible: > > > >

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-03 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review187011 --- Sorry for jumping in so late. We have had discussions and some wo

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review186807 --- Ship it! Master (24d2caf) is green with this patch. ./build-s

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-01 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/ --- (Updated Oct. 1, 2017, 3:36 p.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-10-01 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review186798 --- Ship it! +1 for thin client/fat server. Thanks for the patch!

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-09-30 Thread Bill Farner
> On Sept. 29, 2017, 10:38 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > > Lines 108 (patched) > > > > > > I would find this easier to read and more flexible: > > >

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-09-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review186783 --- Master (24d2caf) is red with this patch. ./build-support/jenkins

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-09-30 Thread Mauricio Garavaglia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/ --- (Updated Sept. 30, 2017, 3:04 p.m.) Review request for Aurora and Stephan Erb.

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-09-30 Thread Mauricio Garavaglia
> On Sept. 29, 2017, 5:38 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > > Lines 108 (patched) > > > > > > I would find this easier to read and more flexible: > > > >

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-09-29 Thread Bill Farner
> On Sept. 29, 2017, 10:38 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > > Lines 108 (patched) > > > > > > I would find this easier to read and more flexible: > > >

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-09-29 Thread Mauricio Garavaglia
> On Sept. 29, 2017, 5:38 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > > Lines 108 (patched) > > > > > > I would find this easier to read and more flexible: > > > >

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-09-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review186700 --- src/main/java/org/apache/aurora/scheduler/app/AppModule.java Line

Re: Review Request 62692: Move job environment validation to the scheduler.

2017-09-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62692/#review186687 --- Master (7a80373) is red with this patch. ./build-support/jenkins