Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

> On Dec. 22, 2016, 10:54 a.m., David McLaughlin wrote: > > Ship It! This has been merged to master. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159944 --

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159944 --- Ship it! Ship It! - David McLaughlin On Dec. 22, 2016, 6:49

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159934 --- Ship it! Ship It! - Stephan Erb On Dec. 22, 2016, 7:49 a.m.,

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159929 --- Master (38b9311) is green with this patch. ./build-support/jenki

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/ --- (Updated Dec. 21, 2016, 10:49 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

> On Dec. 21, 2016, 6:26 p.m., David McLaughlin wrote: > > src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java, > > lines 97-98 > > > > > > Inline? This was originally inline but threw PMD

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159914 --- src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCo

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159903 --- Master (38b9311) is green with this patch. ./build-support/jenki

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/ --- (Updated Dec. 21, 2016, 5:11 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

> On Dec. 21, 2016, 4:33 p.m., Aurora ReviewBot wrote: > > Master (38b9311) is red with this patch. > > ./build-support/jenkins/build.sh > > > > at > > org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120) > > at > > org.gradle.launcher

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159894 --- Master (38b9311) is red with this patch. ./build-support/jenkins

Re: Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/#review159893 --- Ship it! LGTM modulo my `Stats` vs `StatsProvider` comment. s

Review Request 54959: AURORA-1842 Expose stats on garbage collected rows in RowGarbageCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54959/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1842