[Impala-ASF-CR] IMPALA-5058: Improve the concurrency of DDL/DML operations

2017-12-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8752 ) Change subject: IMPALA-5058: Improve the concurrency of DDL/DML operations .. Patch Set 1: (27 comments)

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. Patch Set 1: (11 comments)

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-11 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: Code-Review-1 (2 comments) Currently I count

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots

2017-12-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5014: Part 1: Round when casting string to decimal

2017-12-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8774 ) Change subject: IMPALA-5014: Part 1: Round when casting string to decimal .. IMPALA-5014: Part 1: Round when casting string to

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. Patch Set 7: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 3: (5 comments) > Patch Set 3: > > (5 comments)

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-11 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8782 to look at the new patch set (#2). Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker ..

[Impala-ASF-CR] [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI.

2017-12-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8529 ) Change subject: [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI. .. Patch Set 3: Code-Review+1 (6 comments) mostly

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-12-11 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 5: Looks like the slow down is due to the 2x

[Impala-ASF-CR] IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT

2017-12-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adopt Oracle-style hint placement for INSERT/UPSERT .. Patch Set 1: (7 comments) Thanks for the change!

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-12-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: I played around a bit with inducing crashes in my dev

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 4: (18 comments)

[Impala-ASF-CR] IMPALA-6270: create Impala parent pom

2017-12-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8753 ) Change subject: IMPALA-6270: create Impala parent pom .. Patch Set 1: > Patch Set 1: > > Build started:

[Impala-ASF-CR] Add 'lsof' to bootstrap system.

2017-12-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8813 ) Change subject: Add 'lsof' to bootstrap_system. .. Patch Set 1: Build started:

[Impala-ASF-CR] Add 'lsof' to bootstrap system.

2017-12-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8813 ) Change subject: Add 'lsof' to bootstrap_system. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8813

[Impala-ASF-CR] IMPALA-5191: Behavior of column aliases should be more standard conforming

2017-12-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Behavior of column aliases should be more standard conforming .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots

2017-12-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8807 ) Change subject: IMPALA-6301: Fix test failures when username or group name contains dots .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8782 ) Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-12-11 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8569 to look at the new patch set (#9). Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function.

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-11 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#3). Change subject: IMPALA-4993: extend dictionary filtering to collections ..

[Impala-ASF-CR] IMPALA-6301: Fix test failures when username or group name contains dots

2017-12-11 Thread Quanlong Huang (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8807 to look at the new patch set (#3). Change subject: IMPALA-6301: Fix test failures when username or group name contains dots

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2017-12-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6270: create Impala parent pom

2017-12-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8753 ) Change subject: IMPALA-6270: create Impala parent pom .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5058: Improve the concurrency of DDL/DML operations

2017-12-11 Thread Dimitris Tsirogiannis (Code Review)
Hello Tianyi Wang, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8752 to look at the new patch set (#2). Change subject: IMPALA-5058: Improve the concurrency of DDL/DML operations

[Impala-ASF-CR] Add 'lsof' to bootstrap system.

2017-12-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8813 Change subject: Add 'lsof' to bootstrap_system. .. Add 'lsof' to bootstrap_system. "be/src/kudu/security/test/mini_kdc.cc" uses lsof,

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. IMPALA-6245: Tolerate column indenting from Hive

[Impala-ASF-CR] IMPALA-4664: Unexpected string conversion in Shell

2017-12-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8639 ) Change subject: IMPALA-4664: Unexpected string conversion in Shell .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 3: planner tests: adds a test and updates where

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-12-11 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8569 to look at the new patch set (#7). Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function.

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-12-11 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8569 to look at the new patch set (#8). Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function.

[Impala-ASF-CR] IMPALA-5310: Part 2: Add SAMPLED NDV() function.

2017-12-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8569 ) Change subject: IMPALA-5310: Part 2: Add SAMPLED_NDV() function. .. Patch Set 7: Code-Review+2 -- To view, visit

[native-toolchain-CR] Prepare to move automated toolchain builds to a new environment

2017-12-11 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8787 ) Change subject: Prepare to move automated toolchain builds to a new environment .. Prepare to move automated toolchain builds to

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 4: Code-Review+1 LGTM -- To view, visit

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 3: (1 comment) Serves me right for editing the output.

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6297: Don't partition/sort for DML on unpartitioned Kudu table

2017-12-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8810 ) Change subject: IMPALA-6297: Don't partition/sort for DML on unpartitioned Kudu table .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-11 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#2). Change subject: IMPALA-4993: extend dictionary filtering to collections ..

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-11 Thread Bikramjeet Vig (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8660 to look at the new patch set (#3). Change subject: IMPALA-5929: Remove redundant explicit casts to string

[native-toolchain-CR] Prepare to move automated toolchain builds to a new environment

2017-12-11 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/8787 ) Change subject: Prepare to move automated toolchain builds to a new environment .. Patch Set 1: Please note that

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2017-12-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 1: (19 comments) thx for the reviews.

[Impala-ASF-CR] IMPALA-5848: Account for TCMalloc overhead in MemTracker

2017-12-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8782 ) Change subject: IMPALA-5848: Account for TCMalloc overhead in MemTracker .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-11 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8660 ) Change subject: IMPALA-5929: Remove redundant explicit casts to string .. Patch Set 2: (11 comments)

[Impala-ASF-CR] [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI.

2017-12-11 Thread Dimitris Tsirogiannis (Code Review)
Hello Bharath Vissapragada, Philip Zeyliger, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8529 to look at the new patch set (#3). Change subject: [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI.

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2017-12-11 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 2: The details about 0/1 <=> Booleans and bad

[Impala-ASF-CR] IMPALA-5929: Remove redundant explicit casts to string

2017-12-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8660 ) Change subject: IMPALA-5929: Remove redundant explicit casts to string .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread John Russell (Code Review)
Hello Greg Rahn, sandeep akinapelli, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8768 to look at the new patch set (#3). Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function

[Impala-ASF-CR] IMPALA-5317: [DOCS] Doc for DATE TRUNC() function

2017-12-11 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8768 ) Change subject: IMPALA-5317: [DOCS] Doc for DATE_TRUNC() function .. Patch Set 2: (3 comments)

[Impala-ASF-CR] [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI.

2017-12-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8529 ) Change subject: [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI. .. Patch Set 2: (28 comments) Thanks for

[Impala-ASF-CR] IMPALA-6297: Don't partition/sort for DML on unpartitioned Kudu table

2017-12-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8810 Change subject: IMPALA-6297: Don't partition/sort for DML on unpartitioned Kudu table .. IMPALA-6297: Don't partition/sort for

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Zach Amsden (Code Review)
Hello Philip Zeyliger, David Knupp, Joe McDonnell, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8719 to look at the new patch set (#7). Change subject: IMPALA-6245: Tolerate column indenting from Hive

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-6245: Tolerate column indenting from Hive

2017-12-11 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/8719 ) Change subject: IMPALA-6245: Tolerate column indenting from Hive .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6298: Skip test profile fragment instances on local filesystem

2017-12-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8809 ) Change subject: IMPALA-6298: Skip test_profile_fragment_instances on local filesystem .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6298: Skip test profile fragment instances on local filesystem

2017-12-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8809 ) Change subject: IMPALA-6298: Skip test_profile_fragment_instances on local filesystem .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6298: Skip test profile fragment instances on local filesystem

2017-12-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8809 Change subject: IMPALA-6298: Skip test_profile_fragment_instances on local filesystem .. IMPALA-6298: Skip

[Impala-ASF-CR] IMPALA-5191: Behavior of column aliases should be more standard conforming

2017-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Taras Bobrovytsky, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8801 to look at the new patch set (#3). Change subject: IMPALA-5191: Behavior of column aliases should be more standard conforming

[Impala-ASF-CR] IMPALA-5191: Behavior of column aliases should be more standard conforming

2017-12-11 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8801 to look at the new patch set (#2). Change subject: IMPALA-5191: Behavior of column aliases should be more standard conforming

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 17: (1 comment) > Fixed. Build failure happened due to

[native-toolchain-CR] Prepare to move automated toolchain builds to a new environment

2017-12-11 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/8787 ) Change subject: Prepare to move automated toolchain builds to a new environment .. Patch Set 1: Changes have been verified on our

[native-toolchain-CR] Prepare to move automated toolchain builds to a new environment

2017-12-11 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/8787 ) Change subject: Prepare to move automated toolchain builds to a new environment .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-11 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 9: (3 comments) Thanks for your advice.

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-11 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#9). Change subject: IMPALA-2640: Make a given command case-sensitive

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 8: (1 comment) Thanks for reacting so quickly. I

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-11 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-11 Thread Kim Jin Chul (Code Review)
Hello John Russell, Andre Araujo, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8762 to look at the new patch set (#8). Change subject: IMPALA-2640: Make a given command case-sensitive

[Impala-ASF-CR] IMPALA-2640: Make a given command case-sensitive

2017-12-11 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8762 ) Change subject: IMPALA-2640: Make a given command case-sensitive .. Patch Set 7: (2 comments) Thank you for working on my

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-11 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: (6 comments) Thanks for your answers.

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2017-12-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 6: (5 comments) Thanks for the explanation!

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-11 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 ) Change subject: IMPALA-5754: Improve randomness of rand()/random() .. Patch Set 17: Fixed. Build failure happened due to missing

[Impala-ASF-CR] IMPALA-5754: Improve randomness of rand()/random()

2017-12-11 Thread Kim Jin Chul (Code Review)
Hello Michael Ho, Jim Apple, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8355 to look at the new patch set (#17). Change subject: IMPALA-5754: Improve randomness of rand()/random()

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-11 Thread Kim Jin Chul (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8747 to look at the new patch set (#5). Change subject: IMPALA-5993: Fix the file offset in value parsing error ..