[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-01-25 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 7: (5 comments) Applied the update. @Gabor, I am

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-01-25 Thread Kim Jin Chul (Code Review)
Hello Gabor Kaszab, Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8508 to look at the new patch set (#7). Change subject: IMPALA-5237: Support a quoted string in date/time format

[Impala-ASF-CR] IMPALA-3203: Part 1: Free list implementation

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/6410 ) Change subject: IMPALA-3203: Part 1: Free list implementation .. Patch Set 11: Build started: https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 8: Verified-1 Build failed: https://jenkins.i

[native-toolchain-CR] Build old versions of gperftools and thrift.

2018-01-25 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/9120 ) Change subject: Build old versions of gperftools and thrift. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9120 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 2: Verified-1 Build fail

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 4: Code-Review+1 carry the +1 from Bikram. any takers to +

[Impala-ASF-CR] IMPALA-6441: update explain string for stress test

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9141 ) Change subject: IMPALA-6441: update explain string for stress test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-6441: update explain string for stress test

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9141 ) Change subject: IMPALA-6441: update explain string for stress test .. IMPALA-6441: update explain string for stress test

[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-25 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9030 ) Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: > In addition to the text that w

[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-25 Thread Kim Jin Chul (Code Review)
Hello John Russell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9030 to look at the new patch set (#2). Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT ..

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 ) Change subject: IMPALA-6410: compare_branches: use looser expression .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-25 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 8: (4 comments) Applied the update. http://gerrit.cloude

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-25 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#9). Change subject: IMPALA-3193: Show table's comment on show tables .. IMPA

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 ) Change subject: IMPALA-6410: compare_branches: use looser expression .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, Lars Volker, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9135 to look at the new patch set (#3). Change subject: IMPALA-6410: compare_branches: use looser expression

[native-toolchain-CR] Bump Kudu version to c6beta-impala-toolchain-tag1

2018-01-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9086 ) Change subject: Bump Kudu version to c6beta-impala-toolchain-tag1 .. Patch Set 2: I think we want to keep the master branch buildable

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 12: (10 comments) Sorry for the delay here. This

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-01-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8997 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Patch Set 3: Code-Review+1 (1 comment) The change LGTM. The

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/8914

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 11: Thanks for the reviews, Michael. I removed the helper

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-25 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8914 to look at the new patch set (#11). Change subject: IMPALA-6193: Track memory of incoming data streams .

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-01-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 5: (16 comments) http://

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 8: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 8: Code-Review+2 Thanks for the review. Rebase, carr

[native-toolchain-CR](cdh5.x) IMPALA-6401 : Re-apply the PPC Breakpad patches

2018-01-25 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9142 ) Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches .. IMPALA-6401 : Re-apply the PPC Breakpad patches Thi

[native-toolchain-CR](cdh5.x) IMPALA-6401 : Re-apply the PPC Breakpad patches

2018-01-25 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9142 ) Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cl

[native-toolchain-CR](cdh5.x) IMPALA-6401 : Re-apply the PPC Breakpad patches

2018-01-25 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9142 ) Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches .. Patch Set 1: Code-Review+2 This is just to cherry-pick onto

[native-toolchain-CR](cdh5.x) IMPALA-6401 : Re-apply the PPC Breakpad patches

2018-01-25 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9142 Change subject: IMPALA-6401 : Re-apply the PPC Breakpad patches .. IMPALA-6401 : Re-apply the PPC Breakpad patches This change

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-01-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-01-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8825/8/f

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-01-25 Thread Tianyi Wang (Code Review)
Hello Philip Zeyliger, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8825 to look at the new patch set (#9). Change subject: IMPALA-5990: End-to-end compression of metadata .

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 2: Build started: https:

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 2: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-01-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-25 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-6441: update explain string for stress test

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9141 ) Change subject: IMPALA-6441: update explain string for stress test .. Patch Set 1: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 8: (4 comments) Thanks for the quick iteration.

[Impala-ASF-CR] IMPALA-6441: update explain string for stress test

2018-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9141 ) Change subject: IMPALA-6441: update explain string for stress test .. Patch Set 1: Code-Review+2 Thanks for fixing and sorry for breaki

[Impala-ASF-CR] IMPALA-6441: update explain string for stress test

2018-01-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9141 ) Change subject: IMPALA-6441: update explain string for stress test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/914

[Impala-ASF-CR] IMPALA-6441: update explain string for stress test

2018-01-25 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9141 Change subject: IMPALA-6441: update explain string for stress test .. IMPALA-6441: update explain string for stress test - Update the ex

[Impala-ASF-CR] IMPALA-6377: Bump breakpad version to include the fix for Breakpad #752

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9131 ) Change subject: IMPALA-6377: Bump breakpad version to include the fix for Breakpad #752 .. Patch Set 1: Verified+1 -- To view

[Impala-ASF-CR] IMPALA-6377: Bump breakpad version to include the fix for Breakpad #752

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9131 ) Change subject: IMPALA-6377: Bump breakpad version to include the fix for Breakpad #752 .. IMPALA-6377: Bump breakpad v

[Impala-ASF-CR] IMPALA-6440: Backwards compatibility for HBase metadata

2018-01-25 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. ( http://gerrit.cloudera.org:8080/9124 ) Change subject: IMPALA-6440: Backwards compatibility for HBase metadata .. Abandoned Looks like the Hive change is going to be reverted; no longer

[Impala-ASF-CR] IMPALA-6440: Backwards compatibility for HBase metadata

2018-01-25 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9124 ) Change subject: IMPALA-6440: Backwards compatibility for HBase metadata .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6410: Use subprocess in compare branches.py.

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9130 ) Change subject: IMPALA-6410: Use subprocess in compare_branches.py. .. IMPALA-6410: Use subprocess in compare_branches.p

[Impala-ASF-CR] IMPALA-6410: Use subprocess in compare branches.py.

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9130 ) Change subject: IMPALA-6410: Use subprocess in compare_branches.py. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-25 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9140 Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns .. IMPALA-6311: Skip row groups with predicates on NULL colum

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 ) Change subject: IMPALA-6410: compare_branches: use looser expression .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 ) Change subject: IMPALA-6410: compare_branches: use looser expression .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, Lars Volker, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9135 to look at the new patch set (#2). Change subject: IMPALA-6410: compare_branches: use looser expression

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-01-25 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9139 Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. IMPALA-6228: Control stats extrapolation via tbl prop. Introduces

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/8914

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-01-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. Patch Set 8: (14 comments) http://gerrit.cloudera.org:8080/#/c/8825/6

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-01-25 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. IMPALA-5990: End-to-end compression of metadata Currently the catalog da

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-25 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8950 to look at the new patch set (#7). Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr ..

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9113 ) Change subject: IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE .. Patch Set 1: (5 comments) looks good, just a couple of

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6377: Bump breakpad version to include the fix for Breakpad #752

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9131 ) Change subject: IMPALA-6377: Bump breakpad version to include the fix for Breakpad #752 .. Patch Set 1: Build started: https:/

[Impala-ASF-CR] IMPALA-6377: Bump breakpad version to include the fix for Breakpad #752

2018-01-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9131 ) Change subject: IMPALA-6377: Bump breakpad version to include the fix for Breakpad #752 .. Patch Set 1: Passed a private exhaustive buil

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 ) Change subject: IMPALA-6410: compare_branches: use looser expression .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9135 Change subject: IMPALA-6410: compare_branches: use looser expression .. IMPALA-6410: compare_branches: use looser expression We've alr

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 9: (1 comment) Thanks fo

[Impala-ASF-CR] IMPALA-6410: Use subprocess in compare branches.py.

2018-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9130 ) Change subject: IMPALA-6410: Use subprocess in compare_branches.py. .. Patch Set 1: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-6410: Use subprocess in compare branches.py.

2018-01-25 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9130 ) Change subject: IMPALA-6410: Use subprocess in compare_branches.py. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-01-25 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 ) Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function .. Patch Set 1: (5 comments) Applied the update. http://gerrit.clou

[Impala-ASF-CR] IMPALA-3651: [DOCS] Doc for MURMUR HASH() function

2018-01-25 Thread Kim Jin Chul (Code Review)
Hello John Russell, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9031 to look at the new patch set (#2). Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. IMPALA-3562: support column restriction for compute stats Th

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9133 Change subject: IMPALA-3562: support column restriction for compute stats .. IMPALA-3562: support column restriction for compute stats T