[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 5: (2 comments) Addressed the comments. Removed the remaining e

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-06 Thread Philip Zeyliger (Code Review)
Hello Jim Apple, Dimitris Tsirogiannis, Alex Behm, Zach Amsden, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#6). Change subject: IMPALA-6204: Remove external DataSource ..

[Impala-ASF-CR] IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9228 ) Change subject: IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog .. Patch Set 1: Verified-1 Build failed

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Force inlining of BloomFilter::MakeMask I noticed that this

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Se

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC ..

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. IMPALA-6392: Consistent explain format for par

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 11: Code-Review+1 Carrying Vuk's +

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 10: Code-Review+1 Carrying Vuk's +

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. IMPALA-6392: Consistent explain format for par

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 9: Code-Review+1 (2 comments) Car

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. IMPALA-6392: Consistent explain format for parq

[Impala-ASF-CR](2.x) IMPALA-6228: Control stats extrapolation via tbl prop.

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9231 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 1: Verified-1 Build failed: https://jenkins

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 16: Rebased and fixed some minor merge conflicts.

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 24: Code-Review+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. Patch Set 22: Code-Review+2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-06 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#16). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPA

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-06 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8707 to look at the new patch set (#24). Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-02-06 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#22). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation ...

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9228 ) Change subject: IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog .. Patch Set 1: Build started: https://

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-ver

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 8: (2 comments) Nice! http://gerrit

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-02-06 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#13). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPA

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Se

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Set 5: Cod

[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9226 ) Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption" .. Patch Set 1: Verified+1 -- To view, visit ht

[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9226 ) Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption" .. Revert "IMPALA-6219: Use AES-GCM for s

[Impala-ASF-CR] IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart

2018-02-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9232 Change subject: IMPALA-6486: Fix INVALIDATE METADATA hang after statestore restart .. IMPALA-6486: Fix INVALIDATE METADATA hang

[Impala-ASF-CR] IMPALA-6424: Avoid loading metadata twice when refreshing unloaded tables

2018-02-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9224 ) Change subject: IMPALA-6424: Avoid loading metadata twice when refreshing unloaded tables .. Patch Set 1: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9225 ) Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 1: Build started: https://j

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2018-02-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9225 ) Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 1: > It looks like the old patch a

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 10: (10 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-06 Thread Bikramjeet Vig (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8971 to look at the new patch set (#10). Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 9: (8 comments) http://gerrit.c

[Impala-ASF-CR](2.x) IMPALA-6228: Control stats extrapolation via tbl prop.

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9231 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 1: Build started: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-5037: Default PARQUET ARRAY RESOLUTION=THREE LEVEL

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9210 ) Change subject: IMPALA-5037: Default PARQUET_ARRAY_RESOLUTION=THREE_LEVEL .. Patch Set 3: Verified+1 -- To view, visit http://

[Impala-ASF-CR] IMPALA-5037: Default PARQUET ARRAY RESOLUTION=THREE LEVEL

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9210 ) Change subject: IMPALA-5037: Default PARQUET_ARRAY_RESOLUTION=THREE_LEVEL .. IMPALA-5037: Default PARQUET_ARRAY_RESOLUTI

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Patch Set 2: (2 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog

2018-02-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/9228 ) Change subject: IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog .. Patch Set 1: Code-Review+2 -- To vi

[Impala-ASF-CR](2.x) IMPALA-6228: Control stats extrapolation via tbl prop.

2018-02-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9231 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface .. Patch Set 3: This fell off my radar - I was ignored it sin

[Impala-ASF-CR](2.x) IMPALA-6228: Control stats extrapolation via tbl prop.

2018-02-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9231 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/923

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 9: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR](2.x) IMPALA-6228: Control stats extrapolation via tbl prop.

2018-02-06 Thread Alex Behm (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9231 to review the following change. Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. IM

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Set 4: Cod

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-06 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9186 to look at the new patch set (#4). Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC ...

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-06 Thread Anonymous Coward (Code Review)
xyutin...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 10: Patch 10 stressed on the comment

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-06 Thread Anonymous Coward (Code Review)
xyutin...@cloudera.com has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. IMPALA-5440 Add planner tests with extreme stati

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Set 3: Code-R

[Impala-ASF-CR] IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog

2018-02-06 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9228 Change subject: IMPALA-6478: Remove garbage NativeAddPendingTopicItem log from catalog .. IMPALA-6478: Remove garbage NativeAddPendingTopi

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 5: Code-Review+1 > Patch Set 4: Code

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 8: Code-Review+1 > (1 comment) car

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. IMPALA-6392: Consistent explain format for parq

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 7: Code-Review+1 (1 comment) htt

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. IMPALA-5269: Fix issue with final line of query f

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. IMPALA-6392: Consistent explain format for parq

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 7: (3 comments) http://gerrit.clo

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-ver

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 3: I did set them - the benchmark complains otherwise. It is a bit

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/92

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 3: > On my system after: > > With AVX2: > > insert:

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 5: (1 comment) ht

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 5: (3 comments) h

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Hello Jim Apple, Mostafa Mokhtar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9214 to look at the new patch set (#3). Change subject: Force inlining of BloomFilter::MakeMask .. Force in

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 2: On my system after: With AVX2: insert:Fun

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 2: The speedup was pretty significant on the benchmark. On my sys

[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9226 ) Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption" .. Patch Set 1: Build started: https://jenkins.i

[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"

2018-02-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9226 ) Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption" .. Patch Set 1: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-6396: Exchange node's memory usage should include its receiver's

2018-02-06 Thread Michael Ho (Code Review)
Michael Ho has removed Lars Volker from this change. ( http://gerrit.cloudera.org:8080/9202 ) Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's .. Removed reviewer Lars Volker. -- To view

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-06 Thread Sailesh Mukil (Code Review)
Hello Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8363 to look at the new patch set (#5). Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_

[Impala-ASF-CR] IMPALA-4456: Address scalability issues of qs map lock and client request state map lock

2018-02-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8363 ) Change subject: IMPALA-4456: Address scalability issues of qs_map_lock_ and client_request_state_map_lock_ .. Patch Set 5: (3 comments

[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"

2018-02-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9226 ) Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption" .. Patch Set 1: I believe this is breaking all builds becaus

[Impala-ASF-CR] Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption"

2018-02-06 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9226 Change subject: Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encryption" .. Revert "IMPALA-6219: Use AES-GCM for spill-to-disk encrypti

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2018-02-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9225 ) Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 1: Code-Review+2 It looks like the

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 5: (3 comments) http://gerrit.cl

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 5: > > Was there ever an announcement that this was deprecated? > >

[Impala-ASF-CR] IMPALA-5037: Default PARQUET ARRAY RESOLUTION=THREE LEVEL

2018-02-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9210 ) Change subject: IMPALA-5037: Default PARQUET_ARRAY_RESOLUTION=THREE_LEVEL .. Patch Set 3: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-5037: Default PARQUET ARRAY RESOLUTION=THREE LEVEL

2018-02-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9210 ) Change subject: IMPALA-5037: Default PARQUET_ARRAY_RESOLUTION=THREE_LEVEL .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-5037: Default PARQUET ARRAY RESOLUTION=THREE LEVEL

2018-02-06 Thread Alex Behm (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9210 to look at the new patch set (#3). Change subject: IMPALA-5037: Default PARQUET_ARRAY_RESOLUTION=THREE_LEVEL .. IMP

[Impala-ASF-CR] IMPALA-5037: Default PARQUET ARRAY RESOLUTION=THREE LEVEL

2018-02-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9210 ) Change subject: IMPALA-5037: Default PARQUET_ARRAY_RESOLUTION=THREE_LEVEL .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2018-02-06 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9225 Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. IMPALA-4795: Allow fetching function obj from

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9186 ) Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC .. Patch Set 3: (3

[Impala-ASF-CR] IMPALA-6456: Add flags to configure rpc negotiation timeout ms and negotiation thread count in KRPC

2018-02-06 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9186 to look at the new patch set (#3). Change subject: IMPALA-6456: Add flags to configure rpc_negotiation_timeout_ms and negotiation thread count in KRPC ...

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 5: (9 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. IMPALA-6392: Consistent explain format for parq

[Impala-ASF-CR] IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 14: Code-Review+1 This looks okay to me. I focus

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9192/5/common/thri

[Impala-ASF-CR] IMPALA-6392: Explain format for parquet predicate statistics should be consistent with predicates

2018-02-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Explain format for parquet predicate statistics should be consistent with predicates .. Patch Set 2: My us

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-02-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 9: (15 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6392: Explain format for parquet predicate statistics should be consistent with predicates

2018-02-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Explain format for parquet predicate statistics should be consistent with predicates .. Patch Set

[Impala-ASF-CR] IMPALA-6424: Avoid loading metadata twice when refreshing unloaded tables

2018-02-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9224 Change subject: IMPALA-6424: Avoid loading metadata twice when refreshing unloaded tables .. IMPALA-6424: Avoid loading metadata

[Impala-ASF-CR] IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool

2018-02-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8971 ) Change subject: IMPALA-5519: Allocate fragment's runtime filter memory from Buffer pool .. Patch Set 9: (8 comments) http://g

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 5: > Was there ever an announcement that this was deprecated? Is http

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-06 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 5: (2 comments) Maybe also manually test that the various SQL related

[Impala-ASF-CR] Force inlining of BloomFilter::MakeMask

2018-02-06 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/9214 ) Change subject: Force inlining of BloomFilter::MakeMask .. Patch Set 2: Code-Review+1 Just for sanity checking, did you run bloom-filter-be

  1   2   >