[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create/drop function statements

2018-03-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create/drop function statements .. Patch Set 6: (6 comments) The

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Michael Ho (Code Review)
Hello Lars Volker, Mostafa Mokhtar, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9690 to look at the new patch set (#7). Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9749/

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-03-27 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/974

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/974

[Impala-ASF-CR] IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION

2018-03-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9819 ) Change subject: IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION .. Patch Set 3: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9749/

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 6: Verified-1 Build

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9749 to look at the new patch set (#4). Change subject: IMPALA-6694: fix "buffer pool" child profile order ..

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/97

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. IMPALA-5980: Upgrade to LLVM 5.0.1 Highlighting a few changes in

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. IMPALA-6752: fix pip --no-binary usage The key facts here are

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 3: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. IMPALA-4277: Switch to using Hadoop 3 a

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 9: Verified+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. Patch Set 4: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. IMPALA-6699: Fix DST end time for Australian

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 3: Code-Review+2 This looks good to me. Thanks for f

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 3: Code-Review+1 This makes sense as I understand

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread David Knupp (Code Review)
Hello Lars Volker, Michael Brown, Philip Zeyliger, Sailesh Mukil, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9836 to look at the new patch set (#3). Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .

[Impala-ASF-CR] IMPALA-5384, part 1: introduce InsertExecState

2018-03-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9793 ) Change subject: IMPALA-5384, part 1: introduce InsertExecState .. Patch Set 4: (13 comments) http://gerrit.cloudera.org:8080/#/c/9793/4/be

[Impala-ASF-CR] IMPALA-5384, part 1: introduce InsertExecState

2018-03-27 Thread Dan Hecht (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9793 to look at the new patch set (#5). Change subject: IMPALA-5384, part 1: introduce InsertExecState ..

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 6: Build started: h

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9836 ) Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6753: Update Hadoop versions in impala-config.sh

2018-03-27 Thread David Knupp (Code Review)
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9836 Change subject: IMPALA-6753: Update Hadoop versions in impala-config.sh .. IMPALA-6753: Update Hadoop versions in impala-config.sh Updates

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-d

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-veri

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Tim Armstrong (Code Review)
Hello Lars Volker, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9829 to look at the new patch set (#2). Change subject: IMPALA-6752: fix pip --no-binary usage

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/958

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 4: (4 comments) This chang

[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9833 ) Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list. .. Adding "IMPALA-4277: Pin org.gla

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 6: (10 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-27 Thread Zoltan Borok-Nagy (Code Review)
Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#7). Change subject: IMPALA-5842: Write page index in Parquet files .

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 3: (4 comments) Logic looks good to me, had some minor q

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 1: (1 comment) Awesome find, this explains why --no-index seemingly

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/9584/4/be/src/rpc

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9584 to look at the new patch set (#5). Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 8: Verified-1 Build failed: https://

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9829 ) Change subject: IMPALA-6752: fix pip --no-binary usage .. Patch Set 1: GVO and a Cloudera-internal build using a PYPI_MIRROR both got p

[Impala-ASF-CR] IMPALA-6752: fix pip --no-binary usage

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9829 Change subject: IMPALA-6752: fix pip --no-binary usage .. IMPALA-6752: fix pip --no-binary usage The key facts here are: * --no-cache-di

[Impala-ASF-CR] IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9680 ) Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns .. Patch Set 12: Code-Review+1 (4 comments) Looks good,

[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9833 ) Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list. .. Patch Set 1: Code-Review+2 -- To view, v

[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9833 ) Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list. .. Patch Set 1: Verified+1 There's no poin

[Impala-ASF-CR](2.x) Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9833 Change subject: Adding "IMPALA-4277: Pin org.glassfish:javax.el version." to ignore list. .. Adding "IMPALA-4277: Pin org.glassfish:ja

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-27 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9799 to look at the new patch set (#3). Change subject: IMPALA-4123 (prep): Parquet column reader cleanup .

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 ) Change subject: IMPALA-4123 (prep): Parquet column reader cleanup .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9799

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 9: Code-Review+2 Carry +2 from Alex; this

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 9: Build started: https://jenkins.im

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Philip Zeyliger (Code Review)
Hello Michael Brown, Tim Armstrong, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9743 to look at the new patch set (#9). Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. ..

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 8: > I was surprised this commit is missin

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. Patch Set 4: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 8: I was surprised this commit is missing th

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. Patch Set 4: Looks like a jenkins issue: 19:37:21 java.io.

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. IMPALA-6389: Make '\0' delimited text files work In

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6711: loosen shell test prompt regex

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9831 Change subject: IMPALA-6711: loosen shell test prompt regex .. IMPALA-6711: loosen shell test prompt regex We have seen this test fail b

[Impala-ASF-CR] IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT

2018-03-27 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9030 ) Change subject: IMPALA-4168: [DOCS] Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: Jin Chul, Could you please respon

[Impala-ASF-CR] IMPALA-6338: Disable flaky bloom filter test

2018-03-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9822 ) Change subject: IMPALA-6338: Disable flaky bloom filter test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-4025: Part 1: Add percentile disc aggregation function

2018-03-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/9777 ) Change subject: IMPALA-4025: Part 1: Add percentile_disc aggregation function .. Patch Set 1: (17 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-6699: Fix DST end time for Australian time zones

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9724 ) Change subject: IMPALA-6699: Fix DST end time for Australian time zones .. Patch Set 4: Verified-1 Build failed: https://jenkin

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9494 ) Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit_code 5 .. Patch Set 15: Verified+1 -- To view, v

[Impala-ASF-CR] IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit code 5

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9494 ) Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit_code 5 .. IMPALA-5886 & IMPALA-4812 Update

[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

2018-03-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 ) Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search .. Patch Set 8: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6338: Disable flaky bloom filter test

2018-03-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9822 ) Change subject: IMPALA-6338: Disable flaky bloom filter test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9822/1/testda

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 6: Code-Review+2 > I think so; I'll let it run through GVO fi

[Impala-ASF-CR] IMPALA-6751: Let minicluster DN http server listen to 0.0.0.0

2018-03-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has abandoned this change. ( http://gerrit.cloudera.org:8080/9828 ) Change subject: IMPALA-6751: Let minicluster DN http server listen to 0.0.0.0 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9828 To

[Impala-ASF-CR] IMPALA-6751: Let minicluster DN http server listen to 0.0.0.0

2018-03-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9828 Change subject: IMPALA-6751: Let minicluster DN http server listen to 0.0.0.0 .. IMPALA-6751: Let minicluster DN http server listen to 0.0.

[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

2018-03-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 ) Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search .. Patch Set 7: (7 comments) http://gerrit.clo

[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

2018-03-27 Thread Michael Brown (Code Review)
Hello Nithya Janarthanan, David Knupp, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9770 to look at the new patch set (#8). Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

[Impala-ASF-CR] IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9680 ) Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns .. Patch Set 12: Any more comments? -- To view, visit ht

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9749 to look at the new patch set (#3). Change subject: IMPALA-6694: fix "buffer pool" child profile order ..

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9749 ) Change subject: IMPALA-6694: fix "buffer pool" child profile order .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/974

[Impala-ASF-CR] IMPALA-6694: fix "buffer pool" child profile order

2018-03-27 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9749 to look at the new patch set (#2). Change subject: IMPALA-6694: fix "buffer pool" child profile order ..

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-03-27 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/6023 ) Change subject: IMPALA-4848: Add WIDTH_BUCKET() function .. Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/6023/10/be/src

[Impala-ASF-CR] IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search

2018-03-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9770 ) Change subject: IMPALA-5721,IMPALA-6717,IMPALA-6738: improve stress test binary search .. Patch Set 7: (3 comments) I'm probably going

[Impala-ASF-CR] IMPALA-4848: Add WIDTH BUCKET() function

2018-03-27 Thread anujphadke (Code Review)
Hello Taras Bobrovytsky, Michael Brown, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6023 to look at the new patch set (#12). Change subject: IMPALA-4848: Add WIDTH_BUCKET() function ..

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-03-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/9718 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Abandoned Thanks Lars for taking a look at this. After discus

[Impala-ASF-CR] IMPALA-6338: Disable flaky bloom filter test

2018-03-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9822 Change subject: IMPALA-6338: Disable flaky bloom filter test .. IMPALA-6338: Disable flaky bloom filter test The underlying iss

[Impala-ASF-CR] IMPALA-4277: Switch to using Hadoop 3 and friends by default.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9743 ) Change subject: IMPALA-4277: Switch to using Hadoop 3 and friends by default. .. Patch Set 8: Build started: https://jenkins.im

[Impala-ASF-CR] IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION

2018-03-27 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9819 ) Change subject: IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION .. Patch Set 3: Code-Review+1 -- To view, visit http

[Impala-ASF-CR] IMPALA-4277: Pin org.glassfish:javax.el version.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9808 ) Change subject: IMPALA-4277: Pin org.glassfish:javax.el version. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-4277: Pin org.glassfish:javax.el version.

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9808 ) Change subject: IMPALA-4277: Pin org.glassfish:javax.el version. .. IMPALA-4277: Pin org.glassfish:javax.el version. Th

[Impala-ASF-CR] IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION

2018-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9819 ) Change subject: IMPALA-6739: IndexOutOfBoundsException in ALTER TABLE SET LOCATION .. IMPALA-6739: IndexOutOfBoundsException in ALTER TABL

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-27 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 6: I think so; I'll let it run through GVO first. -- To v

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 6: Build started: https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create/drop function statements

2018-03-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create/drop function statements .. Patch Set 6: (1 comment) http://gerrit

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create/drop function statements

2018-03-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create/drop function statements .. Patch Set 5: (1 comment) http:

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9813 ) Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect .. IMPALA-6510: [DOCS] Remove refresh_after_connect Re

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 ) Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 ) Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect .. Patch Set 3: Build started: https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 ) Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6510: [DOCS] Remove refresh after connect

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9813 ) Change subject: IMPALA-6510: [DOCS] Remove refresh_after_connect .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-4123 (prep): Parquet column reader cleanup

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9799 ) Change subject: IMPALA-4123 (prep): Parquet column reader cleanup .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9799

  1   2   >