[Impala-ASF-CR] IMPALA-5031: signed overflow in TimestampValue

2018-11-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11919 ) Change subject: IMPALA-5031: signed overflow in TimestampValue .. Patch Set 1: (1 comment) I have two concerns with the solution: 1

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 ) Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-19 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 ) Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-19 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. IMPALA-7367: Pack StringValue and CollectionValue slots Th

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-19 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 7: > Patch Set 7: > > I can submit once you pu

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. IMPALA-7367: Pack StringValue and CollectionValue sl

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has removed Vuk Ercegovac from this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Removed reviewer Vuk Ercegovac. -- To view, visit ht

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 4: I'm not happy with using ORIGINAL as the defaul

[Impala-ASF-CR] IMPALA-7367: Pack StringValue and CollectionValue slots

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11599 ) Change subject: IMPALA-7367: Pack StringValue and CollectionValue slots .. Patch Set 7: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-7871: Don't load Hive builtins

2018-11-19 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11944 to look at the new patch set (#2). Change subject: IMPALA-7871: Don't load Hive builtins .. IMPALA-7871: D

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 4: (6 comments) My comments are not very useful

[Impala-ASF-CR] IMPALA-7585: support LDAP in run-workload.py

2018-11-19 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11938 ) Change subject: IMPALA-7585: support LDAP in run-workload.py .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7857: log more information about statestore failure detection

2018-11-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11937 ) Change subject: IMPALA-7857: log more information about statestore failure detection .. Patch Set 2: Code-Review+2 Thanks for

[Impala-ASF-CR] IMPALA-7585: support LDAP in run-workload.py

2018-11-19 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11938 ) Change subject: IMPALA-7585: support LDAP in run-workload.py .. IMPALA-7585: support LDAP in run-workload.py This patch just threa

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2018-11-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11950 ) Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. Patch Set 1: Code-Review+2 Thanks for fixing this! -- To view

[Impala-ASF-CR] IMPALA-7857: log more information about statestore failure detection

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11937 ) Change subject: IMPALA-7857: log more information about statestore failure detection .. Patch Set 3: Code-Review+2 -- To vie

[Impala-ASF-CR] IMPALA-7857: log more information about statestore failure detection

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11937 ) Change subject: IMPALA-7857: log more information about statestore failure detection .. Patch Set 3: Build started: https://j

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2018-11-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11950 ) Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. Patch Set 2: Code-Review+2 carry Lars's -- To view, visit http:

[Impala-ASF-CR] IMPALA-7871: Don't load Hive builtins

2018-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11944 ) Change subject: IMPALA-7871: Don't load Hive builtins .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11950 ) Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. Patch Set 2: Build started: https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11947 ) Change subject: IMPALA-6656: BufferAllocator observability .. IMPALA-6656: BufferAllocator observability Adds a set of metrics per alloc

[Impala-ASF-CR] IMPALA-7670: Avoid getting the latest tables in bulkAlterPartitions()

2018-11-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11641 ) Change subject: IMPALA-7670: Avoid getting the latest tables in bulkAlterPartitions() .. Patch Set 1: Can this be abandoned fo

[Impala-ASF-CR] IMPALA-7541. Avoid initializing Metrics for IncompleteTables

2018-11-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. ( http://gerrit.cloudera.org:8080/11393 ) Change subject: IMPALA-7541. Avoid initializing Metrics for IncompleteTables .. Abandoned Todd, abandoning for now, doesn't look like th

[Impala-ASF-CR] IMPALA-7409. CatalogObjectVersionSet should not allow duplicates

2018-11-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has abandoned this change. ( http://gerrit.cloudera.org:8080/11151 ) Change subject: IMPALA-7409. CatalogObjectVersionSet should not allow duplicates .. Abandoned Abandoning for now, feel free to reopen. -

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11947 ) Change subject: IMPALA-6656: BufferAllocator observability .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11947/2/be

[Impala-ASF-CR] IMPALA-7871: Don't load Hive builtins

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11944 ) Change subject: IMPALA-7871: Don't load Hive builtins .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-c

[Impala-ASF-CR] IMPALA-5031: Zero-length arrays are undefined behavior

2018-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11811 ) Change subject: IMPALA-5031: Zero-length arrays are undefined behavior .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-7871: Don't load Hive builtins

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11944 ) Change subject: IMPALA-7871: Don't load Hive builtins .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-veri

[Impala-ASF-CR] Revert "IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code"

2018-11-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11699 ) Change subject: Revert "IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code" .. Patch Set 2: > Any luck? I hit some issues wi

[Impala-ASF-CR] IMPALA-5031: Zero-length arrays are undefined behavior

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11811 ) Change subject: IMPALA-5031: Zero-length arrays are undefined behavior .. Patch Set 3: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-5031: Zero-length arrays are undefined behavior

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11811 ) Change subject: IMPALA-5031: Zero-length arrays are undefined behavior .. Patch Set 3: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2018-11-19 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11575 to look at the new patch set (#11). Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader ..

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11953 Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. IMPALA-7866: Predicates, helpers for implicit casts, slo

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11953 ) Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. Patch Set 1: Pre-commit tests passed: https://jenkins.

[Impala-ASF-CR] IMPALA-7865: Repeated type widening of arithmetic expressions

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11952 Change subject: IMPALA-7865: Repeated type widening of arithmetic expressions .. IMPALA-7865: Repeated type widening of arithmetic express

[Impala-ASF-CR] IMPALA-7865: Repeated type widening of arithmetic expressions

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11952 ) Change subject: IMPALA-7865: Repeated type widening of arithmetic expressions .. Patch Set 2: Pre-commit tests passed: https://jenkins.i

[Impala-ASF-CR] Fix use of uninitialised variale in SendTopicUpdate()

2018-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11957 Change subject: Fix use of uninitialised variale in SendTopicUpdate() .. Fix use of uninitialised variale in SendTopicUpdate() When Sen

[Impala-ASF-CR] Fix use of uninitialised variale in SendTopicUpdate()

2018-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11957 ) Change subject: Fix use of uninitialised variale in SendTopicUpdate() .. Patch Set 1: I just noticed while reading code. I thought I s

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11947 ) Change subject: IMPALA-6656: BufferAllocator observability .. Patch Set 2: Build Failed https://jenkins.impala.io/job/gerrit-

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 11: Build Failed https:/

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-19 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11947 to look at the new patch set (#3). Change subject: IMPALA-6656: BufferAllocator observability .. IMPALA-66

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2018-11-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 11: (5 comments) I rebased the pa

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11953 ) Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. Patch Set 1: Build Successful https://jenki

[Impala-ASF-CR] IMPALA-7865: Repeated type widening of arithmetic expressions

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11952 ) Change subject: IMPALA-7865: Repeated type widening of arithmetic expressions .. Patch Set 2: Build Successful https://jenkin

[Impala-ASF-CR] Fix use of uninitialised variale in SendTopicUpdate()

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11957 ) Change subject: Fix use of uninitialised variale in SendTopicUpdate() .. Patch Set 1: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2018-11-19 Thread Sahil Takiar (Code Review)
Hello Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11575 to look at the new patch set (#12). Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader ..

[Impala-ASF-CR] IMPALA-6656: BufferAllocator observability

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11947 ) Change subject: IMPALA-6656: BufferAllocator observability .. Patch Set 3: Build Successful https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-6964: Track stats about column and page sizes in Parquet reader

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11575 ) Change subject: IMPALA-6964: Track stats about column and page sizes in Parquet reader .. Patch Set 12: Build Successful htt

[Impala-ASF-CR] Fix use of uninitialised variale in SendTopicUpdate()

2018-11-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11957 ) Change subject: Fix use of uninitialised variale in SendTopicUpdate() .. Patch Set 1: Code-Review+2 Thanks for fixing this! Feel free to t

[Impala-ASF-CR] IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

2018-11-19 Thread Tim Armstrong (Code Review)
Hello Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11957 to look at the new patch set (#2). Change subject: IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate() ..

[Impala-ASF-CR] IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

2018-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11957 ) Change subject: IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate() .. Patch Set 2: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11957 ) Change subject: IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate() .. Patch Set 2: Build started: https://jenkins.

[Impala-ASF-CR] IMPALA-7670: Avoid getting the latest tables in bulkAlterPartitions()

2018-11-19 Thread Tianyi Wang (Code Review)
Tianyi Wang has abandoned this change. ( http://gerrit.cloudera.org:8080/11641 ) Change subject: IMPALA-7670: Avoid getting the latest tables in bulkAlterPartitions() .. Abandoned -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] Revert "IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code"

2018-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/11699 ) Change subject: Revert "IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code" .. Abandoned Will abandon for now to reflect that it's n

[Impala-ASF-CR] IMPALA-7857: log more information about statestore failure detection

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11937 ) Change subject: IMPALA-7857: log more information about statestore failure detection .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-7857: log more information about statestore failure detection

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11937 ) Change subject: IMPALA-7857: log more information about statestore failure detection .. IMPALA-7857: log more informat

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11950 ) Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. IMPALA-5031: method calls on NULL are not UBSA

[Impala-ASF-CR] IMPALA-5031: method calls on NULL are not UBSAN-clean

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11950 ) Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean .. Patch Set 2: Verified+1 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-7871: Don't load Hive builtins

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11944 ) Change subject: IMPALA-7871: Don't load Hive builtins .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7871: Don't load Hive builtins

2018-11-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11944 ) Change subject: IMPALA-7871: Don't load Hive builtins .. IMPALA-7871: Don't load Hive builtins Dataload has a step of "Loading

[Impala-ASF-CR] IMPALA-5031: Zero-length arrays are undefined behavior

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11811 ) Change subject: IMPALA-5031: Zero-length arrays are undefined behavior .. Patch Set 3: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-5031: Zero-length arrays are undefined behavior

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11811 ) Change subject: IMPALA-5031: Zero-length arrays are undefined behavior .. IMPALA-5031: Zero-length arrays are undefined

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 4: Thanks Csaba, hope you didn't waste too much ti

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has abandoned this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Abandoned Will let Paul Rogers fix (or at least think about) in a big

[Impala-ASF-CR] IMPALA-7659: Simplify expression to collect NULLs count

2018-11-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 ) Change subject: IMPALA-7659: Simplify expression to collect NULLs count .. Patch Set 5: Thanks, Piotr for getting back. I'll ta

[Impala-ASF-CR] IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme

2018-11-19 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11948 ) Change subject: IMPALA-7861: [DOCS] TLS enabled by default regardless of URI scheme .. IMPALA-7861: [DOCS] TLS enabled by defaul

[Impala-ASF-CR] IMPALA-7829: Mark a fragment instance as done only after Close() is called

2018-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11939 ) Change subject: IMPALA-7829: Mark a fragment instance as done only after Close() is called .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11957 ) Change subject: IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate() .. IMPALA-5031: Fix use of uninitialised

[Impala-ASF-CR] IMPALA-7804: Mitigate s3 consistency issues for test scanners

2018-11-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11959 Change subject: IMPALA-7804: Mitigate s3 consistency issues for test_scanners .. IMPALA-7804: Mitigate s3 consistency issues for test_sc

[Impala-ASF-CR] IMPALA-7804: Mitigate s3 consistency issues for test scanners

2018-11-19 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11959 to look at the new patch set (#2). Change subject: IMPALA-7804: Mitigate s3 consistency issues for test_scanners ..

[Impala-ASF-CR] IMPALA-7804: Mitigate s3 consistency issues for test scanners

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11959 ) Change subject: IMPALA-7804: Mitigate s3 consistency issues for test_scanners .. Patch Set 2: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate()

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11957 ) Change subject: IMPALA-5031: Fix use of uninitialised var in SendTopicUpdate() .. Patch Set 2: Verified+1 -- To view, visit h

[Impala-ASF-CR] IMPALA-7804: Mitigate s3 consistency issues for test scanners

2018-11-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11959 ) Change subject: IMPALA-7804: Mitigate s3 consistency issues for test_scanners .. Patch Set 2: I'm running on s3 to see if it helps. Th

[Impala-ASF-CR] IMPALA-7804: Mitigate s3 consistency issues for test scanners

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11959 ) Change subject: IMPALA-7804: Mitigate s3 consistency issues for test_scanners .. Patch Set 1: Build Successful https://jenkin

[Impala-ASF-CR] IMPALA-7804: Mitigate s3 consistency issues for test scanners

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11959 ) Change subject: IMPALA-7804: Mitigate s3 consistency issues for test_scanners .. Patch Set 2: Build Successful https://jenkin

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 ) Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database .. Patch Set 2: Build Started https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 ) Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database .. Patch Set 2: Verified+1 Build Successful https://je

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-19 Thread Alex Rodoni (Code Review)
Hello Attila Jeges, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11946 to look at the new patch set (#2). Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database ..

[Impala-ASF-CR] IMPALA-7233: [DOCS] Support for IANA timezone database

2018-11-19 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11946 ) Change subject: IMPALA-7233: [DOCS] Support for IANA timezone database .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7804: Mitigate s3 consistency issues for test scanners

2018-11-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11959 ) Change subject: IMPALA-7804: Mitigate s3 consistency issues for test_scanners .. Patch Set 2: Verified+1 -- To view, visit ht

[Impala-ASF-CR] MPALA-7867, part 1: Expose List in TreeNode, parser

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11954 Change subject: MPALA-7867, part 1: Expose List in TreeNode, parser .. MPALA-7867, part 1: Expose List in TreeNode, parser When using Jav

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull to use CASE

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull to use CASE .. Abandoned Will revisit after cleaning up blocking issues. -- To view, visit http://

[Impala-ASF-CR] IMPALA-7310: Use NDV=1 for a Column with all nulls

2018-11-19 Thread Paul Rogers (Code Review)
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: Use NDV=1 for a Column with all nulls .. Abandoned Split test code into a separate patch. Will reopen this with just

[Impala-ASF-CR] IMPALA-7869: break up parquet-column-readers.cc

2018-11-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11949 ) Change subject: IMPALA-7869: break up parquet-column-readers.cc .. IMPALA-7869: break up parquet-column-readers.cc Move CollectionColumn