[Impala-ASF-CR] IMPALA-7867 (Part 5): Collection cleanup in analyzer

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12266 ) Change subject: IMPALA-7867 (Part 5): Collection cleanup in analyzer .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7867 (Part 5): Collection cleanup in analyzer

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12266 ) Change subject: IMPALA-7867 (Part 5): Collection cleanup in analyzer .. IMPALA-7867 (Part 5): Collection cleanup in

[Impala-ASF-CR] IMPALA-8148: Misc. FE code cleanup

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12317 ) Change subject: IMPALA-8148: Misc. FE code cleanup .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8148: Misc. FE code cleanup

2019-01-31 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12317 ) Change subject: IMPALA-8148: Misc. FE code cleanup .. Patch Set 2: Passed pre-review tests:

[Impala-ASF-CR] IMPALA-8148: Misc. FE code cleanup

2019-01-31 Thread Paul Rogers (Code Review)
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12317 Change subject: IMPALA-8148: Misc. FE code cleanup .. IMPALA-8148: Misc. FE code cleanup Roll-up of a bunch of minor code cleanup and

[Impala-ASF-CR] IMPALA-7934: Switch to java.util.Base64 implementation

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12250 ) Change subject: IMPALA-7934: Switch to java.util.Base64 implementation .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7934: Switch to java.util.Base64 implementation

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12250 ) Change subject: IMPALA-7934: Switch to java.util.Base64 implementation .. IMPALA-7934: Switch to java.util.Base64

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 3: (1 comment) Key question here is the syntax of the

[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12292 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 2: Build started:

[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-31 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12292 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 2: > Patch Set 2: Code-Review+2 > > I spoke

[Impala-ASF-CR] IMPALA-7867 (Part 5): Collection cleanup in analyzer

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12266 ) Change subject: IMPALA-7867 (Part 5): Collection cleanup in analyzer .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7867 (Part 5): Collection cleanup in analyzer

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12266 ) Change subject: IMPALA-7867 (Part 5): Collection cleanup in analyzer .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 6: Build Successful

[Impala-ASF-CR](2.x) IMPALA-6479: Update DESCRIBE to respect column privileges

2019-01-31 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12292 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 2: Code-Review+2 I spoke to Bharath offline and

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 5: Build Failed

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-31 Thread Bikramjeet Vig (Code Review)
Hello Pooja Nilangekar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12244 to look at the new patch set (#6). Change subject: IMPALA-8092: Add an admission controller debug page

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-31 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8093: Prefix time series counters with a hyphen

2019-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12296 ) Change subject: IMPALA-8093: Prefix time series counters with a hyphen .. Patch Set 4: Code-Review+1 (2 comments) Lars, can

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 5: I did not rebase yet so that reviewers can

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 4: Build Failed

[Impala-ASF-CR] IMPALA-7934: Switch to java.util.Base64 implementation

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12250 ) Change subject: IMPALA-7934: Switch to java.util.Base64 implementation .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7934: Switch to java.util.Base64 implementation

2019-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12250 ) Change subject: IMPALA-7934: Switch to java.util.Base64 implementation .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7934: Switch to java.util.Base64 implementation

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12250 ) Change subject: IMPALA-7934: Switch to java.util.Base64 implementation .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-31 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Fredy Wijaya, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#5). Change subject: IMPALA-5872: Testcase builder for query planner

[Impala-ASF-CR] IMPALA-7934: Switch to java.util.Base64 implementation

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12250 ) Change subject: IMPALA-7934: Switch to java.util.Base64 implementation .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-31 Thread Bharath Vissapragada (Code Review)
Hello Greg Rahn, Paul Rogers, Fredy Wijaya, Balazs Jeszenszky, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12221 to look at the new patch set (#4). Change subject: IMPALA-5872: Testcase builder for query planner

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

2019-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 3: (13 comments)

[Impala-ASF-CR] IMPALA-7934: Switch to java.util.Base64 implementation

2019-01-31 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12250 ) Change subject: IMPALA-7934: Switch to java.util.Base64 implementation .. Patch Set 4: (2 comments) Added some benchmark numbers.

[Impala-ASF-CR] IMPALA-7934: Switch to java.util.Base64 implementation

2019-01-31 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12250 ) Change subject: IMPALA-7934: Switch to java.util.Base64 implementation .. IMPALA-7934: Switch to java.util.Base64 implementation It is

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-8137: [DOCS] Order By does not happens on one node

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12330 ) Change subject: IMPALA-8137: [DOCS] Order By does not happens on one node .. Patch Set 1: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-8137: [DOCS] Order By does not happens on one node

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12330 ) Change subject: IMPALA-8137: [DOCS] Order By does not happens on one node .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-8137: [DOCS] Order By does not happens on one node

2019-01-31 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12330 Change subject: IMPALA-8137: [DOCS] Order By does not happens on one node .. IMPALA-8137: [DOCS] Order By does not happens on one node

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-31 Thread Thomas Marshall (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12049 to look at the new patch set (#5). Change subject: IMPALA-4555: Make QueryState's status reporting more robust

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-31 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 5: (9 comments)

[Impala-ASF-CR] test-with-docker: decrease image size by "de-duping" HDFS.

2019-01-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11782 ) Change subject: test-with-docker: decrease image size by "de-duping" HDFS. .. Patch Set 1: (1 comment) > (1 comment) > > You

[Impala-ASF-CR] IMPALA-8093: Prefix time series counters with a hyphen

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12296 ) Change subject: IMPALA-8093: Prefix time series counters with a hyphen .. Patch Set 4: Build Successful

[Impala-ASF-CR] Logging current database context when logging analyzing queries.

2019-01-31 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12301 ) Change subject: Logging current database context when logging analyzing queries. .. Patch Set 1: (1 comment) This is a one-line

[Impala-ASF-CR] IMPALA-8093: Prefix time series counters with a hyphen

2019-01-31 Thread Yongzhi Chen (Code Review)
Hello Bharath Vissapragada, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12296 to look at the new patch set (#4). Change subject: IMPALA-8093: Prefix time series counters with a hyphen

[Impala-ASF-CR] IMPALA-7999: clean up start-*d.sh scripts

2019-01-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12271 ) Change subject: IMPALA-7999: clean up start-*d.sh scripts .. Patch Set 6: (9 comments)

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-4555: Make QueryState's status reporting more robust

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12049 ) Change subject: IMPALA-4555: Make QueryState's status reporting more robust .. Patch Set 4: (9 comments) Looking good. Some more minor

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-01-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 5: (12 comments) Some more comments. i think this is

[Impala-ASF-CR] IMPALA-8093: Prefix time series counters with a hyphen

2019-01-31 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12296 ) Change subject: IMPALA-8093: Prefix time series counters with a hyphen .. Patch Set 1: (1 comment) As discussed, we usually

[Impala-ASF-CR] IMPALA-8102: update Impala/HBase docs

2019-01-31 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12315 ) Change subject: IMPALA-8102: update Impala/HBase docs .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8102: update Impala/HBase docs

2019-01-31 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12315 ) Change subject: IMPALA-8102: update Impala/HBase docs .. IMPALA-8102: update Impala/HBase docs Provide pointers to Kudu, which

[Impala-ASF-CR] IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198

2019-01-31 Thread Alex Rodoni (Code Review)
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12311 ) Change subject: IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198 .. IMPALA-8111: [DOCS] Take 2: Removed the

[Impala-ASF-CR] IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198

2019-01-31 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12311 ) Change subject: IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198 .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198

2019-01-31 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/12311 ) Change subject: IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198 .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12311 ) Change subject: IMPALA-8111: [DOCS] Take 2: Removed the Fix Version for KUDU-2198 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7985: Port RemoteShutdown() to KRPC.

2019-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12260 ) Change subject: IMPALA-7985: Port RemoteShutdown() to KRPC. .. Patch Set 4: (6 comments)

[Impala-ASF-CR] WIP: IMPALA-5843: Use page index in Parquet files to skip pages

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: WIP: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 5: Build Successful

[Impala-ASF-CR] WIP: IMPALA-5843: Use page index in Parquet files to skip pages

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: WIP: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 4: Build Failed

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8034: Improve planner tests

2019-01-31 Thread Paul Rogers (Code Review)
Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12145 ) Change subject: IMPALA-8034: Improve planner tests .. Patch Set 3: Bharath, can you take a look at this one? Would be very helpful to

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 4: (1 comment)

[Impala-ASF-CR] WIP: IMPALA-5843: Use page index in Parquet files to skip pages

2019-01-31 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12065 ) Change subject: WIP: IMPALA-5843: Use page index in Parquet files to skip pages .. Patch Set 4: (15 comments)

[Impala-ASF-CR] WIP: IMPALA-5843: Use page index in Parquet files to skip pages

2019-01-31 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12065 to look at the new patch set (#4). Change subject: WIP: IMPALA-5843: Use page index in Parquet files to skip pages

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 3: (8 comments) I took a quick look. Some minor issues;

[Impala-ASF-CR] WIP: IMPALA-5843: Use page index in Parquet files to skip pages

2019-01-31 Thread Zoltan Borok-Nagy (Code Review)
Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12065 to look at the new patch set (#3). Change subject: WIP: IMPALA-5843: Use page index in Parquet files to skip pages

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 3: As mentioned in the Jira, I am opposed to introducing

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 3: (13 comments) Hey Paul, Thanks for taking a look! The

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

2019-01-31 Thread Gabor Kaszab (Code Review)
Hello Paul Rogers, Attila Jeges, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12267 to look at the new patch set (#3). Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST()

[Impala-ASF-CR] IMPALA-8092: Add an admission controller debug page

2019-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12244 ) Change subject: IMPALA-8092: Add an admission controller debug page .. Patch Set 5: Code-Review+2 (5 comments) I think this is