[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 20: Verified+1 -- To view, visit ht

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. IMPALA-8564: Add table/view create time

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13400 ) Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration .. Patch Set 8: Verified+1 -- To view, v

[Impala-ASF-CR] IMPALA-8553,IMPALA-8552: fix checks for remote cluster

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13386 ) Change subject: IMPALA-8553,IMPALA-8552: fix checks for remote cluster .. Patch Set 6: No problem, I want to do this the right way.

[Impala-ASF-CR] IMPALA-8450: Add support for zstd in parquet

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13507 ) Change subject: IMPALA-8450: Add support for zstd in parquet .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8450: Add support for zstd in parquet

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13507 ) Change subject: IMPALA-8450: Add support for zstd in parquet .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-8450: Add support for zstd in parquet

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13507 ) Change subject: IMPALA-8450: Add support for zstd in parquet .. Patch Set 6: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-8553,IMPALA-8552: fix checks for remote cluster

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13386 ) Change subject: IMPALA-8553,IMPALA-8552: fix checks for remote cluster .. Patch Set 6: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-8450: Add support for zstd in parquet

2019-06-04 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13507 ) Change subject: IMPALA-8450: Add support for zstd in parquet .. IMPALA-8450: Add support for zstd in parquet Makefile was updated to in

[Impala-ASF-CR] IMPALA-8578: part 2: move metrics code to .cc files

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13501 ) Change subject: IMPALA-8578: part 2: move metrics code to .cc files .. IMPALA-8578: part 2: move metrics code to .cc fi

[Impala-ASF-CR] IMPALA-8578: part 2: move metrics code to .cc files

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13501 ) Change subject: IMPALA-8578: part 2: move metrics code to .cc files .. Patch Set 5: Verified+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13409 ) Change subject: IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13465 ) Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE .. IMPALA-8505: Disallow setting Kudu table

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. Patch Set 4: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. Patch Set 4: Build started: https:

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 20: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 20: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-8425: part 1: reduce size of binaries in container

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13487 ) Change subject: IMPALA-8425: part 1: reduce size of binaries in container .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8425: part 1: reduce size of binaries in container

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13487 ) Change subject: IMPALA-8425: part 1: reduce size of binaries in container .. Patch Set 4: For our test runs we would still have the un

[Impala-ASF-CR] WIP IMPALA-8425: Prototype to skip unneeded Kudu binaries for docker image

2019-06-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/13488 ) Change subject: WIP IMPALA-8425: Prototype to skip unneeded Kudu binaries for docker image .. Abandoned -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8425: part 1: reduce size of binaries in container

2019-06-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13487 ) Change subject: IMPALA-8425: part 1: reduce size of binaries in container .. Patch Set 4: (1 comment) This makes sense to me. Thanks

[Impala-ASF-CR] IMPALA-8553,IMPALA-8552: fix checks for remote cluster

2019-06-04 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/13386 ) Change subject: IMPALA-8553,IMPALA-8552: fix checks for remote cluster .. Patch Set 5: I don't want to belabor this review, but I'm goin

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13400 ) Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration .. Patch Set 8: Build started: https://je

[Impala-ASF-CR] IMPALA-8553,IMPALA-8552: fix checks for remote cluster

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13386 ) Change subject: IMPALA-8553,IMPALA-8552: fix checks for remote cluster .. Patch Set 6: Filed IMPALA-8625 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-8553,IMPALA-8552: fix checks for remote cluster

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13386 ) Change subject: IMPALA-8553,IMPALA-8552: fix checks for remote cluster .. Patch Set 5: The previous failure was related to catalog V2

[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 ) Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE .. Patch Set 3: Verified+1 -- To view, visit http:

[Impala-ASF-CR] IMPALA-8553,IMPALA-8552: fix checks for remote cluster

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13386 ) Change subject: IMPALA-8553,IMPALA-8552: fix checks for remote cluster .. Patch Set 6: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-8553,IMPALA-8552: fix checks for remote cluster

2019-06-04 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/13386 ) Change subject: IMPALA-8553,IMPALA-8552: fix checks for remote cluster .. Patch Set 5: > Patch Set 4: > > Yeah that was caused by https:

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13400 ) Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-8564: Add table/view create time in the lineage graph

2019-06-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13399 ) Change subject: IMPALA-8564: Add table/view create time in the lineage graph .. Patch Set 19: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-8553,IMPALA-8552: fix checks for remote cluster

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13386 ) Change subject: IMPALA-8553,IMPALA-8552: fix checks for remote cluster .. Patch Set 5: Verified-1 Build failed: https://jenkin

[Impala-ASF-CR] IMPALA-8450: Add support for zstd in parquet

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13507 ) Change subject: IMPALA-8450: Add support for zstd in parquet .. Patch Set 5: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 ) Change subject: Add option to set driver in ImpalaJdbcDriver .. Patch Set 1: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-8567: revert dockerised cluster to catalog v1

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13504 ) Change subject: IMPALA-8567: revert dockerised cluster to catalog v1 .. Patch Set 2: Verified+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-8567: revert dockerised cluster to catalog v1

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13504 ) Change subject: IMPALA-8567: revert dockerised cluster to catalog v1 .. IMPALA-8567: revert dockerised cluster to catal

[Impala-ASF-CR] IMPALA-8578: part 2: move metrics code to .cc files

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13501 ) Change subject: IMPALA-8578: part 2: move metrics code to .cc files .. Patch Set 5: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13491 ) Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .. IMPALA-8578: part 1: reduce dependencies on *metrics.

[Impala-ASF-CR] IMPALA-8578: part 2: move metrics code to .cc files

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13501 ) Change subject: IMPALA-8578: part 2: move metrics code to .cc files .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13491 ) Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13491 ) Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .. Patch Set 7: Carrying verification through rebase. -- To v

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13491 ) Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .. Patch Set 6: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

2019-06-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13514 Change subject: Add option to set driver in ImpalaJdbcDriver .. Add option to set driver in ImpalaJdbcDriver ImpalaJdbcDriver is a si

[Impala-ASF-CR] IMPALA-8450: Add support for zstd in parquet

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13507 ) Change subject: IMPALA-8450: Add support for zstd in parquet .. Patch Set 5: Build Failed https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13409 ) Change subject: IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration .. Patch Set 3: Build started: https://

[Impala-ASF-CR] IMPALA-8450: Add support for zstd in parquet

2019-06-04 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13507 ) Change subject: IMPALA-8450: Add support for zstd in parquet .. IMPALA-8450: Add support for zstd in parquet Makefile was updated to in

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. Patch Set 3: Build Successful htt

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. Patch Set 3: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-8450: Add support for zstd in parquet

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13507 ) Change subject: IMPALA-8450: Add support for zstd in parquet .. Patch Set 4: (4 comments) Minor comments only then I can +2 http://g

[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE

2019-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 ) Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE .. Patch Set 3: Code-Review+1 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-04 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. IMPALA-8562: Data cache should skip insertion of

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. Patch Set 3: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 ) Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE .. Patch Set 3: Build started: https://jenkins.impa

[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE

2019-06-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 ) Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE .. Patch Set 3: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13409 ) Change subject: IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration .. Patch Set 3: Build Successful https

[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE

2019-06-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 ) Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE .. Patch Set 3: Code-Review+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration

2019-06-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13409 ) Change subject: IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration

2019-06-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13409 ) Change subject: IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration .. Patch Set 3: (3 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integration

2019-06-04 Thread Hao Hao (Code Review)
Hello Thomas Marshall, Alexey Serbin, Andrew Wong, Grant Henke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13409 to look at the new patch set (#3). Change subject: IMPALA-8506: Support RENAME TABLE statement with Kudu/HMS integr

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13491 ) Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .. Patch Set 7: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-8578: part 2: move metrics code to .cc files

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13501 ) Change subject: IMPALA-8578: part 2: move metrics code to .cc files .. Patch Set 4: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 ) Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE .. Patch Set 3: Build Successful https://jenkins.i

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13400 ) Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration .. Patch Set 7: Build Successful https:/

[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 ) Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE .. Patch Set 3: Build started: https://jenkins.impa

[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE

2019-06-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 ) Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE

2019-06-04 Thread Hao Hao (Code Review)
Hello Thomas Marshall, Alexey Serbin, Andrew Wong, Grant Henke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13465 to look at the new patch set (#3). Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE ..

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13400 ) Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration .. Patch Set 6: Build Failed https://jen

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-06-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13400 ) Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration .. Patch Set 7: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13400 ) Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration .. Patch Set 7: Build started: https://je

[Impala-ASF-CR] IMPALA-8578: part 2: move metrics code to .cc files

2019-06-04 Thread Tim Armstrong (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13501 to look at the new patch set (#4). Change subject: IMPALA-8578: part 2: move metrics code to .cc files .

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Tim Armstrong (Code Review)
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13491 to look at the new patch set (#7). Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-06-04 Thread Hao Hao (Code Review)
Hello Thomas Marshall, Alexey Serbin, Andrew Wong, Grant Henke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13400 to look at the new patch set (#7). Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integrat

[Impala-ASF-CR] IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration

2019-06-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13375 ) Change subject: IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration .. IMPALA-8504 (part 2): Supp

[Impala-ASF-CR] IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration

2019-06-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13375 ) Change subject: IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 9: Verified+1 There hav

[Impala-ASF-CR] IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13375 ) Change subject: IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 9: -Code-Review B

[Impala-ASF-CR] IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration

2019-06-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13375 ) Change subject: IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 9: Code-Review+1 -- To vie

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-06-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13400 ) Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration .. Patch Set 6: Code-Review+1 -- To view, visit ht

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-06-04 Thread Hao Hao (Code Review)
Hello Thomas Marshall, Alexey Serbin, Andrew Wong, Grant Henke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13400 to look at the new patch set (#6). Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integrat

[Impala-ASF-CR] IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration

2019-06-04 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13400 ) Change subject: IMPALA-8507: Support DROP TABLE statement with Kudu/HMS integration .. Patch Set 6: (2 comments) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration

2019-06-04 Thread Thomas Marshall (Code Review)
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13375 ) Change subject: IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 8: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration

2019-06-04 Thread Hao Hao (Code Review)
Hello Thomas Marshall, Alexey Serbin, Andrew Wong, Grant Henke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13375 to look at the new patch set (#9). Change subject: IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/H

[Impala-ASF-CR] IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13375 ) Change subject: IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 8: Code-Review+2

[Impala-ASF-CR] IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13375 ) Change subject: IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-8553,IMPALA-8552: fix checks for remote cluster

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13386 ) Change subject: IMPALA-8553,IMPALA-8552: fix checks for remote cluster .. Patch Set 5: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13491 ) Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .. Patch Set 5: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-8567: revert dockerised cluster to catalog v1

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13504 ) Change subject: IMPALA-8567: revert dockerised cluster to catalog v1 .. Patch Set 2: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-8450: Add support for zstd in parquet

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13507 ) Change subject: IMPALA-8450: Add support for zstd in parquet .. Patch Set 4: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration

2019-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13375 ) Change subject: IMPALA-8504 (part 2): Support CREATE TABLE statement with Kudu/HMS integration .. Patch Set 7: (1 comment) http://ge

[Impala-ASF-CR] IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE

2019-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13465 ) Change subject: IMPALA-8505: Disallow setting Kudu table id in ALTER TABLE .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13369 ) Change subject: IMPALA-8562: Data cache should skip insertion of uncacheable ScanRanges .. Patch Set 2: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8567: revert dockerised cluster to catalog v1

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13504 ) Change subject: IMPALA-8567: revert dockerised cluster to catalog v1 .. Patch Set 2: Build started: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13491 ) Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .. Patch Set 6: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13491 ) Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .. Patch Set 6: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13491 ) Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-8567: revert dockerised cluster to catalog v1

2019-06-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13504 ) Change subject: IMPALA-8567: revert dockerised cluster to catalog v1 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13491 ) Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-8578: part 1: reduce dependencies on *metrics.h

2019-06-04 Thread Tim Armstrong (Code Review)
Hello Zoltan Borok-Nagy, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13491 to look at the new patch set (#5). Change subject: IMPALA-8578: part 1: reduce dependencies on *metrics.h .

[Impala-ASF-CR] IMPALA-8567: revert dockerised cluster to catalog v1

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13504 ) Change subject: IMPALA-8567: revert dockerised cluster to catalog v1 .. Patch Set 2: The dockerised build hit a build error that looke

[Impala-ASF-CR] IMPALA-8567: revert dockerised cluster to catalog v1

2019-06-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13504 Change subject: IMPALA-8567: revert dockerised cluster to catalog v1 .. IMPALA-8567: revert dockerised cluster to catalog v1 Change-Id:

[Impala-ASF-CR] IMPALA-8450: Add support for zstd in parquet

2019-06-04 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13507 ) Change subject: IMPALA-8450: Add support for zstd in parquet .. IMPALA-8450: Add support for zstd in parquet Makefile was updated to in

[Impala-ASF-CR] IMPALA-8578: part 2: move metrics code to .cc files

2019-06-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13501 ) Change subject: IMPALA-8578: part 2: move metrics code to .cc files .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit

  1   2   >