[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 10: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 10: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-8901: Fix # links on /catalog page.

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14153 ) Change subject: IMPALA-8901: Fix # links on /catalog page. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-8897: Fully qualify all links on the webserver

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14151 ) Change subject: IMPALA-8897: Fully qualify all links on the webserver .. Patch Set 1: Build Successful https://jenkins.impala

[Impala-ASF-CR] IMPALA-8901: Fix # links on /catalog page.

2019-08-27 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14153 Change subject: IMPALA-8901: Fix # links on /catalog page. .. IMPALA-8901: Fix # links on /catalog page. After IMPALA-7935, the

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 9: Verified-1 Build failed: https://je

[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 ) Change subject: IMPALA-7604: part 1: tests for agg cardinality .. Patch Set 6: Verified-1 Build failed: https://jenkins.impala

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution .. Patch Set 23: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution .. Patch Set 22: Build Failed https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-8897: Fully qualify all links on the webserver

2019-08-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14151 Change subject: IMPALA-8897: Fully qualify all links on the webserver .. IMPALA-8897: Fully qualify all links on the webserver

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#22). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#23). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution .. Patch Set 21: Build Failed https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-8579: Ignore trivial alter table/partition events.

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14145 ) Change subject: IMPALA-8579: Ignore trivial alter table/partition events. .. Patch Set 4: Build Successful https://jenkins.im

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#21). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 6: (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-8579: Ignore trivial alter table/partition events.

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14145 ) Change subject: IMPALA-8579: Ignore trivial alter table/partition events. .. Patch Set 4: Build Failed https://jenkins.impala

[Impala-ASF-CR] IMPALA-8579: Ignore trivial alter table/partition events.

2019-08-27 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14145 ) Change subject: IMPALA-8579: Ignore trivial alter table/partition events. .. Patch Set 4: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8579: Ignore trivial alter table/partition events.

2019-08-27 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14145 ) Change subject: IMPALA-8579: Ignore trivial alter table/partition events. .. IMPALA-8579: Ignore trivial alter table/partition eve

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in tests

2019-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 ) Change subject: IMPALA-8795 : Enable event polling by default in tests .. Patch Set 9: LMK when I should take another look at this, it

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 9: Build Successful https://jenkins.i

[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 ) Change subject: IMPALA-7604: part 1: tests for agg cardinality .. Patch Set 4: Build Successful https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 8: Build Successful https://jenkins.i

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 7: Build Successful https://jenkins.i

[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 ) Change subject: IMPALA-7604: part 1: tests for agg cardinality .. Patch Set 6: Build started: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 9: Build started: https://jenkins.impa

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 9: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 9: Changes weren't totally trivial, would be g

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14132 to look at the new patch set (#9). Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality ...

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14132 to look at the new patch set (#8). Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality ...

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 7: (6 comments) PS8 is a rebase onto the late

[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality

2019-08-27 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14131 to look at the new patch set (#4). Change subject: IMPALA-7604: part 1: tests for agg cardinality ...

[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality

2019-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 ) Change subject: IMPALA-7604: part 1: tests for agg cardinality .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14131/

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14132 to look at the new patch set (#7). Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality ...

[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint

2019-08-27 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14146 ) Change subject: IMPALA-8895: Expose daemon health endpoint .. IMPALA-8895: Expose daemon health endpoint This change exposes the

[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint

2019-08-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 ) Change subject: IMPALA-8895: Expose daemon health endpoint .. Patch Set 4: Verified+1 Code-Review+2 Rebased to decouple from the change

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 5: Build Successful https:/

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-8858: Add observability of the query load on executor groups

2019-08-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14103 ) Change subject: IMPALA-8858: Add observability of the query load on executor groups .. Patch Set 5: (4 comments) Only looked at the de

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 4: Build Successful https:/

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 3: Build Successful https:/

[Impala-ASF-CR] IMPALA-8579: Ignore trivial alter table/partition events.

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14145 ) Change subject: IMPALA-8579: Ignore trivial alter table/partition events. .. Patch Set 3: Build Successful https://jenkins.im

[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 ) Change subject: IMPALA-8895: Expose daemon health endpoint .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 5: (4 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-27 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14104 to look at the new patch set (#5). Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend

[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality

2019-08-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 ) Change subject: IMPALA-7604: part 1: tests for agg cardinality .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14131

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 6: Code-Review+2 (1 comment) Lgtm http://ge

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 4: (24 comments) Addressed all pendi

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14121 to look at the new patch set (#8). Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries ...

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-27 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14104 to look at the new patch set (#4). Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 3: (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-27 Thread Sahil Takiar (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14104 to look at the new patch set (#3). Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 7: Build Failed htt

[Impala-ASF-CR] IMPALA-8579: Ignore trivial alter table/partition events.

2019-08-27 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14145 ) Change subject: IMPALA-8579: Ignore trivial alter table/partition events. .. Patch Set 2: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 7: (2 comments) http:

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13748 ) Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution .. Patch Set 20: Build Failed https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-8579: Ignore trivial alter table/partition events.

2019-08-27 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14145 ) Change subject: IMPALA-8579: Ignore trivial alter table/partition events. .. Patch Set 3: (2 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-8579: Ignore trivial alter table/partition events.

2019-08-27 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14145 ) Change subject: IMPALA-8579: Ignore trivial alter table/partition events. .. IMPALA-8579: Ignore trivial alter table/partition eve

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 6: (3 comments) http://ge

[Impala-ASF-CR] IMPALA-8571[WIP]: improve QueryEventHook execution

2019-08-27 Thread radford nguyen (Code Review)
Hello Bharath Vissapragada, Andrew Sherman, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13748 to look at the new patch set (#20). Change subject: IMPALA-8571[WIP]: improve QueryEventHook execution

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14121 to look at the new patch set (#7). Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries ...

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14149 ) Change subject: Fix THttpServer to not call the cookie function with an empty cookie .. Fix THttpServer to not call th

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14149 ) Change subject: Fix THttpServer to not call the cookie function with an empty cookie .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 6: (3 comments) http:

[Impala-ASF-CR] IMPALA-7604: part 2: fixes for AggregationNode cardinality

2019-08-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14132 ) Change subject: IMPALA-7604: part 2: fixes for AggregationNode cardinality .. Patch Set 6: Code-Review+1 (4 comments) Patch an

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14149 ) Change subject: Fix THttpServer to not call the cookie function with an empty cookie .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-8890: Advance read page in UnpinStream

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14144 ) Change subject: IMPALA-8890: Advance read page in UnpinStream .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-8890: Advance read page in UnpinStream

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14144 ) Change subject: IMPALA-8890: Advance read page in UnpinStream .. IMPALA-8890: Advance read page in UnpinStream Fixes a

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 5: Verified-1 Build

[Impala-ASF-CR] IMPALA-8572: Log query events before Unregister() call.

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before Unregister() call. .. Patch Set 4: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-8797: Support database and table blacklist

2019-08-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14134 ) Change subject: IMPALA-8797: Support database and table blacklist .. Patch Set 7: I'm out for a week or so and won't be able to

[Impala-ASF-CR] IMPALA-8797: Support database and table blacklist

2019-08-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14134 ) Change subject: IMPALA-8797: Support database and table blacklist .. Patch Set 7: (13 comments) Couple of requests for test co

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 6: (2 comments) http:

[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 ) Change subject: IMPALA-8895: Expose daemon health endpoint .. Patch Set 3: Build Successful https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-8579: Ignore trivial alter table/partition events.

2019-08-27 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14145 ) Change subject: IMPALA-8579: Ignore trivial alter table/partition events. .. Patch Set 2: (4 comments) Looks good to me. Few mo

[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 ) Change subject: IMPALA-8895: Expose daemon health endpoint .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint

2019-08-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 ) Change subject: IMPALA-8895: Expose daemon health endpoint .. Patch Set 3: Code-Review+2 Updated call signature in one test. Carrying Ti

[Impala-ASF-CR] IMPALA-8793: Implement TRUNCATE for insert-only ACID tables

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14071 ) Change subject: IMPALA-8793: Implement TRUNCATE for insert-only ACID tables .. IMPALA-8793: Implement TRUNCATE for inse

[Impala-ASF-CR] IMPALA-8793: Implement TRUNCATE for insert-only ACID tables

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14071 ) Change subject: IMPALA-8793: Implement TRUNCATE for insert-only ACID tables .. Patch Set 11: Verified+1 -- To view, visit htt

[Impala-ASF-CR] IMPALA-8572: Log query events before Unregister() call.

2019-08-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before Unregister() call. .. Patch Set 4: I think this is in a decent shape that

[Impala-ASF-CR] IMPALA-8572: Log query events before Unregister() call.

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14143 ) Change subject: IMPALA-8572: Log query events before Unregister() call. .. Patch Set 4: (5 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8572: Log query events before Unregister() call.

2019-08-27 Thread Bharath Vissapragada (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14143 to look at the new patch set (#4). Change subject: IMPALA-8572: Log query events before Unregister() call.

[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint

2019-08-27 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14146 to look at the new patch set (#3). Change subject: IMPALA-8895: Expose daemon health endpoint ..

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14149 ) Change subject: Fix THttpServer to not call the cookie function with an empty cookie .. Patch Set 2: Build Successful https:

[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint

2019-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 ) Change subject: IMPALA-8895: Expose daemon health endpoint .. Patch Set 2: Code-Review+2 (1 comment) I'm OK with proceeding as-is and

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 6: Build Successful

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14149 ) Change subject: Fix THttpServer to not call the cookie function with an empty cookie .. Patch Set 2: Build started: https://j

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14149 ) Change subject: Fix THttpServer to not call the cookie function with an empty cookie .. Patch Set 1: Build Successful https:

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14149 ) Change subject: Fix THttpServer to not call the cookie function with an empty cookie .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14149 ) Change subject: Fix THttpServer to not call the cookie function with an empty cookie .. Patch Set 2: (1 comment) http://ger

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Thomas Tauber-Marshall (Code Review)
Hello Attila Jeges, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14149 to look at the new patch set (#2). Change subject: Fix THttpServer to not call the cookie function with an empty cookie .

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14149 ) Change subject: Fix THttpServer to not call the cookie function with an empty cookie .. Patch Set 1: (1 comment) http://gerrit.cloud

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14149 ) Change subject: Fix THttpServer to not call the cookie function with an empty cookie .. Patch Set 1: Build started: https://j

[Impala-ASF-CR] Fix THttpServer to not call the cookie function with an empty cookie

2019-08-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14149 Change subject: Fix THttpServer to not call the cookie function with an empty cookie .. Fix THttpServer to not call the cookie

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 6: (1 comment) http://ger

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Csaba Ringhofer (Code Review)
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14121 to look at the new patch set (#6). Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries ...

[Impala-ASF-CR] IMPALA-8895: Expose daemon health endpoint

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 ) Change subject: IMPALA-8895: Expose daemon health endpoint .. Patch Set 2: Build Failed https://jenkins.impala.io/job/gerrit-

[Impala-ASF-CR] IMPALA-8890: Advance read page in UnpinStream

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14144 ) Change subject: IMPALA-8890: Advance read page in UnpinStream .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-8890: Advance read page in UnpinStream

2019-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14144 ) Change subject: IMPALA-8890: Advance read page in UnpinStream .. Patch Set 4: Build started: https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-8851: Do not throw authorization exception in drop if exists queries

2019-08-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14121 ) Change subject: IMPALA-8851: Do not throw authorization exception in drop if exists queries .. Patch Set 5: (1 comment) http://gerri

  1   2   >