[Impala-ASF-CR] IMPALA-9620: Ensure group-by and cnf exprs are analyzed

2020-04-08 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/15693 ) Change subject: IMPALA-9620: Ensure group-by and cnf exprs are analyzed .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-9620: Ensure group-by and cnf exprs are analyzed

2020-04-08 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15693 ) Change subject: IMPALA-9620: Ensure group-by and cnf exprs are analyzed .. Patch Set 1: Code-Review+2 (2 comments) The fix makes sen

[Impala-ASF-CR] IMPALA-8632: Add support for self-event detection for insert events

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15648 ) Change subject: IMPALA-8632: Add support for self-event detection for insert events .. Patch Set 9: Build Successful https:/

[Impala-ASF-CR] IMPALA-8632: Add support for self-event detection for insert events

2020-04-08 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15648 ) Change subject: IMPALA-8632: Add support for self-event detection for insert events .. IMPALA-8632: Add support for self

[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15653 ) Change subject: IMPALA-9602: Fix case-sensitivity for local catalog .. Patch Set 5: Verified+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15653 ) Change subject: IMPALA-9602: Fix case-sensitivity for local catalog .. IMPALA-9602: Fix case-sensitivity for local cata

[Impala-ASF-CR] IMPALA-8632: Add support for self-event detection for insert events

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15648 ) Change subject: IMPALA-8632: Add support for self-event detection for insert events .. Patch Set 9: (2 comments) http://gerr

[Impala-ASF-CR] IMPALA-8632: Add support for self-event detection for insert events

2020-04-08 Thread Xiaomeng Zhang (Code Review)
Xiaomeng Zhang has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/15648 ) Change subject: IMPALA-8632: Add support for self-event detection for insert events .. IMPALA-8632: Add support for self-event detectio

[Impala-ASF-CR] IMPALA-9616

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 ) Change subject: IMPALA-9616 .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/15692/1//COMMIT_MSG Commit Message: htt

[Impala-ASF-CR] IMPALA-9618: fix some usability issues with dev env

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15687 ) Change subject: IMPALA-9618: fix some usability issues with dev env .. Patch Set 8: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-9613 Document the data cache eviction policy

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15694 ) Change subject: IMPALA-9613 Document the data_cache_eviction_policy .. Patch Set 1: Verified-1 Build Failed https://jenkins.i

[Impala-ASF-CR] IMPALA-9618: fix some usability issues with dev env

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15687 ) Change subject: IMPALA-9618: fix some usability issues with dev env .. Patch Set 7: Build Successful https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-9613 Document the data cache eviction policy

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15694 ) Change subject: IMPALA-9613 Document the data_cache_eviction_policy .. Patch Set 1: Build Started https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-9613 Document the data cache eviction policy

2020-04-08 Thread Kristine Hahn (Code Review)
Kristine Hahn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15694 Change subject: IMPALA-9613 Document the data_cache_eviction_policy .. IMPALA-9613 Document the data_cache_eviction_policy Added how to

[Impala-ASF-CR] IMPALA-9618: fix some usability issues with dev env

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15687 ) Change subject: IMPALA-9618: fix some usability issues with dev env .. Patch Set 9: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-9618: fix some usability issues with dev env

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15687 ) Change subject: IMPALA-9618: fix some usability issues with dev env .. Patch Set 9: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 7: Looks like IMPALA-9596 -- To view,

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 7: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-9618: fix some usability issues with dev env

2020-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15687 ) Change subject: IMPALA-9618: fix some usability issues with dev env .. Patch Set 8: Code-Review+2 Thanks! Glad to be free from the tyran

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 7: Looks like a flaky test, I'll file a

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 7: Build started: https://jenkin

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 6: Yeah that could be worth doing, it seems relatively safe

[native-toolchain-CR] Add build script to create and publish Docker containers

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 ) Change subject: Add build script to create and publish Docker containers .. Patch Set 3: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-9618: fix some usability issues with dev env

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15687 ) Change subject: IMPALA-9618: fix some usability issues with dev env .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-9618: fix some usability issues with dev env

2020-04-08 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15687 to look at the new patch set (#8). Change subject: IMPALA-9618: fix some usability issues with dev env ..

[Impala-ASF-CR] IMPALA-9618: fix some usability issues with dev env

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15687 ) Change subject: IMPALA-9618: fix some usability issues with dev env .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9618: fix some usability issues with dev env

2020-04-08 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15687 to look at the new patch set (#7). Change subject: IMPALA-9618: fix some usability issues with dev env ..

[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 21: Build Successful https://jenkins.impala.io/job/gerrit-code-

[Impala-ASF-CR] IMPALA-9620: Ensure group-by and cnf exprs are analyzed

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15693 ) Change subject: IMPALA-9620: Ensure group-by and cnf exprs are analyzed .. Patch Set 1: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-8857: Fix flaky Kudu tests with external inserts

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15633 ) Change subject: IMPALA-8857: Fix flaky Kudu tests with external inserts .. Patch Set 2: Verified+1 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-8857: Fix flaky Kudu tests with external inserts

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15633 ) Change subject: IMPALA-8857: Fix flaky Kudu tests with external inserts .. IMPALA-8857: Fix flaky Kudu tests with exter

[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops

2020-04-08 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 21: Hi, Tim. This has been modified as your request. -- To vi

[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops

2020-04-08 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/15300/18//

[Impala-ASF-CR] IMPALA-9428 Add arm64 atomic ops

2020-04-08 Thread Anonymous Coward (Code Review)
zhaoren...@hotmail.com has uploaded a new patch set (#21). ( http://gerrit.cloudera.org:8080/15300 ) Change subject: IMPALA-9428 Add arm64 atomic ops .. IMPALA-9428 Add arm64 atomic ops Atomic ops are implemented by asm. Differ

[Impala-ASF-CR] IMPALA-9398: Fix shell history duplication when cmdloop breaks

2020-04-08 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15345 ) Change subject: IMPALA-9398: Fix shell history duplication when cmdloop breaks .. Patch Set 4: > Patch Set 4: > > Hi Fang-Yu, > > It is

[Impala-ASF-CR] IMPALA-9620: Ensure group-by and cnf exprs are analyzed

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15693 ) Change subject: IMPALA-9620: Ensure group-by and cnf exprs are analyzed .. Patch Set 1: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-9620: Ensure group-by and cnf exprs are analyzed

2020-04-08 Thread Aman Sinha (Code Review)
Aman Sinha has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15693 Change subject: IMPALA-9620: Ensure group-by and cnf exprs are analyzed .. IMPALA-9620: Ensure group-by and cnf exprs are analyzed This ch

[Impala-ASF-CR] IMPALA-9616

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 ) Change subject: IMPALA-9616 .. Patch Set 1: Verified+1 Build Successful https://jenkins.impala.io/job/gerrit-docs-auto-test/5

[Impala-ASF-CR] IMPALA-9616

2020-04-08 Thread Kristine Hahn (Code Review)
Kristine Hahn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15692 Change subject: IMPALA-9616 .. IMPALA-9616 Added new query options topics: --A topic to cover the spill-to-disk compression support --A

[Impala-ASF-CR] IMPALA-9616

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 ) Change subject: IMPALA-9616 .. Patch Set 1: Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/575/ Testing do

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 6: Verified-1 Build failed: http

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 6: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15653 ) Change subject: IMPALA-9602: Fix case-sensitivity for local catalog .. Patch Set 5: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog

2020-04-08 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15653 ) Change subject: IMPALA-9602: Fix case-sensitivity for local catalog .. Patch Set 4: > Build failed: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15653 ) Change subject: IMPALA-9602: Fix case-sensitivity for local catalog .. Patch Set 5: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 6: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5746: Test case for remote fragments releasing memory

2020-04-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15666 ) Change subject: IMPALA-5746: Test case for remote fragments releasing memory .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/15624/6/infra

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 6: Code-Review+1 LGTM pending the perf issues -- To view,

[Impala-ASF-CR] IMPALA-9590 Resolve error when build tsan and ubsan on arm64

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15630 ) Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 .. IMPALA-9590 Resolve error when build ts

[Impala-ASF-CR] IMPALA-9590 Resolve error when build tsan and ubsan on arm64

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15630 ) Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 .. Patch Set 11: Verified+1 -- To view, visit ht

[native-toolchain-CR] Add build script to create and publish Docker containers

2020-04-08 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 ) Change subject: Add build script to create and publish Docker containers .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/

[native-toolchain-CR] Add build script to create and publish Docker containers

2020-04-08 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 ) Change subject: Add build script to create and publish Docker containers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15653 ) Change subject: IMPALA-9602: Fix case-sensitivity for local catalog .. Patch Set 4: Verified-1 Build failed: https://jenkins.i

[native-toolchain-CR] Add build script to create and publish Docker containers

2020-04-08 Thread Laszlo Gaal (Code Review)
Hello Hector Acosta, David Knupp, Tim Armstrong, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15675 to look at the new patch set (#2). Change subject: Add build script to create and publish Docker containers

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 6: > Patch Set 6: > > I think we can probably live with a 10-

[Impala-ASF-CR] IMPALA-8857: Fix flaky Kudu tests with external inserts

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15633 ) Change subject: IMPALA-8857: Fix flaky Kudu tests with external inserts .. Patch Set 2: Code-Review+2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-8857: Fix flaky Kudu tests with external inserts

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15633 ) Change subject: IMPALA-8857: Fix flaky Kudu tests with external inserts .. Patch Set 2: Build started: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-8857: Fix flaky Kudu tests with external inserts

2020-04-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15633 ) Change subject: IMPALA-8857: Fix flaky Kudu tests with external inserts .. Patch Set 1: Code-Review+2 This looks good to me -- To vi

[native-toolchain-CR] Add build script to create and publish Docker containers

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 ) Change subject: Add build script to create and publish Docker containers .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080

[native-toolchain-CR] Add build script to create and publish Docker containers

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15675 ) Change subject: Add build script to create and publish Docker containers .. Patch Set 1: Code-Review+2 LGTM once the minor things are

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 5: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 6: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 6: Build started: https://jenkin

[Impala-ASF-CR] IMPALA-9625: Convert fully-qualified table name to lowercase in getTable()

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15689 ) Change subject: IMPALA-9625: Convert fully-qualified table name to lowercase in getTable() .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9625: Convert fully-qualified table name to lowercase in getTable()

2020-04-08 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15689 Change subject: IMPALA-9625: Convert fully-qualified table name to lowercase in getTable() .. IMPALA-9625: Convert fully-qualified table

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 5: Build Successful https://jen

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 13: Build Successful https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 4: Build Successful https://jen

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 12: Build Successful https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3.

2020-04-08 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15524 ) Change subject: IMPALA-3343, IMPALA-9489: Make impala-shell compatible with python 3. .. Patch Set 6: (3 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 5: (1 comment) http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Riza Suminto (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15673 to look at the new patch set (#5). Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 11: Build Successful https://jenkins.impala.io/job/gerr

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 6: I think we can probably live with a 10-15% regression fo

[Impala-ASF-CR] Add CentOS 8.1 support to bootstrap system.sh

2020-04-08 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 ) Change subject: Add CentOS 8.1 support to bootstrap_system.sh .. Patch Set 10: Note: There is one final update coming before this patch

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 13: Note: There is one final update coming before this patch can b

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 4: (1 comment) LGTM aside from a minor

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 13: (1 comment) Carry +1 from Tim http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1

2020-04-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15642 ) Change subject: IMPALA-9362: Upgrade sqlparse 0.1.19 -> 0.3.1 .. Patch Set 6: > Patch Set 6: > > Agree it would be good to sanity check

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Laszlo Gaal (Code Review)
Hello David Knupp, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15624 to look at the new patch set (#13). Change subject: Use Python from the toolchain for Impala ...

[Impala-ASF-CR] Add CentOS 8.1 support to bootstrap system.sh

2020-04-08 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 ) Change subject: Add CentOS 8.1 support to bootstrap_system.sh .. Patch Set 10: Code-Review+1 (3 comments) Carry +1 from Tim http://ger

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Laszlo Gaal (Code Review)
Hello David Knupp, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15624 to look at the new patch set (#12). Change subject: Use Python from the toolchain for Impala ...

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 11: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] Add CentOS 8.1 support to bootstrap system.sh

2020-04-08 Thread Laszlo Gaal (Code Review)
Hello Zoltan Borok-Nagy, David Knupp, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15623 to look at the new patch set (#10). Change subject: Add CentOS 8.1 support to bootstrap_system.sh ..

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/15624/6//COM

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 4: (5 comments) Thanks, Tim! Learn new s

[Impala-ASF-CR] Add CentOS 8.1 support to bootstrap system.sh

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 ) Change subject: Add CentOS 8.1 support to bootstrap_system.sh .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] Add CentOS 8.1 support to bootstrap system.sh

2020-04-08 Thread Laszlo Gaal (Code Review)
Hello Zoltan Borok-Nagy, David Knupp, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15623 to look at the new patch set (#9). Change subject: Add CentOS 8.1 support to bootstrap_system.sh ...

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Laszlo Gaal (Code Review)
Hello David Knupp, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15624 to look at the new patch set (#11). Change subject: Use Python from the toolchain for Impala ...

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/15624/6//COM

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Riza Suminto (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15673 to look at the new patch set (#4). Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

[Impala-ASF-CR] IMPALA-9590 Resolve error when build tsan and ubsan on arm64

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15630 ) Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 .. Patch Set 11: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-9590 Resolve error when build tsan and ubsan on arm64

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15630 ) Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 .. Patch Set 10: Code-Review+2 -- To view, visit http://

[Impala-ASF-CR] IMPALA-9590 Resolve error when build tsan and ubsan on arm64

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15630 ) Change subject: IMPALA-9590 Resolve error when build tsan and ubsan on arm64 .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15653 ) Change subject: IMPALA-9602: Fix case-sensitivity for local catalog .. Patch Set 4: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-9602: Fix case-sensitivity for local catalog

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15653 ) Change subject: IMPALA-9602: Fix case-sensitivity for local catalog .. Patch Set 4: Build started: https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival

2020-04-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15673 ) Change subject: IMPALA-9612: Fix race condition in RuntimeFilter::WaitForArrival .. Patch Set 3: (5 comments) Thanks for adding the t

[Impala-ASF-CR] Use Python from the toolchain for Impala

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15624 ) Change subject: Use Python from the toolchain for Impala .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerri

[Impala-ASF-CR] Add CentOS 8.1 support to bootstrap system.sh

2020-04-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15623 ) Change subject: Add CentOS 8.1 support to bootstrap_system.sh .. Patch Set 7: Build Successful https://jenkins.impala.io/job/

  1   2   >