[Impala-ASF-CR] IMPALA-10005: Fix Snappy decompression for non-block filesystems

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16278 ) Change subject: IMPALA-10005: Fix Snappy decompression for non-block filesystems .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-10037: Remove flaky test mt dop scan node

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16286 ) Change subject: IMPALA-10037: Remove flaky test_mt_dop_scan_node .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10047: Revert core piece of IMPALA-6984

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16288 ) Change subject: IMPALA-10047: Revert core piece of IMPALA-6984 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16252 ) Change subject: IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-10047: Revert core piece of IMPALA-6984

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16288 ) Change subject: IMPALA-10047: Revert core piece of IMPALA-6984 .. Patch Set 1: Build Successful

[Impala-ASF-CR] Add logging when query unregisters

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16285 ) Change subject: Add logging when query unregisters .. Patch Set 3: Build started:

[Impala-ASF-CR] Add logging when query unregisters

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16285 ) Change subject: Add logging when query unregisters .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10037: Remove flaky test mt dop scan node

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16286 ) Change subject: IMPALA-10037: Remove flaky test_mt_dop_scan_node .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10037: Remove flaky test mt dop scan node

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16286 ) Change subject: IMPALA-10037: Remove flaky test_mt_dop_scan_node .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Add logging when query unregisters

2020-08-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16285 ) Change subject: Add logging when query unregisters .. Patch Set 2: Code-Review+2 Carrying forward Tim's +2 -- To view, visit

[Impala-ASF-CR] Add logging when query unregisters

2020-08-04 Thread Bikramjeet Vig (Code Review)
Hello Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16285 to look at the new patch set (#2). Change subject: Add logging when query unregisters

[Impala-ASF-CR] IMPALA-10037: Remove flaky test mt dop scan node

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16286 ) Change subject: IMPALA-10037: Remove flaky test_mt_dop_scan_node .. Patch Set 1: Build Successful

[Impala-ASF-CR] Add logging when query unregisteres

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16285 ) Change subject: Add logging when query unregisteres .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10047: Revert core piece of IMPALA-6984

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16288 ) Change subject: IMPALA-10047: Revert core piece of IMPALA-6984 .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-10047: Revert core piece of IMPALA-6984

2020-08-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16288 Change subject: IMPALA-10047: Revert core piece of IMPALA-6984 .. IMPALA-10047: Revert core piece of IMPALA-6984 Performance testing

[Impala-ASF-CR] IMPALA-10005: Fix Snappy decompression for non-block filesystems

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16278 ) Change subject: IMPALA-10005: Fix Snappy decompression for non-block filesystems .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10037: Remove flaky test mt dop scan node

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16286 ) Change subject: IMPALA-10037: Remove flaky test_mt_dop_scan_node .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Add logging when query unregisteres

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16285 ) Change subject: Add logging when query unregisteres .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-10037: Remove flaky test mt dop scan node

2020-08-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16286 Change subject: IMPALA-10037: Remove flaky test_mt_dop_scan_node .. IMPALA-10037: Remove flaky test_mt_dop_scan_node This test has

[Impala-ASF-CR] Add logging when query unregisteres

2020-08-04 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16285 Change subject: Add logging when query unregisteres .. Add logging when query unregisteres This adds a log line which is printed when

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-04 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 ) Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. Patch Set 2: For the variants that are added, could you add a

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. IMPALA-9984: Implement codegen for

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 ) Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. Patch Set 2: Code-Review+1 LGTM. I can +2 but wanted to

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 3: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. IMPALA-9909: Print body of http error

[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16252 ) Change subject: IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16252 ) Change subject: IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 3: Code-Review+1 (2

[Impala-ASF-CR] IMPALA-10005: Fix Snappy decompression for non-block filesystems

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16278 ) Change subject: IMPALA-10005: Fix Snappy decompression for non-block filesystems .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user

2020-08-04 Thread Thomas Tauber-Marshall (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16252 to look at the new patch set (#2). Change subject: IMPALA-9988 (part 2): Integrate ldap filters and impala.doas.user

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. Patch Set 27: Build Successful

[Impala-ASF-CR] IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans

2020-08-04 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#27). ( http://gerrit.cloudera.org:8080/16098 ) Change subject: IMPALA-9744: Treat corrupt table stats as missing to avoid bad plans .. IMPALA-9744: Treat corrupt table stats as missing

[Impala-ASF-CR] IMPALA-5022: Outer join simplification

2020-08-04 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022: Outer join simplification .. Patch Set 5: (1 comment) Add one more comment. Thanks!

[Impala-ASF-CR] IMPALA-5022: Outer join simplification

2020-08-04 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022: Outer join simplification .. Patch Set 5: (10 comments) Hi Xianqing, thank you so much for this

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-9984: Implement codegen for TupleIsNullPredicate

2020-08-04 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16227 ) Change subject: IMPALA-9984: Implement codegen for TupleIsNullPredicate .. IMPALA-9984: Implement codegen for TupleIsNullPredicate This

[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5022: Outer join simplification

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022: Outer join simplification .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9909: Print body of http error code in Impala Shell.

2020-08-04 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16269 ) Change subject: IMPALA-9909: Print body of http error code in Impala Shell. .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator

2020-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: WIP IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator .. Patch Set

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) .. Patch Set 6: Verified+1

[Impala-ASF-CR] IMPALA-10005: Fix Snappy decompression for non-block filesystems

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16278 ) Change subject: IMPALA-10005: Fix Snappy decompression for non-block filesystems .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 ) Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10005: Fix Snappy decompression for non-block filesystems

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16278 ) Change subject: IMPALA-10005: Fix Snappy decompression for non-block filesystems .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-10029: Strip debug symbols from libkudu client and libstdc++ binaries

2020-08-04 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16263 ) Change subject: IMPALA-10029: Strip debug symbols from libkudu_client and libstdc++ binaries .. Patch Set 3: (2 comments) Looks good

[Impala-ASF-CR] IMPALA-10005: Fix Snappy decompression for non-block filesystems

2020-08-04 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16278 to look at the new patch set (#2). Change subject: IMPALA-10005: Fix Snappy decompression for non-block filesystems

[Impala-ASF-CR] IMPALA-5022: Outer join simplification

2020-08-04 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022: Outer join simplification .. Patch Set 5: (14 comments) Thanks for the work.

[Impala-ASF-CR] IMPALA-9989 Improve admission control pool stats logging

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16220 ) Change subject: IMPALA-9989 Improve admission control pool stats logging .. Patch Set 22: Build Successful

[Impala-ASF-CR] IMPALA-9989 Improve admission control pool stats logging

2020-08-04 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#22). ( http://gerrit.cloudera.org:8080/16220 ) Change subject: IMPALA-9989 Improve admission control pool stats logging .. IMPALA-9989 Improve admission control pool stats logging This

[Impala-ASF-CR] IMPALA-9741: Support querying Iceberg table by impala

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 ) Change subject: IMPALA-9741: Support querying Iceberg table by impala .. Patch Set 17: Build Successful

[Impala-ASF-CR] IMPALA-9741: Support querying Iceberg table by impala

2020-08-04 Thread wangsheng (Code Review)
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16143 ) Change subject: IMPALA-9741: Support querying Iceberg table by impala .. Patch Set 17: (4 comments) Hi anjalinorwood, thanks for your

[Impala-ASF-CR] IMPALA-9741: Support querying Iceberg table by impala

2020-08-04 Thread wangsheng (Code Review)
Hello Zoltan Borok-Nagy, Anonymous Coward (606), Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16143 to look at the new patch set (#17). Change subject: IMPALA-9741: Support querying Iceberg table by impala

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-04 Thread Adam Tamas (Code Review)
Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/16283 ) Change subject: IMPALA-10018: Implement ds_kll_rank() function .. Patch Set 2: Code-Review+1 LGTM! -- To view, visit

[Impala-ASF-CR] IMPALA-5022: Outer join simplification

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022: Outer join simplification .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) .. Patch Set 6: Build

[Impala-ASF-CR] IMPALA-5022: Outer join simplification

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022: Outer join simplification .. Patch Set 5: Build started:

[Impala-ASF-CR] WIP

2020-08-04 Thread Xianqing He (Code Review)
Xianqing He has abandoned this change. ( http://gerrit.cloudera.org:8080/15614 ) Change subject: WIP .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/15614 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) .. Patch Set 6: Build

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Aman Sinha, Gabor Kaszab, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16228 to look at the new patch set (#6). Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex

[Impala-ASF-CR] IMPALA-5022: Outer join simplification

2020-08-04 Thread Xianqing He (Code Review)
Xianqing He has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022: Outer join simplification .. IMPALA-5022: Outer join simplification As a general rule, an outer join can be

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) .. Patch Set 5: Verified-1

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 ) Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) .. Patch Set 5: Build

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Aman Sinha, Gabor Kaszab, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16228 to look at the new patch set (#5). Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) .. Patch Set 5: Build

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) .. Patch Set 5: PS5 is a

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16228 ) Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types) .. Patch Set 4: (6 comments)

[Impala-ASF-CR] IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex types)

2020-08-04 Thread Zoltan Borok-Nagy (Code Review)
Hello Aman Sinha, Gabor Kaszab, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16228 to look at the new patch set (#4). Change subject: IMPALA-9859: Full ACID Milestone 4: Part 2 Reading modified tables (complex

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16283 ) Change subject: IMPALA-10018: Implement ds_kll_rank() function .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16259 ) Change subject: IMPALA-9963: Implement ds_kll_n() function .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16283 ) Change subject: IMPALA-10018: Implement ds_kll_rank() function .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-04 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16283 to look at the new patch set (#2). Change subject: IMPALA-10018: Implement ds_kll_rank() function

[Impala-ASF-CR] IMPALA-9963: Implement ds kll n() function

2020-08-04 Thread Gabor Kaszab (Code Review)
Hello Adam Tamas, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16259 to look at the new patch set (#4). Change subject: IMPALA-9963: Implement ds_kll_n() function

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-04 Thread Adam Tamas (Code Review)
Adam Tamas has posted comments on this change. ( http://gerrit.cloudera.org:8080/16283 ) Change subject: IMPALA-10018: Implement ds_kll_rank() function .. Patch Set 1: (1 comment) Hi Gabor, Thank you for the good work with

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16283 ) Change subject: IMPALA-10018: Implement ds_kll_rank() function .. Patch Set 1: Build Successful

[Impala-ASF-CR] WIP IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16240 ) Change subject: WIP IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator ..

[Impala-ASF-CR] IMPALA-10018: Implement ds kll rank() function

2020-08-04 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16283 Change subject: IMPALA-10018: Implement ds_kll_rank() function .. IMPALA-10018: Implement ds_kll_rank() function ds_kll_rank() receives

[Impala-ASF-CR] WIP IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator

2020-08-04 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16240 to look at the new patch set (#5). Change subject: WIP IMPALA-9955,IMPALA-9957: Fix not enough reservation for large read/write pages in GroupingAggregator

[Impala-ASF-CR] IMPALA-5022: Outer join simplification

2020-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022: Outer join simplification .. Patch Set 4: Build failed: