[Impala-ASF-CR] IMPALA-9224 (part 1): Blacklist nodes with faulty disks

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16949 ) Change subject: IMPALA-9224 (part 1): Blacklist nodes with faulty disks .. Patch Set 8: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-10377: Improve the accuracy of resource estimation PlanNode does not consider some factors when estimating memory, this will cause a large error rate

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16842 ) Change subject: IMPALA-10377: Improve the accuracy of resource estimation PlanNode does not consider some factors when estimating memory, this will cause a large error rate ..

[Impala-ASF-CR] IMPALA-9224 (part 1): Blacklist nodes with faulty disks

2021-01-25 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/16949 ) Change subject: IMPALA-9224 (part 1): Blacklist nodes with faulty disks .. IMPALA-9224 (part 1): Blacklist nodes with faulty disks This pa

[Impala-ASF-CR] IMPALA-10377: Improve the accuracy of resource estimation PlanNode does not consider some factors when estimating memory, this will cause a large error rate

2021-01-25 Thread liuyao (Code Review)
Hello Aman Sinha, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16842 to look at the new patch set (#16). Change subject: IMPALA-10377: Improve the accuracy of resource estimation PlanNode does not con

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 12: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 12: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 11: Hit IMPALA-10316 -- To view, visit http:

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16966 ) Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16966 ) Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. Patch Set 5: Build started: https://jen

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 11: Verified-1 Build failed: https://j

[Impala-ASF-CR] IMPALA-9224 (part 1): Blacklist nodes with faulty disks

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16949 ) Change subject: IMPALA-9224 (part 1): Blacklist nodes with faulty disks .. Patch Set 7: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 28: Build Successful https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-9224 (part 1): Blacklist nodes with faulty disks

2021-01-25 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/16949 ) Change subject: IMPALA-9224 (part 1): Blacklist nodes with faulty disks .. IMPALA-9224 (part 1): Blacklist nodes with faulty disks This pa

[Impala-ASF-CR] IMPALA-9224 (part 1): Blacklist nodes with faulty disks

2021-01-25 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16949 ) Change subject: IMPALA-9224 (part 1): Blacklist nodes with faulty disks .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#28). Change subject: IMPALA-9979: part 2: partitioned top-n .

[Impala-ASF-CR] IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16908 ) Change subject: IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions .. IMPALA-2019(P

[Impala-ASF-CR] IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16908 ) Change subject: IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions .. Patch Set 12: Verifie

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 27: Verified+1 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16966 ) Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 ) Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support .. Patch Set 1: Verified+1 Build Successful https

[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16982 ) Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support .. Patch Set 1: Build Started https://jenkins.impa

[Impala-ASF-CR] IMPALA-10404: Update docs to reflect RLE DICTIONARY support

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16982 Change subject: IMPALA-10404: Update docs to reflect RLE_DICTIONARY support .. IMPALA-10404: Update docs to reflect RLE_DICTIONARY suppo

[Impala-ASF-CR] IMPALA-8306: clarify wording on /sessions UI

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16981 ) Change subject: IMPALA-8306: clarify wording on /sessions UI .. Patch Set 1: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-9224 (part 1): Blacklist nodes with faulty disks

2021-01-25 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16949 ) Change subject: IMPALA-9224 (part 1): Blacklist nodes with faulty disks .. Patch Set 6: (3 comments) As discussed, it would

[Impala-ASF-CR] IMPALA-8306: clarify wording on /sessions UI

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16981 Change subject: IMPALA-8306: clarify wording on /sessions UI .. IMPALA-8306: clarify wording on /sessions UI Change-Id: I01578feb0f2bcc

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 11: Thanks for the review! -- To view, visit

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 11: Build started: https://jenkins.imp

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 11: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-9793: Impala quickstart cluster with docker-compose

2021-01-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15966 ) Change subject: IMPALA-9793: Impala quickstart cluster with docker-compose .. Patch Set 10: Code-Review+2 This looks good to me. Thank

[Impala-ASF-CR] WIP: IMPALA-1652: fix char semantics

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/16339 ) Change subject: WIP: IMPALA-1652: fix char semantics .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/16339 To unsubscribe, visit

[Impala-ASF-CR] WIP: IMPALA-2138: part 4: implicit cast handling

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14399 ) Change subject: WIP: IMPALA-2138: part 4: implicit cast handling .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] WIP: IMPALA-1652: fix char semantics

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16339 Change subject: WIP: IMPALA-1652: fix char semantics .. WIP: IMPALA-1652: fix char semantics select 'expected 2',count(*) from ax where

[Impala-ASF-CR] WIP: IMPALA-2138: part 4: implicit cast handling

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14399 Change subject: WIP: IMPALA-2138: part 4: implicit cast handling .. WIP: IMPALA-2138: part 4: implicit cast handling This solves some l

[Impala-ASF-CR] WIP: IMPALA-2138: part 4: implicit cast handling

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/14399 ) Change subject: WIP: IMPALA-2138: part 4: implicit cast handling .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/14399 To unsubsc

[Impala-ASF-CR] WIP: IMPALA-2138,IMPALA-1306: project tuples before exchanges

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14216 ) Change subject: WIP: IMPALA-2138,IMPALA-1306: project tuples before exchanges .. Patch Set 8: (2 comments) http://gerrit.clou

[Impala-ASF-CR] WIP: IMPALA-2138,IMPALA-1306: project tuples before exchanges

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/14216 ) Change subject: WIP: IMPALA-2138,IMPALA-1306: project tuples before exchanges .. Abandoned not doing for now -- To view, visit http://gerrit.cl

[Impala-ASF-CR] WIP: IMPALA-2138,IMPALA-1306: project tuples before exchanges

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14216 Change subject: WIP: IMPALA-2138,IMPALA-1306: project tuples before exchanges .. WIP: IMPALA-2138,IMPALA-1306: project tuples before exc

[Impala-ASF-CR] WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16214 ) Change subject: WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen .. Patch Set 1: (2 comments) http://gerrit.clou

[Impala-ASF-CR] WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/16214 ) Change subject: WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen .. Abandoned Now redundant, this was solved in a different way --

[Impala-ASF-CR] WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16214 Change subject: WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator codegen .. WIP: IMPALA-3816,IMPALA-4065: full TupleRowComparator c

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16966 ) Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. Patch Set 4: Build Successful https://

[Impala-ASF-CR] IMPALA-10447: Add a newline when exporting shell output to a file.

2021-01-25 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16966 ) Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. .. IMPALA-10447: Add a newline when exporting shell

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 27: Build Successful https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16908 ) Change subject: IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions .. Patch Set 12: Code-Re

[Impala-ASF-CR] IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16908 ) Change subject: IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions .. Patch Set 12: Build

[Impala-ASF-CR] IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16908 ) Change subject: IMPALA-2019(Part-1): Provide UTF-8 support in length, substring and reverse functions .. Patch Set 11: Code-Review+2

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 27: Rebased onto master after the previous patch was merged -- T

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 27: Build started: https://jenkins.impala.io/job/gerrit-ve

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#27). Change subject: IMPALA-9979: part 2: partitioned top-n .

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-01-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch Set 5

[Impala-ASF-CR] IMPALA-10147: Avoid getting a file handle for data cache hits

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16963 ) Change subject: IMPALA-10147: Avoid getting a file handle for data cache hits .. IMPALA-10147: Avoid getting a file han

[Impala-ASF-CR] IMPALA-10147: Avoid getting a file handle for data cache hits

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16963 ) Change subject: IMPALA-10147: Avoid getting a file handle for data cache hits .. Patch Set 3: Verified+1 -- To view, visit ht

[Impala-ASF-CR] IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16979 ) Change subject: IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax .. Patch Set 1: Build Successful https://

[Impala-ASF-CR] IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax

2021-01-25 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16979 Change subject: IMPALA-10452: CREATE Iceberg tables with old PARTITIONED BY syntax .. IMPALA-10452: CREATE Iceberg tables with old

[Impala-ASF-CR] IMPALA-10147: Avoid getting a file handle for data cache hits

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16963 ) Change subject: IMPALA-10147: Avoid getting a file handle for data cache hits .. Patch Set 3: Build started: https://jenkins.i

[Impala-ASF-CR] IMPALA-10147: Avoid getting a file handle for data cache hits

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16963 ) Change subject: IMPALA-10147: Avoid getting a file handle for data cache hits .. Patch Set 3: Code-Review+2 -- To view, visit