[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 33: (3 comments) Just one other comment after which I am ready to

[Impala-ASF-CR] IMPALA-9586: update query option docs for mt dop

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17043 ) Change subject: IMPALA-9586: update query option docs for mt_dop .. Patch Set 2: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-9586: update query option docs for mt dop

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17043 ) Change subject: IMPALA-9586: update query option docs for mt_dop .. Patch Set 2: Build Started

[Impala-ASF-CR] IMPALA-9586: update query option docs for mt dop

2021-02-08 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17043 to look at the new patch set (#2). Change subject: IMPALA-9586: update query option docs for mt_dop

[Impala-ASF-CR] IMPALA-8721: re-enable test hive impala interop

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17042 ) Change subject: IMPALA-8721: re-enable test_hive_impala_interop .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9586: update query option docs for mt dop

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17043 ) Change subject: IMPALA-9586: update query option docs for mt_dop .. Patch Set 1: Verified-1 Build Failed

[Impala-ASF-CR] IMPALA-9586: update query option docs for mt dop

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17043 ) Change subject: IMPALA-9586: update query option docs for mt_dop .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-9586: update query option docs for mt dop

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17043 Change subject: IMPALA-9586: update query option docs for mt_dop .. IMPALA-9586: update query option docs for mt_dop There are

[Impala-ASF-CR] IMPALA-8721: re-enable test hive impala interop

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17042 Change subject: IMPALA-8721: re-enable test_hive_impala_interop .. IMPALA-8721: re-enable test_hive_impala_interop The test now passes

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: (21 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 32: Build Successful

[Impala-ASF-CR] wip

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17040 ) Change subject: wip .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/8096/ : Initial

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 31: Build Successful

[Impala-ASF-CR] MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

2021-02-08 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17038 ) Change subject: MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException ..

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-02-08 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 30: (1 comment)

[Impala-ASF-CR] wip

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/17040 ) Change subject: wip .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/17040 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#32). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#31). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] wip

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17040 Change subject: wip .. wip Change-Id: If1919b896ee3e4eaef2d02cf8b1d29d7a0996632 --- M be/src/exec/topn-node.cc M

[Impala-ASF-CR] IMPALA-10469: push quickstart to apache repo

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17030 ) Change subject: IMPALA-10469: push quickstart to apache repo .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. Patch Set 35: Build Successful

[Impala-ASF-CR] IMPALA-9867: Add Support for Spilling to S3: Milestone 1

2021-02-08 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#35). ( http://gerrit.cloudera.org:8080/16318 ) Change subject: IMPALA-9867: Add Support for Spilling to S3: Milestone 1 .. IMPALA-9867: Add Support for Spilling to S3: Milestone 1 Major

[Impala-ASF-CR] IMPALA-10469: push quickstart to apache repo

2021-02-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17030 ) Change subject: IMPALA-10469: push quickstart to apache repo .. Patch Set 2: (1 comment) I think this makes sense. The version

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 18: Build Failed

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16833 ) Change subject: [WiP] SAML implementation in Impala .. Patch Set 18: (20 comments)

[Impala-ASF-CR] [WiP] SAML implementation in Impala

2021-02-08 Thread Csaba Ringhofer (Code Review)
Hello Thomas Tauber-Marshall, Vihang Karajgaonkar, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16833 to look at the new patch set (#18). Change subject: [WiP] SAML implementation in Impala

[Impala-ASF-CR] IMPALA-10161: User LDAP Search bind support

2021-02-08 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/16717 ) Change subject: IMPALA-10161: User LDAP Search bind support .. Patch Set 10: (4 comments) Hi Thomas, thank you for the review, update

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-08 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#63). ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. IMPALA-10325:

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: Code-Review+1 With the exception of small number of review

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: (5 comments)

[Impala-ASF-CR] MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

2021-02-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17038 ) Change subject: MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException ..

[Impala-ASF-CR] MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

2021-02-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17038 ) Change subject: MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException ..

[Impala-ASF-CR] IMPALA-9234: Support Ranger row filtering policies

2021-02-08 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16976 ) Change subject: IMPALA-9234: Support Ranger row filtering policies .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. Patch

[Impala-ASF-CR] IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate

2021-02-08 Thread Qifan Chen (Code Review)
Qifan Chen has uploaded a new patch set (#62). ( http://gerrit.cloudera.org:8080/16720 ) Change subject: IMPALA-10325: Parquet scan should use min/max statistics to skip pages based on equi-join predicate .. IMPALA-10325:

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17039 ) Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution .. Patch Set 1:

[Impala-ASF-CR] IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution

2021-02-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17039 Change subject: IMPALA-10485: part(1): make ORC column reader creation independent of schema resolution .. IMPALA-10485: part(1):

[Impala-ASF-CR] IMPALA-9234: Support Ranger row filtering policies

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16976 ) Change subject: IMPALA-9234: Support Ranger row filtering policies .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9234: Support Ranger row filtering policies

2021-02-08 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16976 ) Change subject: IMPALA-9234: Support Ranger row filtering policies .. Patch Set 2: (4 comments) Thanks Tim's comments! This patch

[Impala-ASF-CR] IMPALA-9234: Support Ranger row filtering policies

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16976 ) Change subject: IMPALA-9234: Support Ranger row filtering policies .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9234: Support Ranger row filtering policies

2021-02-08 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16976 to look at the new patch set (#2). Change subject: IMPALA-9234: Support Ranger row filtering policies

[Impala-ASF-CR] MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17038 ) Change subject: MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

[Impala-ASF-CR] MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException

2021-02-08 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17038 Change subject: MPALA-10482: Select-star query on unrelative collection column of transactional table hits IllegalStateException ..