[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-11-30 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 13: (10 comments)

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 13: Build Successful

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-11-30 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. IMPALA-11470: Add Cache For Codegen Functions The patch adds supports of

[Impala-ASF-CR] IMPALA-11470: Add Cache For Codegen Functions

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19181 ) Change subject: IMPALA-11470: Add Cache For Codegen Functions .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19291 ) Change subject: IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-11-30 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 9: (5 comments) I slightly revised the patch

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-11-30 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19194 to look at the new patch set (#9). Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF

[Impala-ASF-CR] IMPALA-10986: Require the SELECT privilege to execute a UDF

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19194 ) Change subject: IMPALA-10986: Require the SELECT privilege to execute a UDF .. Patch Set 9: Build started:

[Impala-ASF-CR] WIP IMPALA-11629: Support for huawei OBS FileSystem

2022-11-30 Thread Anonymous Coward (Code Review)
lipeng...@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19110 ) Change subject: WIP IMPALA-11629: Support for huawei OBS FileSystem .. Patch Set 5: (2 comments) LGTM. Left some minor

[Impala-ASF-CR] IMPALA-11478: Cleanup JniCatalog

2022-11-30 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19198 ) Change subject: IMPALA-11478: Cleanup JniCatalog .. Patch Set 4: (2 comments) The refactor is pretty good! I just have minor

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 ) Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. Patch Set 2:

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 ) Change subject: IMPALA-11736: Copy data between ofs buckets .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19291 ) Change subject: IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-11-30 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 ) Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. Patch Set 1: (3

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-11-30 Thread Quanlong Huang (Code Review)
Hello Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19289 to look at the new patch set (#2). Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

[Impala-ASF-CR] IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19291 ) Change subject: IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned

2022-11-30 Thread Steve Carlin (Code Review)
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19291 Change subject: IMPALA-11766: In buildBinaryStatsPredicate, an Expr needs to be cloned .. IMPALA-11766: In buildBinaryStatsPredicate,

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-11-30 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19251 ) Change subject: IMPALA-11730: Add support for spilling to Ozone .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-11730: Add support for spilling to Ozone

2022-11-30 Thread Michael Smith (Code Review)
Hello Yida Wu, Abhishek Rawat, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19251 to look at the new patch set (#7). Change subject: IMPALA-11730: Add support for spilling to Ozone

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-11736: Copy data between ofs buckets

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19262 ) Change subject: IMPALA-11736: Copy data between ofs buckets .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 7: Code-Review+2 LGTM! -- To

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. IMPALA-11758: Fixed error detection for usage of

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-11-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 ) Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. Patch Set 1: (4

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. IMPALA-11758: Fixed error detection for usage of

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Code Review
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Code Review
Gergely Fürnstáhl has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. IMPALA-11758: Fixed error detection for usage of

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19290 ) Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-11758: Fixed error detection for usage of reserved words.

2022-11-30 Thread Code Review
Gergely Fürnstáhl has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19290 Change subject: IMPALA-11758: Fixed error detection for usage of reserved words. .. IMPALA-11758: Fixed error detection for usage

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-11-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19289 ) Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. Patch Set 1:

[Impala-ASF-CR] IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState

2022-11-30 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19289 Change subject: IMPALA-11751: Template tuple of Avro header should be transferred to ScanRangeSharedState .. IMPALA-11751: Template

[Impala-ASF-CR] IMPALA-11728: Set fallback database for functions

2022-11-30 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/19252 ) Change subject: IMPALA-11728: Set fallback database for functions .. Patch Set 17: (3 comments) Hi all, I just left some more comments