[Impala-ASF-CR] IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables

2023-01-27 Thread Anonymous Coward (Code Review)
lipeng...@apache.org has posted comments on this change. ( http://gerrit.cloudera.org:8080/19416 ) Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables .. Patch Set 2:

[Impala-ASF-CR] IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19416 ) Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables .. Patch Set

[Impala-ASF-CR] IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables

2023-01-27 Thread Anonymous Coward (Code Review)
lipeng...@apache.org has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19416 ) Change subject: IMPALA-11798: Property 'external.table.purge' should not be ignored when CREATE Iceberg tables .. IMPALA-11798:

[Impala-ASF-CR] IMPALA-10803: Change default cache eviction policy to LIRS

2023-01-27 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19381 ) Change subject: IMPALA-10803: Change default cache eviction policy to LIRS .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-11662: Improve 'refresh iceberg tbl on oss' performance

2023-01-27 Thread Anonymous Coward (Code Review)
lipeng...@apache.org has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/19379 ) Change subject: IMPALA-11662: Improve 'refresh iceberg_tbl_on_oss' performance .. IMPALA-11662: Improve 'refresh

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 21: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-27 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. IMPALA-11617: Pool service should be made

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 5: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 3: Verified+1

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. IMPALA-11835: [DOCS] Document

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 3: Build

[Impala-ASF-CR] IMPALA-11867: [DOCS] Document Ozone support

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19448 ) Change subject: IMPALA-11867: [DOCS] Document Ozone support .. Patch Set 1: Verified+1 Build Successful

[Impala-ASF-CR] IMPALA-11867: [DOCS] Document Ozone support

2023-01-27 Thread Michael Smith (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19448 to look at the new patch set (#2). Change subject: IMPALA-11867: [DOCS] Document Ozone support ..

[Impala-ASF-CR] IMPALA-11867: Document Ozone support

2023-01-27 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19448 Change subject: IMPALA-11867: Document Ozone support .. IMPALA-11867: Document Ozone support Adds a topic documenting Apache Ozone

[Impala-ASF-CR] IMPALA-11867: Document Ozone support

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19448 ) Change subject: IMPALA-11867: Document Ozone support .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 21: Build started:

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 21: Code-Review+2 Carrying +2 after addressing test and

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 21: Build Successful

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 2: Code-Review+1

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Michael Smith (Code Review)
Hello Andrew Sherman, Attila Bukor, Wenzhe Zhou, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19199 to look at the new patch set (#21). Change subject: IMPALA-11856: Use POST requests to set log

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 20: (3 comments)

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 36: ps36 adds the following: - CheckEffectiveInstanceCount in

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 20: Code-Review+2 (3 comments) LGTM, thanks for this

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 36: Build Successful

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 1: Verified+1 Build

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-27 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#36) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 5: Code-Review+2 Thanks for the

[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19447 Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. IMPALA-11862: [DOCS] Document the default

[Impala-ASF-CR] IMPALA-11862: [DOCS] Document the default value of --ssl cipher list.

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19447 ) Change subject: IMPALA-11862: [DOCS] Document the default value of --ssl_cipher_list. .. Patch Set 1: Build Started

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 2: Verified+1

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. IMPALA-11835: [DOCS] Document

[Impala-ASF-CR] IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema.

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19420 ) Change subject: IMPALA-11835: [DOCS] Document that Iceberg Time Travel queries use the old schema. .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-27 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-11693: Enable allow erasure coded files by default

2023-01-27 Thread Michael Smith (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19362 to look at the new patch set (#4). Change subject: IMPALA-11693: Enable allow_erasure_coded_files by default

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 20: Build Successful

[Impala-ASF-CR] WIP - IMPALA-11828: Incorrect result of joining unnest with view

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19434 ) Change subject: WIP - IMPALA-11828: Incorrect result of joining unnest with view .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Michael Smith (Code Review)
Hello Andrew Sherman, Attila Bukor, Wenzhe Zhou, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19199 to look at the new patch set (#20). Change subject: IMPALA-11856: Use POST requests to set log

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 19: (3 comments)

[Impala-ASF-CR] WIP - IMPALA-11828: Incorrect result of joining unnest with view

2023-01-27 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/19434 ) Change subject: WIP - IMPALA-11828: Incorrect result of joining unnest with view .. WIP - IMPALA-11828: Incorrect result of joining

[Impala-ASF-CR] WIP - IMPALA-11828: Incorrect result of joining unnest with view

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19434 ) Change subject: WIP - IMPALA-11828: Incorrect result of joining unnest with view .. Patch Set 3: Build Successful

[Impala-ASF-CR] WIP - IMPALA-11828: Incorrect result of joining unnest with view

2023-01-27 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/19434 ) Change subject: WIP - IMPALA-11828: Incorrect result of joining unnest with view .. WIP - IMPALA-11828: Incorrect result of joining

[Impala-ASF-CR] WIP - IMPALA-11828: Incorrect result of joining unnest with view

2023-01-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19434 ) Change subject: WIP - IMPALA-11828: Incorrect result of joining unnest with view .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files

2023-01-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19441 ) Change subject: IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files .. IMPALA-11864: Iceberg LOAD DATA should

[Impala-ASF-CR] IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files

2023-01-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19441 ) Change subject: IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files .. Patch Set 3: Code-Review+2 Thanks for fixing

[Impala-ASF-CR] IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files

2023-01-27 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19441 ) Change subject: IMPALA-11864: Iceberg LOAD DATA should not load S3 hidden files .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11857: Connect join build fragment to join in graphical plan

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19437 ) Change subject: IMPALA-11857: Connect join build fragment to join in graphical plan .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-11857: Connect join build fragment to join in graphical plan

2023-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19437 ) Change subject: IMPALA-11857: Connect join build fragment to join in graphical plan .. IMPALA-11857: Connect join

[Impala-ASF-CR] IMPALA-11856: Use POST requests to set log level

2023-01-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19199 ) Change subject: IMPALA-11856: Use POST requests to set log level .. Patch Set 19: Code-Review+1 (3 comments) Went through the