[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore

2023-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. Patch Set 16: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore

2023-10-19 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. Patch Set 16: (6 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore

2023-10-19 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. IMPALA-12156: Support High Availability for Statestore To suppo

[Impala-ASF-CR] IMPALA-12499: Deflake test hdfs scanner thread mem scaling

2023-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20593 ) Change subject: IMPALA-12499: Deflake test_hdfs_scanner_thread_mem_scaling .. Patch Set 2: Verified+1 -- To view, visit http:

[Impala-ASF-CR] IMPALA-12499: Deflake test hdfs scanner thread mem scaling

2023-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20593 ) Change subject: IMPALA-12499: Deflake test_hdfs_scanner_thread_mem_scaling .. IMPALA-12499: Deflake test_hdfs_scanner_t

[Impala-ASF-CR] IMPALA-12415: Implement tests for graphical query timeline in webUI

2023-10-19 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20538 ) Change subject: IMPALA-12415: Implement tests for graphical query timeline in webUI .. Patch Set 3: (2 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-10-19 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 3: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-10-19 Thread Riza Suminto (Code Review)
Hello Daniel Becker, Abhishek Rawat, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20498 to look at the new patch set (#3). Change subject: IMPALA-12018: Consider runtime filter for cardinality reductio

[Impala-ASF-CR] IMPALA-12115: Put each filesystem in a different directory

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19841 ) Change subject: IMPALA-12115: Put each filesystem in a different directory .. Patch Set 8: Verified+1 Code-Review+2 (1 comment) Retes

[Impala-ASF-CR] IMPALA-12115: Put each filesystem in a different directory

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19841 ) Change subject: IMPALA-12115: Put each filesystem in a different directory .. IMPALA-12115: Put each filesystem in a different

[Impala-ASF-CR] IMPALA-12415: Implement tests for graphical query timeline in webUI

2023-10-19 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20538 ) Change subject: IMPALA-12415: Implement tests for graphical query timeline in webUI .. Patch Set 3: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-12504: Split graphical query timeline script into es6 modules

2023-10-19 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20588 ) Change subject: IMPALA-12504: Split graphical query timeline script into es6 modules .. Patch Set 1: (14 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore

2023-10-19 Thread Jason Fehr (Code Review)
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. Patch Set 15: (20 comments) A few more thoughts/questions. ht

[Impala-ASF-CR] IMPALA-12499: Deflake test hdfs scanner thread mem scaling

2023-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20593 ) Change subject: IMPALA-12499: Deflake test_hdfs_scanner_thread_mem_scaling .. Patch Set 2: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-12499: Deflake test hdfs scanner thread mem scaling

2023-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20593 ) Change subject: IMPALA-12499: Deflake test_hdfs_scanner_thread_mem_scaling .. Patch Set 2: Build started: https://jenkins.impa

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 13: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-12115: Put each filesystem in a different directory

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19841 ) Change subject: IMPALA-12115: Put each filesystem in a different directory .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-10-19 Thread Michael Smith (Code Review)
Hello Daniel Becker, Yida Wu, Noemi Pap-Takacs, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20399 to look at the new patch set (#13). Change subject: IMPALA-5081: Add codegen_opt_level query option ...

[Impala-ASF-CR] IMPALA-12115: Put each filesystem in a different directory

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19841 ) Change subject: IMPALA-12115: Put each filesystem in a different directory .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-12429: Reduce parallelism for TPC-DS q51a and q67a test.

2023-10-19 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20581 ) Change subject: IMPALA-12429: Reduce parallelism for TPC-DS q51a and q67a test. .. Patch Set 1: > Patch Set 1: Code-Review+2 > > This m

[Impala-ASF-CR] IMPALA-12499: Deflake test hdfs scanner thread mem scaling

2023-10-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20593 ) Change subject: IMPALA-12499: Deflake test_hdfs_scanner_thread_mem_scaling .. Patch Set 1: Code-Review+2 Thanks for looking at this, t

[Impala-ASF-CR] IMPALA-12429: Reduce parallelism for TPC-DS q51a and q67a test.

2023-10-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20581 ) Change subject: IMPALA-12429: Reduce parallelism for TPC-DS q51a and q67a test. .. Patch Set 1: Code-Review+2 This makes sense to me.

[Impala-ASF-CR] IMPALA-12115: Put each filesystem in a different directory

2023-10-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19841 ) Change subject: IMPALA-12115: Put each filesystem in a different directory .. Patch Set 7: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 12: Build Successful https://jenkins.impala.io/j

[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. Patch Set 15: Code-Review+1 Option naming is slightly incons

[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-12156: Support High Availability for Statestore

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20372 ) Change subject: IMPALA-12156: Support High Availability for Statestore .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/203

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-10-19 Thread Michael Smith (Code Review)
Hello Daniel Becker, Yida Wu, Noemi Pap-Takacs, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20399 to look at the new patch set (#12). Change subject: IMPALA-5081: Add codegen_opt_level query option ...

[Impala-ASF-CR] IMPALA-12473: Fix profile's missing event timestamp exception in query timeline

2023-10-19 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20522 ) Change subject: IMPALA-12473: Fix profile's missing event timestamp exception in query timeline .. Patch Set 6: Code-Review+1 -- To vi

[Impala-ASF-CR] IMPALA-12484: Update kudu and libunwind

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20566 ) Change subject: IMPALA-12484: Update kudu and libunwind .. Patch Set 2: Code-Review+2 Updated to follow native-toolchain#master and pa

[Impala-ASF-CR] IMPALA-12490: Fix tests on ARM

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20557 ) Change subject: IMPALA-12490: Fix tests on ARM .. Patch Set 5: Code-Review+2 ARM run passed. Carrying +2. -- To view, visit http://g

[Impala-ASF-CR] IMPALA-12484: Update kudu and libunwind

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20566 ) Change subject: IMPALA-12484: Update kudu and libunwind .. IMPALA-12484: Update kudu and libunwind Updates libunwind to 1.7.2

[Impala-ASF-CR] IMPALA-12490: Fix tests on ARM

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20557 ) Change subject: IMPALA-12490: Fix tests on ARM .. IMPALA-12490: Fix tests on ARM Fixes failing llvm-codegen-cache-test on ARM

[Impala-ASF-CR] IMPALA-12484: Update kudu and libunwind

2023-10-19 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20566 ) Change subject: IMPALA-12484: Update kudu and libunwind .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-12018: Consider runtime filter for cardinality reduction

2023-10-19 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20498 ) Change subject: IMPALA-12018: Consider runtime filter for cardinality reduction .. Patch Set 2: (4 comments) Thanks Riza. http://ger

[Impala-ASF-CR] IMPALA-11996: Scanner change for Iceberg metadata querying

2023-10-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20010 ) Change subject: IMPALA-11996: Scanner change for Iceberg metadata querying .. Patch Set 14: Btw, can we have some test queries fro

[Impala-ASF-CR] IMPALA-11996: Scanner change for Iceberg metadata querying

2023-10-19 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20010 ) Change subject: IMPALA-11996: Scanner change for Iceberg metadata querying .. Patch Set 14: (3 comments) Thanks for the refactori

[Impala-ASF-CR] IMPALA-11387: Introduce virtual column to expose Iceberg's file-level data sequence number

2023-10-19 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20595 ) Change subject: IMPALA-11387: Introduce virtual column to expose Iceberg's file-level data sequence number .. Patch Set 1: (4 comment

[Impala-ASF-CR] IMPALA-11996: Scanner change for Iceberg metadata querying

2023-10-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20010 ) Change subject: IMPALA-11996: Scanner change for Iceberg metadata querying .. Patch Set 14: (10 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-11996: Scanner change for Iceberg metadata querying

2023-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20010 ) Change subject: IMPALA-11996: Scanner change for Iceberg metadata querying .. Patch Set 14: Build Successful https://jenkins.

[Impala-ASF-CR] IMPALA-11996: Scanner change for Iceberg metadata querying

2023-10-19 Thread Tamas Mate (Code Review)
Tamas Mate has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/20010 ) Change subject: IMPALA-11996: Scanner change for Iceberg metadata querying .. IMPALA-11996: Scanner change for Iceberg metadata querying T

[Impala-ASF-CR] IMPALA-11996: Scanner change for Iceberg metadata querying

2023-10-19 Thread Tamas Mate (Code Review)
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20010 ) Change subject: IMPALA-11996: Scanner change for Iceberg metadata querying .. Patch Set 14: (8 comments) Thank you for the review Zoltan

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-10-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 11: Code-Review+1 (3 comments) looks great! http://ge

[Impala-ASF-CR] PROTOTYPE: IMPALA-12463: Batch non-consecutive table events in the event processor

2023-10-19 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20533 ) Change subject: PROTOTYPE: IMPALA-12463: Batch non-consecutive table events in the event processor .. Patch Set 3: (1 comment) http:

[Impala-ASF-CR] IMPALA-11387: Introduce virtual column to expose Iceberg's file-level data sequence number

2023-10-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20595 ) Change subject: IMPALA-11387: Introduce virtual column to expose Iceberg's file-level data sequence number .. Patch Set 1: Bu

[Impala-ASF-CR] IMPALA-11387: Introduce virtual column to expose Iceberg's file-level data sequence number

2023-10-19 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20595 Change subject: IMPALA-11387: Introduce virtual column to expose Iceberg's file-level data sequence number .. IMPALA-11387: Introduce vi

[Impala-ASF-CR] IMPALA-10976: Sync db/table in catalogD to latest HMS event id for all DDLS from Impala clients

2023-10-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20367 ) Change subject: IMPALA-10976: Sync db/table in catalogD to latest HMS event id for all DDLS from Impala clients .. Patch Set 3: (4 c