[Impala-ASF-CR] WIP ONLY - Try to reduce number of MVN repo dependencies

2019-05-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13279 ) Change subject: WIP ONLY - Try to reduce number of MVN repo dependencies .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] [DOCS] Fix show SQL typos

2019-05-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13272 ) Change subject: [DOCS] Fix show SQL typos .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13272 To uns

[Impala-ASF-CR] [DOCS] Typos fixed

2019-05-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13272 ) Change subject: [DOCS] Typos fixed .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13272/1//COMMIT_MSG Commit Message:

[native-toolchain-CR] Fix issues with toolchain Python and bump version

2019-05-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13249 ) Change subject: Fix issues with toolchain Python and bump version .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-8364: [DOCS] Remove refereces to authz policy files

2019-05-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13235 ) Change subject: IMPALA-8364: [DOCS] Remove refereces to authz policy files .. Patch Set 4: Code-Review+2 (2 comments) I found few typo

[Impala-ASF-CR] IMPALA-8364: [DOCS] Remove refereces to authz policy files

2019-05-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13235 ) Change subject: IMPALA-8364: [DOCS] Remove refereces to authz policy files .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8364: [DOCS] Remove refereces to authz policy files

2019-05-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13235 ) Change subject: IMPALA-8364: [DOCS] Remove refereces to authz policy files .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8364: [DOCS] Remove refereces to authz policy files

2019-05-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13235 ) Change subject: IMPALA-8364: [DOCS] Remove refereces to authz policy files .. Patch Set 1: (4 comments) I think it's better if we don'

[Impala-ASF-CR] IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3

2019-05-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13234 ) Change subject: IMPALA-8488: Fix hardcoded path in Ranger E2E test on S3 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit

[Impala-ASF-CR] Fix redundant downloads of hive source tarball

2019-05-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13219 ) Change subject: Fix redundant downloads of hive source tarball .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] Fix redundant downloads of hive source tarball

2019-05-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13219 ) Change subject: Fix redundant downloads of hive source tarball .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13219/4

[Impala-ASF-CR] IMPALA-8488: Hardcoded path in Ranger E2E test breaks for S3

2019-05-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13234 ) Change subject: IMPALA-8488: Hardcoded path in Ranger E2E test breaks for S3 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-8477: [DOCS] SHOW GRANT GROUP for Ranger authorization

2019-05-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13220 ) Change subject: IMPALA-8477: [DOCS] SHOW GRANT GROUP for Ranger authorization .. Patch Set 1: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] Fix redundant downloads of hive source tarball

2019-05-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13219 ) Change subject: Fix redundant downloads of hive source tarball .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13219/

[Impala-ASF-CR] IMPALA-8472: Fix the refresh privilege workaround in Ranger

2019-05-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13229 Change subject: IMPALA-8472: Fix the refresh privilege workaround in Ranger .. IMPALA-8472: Fix the refresh privilege workaround in Range

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-05-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 13: > Patch Set 13: > > > Thanks for the fix. >

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-05-03 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 12: Code-Review+2 Thanks for the fix. -- To vi

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1056671

2019-05-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13213 ) Change subject: Bump CDP_BUILD_NUMBER to 1056671 .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13213

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-05-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 11: > Patch Set 11: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-8482: Package ranger-plugins-audit runtime dependencies

2019-05-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13216 ) Change subject: IMPALA-8482: Package ranger-plugins-audit runtime dependencies .. Patch Set 1: Tested it and passed the private build.

[Impala-ASF-CR] IMPALA-8482: Package ranger-plugins-audit runtime dependencies

2019-05-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13216 ) Change subject: IMPALA-8482: Package ranger-plugins-audit runtime dependencies .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-8482: Package ranger-plugins-audit runtime dependencies

2019-05-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13216 Change subject: IMPALA-8482: Package ranger-plugins-audit runtime dependencies .. IMPALA-8482: Package ranger-plugins-audit runtime depen

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1056671

2019-05-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13213 ) Change subject: Bump CDP_BUILD_NUMBER to 1056671 .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13213

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

2019-05-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13208 ) Change subject: IMPALA-8269: Refactor authorization test package structure .. Patch Set 2: Code-Review+2 +1s from Joe and Austin, bumpi

[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.

2019-05-02 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 ) Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188. .. Patch Set 3: Code-Review+2 > Patch Set 3: > > Not really sure why the

[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.

2019-05-01 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 ) Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

2019-05-01 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13208 ) Change subject: IMPALA-8269: Refactor authorization test package structure .. IMPALA-8269: Refactor authorization test package structure

[Impala-ASF-CR] IMPALA-8478: Fix test provider.py Python 2.6 compatibility

2019-05-01 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13211 Change subject: IMPALA-8478: Fix test_provider.py Python 2.6 compatibility .. IMPALA-8478: Fix test_provider.py Python 2.6 compatibility

[Impala-ASF-CR] IMPALA-8269: Refactor authorization test package structure

2019-05-01 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13208 Change subject: IMPALA-8269: Refactor authorization test package structure .. IMPALA-8269: Refactor authorization test package structure

[Impala-ASF-CR] IMPALA-8269: Clean up authorization test package structure

2019-05-01 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has abandoned this change. ( http://gerrit.cloudera.org:8080/12654 ) Change subject: IMPALA-8269: Clean up authorization test package structure .. Abandoned Abandoning this CR since it has way too many conflicts,

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-05-01 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 10: Code-Review+1 LGTM. Thomas, can you take a l

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. Patch Set 11: > Patch Set 11: Verified-1 > > Build f

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. IMPALA-8293 (Part 2): Add support for Ranger cache inv

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. Patch Set 10: Code-Review+2 Rebased to fix the merge

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. Patch Set 9: Code-Review+1 -- To view, visit http:/

[Impala-ASF-CR] Bump Kudu version to 9ba901a

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13197 ) Change subject: Bump Kudu version to 9ba901a .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13197 To

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. IMPALA-8293 (Part 2): Add support for Ranger cache inva

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. Patch Set 9: (1 comment) Carry +1 http://gerrit.cl

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. Patch Set 8: Code-Review+1 (7 comments) Carry Bhara

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. IMPALA-8293 (Part 2): Add support for Ranger cache inva

[native-toolchain-CR] Bump Kudu version to 9ba901a

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13194 ) Change subject: Bump Kudu version to 9ba901a .. Patch Set 1: Code-Review+2 Thanks for doing this! -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-8280, IMPALA-8281: Add support for show grant user/group with Ranger

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13074 ) Change subject: IMPALA-8280, IMPALA-8281: Add support for show grant user/group with Ranger .. Patch Set 13: Code-Review+2 -- To view

[Impala-ASF-CR] fe: set classpath using maven dependency resolution

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13185 ) Change subject: fe: set classpath using maven dependency resolution .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-7973: Add support for fine grained events processing for partition level HMS events.

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13111 ) Change subject: IMPALA-7973: Add support for fine grained events processing for partition level HMS events. .. Patch Set 8: Code-Review

[Impala-ASF-CR] IMPALA-8280, IMPALA-8281: Add support for show grant user/group with Ranger

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13074 ) Change subject: IMPALA-8280, IMPALA-8281: Add support for show grant user/group with Ranger .. Patch Set 11: Code-Review+2 -- To view

[Impala-ASF-CR] IMPALA-8280, IMPALA-8281: Add support for show grant user/group with Ranger

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13074 ) Change subject: IMPALA-8280, IMPALA-8281: Add support for show grant user/group with Ranger .. Patch Set 9: (4 comments) http://gerri

[Impala-ASF-CR] IMPALA-8280, IMPALA-8281: Add support for show grant user/group with Ranger

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13074 ) Change subject: IMPALA-8280, IMPALA-8281: Add support for show grant user/group with Ranger .. Patch Set 8: (2 comments) http://gerri

[Impala-ASF-CR] IMPALA-7973: Add support for fine grained events processing for partition level HMS events.

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13111 ) Change subject: IMPALA-7973: Add support for fine grained events processing for partition level HMS events. .. Patch Set 7: (3 comment

[Impala-ASF-CR] IMPALA-8419 : Validate event processing related configurations

2019-04-30 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13019 ) Change subject: IMPALA-8419 : Validate event processing related configurations .. Patch Set 15: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 9: The compilation error fix has been merged. Yo

[Impala-ASF-CR] Revert "IMPALA-7971: Add support for insert events in event processor."

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has abandoned this change. ( http://gerrit.cloudera.org:8080/13182 ) Change subject: Revert "IMPALA-7971: Add support for insert events in event processor." .. Abandoned Abandoning this CR since the fix has been

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 9: > Patch Set 9: > > It seems there is somethin

[Impala-ASF-CR] IMPALA-7973: Add support for fine grained events processing for partition level HMS events.

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13111 ) Change subject: IMPALA-7973: Add support for fine grained events processing for partition level HMS events. .. Patch Set 6: (8 comment

[Impala-ASF-CR] Revert "IMPALA-7971: Add support for insert events in event processor."

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13182 Change subject: Revert "IMPALA-7971: Add support for insert events in event processor." .. Revert "IMPALA-7971: Add support for insert e

[Impala-ASF-CR] IMPALA-8419 : Validate event processing related configurations

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13019 ) Change subject: IMPALA-8419 : Validate event processing related configurations .. Patch Set 14: > Patch Set 14: Verified-1 > > Build fa

[Impala-ASF-CR] IMPALA-8280, IMPALA-8281: Add support for show grant user/group with Ranger

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13074 ) Change subject: IMPALA-8280, IMPALA-8281: Add support for show grant user/group with Ranger .. Patch Set 7: (20 comments) http://gerr

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. Patch Set 7: (11 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13134 ) Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. IMPALA-8293 (Part 2): Add support for Ranger cache inva

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 9: > Patch Set 8: > > (1 comment) > > --helifu A

[Impala-ASF-CR] IMPALA-8419 : Validate event processing related configurations

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13019 ) Change subject: IMPALA-8419 : Validate event processing related configurations .. Patch Set 13: Code-Review+1 Thanks for all the fixes.

[Impala-ASF-CR] IMPALA-7290: part 1: clean up shell tests

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13083 ) Change subject: IMPALA-7290: part 1: clean up shell tests .. Patch Set 8: Code-Review+2 The changes make sense. -- To view, visit htt

[Impala-ASF-CR] IMPALA-8419 : Validate event processing related configurations

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13019 ) Change subject: IMPALA-8419 : Validate event processing related configurations .. Patch Set 11: Code-Review+1 (2 comments) Will let Vi

[Impala-ASF-CR] IMPALA-8419 : Validate event processing related configurations

2019-04-29 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13019 ) Change subject: IMPALA-8419 : Validate event processing related configurations .. Patch Set 9: (25 comments) In general CR looks good,

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 8: (1 comment) > Patch Set 8: > > Build Failed

[Impala-ASF-CR] Bump CDH BUILD NUMBER to 1046268.

2019-04-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13140 ) Change subject: Bump CDH_BUILD_NUMBER to 1046268. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1314

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 23: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 23: > Patch Set 23: Verified-1 > > Build failed: https:/

[Impala-ASF-CR] IMPALA-8149 : Add support for alter database events

2019-04-27 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13049 ) Change subject: IMPALA-8149 : Add support for alter_database events .. Patch Set 6: > Patch Set 6: Verified-1 > > Build failed: https:/

[Impala-ASF-CR] IMPALA-8149 : Add support for alter database events

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13049 ) Change subject: IMPALA-8149 : Add support for alter_database events .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-8149 : Add support for alter database events

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13049 ) Change subject: IMPALA-8149 : Add support for alter_database events .. Patch Set 5: Code-Review+1 (1 comment) I will give a chance for

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#22) to the change originally created by radford nguyen. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. IMPALA-8309: add

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 22: (1 comment) Running a dry-run first. http://gerrit

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 21: > Patch Set 20: Verified-1 > > Build failed: https:/

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#21) to the change originally created by radford nguyen. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. IMPALA-8309: add

[Impala-ASF-CR] IMPALA-8293 (Part 2): Add support for Ranger cache invalidation

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13134 Change subject: IMPALA-8293 (Part 2): Add support for Ranger cache invalidation .. IMPALA-8293 (Part 2): Add support for Ranger cache inv

[Impala-ASF-CR] IMPALA-8149 : Add support for alter database events

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13049 ) Change subject: IMPALA-8149 : Add support for alter_database events .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. IMPALA-8444: Fix performance regression when bui

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. Patch Set 10: Code-Review+2 (1 comment) Carry

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. IMPALA-8444: Fix performance regression when buil

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. Patch Set 9: (4 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 19: Code-Review+2 > Patch Set 19: Verified-1 > > Build f

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-26 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Removed reviewer Todd Lipcon. -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. Patch Set 8: (5 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. IMPALA-8444: Fix performance regression when buil

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. Patch Set 8: Csaba, this is ready for review.

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-25 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 18: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 4: Overall it looks good. Can you add E2E tests

[Impala-ASF-CR] [WIP] IMPALA-8281: Add support for show grant user/group with Ranger

2019-04-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13074 ) Change subject: [WIP] IMPALA-8281: Add support for show grant user/group with Ranger .. Patch Set 6: (8 comments) First pass on this.

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. Patch Set 7: Code-Review+1 (1 comment) Carry

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. IMPALA-8444: Fix performance regression when buil

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 16: Code-Review+2 Thanks Radford and Austin for the patc

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. Patch Set 6: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. IMPALA-8444: Fix performance regression when buil

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. IMPALA-8444: Fix performance regression when buil

[Impala-ASF-CR] IMPALA-8309: add user authorization provider flag

2019-04-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12901 ) Change subject: IMPALA-8309: add user authorization_provider flag .. Patch Set 10: (16 comments) http://gerrit.cloudera.org:8080/#/c/1

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. IMPALA-8444: Fix performance regression when buil

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-24 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. Patch Set 3: (8 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-8444: Fix performance regression when building privilege name

2019-04-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13095 ) Change subject: IMPALA-8444: Fix performance regression when building privilege name .. IMPALA-8444: Fix performance regression when buil

[Impala-ASF-CR] IMPMALA-8444: Fix performance regression when building privilege name

2019-04-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13095 Change subject: IMPMALA-8444: Fix performance regression when building privilege name .. IMPMALA-8444: Fix performance regression when b

<    1   2   3   4   5   6   7   8   9   10   >