[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-22 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12830 ) Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. IMPALA-8337: Fix OrderedDict Python

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 18: Code-Review+2 Apparently Iterables.getOnlyElement()

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#18). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. IMPALA-8330: Impala shell config file should use flag

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12830 ) Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. Patch Set 1: I'm running the private build

[Impala-ASF-CR] IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12830 Change subject: IMPALA-8337: Fix OrderedDict Python compatibility issue in Impala shell .. IMPALA-8337: Fix OrderedDict Python

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 17: Code-Review+2 Rebased. Carry Todd's +2. -- To

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 ) Change subject: IMPALA-8330: Impala shell config file should use flag names .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8330: Impala shell config file should use flag names

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12823 Change subject: IMPALA-8330: Impala shell config file should use flag names .. IMPALA-8330: Impala shell config file should use flag

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 19: Code-Review+2 Trivial rebase fix due to CR that recently

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#19). ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. IMPALA-8100: Add initial support for Ranger This patch adds an initial

[Impala-ASF-CR](2.x) IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12800 ) Change subject: IMPALA-6223: Gracefully handle malformed 'with' queries in impala-shell .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-21 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. Patch Set 11: Code-Review+2 Fixed minor

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 17: (2 comments)

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. IMPALA-8100: Add initial support for Ranger This patch adds an initial

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. Patch Set 9: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. IMPALA-8317: Add support for list type flags

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 15: Code-Review+2 (1 comment) Carry Todd's +2. Will

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. IMPALA-8317: Add support for list type flags

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-8328: Add missing ToSql test cases for authorization statements

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12817 ) Change subject: IMPALA-8328: Add missing ToSql test cases for authorization statements .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. IMPALA-8317: Add support for list type flags

[Impala-ASF-CR] IMPALA-8312 : Alter database operations have race condition

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12789 ) Change subject: IMPALA-8312 : Alter database operations have race condition .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 ) Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql .. Patch Set 5: Code-Review+2 Thanks for fixing this and added a missing

[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt::toSql

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 ) Change subject: IMPALA-8326: Fix CreateDropRoleStmt::toSql .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8325: Leading Unicode comments cause Impala Shell failure.

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12812 ) Change subject: IMPALA-8325: Leading Unicode comments cause Impala Shell failure. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8326: Fix CreateDropRoleStmt toSql

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12813 ) Change subject: IMPALA-8326: Fix CreateDropRoleStmt toSql .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 13: Rebased after https://gerrit.cloudera.org/c/12632

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part

[Impala-ASF-CR](2.x) IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12807 ) Change subject: IMPALA-7254: Inconsistent decimal behavior for IN/BETWEEN predicate .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12799 ) Change subject: IMPALA-6988: Implement ALTER TABLE/VIEW SET OWNER .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6918: [DOCS] COMMENT ON COLUMN privileges

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12803 ) Change subject: IMPALA-6918: [DOCS] COMMENT ON COLUMN privileges .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12802 ) Change subject: IMPALA-3956: [DOCS] Escape variables with '\' in impala-shell .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#16). ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. IMPALA-8100: Add initial support for Ranger This patch adds an initial

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-20 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 16: Rebased to fix merge conflicts. -- To view, visit

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. IMPALA-8100: Add initial support for Ranger This patch adds an initial

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-19 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 15: Todd, as discussed offline, I updated the CR to use Hive

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. IMPALA-8317: Add support for list type flags

[Impala-ASF-CR] IMPALA-8317: AAdd support for list type flags in Impala shell config file

2019-03-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12781 Change subject: IMPALA-8317: AAdd support for list type flags in Impala shell config file .. IMPALA-8317: AAdd support for list type

[Impala-ASF-CR] IMPALA-8317: Add support for list type flags in Impala shell config file

2019-03-18 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12781 ) Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file .. IMPALA-8317: Add support for list type flags

[Impala-ASF-CR] IMPALA-8225: Add ranger support for grant/revoke privilege to/from user

2019-03-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12769 ) Change subject: IMPALA-8225: Add ranger support for grant/revoke privilege to/from user .. Patch Set 1: (21 comments) I understand

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 11: (25 comments)

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 13: (3 comments)

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. IMPALA-8100: Add initial support for Ranger This patch adds an initial

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. IMPALA-8100: Add initial support for Ranger This patch adds an initial

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-14 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 11: (25 comments)

[Impala-ASF-CR] IMPALA-8293 (WIP): Support for Ranger cache invalidation

2019-03-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12748 ) Change subject: IMPALA-8293 (WIP): Support for Ranger cache invalidation .. Patch Set 1: A sneak peak to force Ranger cache

[Impala-ASF-CR] IMPALA-8293 (WIP): Support for Ranger cache invalidation

2019-03-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12748 Change subject: IMPALA-8293 (WIP): Support for Ranger cache invalidation .. IMPALA-8293 (WIP): Support for Ranger cache invalidation

[Impala-ASF-CR](2.x) IMPALA-6802 (part 6): Clean up authorization tests

2019-03-12 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12722 ) Change subject: IMPALA-6802 (part 6): Clean up authorization tests .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part of

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 9: Code-Review+1 Carry Bharath's +1. -- To view,

[Impala-ASF-CR](2.x) IMPALA-6802 (part 5): Clean up authorization tests

2019-03-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12712 ) Change subject: IMPALA-6802 (part 5): Clean up authorization tests .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6802 (part 4): Clean up authorization tests

2019-03-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12711 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6802 (part 3): Clean up authorization tests

2019-03-10 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12710 ) Change subject: IMPALA-6802 (part 3): Clean up authorization tests .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6802 (part 2): Clean up authorization tests

2019-03-09 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12709 ) Change subject: IMPALA-6802 (part 2): Clean up authorization tests .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6802 (part 1): Clean up authorization tests

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12708 ) Change subject: IMPALA-6802 (part 1): Clean up authorization tests .. Patch Set 1: Code-Review+2 > Patch Set 1: > > Hi Fredy, I'm

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. Patch Set 6: Code-Review+1 (1 comment) Carry

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. IMPALA-8271: Refactor the use of Thrift enums for

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 8: Code-Review+1 (3 comments) Carry Bharath's +1.

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part of

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. IMPALA-8271: Refactor the use of Thrift enums for

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-08 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part of

[Impala-ASF-CR] IMPALA-8255: [DOCS] Document the DEFAULT FILE FORMAT query option

2019-03-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12670 ) Change subject: IMPALA-8255: [DOCS] Document the DEFAULT_FILE_FORMAT query option .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12682 ) Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. IMPALA-8271: Refactor the use of Thrift enums for

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 5: Rebased to fix conflicts. -- To view, visit

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part of

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 9: Rebased. Paul/Bharath, this is ready for review. Can you

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. IMPALA-8100: Add initial support for Ranger This patch adds an initial

[Impala-ASF-CR](2.x) IMPALA-6883: [DOCS] Refactor impala authorization doc

2019-03-07 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12688 ) Change subject: IMPALA-6883: [DOCS] Refactor impala_authorization doc .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12684 ) Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. Patch Set 4: This should be the last part of Sentry decoupling.

[Impala-ASF-CR] IMPALA-7917 (Part 3): Decouple Sentry from Impala

2019-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12684 Change subject: IMPALA-7917 (Part 3): Decouple Sentry from Impala .. IMPALA-7917 (Part 3): Decouple Sentry from Impala The third part

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. Patch Set 12: > Patch Set 12: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-8271: Refactor the use of Thrift enums for query options

2019-03-06 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12682 Change subject: IMPALA-8271: Refactor the use of Thrift enums for query options .. IMPALA-8271: Refactor the use of Thrift enums for

[Impala-ASF-CR](2.x) Ignore IMPALA-6883 and IMPALA-7236

2019-03-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12678 ) Change subject: Ignore IMPALA-6883 and IMPALA-7236 .. Patch Set 1: > Patch Set 1: > > Fredy, could you help to double check that

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. IMPALA-8100: Add initial support for Ranger This patch adds an initial

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-8100: Add initial support for Ranger

2019-03-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/12632 ) Change subject: IMPALA-8100: Add initial support for Ranger .. IMPALA-8100: Add initial support for Ranger This patch adds an initial

[Impala-ASF-CR] IMPALA-8255: [DOCS] Document the DEFAULT FILE FORMAT query option

2019-03-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12670 ) Change subject: IMPALA-8255: [DOCS] Document the DEFAULT_FILE_FORMAT query option .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7916: Remove support for authorization policy file

2019-03-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12637 ) Change subject: IMPALA-7916: Remove support for authorization policy file .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7916: Remove support for authorization policy file

2019-03-05 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12637 ) Change subject: IMPALA-7916: Remove support for authorization policy file .. Patch Set 7: Code-Review+1 LGTM, thanks! Will be bumping

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-03-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. Patch Set 11: Code-Review+1 (2 comments) Carry Bharath's +1.

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-03-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. IMPALA-7917 (Part 2): Decouple Sentry from Impala This patch adds

[Impala-ASF-CR] IMPALA-7916: Remove support for authorization policy file

2019-03-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12637 ) Change subject: IMPALA-7916: Remove support for authorization policy file .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-8254: Fix error when running compute stats with compression codec set

2019-03-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/12635 ) Change subject: IMPALA-8254: Fix error when running compute stats with compression_codec set .. IMPALA-8254: Fix error when running

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-03-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. IMPALA-7917 (Part 2): Decouple Sentry from Impala This patch adds a

[Impala-ASF-CR] IMPALA-7917 (Part 2): Decouple Sentry from Impala

2019-03-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12542 ) Change subject: IMPALA-7917 (Part 2): Decouple Sentry from Impala .. Patch Set 8: (8 comments)

[Impala-ASF-CR] IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built

2019-03-04 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12630 ) Change subject: IMPALA-8261: Enhance create-test-configuration.sh to not fail when FE has not been built .. Patch Set 4: Build looks

<    1   2   3   4   5   6   7   8   9   10   >