[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: I'll run a perf-AB-test, as this may have perfo

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-25 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: > Patch Set 1: > > I'll run a perf-AB-test, as

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-29 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: (3 comments) > Patch Set 1: > > > Patch Set 1

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-29 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-30 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-08-30 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-05 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-05 Thread Michael Smith (Code Review)
Hello Quanlong Huang, Daniel Becker, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20425 to look at the new patch set (#2). Change subject: IMPALA-10086: Implicit cast comparing char and varchar ..

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-05 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 2: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-06 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-07 Thread Michael Smith (Code Review)
Hello Quanlong Huang, Daniel Becker, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20425 to look at the new patch set (#3). Change subject: IMPALA-10086: Implicit cast comparing char and varchar ..

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 3: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-07 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 3: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-08 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-08 Thread Michael Smith (Code Review)
Hello Quanlong Huang, Daniel Becker, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20425 to look at the new patch set (#4). Change subject: IMPALA-10086: Implicit cast comparing char and varchar .

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-08 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 4: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-11 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 4: (1 comment) Thanks Michael. http://gerrit.clo

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-11 Thread Michael Smith (Code Review)
Hello Quanlong Huang, Daniel Becker, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20425 to look at the new patch set (#5). Change subject: IMPALA-10086: Implicit cast comparing char and varchar .

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 5: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 5: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-11 Thread Michael Smith (Code Review)
Hello Quanlong Huang, Daniel Becker, Peter Rozsa, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20425 to look at the new patch set (#6). Change subject: IMPALA-10086: Implicit cast comparing char and

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-11 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 5: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-11 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 6: Code-Review+1 LGTM -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-12 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 6: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 6: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-12 Thread Michael Smith (Code Review)
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. IMPALA-10086: Implicit cast comparing char and varcha