[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-03-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. IMPALA-11223: Use unique id to create codege

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-03-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 5: Verified+1 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-03-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 5: Build started: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-03-06 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 5: Code-Review+2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-03-05 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 4: Code-Review+2 Thanks Quanlong for fixing the issue a

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-03-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 4: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-03-05 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 4: As discussed with Yida offline, added some lo

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-03-05 Thread Quanlong Huang (Code Review)
Hello Daniel Becker, Yida Wu, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19505 to look at the new patch set (#4). Change subject: IMPALA-11223: Use unique id to create codegen instances

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-03-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 3: > Patch Set 3: Code-Review+1 > > LGTM! > Beca

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-03-02 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 3: Code-Review+1 LGTM! Because it changes the id of the

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 3: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-28 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 3: Code-Review+1 Thanks, this is fine for me. Let

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-28 Thread Quanlong Huang (Code Review)
Hello Daniel Becker, Yida Wu, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19505 to look at the new patch set (#3). Change subject: IMPALA-11223: Use unique id to create codegen instances .

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-27 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 2: Code-Review+1 (2 comments) Thanks Quanlong!

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 2: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-25 Thread Quanlong Huang (Code Review)
Hello Daniel Becker, Yida Wu, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19505 to look at the new patch set (#2). Change subject: IMPALA-11223: Use unique id to create codegen instances .

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 1: > Patch Set 1: > > Thanks Quanlong, this seem

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 1: Thanks Quanlong, this seems good to me. I won

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-16 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 1: Code-Review+1 This seems fine to me. I don't s

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19505 ) Change subject: IMPALA-11223: Use unique id to create codegen instances .. Patch Set 1: Build Successful https://jenkins.impa

[Impala-ASF-CR] IMPALA-11223: Use unique id to create codegen instances

2023-02-16 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19505 Change subject: IMPALA-11223: Use unique id to create codegen instances .. IMPALA-11223: Use unique id to create codegen instances Whe