[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. IMPALA-5980: Upgrade to LLVM 5.0.1 Highlighting a few changes in

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-27 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9584 to look at the new patch set (#5). Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 4: (5 comments) Minor comments on the clang-tidy fixes

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 4: Fixed a bunch of new clang-tidy warnings -- To view, visit

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-23 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9584 to look at the new patch set (#4). Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9584

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-20 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 3: Code-Review+1 Rebased. Carrying over Tim's +1 -- To view, visit

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-20 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9584 to look at the new patch set (#3). Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. IMPALA-5980:

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-20 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-19 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9584 to look at the new patch set (#2). Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. IMPALA-5980:

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: I talked to Bikram about the targeted perf tests. Apparently most

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: > I don't think we have any targeted perf tests for this at the >

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: I don't think we have any targeted perf tests for this at the

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: I don't think looking at cumulative time is quite sufficient unless we

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: > Do any of those benchmarks verify compile time performance? The

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: Do any of those benchmarks verify compile time performance? -- To

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-12 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9584 Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. IMPALA-5980: Upgrade to LLVM 5.0.1 Highlighting a few changes in LLVM: - Minor