[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-09-17 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 13: (1 comment) Thank Qifan and Csaba!

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-09-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 12: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-09-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. IMPALA-6505: Min-Max predicate push down in

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-09-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-09-16 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 12: Code-Review+2 (3 comments) Sounds like a good

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-09-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 12: Code-Review+1 (1 comment) lgtm to me with

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-09-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-09-15 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 12: (8 comments) > Patch Set 11: > > (5

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-09-15 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded a new patch set (#12) to the change originally created by Norbert Luksa. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ..

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-09-07 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 11: (3 comments) Looks great. Just have several

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-09-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 11: (5 comments) A few comments about

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 11: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 11: Build Successful

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-29 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 11: (10 comments) Thank Qifan and Zoltan for

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-29 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded a new patch set (#11) to the change originally created by Norbert Luksa. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ..

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-29 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded a new patch set (#10) to the change originally created by Norbert Luksa. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ..

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-27 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 9: Code-Review+1 (9 comments) Thanks

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-27 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 9: Code-Review+1 (1 comment) Thanks a lot for

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 8: Build Successful

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-26 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 8: (1 comment) * Added FE changes to skip

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-26 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded a new patch set (#8) to the change originally created by Norbert Luksa. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ..

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-26 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-26 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 7: (1 comment) | But I think we do need to improve

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 6: > It will also be great if we can add a test

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 6: (5 comments) Fixed a clang-tidy error

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded a new patch set (#6) to the change originally created by Norbert Luksa. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ..

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 5: (3 comments) Looks great! It will also be

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 5: Build Failed

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 4: (21 comments) Added tests and revoled the

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded a new patch set (#5) to the change originally created by Norbert Luksa. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ..

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded a new patch set (#4) to the change originally created by Norbert Luksa. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ..

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-24 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 3: Uploaded PS3 to resolve conflicts and test

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-24 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded a new patch set (#3) to the change originally created by Norbert Luksa. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner ..

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 2: (1 comment) I'm reviving this patch since

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-19 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 2: Some additional design choices for ORC. 1.

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-19 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 2: (13 comments) The code looks good. My concern

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2021-08-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-31 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-19 Thread Anonymous Coward (Code Review)
Anonymous Coward (520) has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-18 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 2: (3 comments) Just a few nits, otherwise

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 2: Build Failed

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-17 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 1: (6 comments) Thanks Quanlong and Csaba for

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-17 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. IMPALA-6505: Min-Max predicate push down in ORC scanner This

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-16 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 1: (1 comment) The change looks good so far

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 1: Build Failed

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-11 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/15403 ) Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. Patch Set 1: The build should fail since we do not have

[Impala-ASF-CR] IMPALA-6505: Min-Max predicate push down in ORC scanner

2020-03-11 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15403 Change subject: IMPALA-6505: Min-Max predicate push down in ORC scanner .. IMPALA-6505: Min-Max predicate push down in ORC scanner