[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures

2019-03-14 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12751 to look at the new patch set (#2). Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures ..

[Impala-ASF-CR] IMPALA-8176: Convert more backend tests to the unified executable

2019-03-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12759 Change subject: IMPALA-8176: Convert more backend tests to the unified executable .. IMPALA-8176: Convert more backend tests to the

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-03-12 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12668 to look at the new patch set (#2). Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails

[Impala-ASF-CR] Use test -x to check for ntp-wait

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12726 ) Change subject: Use test -x to check for ntp-wait .. Patch Set 1: > > This looks good to me. Quick question: Is this a cosmetic issue

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 ) Change subject: IMPALA-337: Add support for POST to the webserver .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12730 ) Change subject: IMPALA-337: Add support for POST to the webserver .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-13 Thread Joe McDonnell (Code Review)
Hello Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12730 to look at the new patch set (#3). Change subject: IMPALA-337: Add support for POST to the webserver

[Impala-ASF-CR] IMPALA-337: Add support for POST to the webserver

2019-03-13 Thread Joe McDonnell (Code Review)
Hello Andrew Sherman, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12730 to look at the new patch set (#4). Change subject: IMPALA-337: Add support for POST to the webserver

[Impala-ASF-CR] IMPALA-8003: Improve logging for diskspace errors from dataload

2019-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12399 ) Change subject: IMPALA-8003: Improve logging for diskspace errors from dataload .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 ) Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails .. Patch Set 3: Code-Review+1 Rebased, carry +1 --

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 ) Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-03-15 Thread Joe McDonnell (Code Review)
Hello David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12668 to look at the new patch set (#3). Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails

[Impala-ASF-CR] Remove setting of 'kudu.master addresses' from Kudu data loading

2019-03-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12827 ) Change subject: Remove setting of 'kudu.master_addresses' from Kudu data loading .. Patch Set 2: Code-Review+2 Thanks for fixing

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

2019-03-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 ) Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails .. Patch Set 4: Code-Review+1 Rebased, carry +1 --

[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-07 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12124 to look at the new patch set (#6). Change subject: IMPALA-8071: Initial unified backend test framework

[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-07 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12124 to look at the new patch set (#7). Change subject: IMPALA-8071: Initial unified backend test framework

[Impala-ASF-CR] IMPALA-7929: Allow null qualifier in THBaseFilter

2019-02-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12213 ) Change subject: IMPALA-7929: Allow null qualifier in THBaseFilter .. Patch Set 7: Code-Review+2 Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-07 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12124 to look at the new patch set (#8). Change subject: IMPALA-8071: Initial unified backend test framework

[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12124 ) Change subject: IMPALA-8071: Initial unified backend test framework .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

2019-02-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 ) Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag .. Patch Set 4: (1 comment) One small comment, then I

[Impala-ASF-CR] IMPALA-8003: Improve logging for diskspace errors from dataload

2019-02-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12399 Change subject: IMPALA-8003: Improve logging for diskspace errors from dataload .. IMPALA-8003: Improve logging for diskspace errors

[Impala-ASF-CR] Turn off shell debug tracing for create-load-data.sh

2019-02-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12398 Change subject: Turn off shell debug tracing for create-load-data.sh .. Turn off shell debug tracing for create-load-data.sh This

[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12124 ) Change subject: IMPALA-8071: Initial unified backend test framework .. Patch Set 7: Ok, hacked around the CLASSPATH issues, so this

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

2019-02-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 ) Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag .. Patch Set 2: (1 comment) I'm in the process of

[Impala-ASF-CR] IMPALA-7265: Enable caching of remote file handles by default

2019-02-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12387 Change subject: IMPALA-7265: Enable caching of remote file handles by default .. IMPALA-7265: Enable caching of remote file handles by

[Impala-ASF-CR] IMPALA-6503: Support reading complex types from ORC format files

2019-02-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12168 ) Change subject: IMPALA-6503: Support reading complex types from ORC format files .. Patch Set 12: (4 comments) A couple comments

[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12124 ) Change subject: IMPALA-8071: Initial unified backend test framework .. IMPALA-8071: Initial unified backend test framework

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

2019-02-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 ) Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag .. Patch Set 5: It looks like the patch got

[Impala-ASF-CR] Turn off shell debug tracing for create-load-data.sh

2019-02-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12398 ) Change subject: Turn off shell debug tracing for create-load-data.sh .. Patch Set 2: Code-Review+2 Rebase, carry +2 -- To view,

[Impala-ASF-CR] IMPALA-8189: Disable flaky scanner test on S3

2019-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12478 ) Change subject: IMPALA-8189: Disable flaky scanner test on S3 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8193: Fix python 2.6 issue in junit prune notrun.py

2019-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12479 Change subject: IMPALA-8193: Fix python 2.6 issue in junit_prune_notrun.py .. IMPALA-8193: Fix python 2.6 issue in

[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-06 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12124 to look at the new patch set (#4). Change subject: IMPALA-8071: Initial unified backend test framework

[Impala-ASF-CR] test-with-docker: decrease image size by "de-duping" HDFS.

2019-02-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11782 ) Change subject: test-with-docker: decrease image size by "de-duping" HDFS. .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12124 ) Change subject: IMPALA-8071: Initial unified backend test framework .. Patch Set 4: (3 comments) Fix some flake8 issues

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-02-05 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12037 to look at the new patch set (#9). Change subject: IMPALA-7928: Consistent remote read scheduling

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-02-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 9: Code-Review+2 Rebased to get past conflicts. Carry +2

[Impala-ASF-CR] IMPALA-8071: Initial unified backend test framework

2019-02-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12124 ) Change subject: IMPALA-8071: Initial unified backend test framework .. Patch Set 5: My build are failing due to CLASSPATH issues, so

[Impala-ASF-CR] IMPALA-7265: Enable caching of remote file handles by default

2019-02-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12387 ) Change subject: IMPALA-7265: Enable caching of remote file handles by default .. IMPALA-7265: Enable caching of remote file

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-02-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. IMPALA-7928: Consistent remote read scheduling Currently,

[Impala-ASF-CR] IMPALA-8214: Fix bad plan in load nested.py

2019-02-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12519 ) Change subject: IMPALA-8214: Fix bad plan in load_nested.py .. Patch Set 3: Code-Review+2 Thanks for taking this on. Looks good. --

[Impala-ASF-CR] IMPALA-8105: [DOCS] Document cache remote file handles flag

2019-02-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12362 ) Change subject: IMPALA-8105: [DOCS] Document cache_remote_file_handles flag .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-01-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 3: (6 comments) Adding some comments to indicate what

[Impala-ASF-CR] IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

2019-01-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12288 ) Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7980: Fix spinning because of buggy num unqueued files .

2019-01-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12097 ) Change subject: IMPALA-7980: Fix spinning because of buggy num_unqueued_files_. .. Patch Set 7: (1 comment) One last nitpick.

[Impala-ASF-CR] IMPALA-7999: clean up start-*d.sh scripts

2019-01-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12271 ) Change subject: IMPALA-7999: clean up start-*d.sh scripts .. Patch Set 6: (9 comments)

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-01-30 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12037 to look at the new patch set (#4). Change subject: IMPALA-7928: Consistent remote read scheduling

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-01-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 5: Forgot one file. -- To view, visit

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-01-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 3: (11 comments)

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-01-30 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12037 to look at the new patch set (#5). Change subject: IMPALA-7928: Consistent remote read scheduling

[Impala-ASF-CR] IMPALA-7999: clean up start-*d.sh scripts

2019-02-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12271 ) Change subject: IMPALA-7999: clean up start-*d.sh scripts .. Patch Set 9: Code-Review+2 This looks good to me. Thanks for taking this

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-02-04 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12037 to look at the new patch set (#6). Change subject: IMPALA-7928: Consistent remote read scheduling

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-02-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 6: Refresh to get Impala-lzo change -- To view, visit

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-02-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 5: (55 comments)

[Impala-ASF-CR] IMPALA-7941: part 2/2: use cgroups memory limit

2019-01-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12262 ) Change subject: IMPALA-7941: part 2/2: use cgroups memory limit .. Patch Set 3: Code-Review+1 (2 comments) Looks good to me. I

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-02-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 7: Fix clang tidy issue -- To view, visit

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-02-05 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12037 to look at the new patch set (#8). Change subject: IMPALA-7928: Consistent remote read scheduling

[Impala-ASF-CR] IMPALA-7928: Consistent remote read scheduling

2019-02-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12037 ) Change subject: IMPALA-7928: Consistent remote read scheduling .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-09 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#2). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-08 Thread Joe McDonnell (Code Review)
Hello Andrew Sherman, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12885 to look at the new patch set (#6). Change subject: IMPALA-8371: Return appropriate error code for unified backend tests

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 6: Code-Review+2 Carry +2 -- To

[Impala-ASF-CR] IMPALA-8371: Return appropriate error code for unified backend tests

2019-04-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12885 ) Change subject: IMPALA-8371: Return appropriate error code for unified backend tests .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-11 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#4). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb

[Impala-ASF-CR] IMPALA-8344: Add support for running the minicluster with S3Guard

2019-04-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13020 Change subject: IMPALA-8344: Add support for running the minicluster with S3Guard .. IMPALA-8344: Add support for running the

[Impala-ASF-CR] IMPALA-8415: Fix tests broken by storage layer information

2019-04-16 Thread Joe McDonnell (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13025 to look at the new patch set (#2). Change subject: IMPALA-8415: Fix tests broken by storage layer information

[Impala-ASF-CR] IMPALA-8415: Fix tests broken by storage layer information

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13025 ) Change subject: IMPALA-8415: Fix tests broken by storage layer information .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13005 ) Change subject: IMPALA-8369 : Impala should be able to interoperate with Hive 3.1.0 .. Patch Set 3: (3 comments) Before more work

[Impala-ASF-CR] IMPALA-8415: Fix tests broken by storage layer information

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13025 Change subject: IMPALA-8415: Fix tests broken by storage layer information .. IMPALA-8415: Fix tests broken by storage layer

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 ) Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201 .. Patch Set 10: Code-Review+1 (1 comment) This looks fine to me. I

[Impala-ASF-CR] IMPALA-8329: Bump CDP BUILD NUMBER to 1013201

2019-04-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 ) Change subject: IMPALA-8329: Bump CDP_BUILD_NUMBER to 1013201 .. Patch Set 11: Code-Review+2 Bump this to +2 -- To view, visit

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12968 ) Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8322: Add periodic dirty check of done in ThreadTokenAvailableCb

2019-04-12 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12968 to look at the new patch set (#5). Change subject: IMPALA-8322: Add periodic dirty check of done_ in ThreadTokenAvailableCb

[Impala-ASF-CR] IMPALA-8346: Don't create FE testcase files unless testing locally

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12958 ) Change subject: IMPALA-8346: Don't create FE testcase files unless testing locally .. Patch Set 4: Code-Review+1 (1 comment) This

[Impala-ASF-CR] IMPALA-7995: part 2: Jenkins script to automate e2e tests

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12937 ) Change subject: IMPALA-7995: part 2: Jenkins script to automate e2e tests .. Patch Set 7: Code-Review+2 This makes sense to me. --

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 15: Code-Review+1 (3 comments) This makes

[Impala-ASF-CR] IMPALA-7995: part 1: fixes for e2e dockerised impala tests

2019-04-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 ) Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests .. Patch Set 17: Code-Review+2 Thanks for getting this

[Impala-ASF-CR] Move DEBIAN FRONTEND=noninteractive variable to the ubuntu section of the script

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 ) Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script .. Patch Set 1: > > (1 comment) >

[Impala-ASF-CR] IMPALA-8303: Generate JUnitXML for ASAN failures

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12733 ) Change subject: IMPALA-8303: Generate JUnitXML for ASAN failures .. IMPALA-8303: Generate JUnitXML for ASAN failures This

[Impala-ASF-CR] IMPALA-8305: Generate JUnitXML for DCHECK failures

2019-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12751 Change subject: IMPALA-8305: Generate JUnitXML for DCHECK failures .. IMPALA-8305: Generate JUnitXML for DCHECK failures DCHECKs log

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

2019-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 ) Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh .. Patch Set 1: The job that calls

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13343 to look at the new patch set (#2). Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true ..

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

2019-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13335 Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh .. Add USE_CDP_HIVE=true case to

[Impala-ASF-CR] Fix condition for starting YARN on USE CDP HIVE=true

2019-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13343 Change subject: Fix condition for starting YARN on USE_CDP_HIVE=true .. Fix condition for starting YARN on USE_CDP_HIVE=true Dataload

[Impala-ASF-CR] Allow data cache to be enabled optionally when running tests

2019-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13330 ) Change subject: Allow data cache to be enabled optionally when running tests .. Patch Set 4: Code-Review+2 This looks good to me.

[Impala-ASF-CR] Allow running backend tests sharded and in parallel

2019-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13290 ) Change subject: Allow running backend tests sharded and in parallel .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Enable data cache by default for all S3 builds

2019-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13330 ) Change subject: Enable data cache by default for all S3 builds .. Patch Set 2: (2 comments)

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

2019-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 ) Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh .. Patch Set 2: Code-Review+2 Rebased, carry +2 -- To

[Impala-ASF-CR] Allow running backend tests sharded and in parallel

2019-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13290 ) Change subject: Allow running backend tests sharded and in parallel .. Patch Set 2: (2 comments) I think this is a good approach.

[Impala-ASF-CR] WIP: IMPALA-8586: Support download URLs for CDP

2019-05-24 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13432 Change subject: WIP: IMPALA-8586: Support download URLs for CDP .. WIP: IMPALA-8586: Support download URLs for CDP The CDP part of

[Impala-ASF-CR] WIP IMPALA-8425: Prototype to skip unneeded Kudu binaries for docker image

2019-06-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/13488 ) Change subject: WIP IMPALA-8425: Prototype to skip unneeded Kudu binaries for docker image .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-8425: part 1: reduce size of binaries in container

2019-06-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13487 ) Change subject: IMPALA-8425: part 1: reduce size of binaries in container .. Patch Set 4: (1 comment) This makes sense to me. Thanks

[Impala-ASF-CR] IMPALA-8546: collect logs from docker containers

2019-05-28 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13393 ) Change subject: IMPALA-8546: collect logs from docker containers .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8491: Non-root user in container

2019-05-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13451 ) Change subject: IMPALA-8491: Non-root user in container .. Patch Set 3: Code-Review+2 Looks good -- To view, visit

[Impala-ASF-CR] WIP IMPALA-8425: Prototype to skip unneeded Kudu binaries for docker image

2019-05-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13488 Change subject: WIP IMPALA-8425: Prototype to skip unneeded Kudu binaries for docker image .. WIP IMPALA-8425: Prototype to skip

[Impala-ASF-CR] IMPALA-8630: Include partition id when calculating consistent remote placement

2019-06-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13545 Change subject: IMPALA-8630: Include partition id when calculating consistent remote placement .. IMPALA-8630: Include partition id

[Impala-ASF-CR] IMPALA-8425: part 1: reduce size of binaries in container

2019-06-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13487 ) Change subject: IMPALA-8425: part 1: reduce size of binaries in container .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8425: part 1: reduce size of binaries in container

2019-06-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13487 ) Change subject: IMPALA-8425: part 1: reduce size of binaries in container .. Patch Set 4: Code-Review+2 (1 comment) > For our test

[Impala-ASF-CR] IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

2019-06-06 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13522 to look at the new patch set (#4). Change subject: IMPALA-8561: Eliminate mtime=-1 for HDFS scan ranges (part 1)

[Impala-ASF-CR] WIP: IMPALA-8586: Support download URLs for CDP

2019-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13432 ) Change subject: WIP: IMPALA-8586: Support download URLs for CDP .. Patch Set 1: (7 comments) I'm pretty sure extending this to the

<    1   2   3   4   5   6   7   8   9   10   >