[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 1: (3 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 2: (4 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 1: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 2: (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 4: (2 comments) http://gerrit.

[Impala-ASF-CR] KUDU-2301: (Part-1) Add instrumentation on a per connection level

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9383 ) Change subject: KUDU-2301: (Part-1) Add instrumentation on a per connection level .. Patch Set 1: Code-Review+1 Looks good to me, manual

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 5: (4 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 7: (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 8: (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 9: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-02-22 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 10: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-02-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 4: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-02 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6601: fix ASAN issue in row-batch-serialize-test

2018-03-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9488 ) Change subject: IMPALA-6601: fix ASAN issue in row-batch-serialize-test .. Patch Set 1: Code-Review+2 Thanks for fixing this! -- To vie

[Impala-ASF-CR] Draft: Add JSON output to MemTracker::LogUsage()

2018-03-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8955 ) Change subject: Draft: Add JSON output to MemTracker::LogUsage() .. Patch Set 1: This is a draft and not meant for reviewing. -- To vie

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9300/6/b

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 5: (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 12: (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9516 Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC This change renames the TES

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. Patch Set 1: (1 comment) Thanks for the review, Sailesh. Please see PS2

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Hello Michael Ho, Philip Zeyliger, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9516 to look at the new patch set (#2). Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC ..

[Impala-ASF-CR] IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 ) Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads .. Patch Set 13: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. Patch Set 2: Verified+1 This change does not affect the builds in out GD

[Impala-ASF-CR] IMPALA-6613: Change TEST KRPC to DISABLE KRPC

2018-03-06 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9516 ) Change subject: IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC .. IMPALA-6613: Change TEST_KRPC to DISABLE_KRPC This change rename

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-07 Thread Lars Volker (Code Review)
Hello Dan Hecht, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9530 to review the following change. Change subject: IMPALA-6405: Error when string to decimal cast overflows .

[Impala-ASF-CR](2.x) IMPALA-6405: Ignore commit for automatic cherry picking

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9531 Change subject: IMPALA-6405: Ignore commit for automatic cherry picking .. IMPALA-6405: Ignore commit for automatic cherry picking The fix

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9532 Change subject: Add missing brace to example JSON .. Add missing brace to example JSON Change-Id: Ieabf181a6e052790ebe7034a1e4dd1632644fd8

[Impala-ASF-CR](2.x) IMPALA-6405: Ignore commit for automatic cherry picking

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9531 ) Change subject: IMPALA-6405: Ignore commit for automatic cherry picking .. IMPALA-6405: Ignore commit for automatic cherry picking

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Hello Philip Zeyliger, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9532 to look at the new patch set (#2). Change subject: Add missing brace to example JSON .. Add missing br

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9532 ) Change subject: Add missing brace to example JSON .. Patch Set 1: (2 comments) Thanks Alex for the review. Please see PS2. http://gerri

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9532 ) Change subject: Add missing brace to example JSON .. Add missing brace to example JSON Change-Id: Ieabf181a6e052790ebe7034a1e4dd1

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9532 ) Change subject: Add missing brace to example JSON .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9532 To u

[Impala-ASF-CR] Add missing brace to example JSON

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9532 ) Change subject: Add missing brace to example JSON .. Patch Set 2: Marking this as +1 Verified, it only updates a comment and does not aff

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9546/1/tests/que

[Impala-ASF-CR] Fix test dimensions in test errorlog.py

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9546 ) Change subject: Fix test dimensions in test_errorlog.py .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6617: Improve diagnostics for debugging.

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9545 ) Change subject: IMPALA-6617: Improve diagnostics for debugging. .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics

2018-03-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9381 ) Change subject: IMPALA-6542: Fix inconsistent write path of Parquet min/max statistics .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9555 ) Change subject: IMPALA-6227: more logging in test_admission_controller .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-6589: remove invalid DCHECK in parquet reader

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9556 ) Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/955

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: I had done the same, but it's still running: ht

[Impala-ASF-CR] IMPALA-6394: Restart HDFS when blocks are under replicated

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9469 ) Change subject: IMPALA-6394: Restart HDFS when blocks are under replicated .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-08 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9562 Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. IMPALA-6576: Add metrics for data stream service memory us

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: Verified-1 Both builds have failed. Can you have

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 2: (6 comments) Thanks for the review. Please

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9562 to look at the new patch set (#3). Change subject: IMPALA-6576: Add metrics for data stream service memory usage ...

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-09 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 3: (1 comment) Thanks for the review Michael.

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9562 to look at the new patch set (#4). Change subject: IMPALA-6576: Add metrics for data stream service memory usage

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 4: Code-Review+1 Thanks for the reviews. PS4 a

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9562 to look at the new patch set (#5). Change subject: IMPALA-6576: Add metrics for data stream service memory usage .

[Impala-ASF-CR] IMPALA-6576: Add metrics for data stream service memory usage

2018-03-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 ) Change subject: IMPALA-6576: Add metrics for data stream service memory usage .. Patch Set 5: I wasn't happy with the metric naming, I th

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-12 Thread Lars Volker (Code Review)
Hello Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9530 to look at the new patch set (#2). Change subject: IMPALA-6405: Error when string to decimal cast overflows .

[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows

2018-03-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal cast overflo

[Impala-ASF-CR] DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics

2018-03-13 Thread Lars Volker (Code Review)
Lars Volker has restored this change. ( http://gerrit.cloudera.org:8080/7354 ) Change subject: DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics .. Restored We'll want to discuss this as part of implementing page index

[Impala-ASF-CR] IMPALA-6652: Rename Data Stream Manager MemTracker

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9633 Change subject: IMPALA-6652: Rename Data Stream Manager MemTracker .. IMPALA-6652: Rename Data Stream Manager MemTracker This change renam

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9632 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-6652: Rename Data Stream Manager MemTracker

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename Data Stream Manager MemTracker .. Patch Set 1: (2 comments) Thanks for the review. I saw your change

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. IMPALA-6652: Rename label of MemTracker for early RPCs This chang

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. Patch Set 3: (2 comments) Please see PS4. http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9633 ) Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-6652: Rename label of MemTracker for early RPCs

2018-03-14 Thread Lars Volker (Code Review)
Hello Michael Ho, Mostafa Mokhtar, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9633 to look at the new patch set (#4). Change subject: IMPALA-6652: Rename label of MemTracker for early RPCs .

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 4: (6 comments) I had a first look

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 5: Code-Review+1 (2 comments) I was

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. Patch Set 1: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-6690: Fix pip download.py on python 2.6

2018-03-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9694 ) Change subject: IMPALA-6690: Fix pip_download.py on python 2.6 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (12 comments) I, too, left some high level comments. htt

[Impala-ASF-CR] IMPALA-6394: Restart HDFS only when no replication progress is made

2018-03-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9698 ) Change subject: IMPALA-6394: Restart HDFS only when no replication progress is made .. Patch Set 1: (1 comment) http://gerrit.cloudera.

[Impala-ASF-CR](2.x) IMPALA-6690: Fix pip download.py on python 2.6

2018-03-17 Thread Lars Volker (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9710 to review the following change. Change subject: IMPALA-6690: Fix pip_download.py on python 2.6 .. IMPALA-669

[Impala-ASF-CR](2.x) IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-17 Thread Lars Volker (Code Review)
Hello Tianyi Wang, Taras Bobrovytsky, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9709 to review the following change. Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script

[Impala-ASF-CR] IMPALA-6695: Fix PyPi regex, update setuptools version

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9711 Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version .. IMPALA-6695: Fix PyPi regex, update setuptools version pytest-ru

[Impala-ASF-CR](2.x) IMPALA-6695: Fix PyPi regex, update setuptools version

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9712 Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version .. IMPALA-6695: Fix PyPi regex, update setuptools version pytest-ru

[Impala-ASF-CR] IMPALA-6695: Fix PyPi regex, update setuptools version

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9711 ) Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version .. Patch Set 1: Verified+1 Successful pre-submit job here: https:

[Impala-ASF-CR] IMPALA-6695: Fix PyPi regex, update setuptools version

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9711 ) Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version .. IMPALA-6695: Fix PyPi regex, update setuptools version

[Impala-ASF-CR](2.x) IMPALA-6695: Fix PyPi regex, update setuptools version

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9712 ) Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version .. Patch Set 1: Verified+1 Successful pre-submit job here: https:

[Impala-ASF-CR] IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9713 ) Change subject: IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6 .. IMPALA-6697: Downgrade setuptools to be compatible wi

[Impala-ASF-CR] IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9713 Change subject: IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6 .. IMPALA-6697: Downgrade setuptools to be compatible w

[Impala-ASF-CR](2.x) IMPALA-6695: Fix PyPi regex, update setuptools version

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9712 ) Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version .. Patch Set 1: Code-Review+2 Clean cherry-pick. -- To view, vis

[Impala-ASF-CR](2.x) IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9709 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. Patch Set 1: Verified+1 Code-Review+2 Succesful pre-submi

[Impala-ASF-CR](2.x) IMPALA-6695: Fix PyPi regex, update setuptools version

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9712 ) Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version .. IMPALA-6695: Fix PyPi regex, update setuptools version

[Impala-ASF-CR](2.x) IMPALA-6690: Fix pip download.py on python 2.6

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9710 ) Change subject: IMPALA-6690: Fix pip_download.py on python 2.6 .. Patch Set 1: Verified+1 Code-Review+2 Succesful pre-submit job here: h

[Impala-ASF-CR](2.x) IMPALA-6690: Fix pip download.py on python 2.6

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9710 ) Change subject: IMPALA-6690: Fix pip_download.py on python 2.6 .. IMPALA-6690: Fix pip_download.py on python 2.6 IMPALA-6682 used

[Impala-ASF-CR](2.x) IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9709 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. IMPALA-6682: Remove MD5 assumption from pypi downl

[Impala-ASF-CR] IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9713 ) Change subject: IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6 .. IMPALA-6697: Downgrade setuptools to be com

[Impala-ASF-CR] IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9713 ) Change subject: IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6 .. Patch Set 2: Verified+1 Successful pre-commit run

[Impala-ASF-CR](2.x) IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6

2018-03-18 Thread Lars Volker (Code Review)
Hello Philip Zeyliger, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9714 to review the following change. Change subject: IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6 ...

[Impala-ASF-CR](2.x) IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6

2018-03-18 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9714 ) Change subject: IMPALA-6697: Downgrade setuptools to be compatible with Python 2.6 .. Patch Set 1: Code-Review+2 Clean cherry-pick --

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 7: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-03-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9718 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Patch Set 1: (10 comments) Had some comments on the overall ap

[Impala-ASF-CR] Make sys-info-test pass in Docker containers.

2018-03-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9723 ) Change subject: Make sys-info-test pass in Docker containers. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9723/1//C

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 1: (7 comments) http://gerri

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 3: (19 comments) http://gerrit.cloudera.org:8080/#/c/9693/2/

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

2018-03-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9693/2/be

[Impala-ASF-CR] Make sys-info-test pass in Docker containers.

2018-03-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9723 ) Change subject: Make sys-info-test pass in Docker containers. .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-03-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9718 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Patch Set 1: (5 comments) Thanks for the replies. I left some

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 1: (4 comments) http://gerri

[Impala-ASF-CR] IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender

2018-03-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9690 ) Change subject: IMPALA-6685: Improve profiles in KrpcDataStreamRecvr and KrpcDataStreamSender .. Patch Set 3: Code-Review+1 (1 comment)

<    1   2   3   4   5   6   7   8   9   10   >