[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 ) Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 ) Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-7141. Extract interfaces for partition pruning without loading

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10631 ) Change subject: IMPALA-7141. Extract interfaces for partition pruning without loading .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7141. Extract interfaces for partition pruning without loading

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10631 ) Change subject: IMPALA-7141. Extract interfaces for partition pruning without loading .. Patch Set 5: (9 comments)

[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10703 ) Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition pruning .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10703 ) Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition pruning .. Patch Set 2: (2 comments) what was

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10631 ) Change subject: IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading .. Patch Set 6: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10703 ) Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition pruning .. Patch Set 3: ah, thanks for the explanation!

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 1: Code-Review+2 (1 comment) nice

[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10703 ) Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition pruning .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 ) Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10631 ) Change subject: IMPALA-7141 (part 2). Extract interfaces for partition pruning without loading .. Patch Set 7: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7141 (part 1): clean up handling of default/dummy partition

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10711 ) Change subject: IMPALA-7141 (part 1): clean up handling of default/dummy partition .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7140 (part 2). Create skeleton for LocalFsTable

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10712 ) Change subject: IMPALA-7140 (part 2). Create skeleton for LocalFsTable .. Patch Set 2: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-7140 (part 3): load partitions for FS tables

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10713 ) Change subject: IMPALA-7140 (part 3): load partitions for FS tables .. Patch Set 2: (16 comments)

[Impala-ASF-CR] IMPALA-7140 (part 3): load partitions for FS tables

2018-06-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10713 ) Change subject: IMPALA-7140 (part 3): load partitions for FS tables .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-7140 (part 3): load partitions for FS tables

2018-06-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10713 ) Change subject: IMPALA-7140 (part 3): load partitions for FS tables .. Patch Set 3: (5 comments) mostly nits.. perhaps a merge

[Impala-ASF-CR] IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog

2018-06-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10630 ) Change subject: IMPALA-7140 (part 1). Support fetching schema info in LocalCatalog .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7175: deflake check for failed impalad

2018-06-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10745 Change subject: IMPALA-7175: deflake check for failed impalad .. IMPALA-7175: deflake check for failed impalad

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

2018-06-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10746 Change subject: IMPALA-7150: fixes jni frame scope .. IMPALA-7150: fixes jni frame scope A previous change

[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 ) Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7137. Support configuring Frontend to use LocalCatalog

2018-06-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 ) Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 3: Code-Review+2 thanks for the

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. Patch Set 2: (11 comments)

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 2: (3 comments) thanks for the

[Impala-ASF-CR] IMPALA-7140 (part 3): load partitions for FS tables

2018-06-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10713 ) Change subject: IMPALA-7140 (part 3): load partitions for FS tables .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 ) Change subject: IMPALA-7128 (part 2): add an interface for data sources .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 4: Code-Review+2 needs a rebase

[Impala-ASF-CR] IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition

2018-06-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10611 ) Change subject: IMPALA-7128 (part 1) Refactor interfaces for Db, View, Table, Partition .. Patch Set 4: I think this needs to be

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-6802 (part 4): Clean up authorization tests

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10442 ) Change subject: IMPALA-6802 (part 4): Clean up authorization tests .. Patch Set 4: I'm fine with it.. one more small change needed to

[Impala-ASF-CR] IMPALA-7144: Re-enable TestDescribeTableResults

2018-06-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 ) Change subject: IMPALA-7144: Re-enable TestDescribeTableResults .. Patch Set 3: (5 comments) several small suggestions to make

[Impala-ASF-CR] IMPALA-7135. Skeleton implementation of LocalCatalog

2018-06-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10627 ) Change subject: IMPALA-7135. Skeleton implementation of LocalCatalog .. Patch Set 2: (13 comments)

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-05-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 5: (6 comments)

[Impala-ASF-CR] IMPALA-5552: Add support for authorized proxy groups

2018-05-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10510 ) Change subject: IMPALA-5552: Add support for authorized proxy groups .. Patch Set 7: Code-Review+1 (1 comment) thx for the changes.

[Impala-ASF-CR] IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule

2018-05-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10528 ) Change subject: IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule .. Patch Set 2: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule

2018-05-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10528 ) Change subject: IMPALA-7090: Limit the size of expr created by EqualityDisjunctsToInRule .. Patch Set 1: (6 comments)

[Impala-ASF-CR] Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously

2018-05-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10560 ) Change subject: Fix Indents from IMPALA-4970 fixing the mistake in indentation made previously .. Patch Set 1: Same info, but its

[Impala-ASF-CR] [DOCS] Not able to create new tables when the statestore is offline

2018-05-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10481 ) Change subject: [DOCS] Not able to create new tables when the statestore is offline .. Patch Set 2: (3 comments)

[Impala-ASF-CR] [DOCS] Not able to create new tables when the statestore is offline

2018-05-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10481 ) Change subject: [DOCS] Not able to create new tables when the statestore is offline .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs

2018-06-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 ) Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7105. Ensure fe tests pass when running standalone

2018-06-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10570 ) Change subject: IMPALA-7105. Ensure fe tests pass when running standalone .. Patch Set 1: Code-Review+2 tried -DreuseForks=false with

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 4: (5 comments)

[Impala-ASF-CR] [DOCS] Not able to create new tables when the statestore is offline

2018-06-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10481 ) Change subject: [DOCS] Not able to create new tables when the statestore is offline .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10602 Change subject: IMPALA-6956: deflake and logging for query_expiration test .. IMPALA-6956: deflake and logging for query_expiration

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6917: Implement COMMENT ON TABLE/VIEW

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10478 ) Change subject: IMPALA-6917: Implement COMMENT ON TABLE/VIEW .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7106: Print rewritten SQL correctly when log trace is enabled

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10571 ) Change subject: IMPALA-7106: Print rewritten SQL correctly when log trace is enabled .. Patch Set 5: (1 comment) thanks for the

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10602 to look at the new patch set (#2). Change subject: IMPALA-6956: deflake and logging for query_expiration test ..

[Impala-ASF-CR] IMPALA-7077. Add a configuration for the max number of partitions to load

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10584 ) Change subject: IMPALA-7077. Add a configuration for the max number of partitions to load .. Patch Set 1: Another idea that also

[Impala-ASF-CR] IMPALA-6956: deflake and logging for query expiration test

2018-06-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10602 ) Change subject: IMPALA-6956: deflake and logging for query_expiration test .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-7016: Implement ALTER DATABASE SET OWNER

2018-06-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10471 ) Change subject: IMPALA-7016: Implement ALTER DATABASE SET OWNER .. Patch Set 5: (1 comment)

[Impala-ASF-CR] [DOCS] Not able to create new tables when the statestore is offline

2018-06-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10481 ) Change subject: [DOCS] Not able to create new tables when the statestore is offline .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-7224. Improve performance of UpdateCatalogMetrics

2018-06-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10846 ) Change subject: IMPALA-7224. Improve performance of UpdateCatalogMetrics .. Patch Set 1: Code-Review+2 yikes... thanks! -- To view,

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-27 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-6802 (part 5): Clean up authorization tests

2018-06-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10799 ) Change subject: IMPALA-6802 (part 5): Clean up authorization tests .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 18: (2 comments)

[Impala-ASF-CR] IMPALA-7140 (part 4): support creating descriptors for FS tables

2018-06-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10735 ) Change subject: IMPALA-7140 (part 4): support creating descriptors for FS tables .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7140 (part 5): support fetching file info for FS tables

2018-06-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10749 ) Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7140 (part 5): support fetching file info for FS tables

2018-06-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10749 ) Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-7140 (part 5): support fetching file info for FS tables

2018-06-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10749 ) Change subject: IMPALA-7140 (part 5): support fetching file info for FS tables .. Patch Set 2: Code-Review+2 (6 comments)

[Impala-ASF-CR] IMPALA-7140 (part 3): load partitions for FS tables

2018-06-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10713 ) Change subject: IMPALA-7140 (part 3): load partitions for FS tables .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [DOCS] Added another scenario when REFRESH is required

2018-06-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10773 ) Change subject: [DOCS] Added another scenario when REFRESH is required .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

2018-06-20 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10746 to look at the new patch set (#2). Change subject: IMPALA-7150: fixes jni frame scope .. IMPALA-7150: fixes jni

[Impala-ASF-CR] IMPALA-7150: fixes jni frame scope

2018-06-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10746 ) Change subject: IMPALA-7150: fixes jni frame scope .. Patch Set 1: (1 comment) I have not been able to repro-- this particular issue

[Impala-ASF-CR] IMPALA-7175: deflake check for failed impalad

2018-06-20 Thread Vuk Ercegovac (Code Review)
Hello Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10745 to look at the new patch set (#2). Change subject: IMPALA-7175: deflake check for failed impalad ..

[Impala-ASF-CR] IMPALA-7175: deflake check for failed impalad

2018-06-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10745 ) Change subject: IMPALA-7175: deflake check for failed impalad .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6119: Fix issue with multiple partitions sharing same location

2018-06-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 ) Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location .. Patch Set 17: (9 comments)

[Impala-ASF-CR] [DOCS] Added another scenario when REFRESH is required

2018-06-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10773 ) Change subject: [DOCS] Added another scenario when REFRESH is required .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6305: Allow column definitions in ALTER VIEW

2018-06-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10720 ) Change subject: IMPALA-6305: Allow column definitions in ALTER VIEW .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6931: reduces races in query expiration tests

2018-05-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10279 Change subject: IMPALA-6931: reduces races in query expiration tests .. IMPALA-6931: reduces races in query expiration tests Recent

[Impala-ASF-CR] IMPALA-6931: reduces races in query expiration tests

2018-05-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10279 ) Change subject: IMPALA-6931: reduces races in query expiration tests .. Patch Set 1: agreed. an immediate next step is to break this

[Impala-ASF-CR] IMPALA-6948,6962: add end-to-end tests

2018-05-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10291 Change subject: IMPALA-6948,6962: add end-to-end tests .. IMPALA-6948,6962: add end-to-end tests Adds end-to-end tests to validate

[Impala-ASF-CR] IMPALA-6948: Delete catalog update topic entries upon catalog restart

2018-05-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10289 ) Change subject: IMPALA-6948: Delete catalog update topic entries upon catalog restart .. Patch Set 1: (1 comment) still looking ...

[Impala-ASF-CR] IMPALA-6948,6962: add end-to-end tests

2018-05-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10291 ) Change subject: IMPALA-6948,6962: add end-to-end tests .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6948,IMPALA-6962: add end-to-end tests

2018-05-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10291 ) Change subject: IMPALA-6948,IMPALA-6962: add end-to-end tests .. Patch Set 2: (1 comment) several changes: - downgraded several

[Impala-ASF-CR] IMPALA-6948,IMPALA-6962: add end-to-end tests

2018-05-03 Thread Vuk Ercegovac (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10291 to look at the new patch set (#2). Change subject: IMPALA-6948,IMPALA-6962: add end-to-end tests ..

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2017-12-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: I thought about it, but since it was relatively localized,

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 6: ping. -- To view, visit

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8775 ) Change subject: IMPALA-4993: extend dictionary filtering to collections .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-4993: extend dictionary filtering to collections

2018-01-09 Thread Vuk Ercegovac (Code Review)
Hello Lars Volker, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8775 to look at the new patch set (#7). Change subject: IMPALA-4993: extend dictionary filtering to collections

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-01-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 1: (9 comments)

[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators

2018-01-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8890 ) Change subject: IMPALA-3526: update FE tests to pass on S3 .. Patch Set 2: For an explanation for the plan difference, pls have a look

[Impala-ASF-CR] IMPALA-3526: update FE tests to pass on S3

2018-01-08 Thread Vuk Ercegovac (Code Review)
Hello Thomas Tauber-Marshall, Taras Bobrovytsky, Lars Volker, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8890 to look at the new patch set (#3). Change subject: IMPALA-3526: update FE tests to pass on S3

[Impala-ASF-CR] IMPALA-1767: [DOCS] Document new Boolean operators

2018-01-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8942 ) Change subject: IMPALA-1767: [DOCS] Document new Boolean operators .. Patch Set 5: Code-Review+1 -- To view, visit

<    1   2   3   4   5   6   7   8   >