[Impala-ASF-CR] IMPALA-7622: adds profile metrics when fetching incremental stats

2018-09-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11534 ) Change subject: IMPALA-7622: adds profile metrics when fetching incremental stats .. Patch Set 2: (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-7622: adds profile metrics when fetching incremental stats

2018-09-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11534 ) Change subject: IMPALA-7622: adds profile metrics when fetching incremental stats .. Patch Set 3: Code-Review+2 carry +2 -- To view

[Impala-ASF-CR] IMPALA-7599: make the number of local cache retries configurable

2018-09-28 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11539 to look at the new patch set (#2). Change subject: IMPALA-7599: make the number of local cache retries configurable .

[Impala-ASF-CR] IMPALA-7599: make the number of local cache retries configurable

2018-09-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11539 ) Change subject: IMPALA-7599: make the number of local cache retries configurable .. Patch Set 2: (5 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7599: make the number of local cache retries configurable

2018-09-28 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11539 to look at the new patch set (#3). Change subject: IMPALA-7599: make the number of local cache retries configurable .

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-09-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: All-null columns give wrong estimates in planner .. Patch Set 8: (10 comments) first pass comments. will

[Impala-ASF-CR] IMPALA-7599: make the number of local cache retries configurable

2018-09-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11539 ) Change subject: IMPALA-7599: make the number of local cache retries configurable .. Patch Set 3: (2 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7599: make the number of local cache retries configurable

2018-09-28 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11539 to look at the new patch set (#4). Change subject: IMPALA-7599: make the number of local cache retries configurable .

[Impala-ASF-CR] IMPALA-7310: All-null columns give wrong estimates in planner

2018-09-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 ) Change subject: IMPALA-7310: All-null columns give wrong estimates in planner .. Patch Set 8: (3 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7599: make the number of local cache retries configurable

2018-09-28 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11539 to look at the new patch set (#5). Change subject: IMPALA-7599: make the number of local cache retries configurable .

[Impala-ASF-CR] IMPALA-7599: make the number of local cache retries configurable

2018-09-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11539 ) Change subject: IMPALA-7599: make the number of local cache retries configurable .. Patch Set 5: Code-Review+2 carry +2 -- To view,

[Impala-ASF-CR] IMPALA-7532: Add catalogd client backoff time into impalad CLI options

2018-09-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11543 ) Change subject: IMPALA-7532: Add catalogd client backoff time into impalad CLI options .. Patch Set 2: (2 comments) http://gerrit.cl

[Impala-ASF-CR] Revert "IMPALA-7622: adds profile metrics when fetching incremental stats"

2018-10-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11551 Change subject: Revert "IMPALA-7622: adds profile metrics when fetching incremental stats" .. Revert "IMPALA-7622: adds profile metrics

[Impala-ASF-CR] IMPALA-7532: Add catalogd client backoff time into impalad CLI options

2018-10-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11543 ) Change subject: IMPALA-7532: Add catalogd client backoff time into impalad CLI options .. Patch Set 3: Code-Review+2 (1 comment) htt

[Impala-ASF-CR] IMPALA-7532: Add catalogd client backoff time into impalad CLI options

2018-10-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11543 ) Change subject: IMPALA-7532: Add catalogd client backoff time into impalad CLI options .. Patch Set 5: (1 comment) http://gerrit.clo

[Impala-ASF-CR] Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile"

2018-10-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11560 Change subject: Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile" .. Revert "IMPALA-7527: add fetch-from-catalogd cac

[Impala-ASF-CR] Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile"

2018-10-01 Thread Vuk Ercegovac (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11560 to look at the new patch set (#3). Change subject: Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile" ..

[Impala-ASF-CR] Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile"

2018-10-01 Thread Vuk Ercegovac (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11560 to look at the new patch set (#4). Change subject: Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile" ..

[Impala-ASF-CR] Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile"

2018-10-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11560 ) Change subject: Revert "IMPALA-7527: add fetch-from-catalogd cache info to profile" .. Patch Set 4: Code-Review+2 removed too much of

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-10-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11569 Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. IMPALA-7527: add fetch-from-catalogd cache info to profile

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-10-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11569 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 1: (1 comment) The change is to put these met

[Impala-ASF-CR] WIP IMPALA-7626: Throttle catalog partial RPC requests

2018-10-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: WIP IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 4: (7 comments) for testing, depending on that ne

[Impala-ASF-CR] IMPALA-7484: Unrecognized hints are interpreted as straight join Call to setIsStraightJoin() is outside else clause in SelectList.java causing even unrecognized hints to be interpreted

2018-10-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: Unrecognized hints are interpreted as straight_join Call to setIsStraightJoin() is outside else clause in SelectList.java causing even unrecognized hints to be interpreted as

[Impala-ASF-CR] IMPALA-7484: Unrecognized hints are interpreted as straight join

2018-10-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: Unrecognized hints are interpreted as straight_join .. Patch Set 4: (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-10-03 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11569 to look at the new patch set (#2). Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile ..

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-10-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11569 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 2: Code-Review+2 (1 comment) carry +2 http:/

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-10-03 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11569 to look at the new patch set (#3). Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile ..

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-10-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11569 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 3: Code-Review+2 carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-7484: Do not interpret unrecognized hints as straight join hints.

2018-10-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: Do not interpret unrecognized hints as straight_join hints. .. Patch Set 5: (5 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-7484: Do not interpret unrecognized hints as straight join hints.

2018-10-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: Do not interpret unrecognized hints as straight_join hints. .. Patch Set 6: (2 comments) lgtm, couple o

[Impala-ASF-CR] IMPALA-7626: Throttle catalog partial RPC requests

2018-10-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 6: (5 comments) lgtm. mostly nits/stale messages. ht

[Impala-ASF-CR] IMPALA-7626: Throttle catalog partial RPC requests

2018-10-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 7: (3 comments) lgtm. question about a possible race.

[Impala-ASF-CR] IMPALA-7484: Do not interpret unrecognized hints as straight join hints.

2018-10-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: Do not interpret unrecognized hints as straight_join hints. .. Patch Set 9: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-7626: Throttle catalog partial RPC requests

2018-10-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-7633: count user privilege isn't 0 at the end of test owner

2018-10-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11595 ) Change subject: IMPALA-7633: count_user_privilege isn't 0 at the end of test_owner .. Patch Set 1: Code-Review+2 -- To view, visit h

[Impala-ASF-CR] IMPALA-6323 Allow constant "partition by" expressions.

2018-10-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant "partition by" expressions. .. Patch Set 2: (1 comment) lgtm, just a minor style comment.

[Impala-ASF-CR] IMPALA-7671: Fix broken SHOW GRANT USER ON

2018-10-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11598 ) Change subject: IMPALA-7671: Fix broken SHOW GRANT USER ON .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11598/1//

[Impala-ASF-CR] IMPALA-7671: Fix broken SHOW GRANT USER ON

2018-10-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11598 ) Change subject: IMPALA-7671: Fix broken SHOW GRANT USER ON .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-7626: Throttle catalog partial RPC requests

2018-10-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-06 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11608 Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. IMPALA-7597: wraps retries around CatalogMetaProvider When con

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-06 Thread Vuk Ercegovac (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11608 to look at the new patch set (#2). Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider ..

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7688: Fix spurious error messages when updating owner privileges

2018-10-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11649 ) Change subject: IMPALA-7688: Fix spurious error messages when updating owner privileges .. Patch Set 6: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-7688: Fix spurious error messages when updating owner privileges

2018-10-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11649 ) Change subject: IMPALA-7688: Fix spurious error messages when updating owner privileges .. Patch Set 9: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-11 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11608 to look at the new patch set (#3). Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider ..

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 3: latest patch wraps retries higher-up at the call

[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients

2018-10-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 1: (2 comments) http://ger

[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients

2018-10-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 2: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-7701: grant option in SHOW GRANT always returns NULL from HS2 clients

2018-10-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11663 ) Change subject: IMPALA-7701: grant_option in SHOW GRANT always returns NULL from HS2 clients .. Patch Set 3: Code-Review+2 -- To vie

[Impala-ASF-CR] IMPALA-7622: adds profile metrics for incremental stats

2018-10-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11670 Change subject: IMPALA-7622: adds profile metrics for incremental stats .. IMPALA-7622: adds profile metrics for incremental stats Reap

[Impala-ASF-CR] IMPALA-7622: adds profile metrics for incremental stats

2018-10-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11670 ) Change subject: IMPALA-7622: adds profile metrics for incremental stats .. Patch Set 1: correct. -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-12 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11608 to look at the new patch set (#4). Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider ..

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 4: re-worked the tests a bit to separate out the re

[Impala-ASF-CR] IMPALA-7702: enable fetch incremental stats by default

2018-10-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11677 Change subject: IMPALA-7702: enable fetch incremental stats by default .. IMPALA-7702: enable fetch incremental stats by default Flips

[Impala-ASF-CR] IMPALA-7702: enable fetch incremental stats by default

2018-10-13 Thread Vuk Ercegovac (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11677 to look at the new patch set (#2). Change subject: IMPALA-7702: enable fetch incremental stats by default .

[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression level for incr stats

2018-10-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11685 ) Change subject: IMPALA-7708: Switch to faster deflater compression level for incr stats .. Patch Set 2: Code-Review+2 -- To view, vi

[Impala-ASF-CR] IMPALA-7702: enable fetch incremental stats by default

2018-10-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11677 ) Change subject: IMPALA-7702: enable fetch incremental stats by default .. Patch Set 2: Code-Review+2 (3 comments) carry +2 http://ge

[Impala-ASF-CR] IMPALA-7702: enable fetch incremental stats by default

2018-10-15 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11677 to look at the new patch set (#3). Change subject: IMPALA-7702: enable fetch incremental stats by default ..

[Impala-ASF-CR] IMPALA-7702: enable fetch incremental stats by default

2018-10-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11677 ) Change subject: IMPALA-7702: enable fetch incremental stats by default .. Patch Set 3: Code-Review+2 carry +2 -- To view, visit http

[Impala-ASF-CR] IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs

2018-10-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11638 ) Change subject: IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs .. Patch Set 2: (3 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-7639: Move concurrent UDF tests to a custom cluster test

2018-10-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11701 ) Change subject: IMPALA-7639: Move concurrent UDF tests to a custom cluster test .. Patch Set 1: Code-Review+2 thanks! -- To view, vi

[Impala-ASF-CR] IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs

2018-10-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11638 ) Change subject: IMPALA-7669: Gracefully handle concurrent invalidate/partial fetch RPCs .. Patch Set 3: Code-Review+2 (1 comment) ht

[Impala-ASF-CR] IMPALA-7689: Reduce per column per partition stats estimate size

2018-10-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11706 ) Change subject: IMPALA-7689: Reduce per column per partition stats estimate size .. Patch Set 1: Code-Review+2 (1 comment) looks good

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 4: (12 comments) Agreed that spreading this retry

[Impala-ASF-CR] IMPALA-7597: wraps retries around Frontend metadata operations.

2018-10-17 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11608 to look at the new patch set (#5). Change subject: IMPALA-7597: wraps retries around Frontend metadata operations.

[Impala-ASF-CR] IMPALA-7597: wraps retries around Frontend metadata operations.

2018-10-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around Frontend metadata operations. .. Patch Set 5: (5 comments) thx for the suggestions.

[Impala-ASF-CR] IMPALA-7597: wraps retries around Frontend metadata operations.

2018-10-17 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11608 to look at the new patch set (#6). Change subject: IMPALA-7597: wraps retries around Frontend metadata operations.

[Impala-ASF-CR] IMPALA-7597: wraps retries around Frontend metadata operations.

2018-10-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around Frontend metadata operations. .. Patch Set 6: (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-7597: wraps retries around Frontend metadata operations.

2018-10-17 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11608 to look at the new patch set (#7). Change subject: IMPALA-7597: wraps retries around Frontend metadata operations.

[Impala-ASF-CR] IMPALA-7721: Fix broken /catalog object web API when getting a privilege

2018-10-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11721 ) Change subject: IMPALA-7721: Fix broken /catalog_object web API when getting a privilege .. Patch Set 4: (3 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-7597: wraps retries around Frontend metadata operations.

2018-10-18 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11608 to look at the new patch set (#8). Change subject: IMPALA-7597: wraps retries around Frontend metadata operations.

[Impala-ASF-CR] IMPALA-7597: wraps retries around Frontend metadata operations.

2018-10-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around Frontend metadata operations. .. Patch Set 8: Code-Review+2 test change broke anothe

[Impala-ASF-CR] IMPALA-7717: Handle concurrent partition changes in local catalog mode

2018-10-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11732 ) Change subject: IMPALA-7717: Handle concurrent partition changes in local catalog mode .. Patch Set 3: Code-Review+2 (4 comments) lo

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name

2018-10-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11734 ) Change subject: IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name .. Patch Set 4: (7 comments) http://

[Impala-ASF-CR] IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name

2018-10-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11734 ) Change subject: IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name .. Patch Set 4: (3 comments) http://

[Impala-ASF-CR] IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name

2018-10-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11734 ) Change subject: IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name .. Patch Set 7: (2 comments) http://

[Impala-ASF-CR] IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name

2018-10-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11734 ) Change subject: IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name .. Patch Set 7: looks fine.. just one

[Impala-ASF-CR] IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name

2018-10-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11734 ) Change subject: IMPALA-7729: Fix invalidate metadata hang when there is an upper case role name .. Patch Set 8: Code-Review+2 thx for

[Impala-ASF-CR] IMPALA-7721: Fix broken /catalog object web API when getting a privilege

2018-10-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11721 ) Change subject: IMPALA-7721: Fix broken /catalog_object web API when getting a privilege .. Patch Set 6: (9 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-7721: Fix broken /catalog object web API when getting a privilege

2018-10-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11721 ) Change subject: IMPALA-7721: Fix broken /catalog_object web API when getting a privilege .. Patch Set 8: (1 comment) http://gerrit.c

[Impala-ASF-CR] IMPALA-7721: Fix broken /catalog object web API when getting a privilege

2018-10-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11721 ) Change subject: IMPALA-7721: Fix broken /catalog_object web API when getting a privilege .. Patch Set 10: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7699: Fix spilling test run with hdfs erasure coding turned on

2018-10-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11740 ) Change subject: IMPALA-7699: Fix spilling test run with hdfs erasure coding turned on .. Patch Set 1: Code-Review+2 -- To view, visi

[Impala-ASF-CR] IMPALA-7697: Fix flakiness in test resource limits

2018-10-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11741 ) Change subject: IMPALA-7697: Fix flakiness in test_resource_limits .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 4: (3 comments) main question from my end is to co

[Impala-ASF-CR] IMPALA-5004: Switch to sorting node for large TopN queries

2018-10-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11698 ) Change subject: IMPALA-5004: Switch to sorting node for large TopN queries .. Patch Set 5: Code-Review+1 (2 comments) one question ab

[Impala-ASF-CR] IMPALA-6323 Allow constant analytic window expressions.

2018-10-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11556 ) Change subject: IMPALA-6323 Allow constant analytic window expressions. .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException

2018-10-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 3: (1 comment) http://

[Impala-ASF-CR] IMPALA-7710: test owner privileges with grant failed with AuthorizationException

2018-10-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11786 ) Change subject: IMPALA-7710: test_owner_privileges_with_grant failed with AuthorizationException .. Patch Set 4: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata

2018-10-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11794 ) Change subject: IMPALA-7760: Privilege version inconsistency causes a hang when running invalidate metadata .. Patch Set 2: Code-Revie

[Impala-ASF-CR] IMPALA-7742: Stores the Sentry user names in a case sensitive way

2018-10-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11762 ) Change subject: IMPALA-7742: Stores the Sentry user names in a case sensitive way .. Patch Set 1: (5 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-7742: Stores the Sentry user names in a case sensitive way

2018-10-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11762 ) Change subject: IMPALA-7742: Stores the Sentry user names in a case sensitive way .. Patch Set 2: (2 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-7742: Store the Sentry user names in a case sensitive way

2018-10-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11762 ) Change subject: IMPALA-7742: Store the Sentry user names in a case sensitive way .. Patch Set 4: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-5031: memcpy cannot take null arguments

2018-10-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11812 ) Change subject: IMPALA-5031: memcpy cannot take null arguments .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11812/

[Impala-ASF-CR] IMPALA-7655: Rewrite if, isnull, coalesce to use CASE

2018-10-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11760 ) Change subject: IMPALA-7655: Rewrite if, isnull, coalesce to use CASE .. Patch Set 9: (10 comments) still reviewing the tests. http:

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

2018-10-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 ) Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-7614: [DOCS] Part 2: Document the New Invalidate option

2018-10-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11839 ) Change subject: IMPALA-7614: [DOCS] Part 2: Document the New Invalidate option .. Patch Set 1: Code-Review+2 -- To view, visit http:/

<    1   2   3   4   5   6   7   8   9   >