[Impala-ASF-CR] IMPALA-7484: Do not interpret unrecognized hints as straight join hints.

2018-10-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 ) Change subject: IMPALA-7484: Do not interpret unrecognized hints as straight_join hints. .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-7626: Throttle catalog partial RPC requests

2018-10-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 6: (5 comments) lgtm. mostly nits/stale messages.

[Impala-ASF-CR] IMPALA-7626: Throttle catalog partial RPC requests

2018-10-05 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11561 ) Change subject: IMPALA-7626: Throttle catalog partial RPC requests .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-07 Thread Vuk Ercegovac (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11608 to look at the new patch set (#2). Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11608 Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. IMPALA-7597: wraps retries around CatalogMetaProvider When

[Impala-ASF-CR] IMPALA-7597: wraps retries around CatalogMetaProvider

2018-10-09 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 ) Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7532: Add catalogd client backoff time into impalad CLI options

2018-10-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11543 ) Change subject: IMPALA-7532: Add catalogd client backoff time into impalad CLI options .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7532: Add catalogd client backoff time into impalad CLI options

2018-10-01 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11543 ) Change subject: IMPALA-7532: Add catalogd client backoff time into impalad CLI options .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 ) Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 8: Code-Review+2 carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#8) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile ..

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#7) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile ..

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 6: (9 comments)

[Impala-ASF-CR] IMPALA-7498: Fix log spew from LocalCatalog startup

2018-09-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11472 ) Change subject: IMPALA-7498: Fix log spew from LocalCatalog startup .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#9) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile ..

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 9: Code-Review+2 update stale test, carry +2

[Impala-ASF-CR] IMPALA-110: Support for multiple DISTINCT

2018-09-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 ) Change subject: IMPALA-110: Support for multiple DISTINCT .. Patch Set 12: Code-Review+1 (1 comment) +2 for fe part. lgtm for be

[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator

2018-09-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 ) Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7622: adds profile metrics when fetching incremental stats

2018-09-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11534 Change subject: IMPALA-7622: adds profile metrics when fetching incremental stats .. IMPALA-7622: adds profile metrics when fetching

[Impala-ASF-CR] IMPALA-6202. mod and % should be equivalent.

2018-09-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % should be equivalent. .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator

2018-09-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 ) Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7531: Daemon level catalog cache metrics

2018-09-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11511 ) Change subject: IMPALA-7531: Daemon level catalog cache metrics .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator

2018-09-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 ) Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-7531: Daemon level catalog cache metrics

2018-09-25 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11511 ) Change subject: IMPALA-7531: Daemon level catalog cache metrics .. Patch Set 3: Code-Review+2 (1 comment) comment about sync'ing the

[Impala-ASF-CR] IMPALA-7591: Use short name for setting owner

2018-09-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11469 ) Change subject: IMPALA-7591: Use short name for setting owner .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7591: Use short name for setting owner

2018-09-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11469 ) Change subject: IMPALA-7591: Use short name for setting owner .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-7498: Fix log spew from LocalCatalog startup

2018-09-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11472 ) Change subject: IMPALA-7498: Fix log spew from LocalCatalog startup .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7599: make the number of local cache retries configurable

2018-09-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11539 ) Change subject: IMPALA-7599: make the number of local cache retries configurable .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-7599: make the number of local cache retries configurable

2018-09-28 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11539 to look at the new patch set (#3). Change subject: IMPALA-7599: make the number of local cache retries configurable

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 35: (9 comments) thx for the

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 36: (4 comments)

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 37: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-12 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 37: (2 comments)

[Impala-ASF-CR] IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

2018-09-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#2) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11403 ) Change subject: IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

[Impala-ASF-CR] IMPALA-6568 add missing Query Compilation section to profiles.

2018-09-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 ) Change subject: IMPALA-6568 add missing Query Compilation section to profiles. .. Patch Set 5: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-7448: Invalidate recently unused tables from catalogd

2018-09-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11224 ) Change subject: IMPALA-7448: Invalidate recently unused tables from catalogd .. Patch Set 8: (1 comment) one more clarification.

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

2018-09-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11403 ) Change subject: IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

2018-09-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#4) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11403 ) Change subject: IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

[Impala-ASF-CR] IMPALA-7580: Increase timeout int test automatic invalidation

2018-09-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11453 ) Change subject: IMPALA-7580: Increase timeout int test_automatic_invalidation .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

2018-09-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#5) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11403 ) Change subject: IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

[Impala-ASF-CR] IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

2018-09-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11403 ) Change subject: IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata .. Patch Set 5: Code-Review+2 carrying

[Impala-ASF-CR] IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata

2018-09-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11403 ) Change subject: IMPALA-7530, IMPALA-7509. Re-plan queries if they fetch inconsistent metadata .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 40: (5 comments)

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 41: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 42: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#5) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP IMPALA-7527: add fetch-from-catalogd cache info to profile .. WIP

[Impala-ASF-CR] WIP IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#4) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP IMPALA-7527: add fetch-from-catalogd cache info to profile .. WIP

[Impala-ASF-CR] WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP: IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 3: (2 comments)

[Impala-ASF-CR] WIP IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: WIP IMPALA-7527: add fetch-from-catalogd cache info to profile .. Patch Set 5: (4 comments) added e2e test,

[Impala-ASF-CR] IMPALA-7527: add fetch-from-catalogd cache info to profile

2018-09-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#6) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11388 ) Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile ..

[Impala-ASF-CR] IMPALA-7348: fix race in KuduUtil.getKuduClient

2018-09-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11423 ) Change subject: IMPALA-7348: fix race in KuduUtil.getKuduClient .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7579: use the generic filesystem client to delete and create files in test query profile contains all events.

2018-09-18 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11461 ) Change subject: IMPALA-7579: use the generic filesystem_client to delete and create files in test_query_profile_contains_all_events. ..

[Impala-ASF-CR] IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER

2018-09-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 ) Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER .. Patch Set 32: (6 comments)

<    3   4   5   6   7   8