Alex Behm has posted comments on this change.
Change subject: IMPALA-3812: Fix error message for unsupported types
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4859
To unsubscribe, visit http
Alex Behm has posted comments on this change.
Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5040
To unsubscribe, visit http://g
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5050
Change subject: IMPALA-4470: Avoid creating a NumericLiteral from NaN/infinity.
..
IMPALA-4470: Avoid creating a NumericLiteral from NaN/infi
Alex Behm has posted comments on this change.
Change subject: IMPALA-4000: Disable Sentry column-level privileges for Kudu
..
Patch Set 1:
Sorry this was my mistake. I did not get around to updating the JIRA to our
latest thin
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4000: Disable Sentry column-level privileges for Kudu
..
Patch Set 1:
I don't think disabling column-level privileges is the desired behavior. Can
Michael Brown has posted comments on this change.
Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5040
To unsubscribe, visit http
Jim Apple has submitted this change and it was merged.
Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v.
alignof
..
IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v. alignof
This was t
Jim Apple has posted comments on this change.
Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v.
alignof
..
Patch Set 3: Verified+1
Ran all core tests out-of-band
--
To view, visit http://gerrit.c
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5049
Change subject: IMPALA-4452: Always call AggFnEvaluator::Open() before
AggFnEvaluator::Init()
..
IMPALA-4452: Always call AggFnEvaluator::O
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4000: Disable Sentry column-level privileges for Kudu
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5047/1/fe/src/main/java/org/apa
Taras Bobrovytsky has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5047
Change subject: IMPALA-4000: Disable Sentry column-level privileges for Kudu
..
IMPALA-4000: Disable Sentry column-level privileges f
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-3812: Fix error message for unsupported types
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4859/1/fe/src/main/java/org/apache/imp
Taras Bobrovytsky has uploaded a new patch set (#2).
Change subject: IMPALA-3812: Fix error message for unsupported types
..
IMPALA-3812: Fix error message for unsupported types
Before this patch an unclear error message was ret
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3882: Simplify some query exec state locking
..
Patch Set 4:
(9 comments)
Here's how I think about the lock safety (sorry, long, but hopefully helps to
Henry Robinson has uploaded a new patch set (#5).
Change subject: IMPALA-3882: Simplify some query exec state locking
..
IMPALA-3882: Simplify some query exec state locking
query_exec_state_map_lock_ is implicated in many deadlo
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v.
alignof
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5022
To unsu
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4465: Don't hold process wide lock while serializing
Runtime Profile in GetRuntimeProfileStr()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4465: Don't hold process wide lock while serializing
Runtime Profile in GetRuntimeProfileStr()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:80
Sailesh Mukil has uploaded a new patch set (#2).
Change subject: IMPALA-4465: Don't hold process wide lock while serializing
Runtime Profile in GetRuntimeProfileStr()
..
IMPALA-4465: Don't hold process wide lock while serializin
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4461: Make sure data gets loaded for wide hbase tables.
..
IMPALA-4461: Make sure data gets loaded for wide hbase tables.
Ths patch reverts a
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4461: Make sure data gets loaded for wide hbase tables.
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5033
To unsubscri
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5040/1/tests/conftest.py
File tests/c
Thomas Tauber-Marshall has uploaded a new patch set (#2).
Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
..
IMPALA-4454: test_kudu.TestShowCreateTable flaky
The cause of the flakiness is Kudu CREATE TABLE opera
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4363: Add Parquet timestamp validation
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4968/4/tests/query_test/test_scanners.py
File
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4363: Add Parquet timestamp validation
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4968/4/be/src/exec/parquet-column-readers.cc
F
Taras Bobrovytsky has posted comments on this change.
Change subject: Preview: IMPALA-4363: Add timestamp validation
..
Patch Set 2:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/4968/2/be/src/exec/parquet-column-readers.cc
Taras Bobrovytsky has uploaded a new patch set (#4).
Change subject: IMPALA-4363: Add Parquet timestamp validation
..
IMPALA-4363: Add Parquet timestamp validation
Before this patch, we would simply read the INT96 Parquet timest
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4953
to look at the new patch set (#8).
Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage
..
IMPALA-4466:
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4953
to look at the new patch set (#7).
Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage
..
IMPALA-4466:
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage
..
Patch Set 7:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4953/6/testdata/workloads/functional-qu
Dimitris Tsirogiannis has uploaded a new patch set (#4).
Change subject: IMPALA-3726: Add support for Kudu-specific column options
..
IMPALA-3726: Add support for Kudu-specific column options
This commit adds support for Kudu-sp
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-3726: Add support for Kudu-specific column options
..
Patch Set 4:
Changes the parser to use the DEFAULT keyword without breaking compatibility
(
Michael Brown has posted comments on this change.
Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5040/1/tests/conftest.py
File tests/conftest.p
Thomas Tauber-Marshall has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5040
Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky
..
IMPALA-4454: test_kudu.TestShowCreateTable flaky
The cause
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4456: Change query_exec_state_lock_ to a reader-writer
lock
..
Patch Set 3:
Once concern I have is about fairness. It's pretty critical that writers don
Jim Apple has posted comments on this change.
Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v.
alignof
..
Patch Set 3:
> Just want to make sure I understand the bug that you've fixed in
> this la
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v.
alignof
..
Patch Set 3: Code-Review+1
Just want to make sure I understand the bug that you've fi
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4867
to look at the new patch set (#11).
Change subject: IMPALA-3552: Make incremental stats max serialized size
configurable
..
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-3552: Make incremental stats max serialized size
configurable
..
Patch Set 10:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4867/10//COMMIT_M
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage
..
Patch Set 6:
(5 comments)
Thanks, a few small things and I'm gonna follow up with you about validation.
http
Taras Bobrovytsky has uploaded a new patch set (#3).
Change subject: Preview: IMPALA-4363: Add timestamp validation
..
Preview: IMPALA-4363: Add timestamp validation
Change-Id: I9988449aa0dc0f39fabb91ce6cce0dd8a06e8bcf
---
M be/
Alex Behm has posted comments on this change.
Change subject: IMPALA-3552: Make incremental stats max serialized size
configurable
..
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4867/10/common/thrift/Backend
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4456: Change query_exec_state_lock_ to a reader-writer
lock
..
Patch Set 3:
(4 comments)
Did you consider boost::scoped_mutex?
http://gerrit.cloudera.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v.
alignof
..
Patch Set 3:
Data load failed with
#7 0x01853932 in impala::MemPool::TryAll
Hello Alex Behm, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5022
to look at the new patch set (#3).
Change subject: IMPALA-4455: MemPoolTest.TryAllocateAligned failure: sizeof v.
alignof
.
Thomas Tauber-Marshall has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5036
Change subject: IMPALA-4466: Improve Kudu UPDATE test coverage
..
IMPALA-4466: Improve Kudu UPDATE test coverage
Change-Id: Ib6
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4953
to look at the new patch set (#6).
Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage
..
IMPALA-4466:
Henry Robinson has posted comments on this change.
Change subject: IMPALA-3552: Make incremental stats max serialized size
configurable
..
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4867/10/common/thrift/Ba
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4465: Don't hold process wide lock while serializing
Runtime Profile in GetRuntimeProfileStr()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5035
Change subject: IMPALA-4465: Don't hold process wide lock while serializing
Runtime Profile in GetRuntimeProfileStr()
..
IMPALA-4465: Do
Michael Brown has uploaded a new patch set (#2).
Change subject: IMPALA-4450: qgen: use string concatenation operator for
postgres queries
..
IMPALA-4450: qgen: use string concatenation operator for postgres queries
The random
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5034
Change subject: IMPALA-4450: qgen: use string concatenation operator for
postgres queries
..
IMPALA-4450: qgen: use string concatenation
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3552: Make incremental stats max serialized size
configurable
..
Patch Set 10: Code-Review+2
(2 comments)
Please hold off on committing until the blocker br
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4461: Make sure data gets loaded for wide hbase tables.
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5033
To unsubscribe,
David Knupp has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5033
Change subject: IMPALA-4461: Make sure data gets loaded for wide hbase tables.
..
IMPALA-4461: Make sure data gets loaded for wide hbase ta
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4953
to look at the new patch set (#5).
Change subject: Improve Kudu UPSERT test coverage
..
Improve Kudu UPSERT test
Thomas Tauber-Marshall has posted comments on this change.
Change subject: Improve Kudu UPSERT test coverage
..
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4953/4//COMMIT_MSG
Commit Message:
PS4, Line 9: Thi
Donghui Xu has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow.
..
Patch Set 7:
Sorry. I'm not familiar with the use of git-clang-format tools.:)
I
Donghui Xu has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow.
..
Patch Set 7:
(6 comments)
Sorry. I'm not familiar with the use of git-clang-forma
Donghui Xu has uploaded a new patch set (#7).
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow.
..
IMPALA-4431: Add audit event log control mechanism to prevent disk
overflow.
There
Lars Volker has posted comments on this change.
Change subject: IMPALA-4431: Add audit event log control mechanism to prevent
disk overflow.
..
Patch Set 6:
(4 comments)
There are still some minor formatting issues left. Hav
61 matches
Mail list logo
