[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 7: (18 comments) http://gerrit.cloudera.org:8080/#/c/4418/7/be/src/runtime/coordinator.cc File

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ.

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4960

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ.

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ. .. IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ.

[Impala-ASF-CR] IMPALA-4585: Replace file paths with HDFS FILENAME in expected exceptions

2016-12-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4585: Replace file paths with __HDFS_FILENAME__ in expected exceptions .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4578: Pick up bound predicates for Kudu scan nodes.

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4578: Pick up bound predicates for Kudu scan nodes. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5365 To unsubscribe,

[Impala-ASF-CR] IMPALA-4566: Kudu client glog contention can cause timeouts

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4566: Kudu client glog contention can cause timeouts .. Patch Set 2: Code-Review+2 I think this addressed the issue, thanks! -- To view, visit

[Impala-ASF-CR] IMPALA-4585: Replace file paths with HDFS FILENAME in expected exceptions

2016-12-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4585: Replace file paths with __HDFS_FILENAME__ in expected exceptions .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5372

[Impala-ASF-CR] IMPALA-4585: Replace file paths with HDFS FILENAME in expected exceptions

2016-12-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4585: Replace file paths with __HDFS_FILENAME__ in expected exceptions .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5372/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. Patch Set 5: Code-Review+2 rebase and resolve conflict -- To view, visit

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-05 Thread Alex Behm (Code Review)
Hello Impala Public Jenkins, Internal Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5324 to look at the new patch set (#5). Change subject: IMPALA-4574: Do not treat UUID() like a constant expr.

[Impala-ASF-CR] IMPALA-4585: Replace file paths with HDFS FILENAME in expected exceptions

2016-12-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/5372 Change subject: IMPALA-4585: Replace file paths with __HDFS_FILENAME__ in expected exceptions .. IMPALA-4585: Replace file paths

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5317 to look at the new patch set (#5). Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. Patch Set 5: Code-Review+2 Fix test. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert,

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert,

[Impala-ASF-CR] IMPALA-4467: Add support for DML statements in stress test

2016-12-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4467: Add support for DML statements in stress test .. IMPALA-4467: Add support for DML statements in stress test - Add support for insert, upsert,

[Impala-ASF-CR] Preview: IMPALA-4467: Add support for CRUD operations in stress test

2016-12-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Preview: IMPALA-4467: Add support for CRUD operations in stress test .. Patch Set 1: (23 comments)

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5364 To

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. IMPALA-4584: Make alter table operations on Kudu tables synchronous This

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5324 To unsubscribe,

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4571: Push IN predicates to Kudu .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5316 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4571: Push IN predicates to Kudu .. IMPALA-4571: Push IN predicates to Kudu Fixes the KuduScanNode to convert InPredicates to KuduPredicates

[Impala-ASF-CR] IMPALA-4477: Bump Kudu version to latest master (60aa54e)

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5369 Change subject: IMPALA-4477: Bump Kudu version to latest master (60aa54e) .. IMPALA-4477: Bump Kudu version to latest master (60aa54e)

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ.

2016-12-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ. .. Patch Set 4: Code-Review+2 rebase -- To view, visit

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ.

2016-12-05 Thread Alex Behm (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4960 to look at the new patch set (#4). Change subject: IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ.

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5324 To

[Impala-ASF-CR] IMPALA-4467: Add support for CRUD operations in stress test

2016-12-05 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-4467: Add support for CRUD operations in stress test .. IMPALA-4467: Add support for CRUD operations in stress test - Added support for upsert and

[Impala-ASF-CR] IMPALA-4578: Pick up bound predicates for Kudu scan nodes.

2016-12-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4578: Pick up bound predicates for Kudu scan nodes. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5365 To unsubscribe,

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ.

2016-12-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4578: Pick up bound predicates for Kudu scan nodes.

2016-12-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4578: Pick up bound predicates for Kudu scan nodes. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5365 To

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Additional functional testing for default values on Kudu tables .. Additional functional testing for default values on Kudu tables This commit

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 7: rebase past the recent pfe fixes -- To view, visit http://gerrit.cloudera.org:8080/4418

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Additional functional testing for default values on Kudu tables .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5337 To

[Impala-ASF-CR] IMPALA-2925: Mark test alloc update as xfail.

2016-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2925: Mark test_alloc_update as xfail. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5366 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#7). Change subject: IMPALA-4014: Introduce query-wide execution state. .. IMPALA-4014: Introduce query-wide execution state. This introduces a global structure to coordinate

[Impala-ASF-CR] IMPALA-2925: Mark test alloc update as xfail.

2016-12-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2925: Mark test_alloc_update as xfail. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5366/1/tests/custom_cluster/test_alloc_fail.py File

[Impala-ASF-CR] IMPALA-2925: Mark test alloc update as xfail.

2016-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2925: Mark test_alloc_update as xfail. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5366/1/tests/custom_cluster/test_alloc_fail.py

[Impala-ASF-CR] Avoid std::function when possible.

2016-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Avoid std::function when possible. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5230 To unsubscribe, visit

[Impala-ASF-CR] Avoid std::function when possible.

2016-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Avoid std::function when possible. .. Avoid std::function when possible. std::function does some tricky stuff under the hood, and can in fact

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. Patch Set 4: Code-Review+2 fix test section header -- To view, visit

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-05 Thread Alex Behm (Code Review)
Hello Internal Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5324 to look at the new patch set (#4). Change subject: IMPALA-4574: Do not treat UUID() like a constant expr.

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. Patch Set 3: Code-Review+2 Carry Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5364 to look at the new patch set (#3). Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. IMPALA-4584: Make alter table operations on Kudu tables synchronous This commit

[Impala-ASF-CR] IMPALA-2925: Mark test alloc update as xfail.

2016-12-05 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/5366 Change subject: IMPALA-2925: Mark test_alloc_update as xfail. .. IMPALA-2925: Mark test_alloc_update as xfail. test_alloc_update.py is

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4571: Push IN predicates to Kudu .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Matthew Jacobs (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5316 to look at the new patch set (#5). Change subject: IMPALA-4571: Push IN predicates to Kudu .. IMPALA-4571: Push IN

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4578: Pick up bound predicates for Kudu scan nodes.

2016-12-05 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5365 Change subject: IMPALA-4578: Pick up bound predicates for Kudu scan nodes. .. IMPALA-4578: Pick up bound predicates for Kudu scan nodes.

[Impala-ASF-CR] IMPALA-4584: Make alter table operations on Kudu tables synchronous

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5364 Change subject: IMPALA-4584: Make alter table operations on Kudu tables synchronous .. IMPALA-4584: Make alter table operations

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. Patch Set 4: Code-Review+2 Fix error in data loading caused by accidentally

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5317 to look at the new patch set (#4). Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4571: Push IN predicates to Kudu .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#4). Change subject: IMPALA-4571: Push IN predicates to Kudu .. IMPALA-4571: Push IN predicates to Kudu Fixes the KuduScanNode to convert InPredicates to KuduPredicates and push them

[Impala-ASF-CR] IMPALA-4571: Push IN predicates to Kudu

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4571: Push IN predicates to Kudu .. Patch Set 3: (6 comments)

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 7: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5251 To

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/77/ --

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-05 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5324 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/76/ -- To

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-05 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 6: Code-Review+2 No, not necessary as mentioned early. Sorry, thought Marcel had +2 this one.

[Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp

2016-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp .. Patch Set 6: Any more comments? I don't think there were any more to address here, unless we want

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-05 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Additional functional testing for default values on Kudu tables .. Patch Set 2: Build started:

[Impala-ASF-CR] Fix typo in DDL statement for loading Kudu table in stress test

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has submitted this change and it was merged. Change subject: Fix typo in DDL statement for loading Kudu table in stress test .. Fix typo in DDL statement for loading Kudu table in stress test Change-Id:

[Impala-ASF-CR] Fix typo in DDL statement for loading Kudu table in stress test

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Fix typo in DDL statement for loading Kudu table in stress test .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5158 To

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Additional functional testing for default values on Kudu tables .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5337 To

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-12-05 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/4715/4//COMMIT_MSG Commit Message:

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: Additional functional testing for default values on Kudu tables .. Additional functional testing for default values on Kudu tables This commit also fixes

[Impala-ASF-CR] Additional functional testing for default values on Kudu tables

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: Additional functional testing for default values on Kudu tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2057: Better error message for incorrect avro decimal column declaration

2016-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2057: Better error message for incorrect avro decimal column declaration .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE

2016-12-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4561: Replace DISTRIBUTE BY with PARTITION BY in CREATE TABLE .. Patch Set 3: Code-Review+2 Rebase. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.

2016-12-05 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4574: Do not treat UUID() like a constant expr. .. Patch Set 2: Code-Review+2 (1 comment) The fix seems safe and targeted for the specific problem. We

[Impala-ASF-CR] IMPALA-3125: Fix assignment of equality predicates from an outer-join On-clause.

2016-12-05 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3125: Fix assignment of equality predicates from an outer-join On-clause. .. IMPALA-3125: Fix assignment of equality predicates from an

[Impala-ASF-CR] IMPALA-3126: Conservative assignment of inner-join On-clause predicates.

2016-12-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3126: Conservative assignment of inner-join On-clause predicates. .. Patch Set 2: (3 comments)

[Impala-ASF-CR] Avoid std::function when possible.

2016-12-05 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: Avoid std::function when possible. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5230 To unsubscribe, visit