[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 4: > > > Perf results from running on the 10 node cluster: > > > > > > For smaller queri

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. Patch Set 4: Code-Review+1 lgtm pending test run passes thanks! -- To view, visi

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6627/3/be/src/common

[Impala-ASF-CR] IMPALA-2800: make memory maintenance less aggressive

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2800: make memory maintenance less aggressive .. Patch Set 4: Code-Review+1 Thanks for doing this -- To view, visit http://gerrit.cloudera.org:8080/662

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 1: (1 comment) lets wait to hear from JD/Dan about the right link http://gerrit.cloudera.org:80

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6634/1/docs/shared/impala_common.xml File doc

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 1: Code-Review+1 (1 comment) Thanks for your work on this Thomas, I think this looks like a reasonable app

[native-toolchain-CR] IMPALA-5187: Bump breakpad version for Breakpad bug #681

2017-04-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5187: Bump breakpad version for Breakpad bug #681 .. Patch Set 1: why don't we need 0002-Increase-maximum-number-of-threads-for-minidump_stac.patch anym

[Impala-ASF-CR] IMPALA-2800: make memory maintenance less aggressive

2017-04-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2800: make memory maintenance less aggressive .. Patch Set 3: (2 comments) how did you test this? http://gerrit.cloudera.org:8080/#/c/6626/3//COMMIT_MS

[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts

2017-04-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts .. Patch Set 1: Yeah, it's a good question. I don't know and unfortunately I think it's more general

[Impala-ASF-CR] IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts

2017-04-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6616 Change subject: IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts .. IMPALA-5079: Flaky Kudu tests; fix HS2 connection timeouts

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 3: (11 comments) http://gerrit.cloudera.org:8080/#/c/6559/3/be/src/exec/kudu-util.cc File

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP Adds Impala support for TIMESTAMP t

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6526/2/be/src/exec/kudu-table-si

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools scm

2017-04-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools_scm .. Patch Set 1: > > unless we feel we should pin the package to 1.15.0 anyways > > We could pin to 1.15.4 as our k

[Impala-ASF-CR] IMPALA-5189: Pin version of setuptools scm

2017-04-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5189: Pin version of setuptools_scm .. Patch Set 1: Thanks, Lars. How did you test this? -- To view, visit http://gerrit.cloudera.org:8080/6599 To uns

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 2: > > ping @dan > > Are you waiting for something from me? I thought you were wai

[Impala-ASF-CR] IMPALA-5183: increase write wait timeout in BufferedBlockMgrTest

2017-04-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5183: increase write wait timeout in BufferedBlockMgrTest .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6595 To unsubs

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 2: ping @dan -- To view, visit http://gerrit.cloudera.org:8080/6526 To unsubscribe,

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

2017-04-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Impala and Hive have slightly different SQL they accept. .. Patch Set 1: Code-Review+2 Yes, that works for me. Thanks! -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-04-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe, v

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-04-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 6: > Re: gflags - agree we need to look hard at a solution. Do you think > we could do th

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

2017-04-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Impala and Hive have slightly different SQL they accept. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6567/1/index.html File index.html: PS

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-04-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 5: > (5 comments) > > > 1) Brining in all the gflags is maybe concerning. will any > c

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6559/2/be/src/exprs/kudu-partition-exp

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6559/2/be/src/exprs/kudu-partition-exp

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 2: (21 comments) http://gerrit.cloudera.org:8080/#/c/6559/2/be/src/exprs/kudu-partition-e

[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables

2017-04-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables .. IMPALA-5154: Handle 'unpartitioned' Kudu tables The catalogd was hanging trying to load an unpartitioned Kudu t

[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables

2017-04-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6560/1/tests/query_test/test_kudu.py File test

[Impala-ASF-CR] IMPALA-5154: Handle 'unpartitioned' Kudu tables

2017-04-05 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6560 Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables .. IMPALA-5154: Handle 'unpartitioned' Kudu tables The catalogd was han

[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client

2017-04-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/6549 To unsubscrib

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP Adds Impala support for TIMESTAMP t

[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client

2017-04-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6549 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client

2017-04-04 Thread Matthew Jacobs (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6549 to look at the new patch set (#2). Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client .. IMPALA

[Impala-ASF-CR] IMPALA-5156: Drop VLOG level passed into Kudu client

2017-04-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6549 Change subject: IMPALA-5156: Drop VLOG level passed into Kudu client .. IMPALA-5156: Drop VLOG level passed into Kudu client The Kudu l

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 1: (2 comments) > Did you mean to update the patch? Yeah, but I need to iron out a

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6526/1/be/src/runtime/timestamp-v

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 1: (7 comments) Thanks for taking a look, Lars. This was meant to be a WIP because I

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-04-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: Valencia, before we continue the discussion of the work on this toolchain patch much further, I thin

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-04-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6526/1/be/src/runtime/timestamp-v

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-03-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. Patch Set 1: Draft review -- To view, visit http://gerrit.cloudera.org:8080/6526 To unsubscri

[Impala-ASF-CR] IMPALA-5137: Support Kudu UNIXTIME MICROS as Impala TIMESTAMP

2017-03-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6526 Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP .. IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIM

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. IMPALA-5137: pt1, Refactor TimestampValue constructors In preparation for supporting Kudu TIMESTAMPs, so

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/6510/1/be/src/exec/data-source-scan-no

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 5: (1 comment) Some of the same questions/comments apply from the util/ review http://gerri

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 5: (5 comments) 1) Brining in all the gflags is maybe concerning. will any conflict with

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Import kudu util library from kudu@a1bfd7b

2017-03-30 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Import kudu_util library from kudu@a1bfd7b .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5714 To unsubsc

[native-toolchain-CR] Bump Kudu version to 16dd6e4 and remove historical versions

2017-03-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: Bump Kudu version to 16dd6e4 and remove historical versions .. Bump Kudu version to 16dd6e4 and remove historical versions The historical versions were

[Impala-ASF-CR] IMPALA-4226, IMPALA-4227: Bump Breakpad version

2017-03-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6513 Change subject: IMPALA-4226, IMPALA-4227: Bump Breakpad version .. IMPALA-4226, IMPALA-4227: Bump Breakpad version Change-Id: I89cbcc3f

[native-toolchain-CR] Bump Kudu version to 16dd6e4 and remove historical versions

2017-03-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu version to 16dd6e4 and remove historical versions .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6509 To unsubscribe, v

[Impala-ASF-CR] IMPALA-5137: pt1, Refactor TimestampValue constructors

2017-03-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6510 Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors .. IMPALA-5137: pt1, Refactor TimestampValue constructors In pre

[native-toolchain-CR] Bump Kudu version to 16dd6e4 and remove historical versions

2017-03-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6509 Change subject: Bump Kudu version to 16dd6e4 and remove historical versions .. Bump Kudu version to 16dd6e4 and remove historical versio

[native-toolchain-CR] Ported native-toolchain to work on ppc64le

2017-03-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6468/1/buildall.sh File buildall.sh: PS1, Line 270

[Impala-ASF-CR] IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu

2017-03-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu .. Patch Set 2: Code-Review+2 fixed the broken test case -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu

2017-03-24 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6465 to look at the new patch set (#2). Change subject: IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu

[Impala-ASF-CR] IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu

2017-03-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6465 Change subject: IMPALA-5111: Fix check when creating NOT NULL PK col in Kudu .. IMPALA-5111: Fix check when creating NOT NULL PK col in

[Impala-ASF-CR] IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu

2017-03-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4859: Push down IS NULL / IS NOT NULL to Kudu .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5958/3/testdata/workloads/fu

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6453 To unsubscribe, visit htt

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-22 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, David Knupp, Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6453 to look at the new patch set (#2). Change subject: IMPALA-5079: Bump timeout for TestKuduOperations ...

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has abandoned this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Abandoned dupe bad commit msg -- To view, visit http://gerrit.cloudera.org:8080/6458 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6458 Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. IMPALA-5079: Bump timeout for TestKuduOperations Tests seem to be t

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. Patch Set 1: failure seems unrelated to the change, it looks like https://jira.cloudera.com/browse/CDH-5179

[Impala-ASF-CR] Bump Kudu client version to 16dd6e4

2017-03-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Bump Kudu client version to 16dd6e4 .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/6423 To unsubscribe, visit http://g

[Impala-ASF-CR] Bump Kudu client version to 16dd6e4

2017-03-21 Thread Matthew Jacobs (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6423 to look at the new patch set (#2). Change subject: Bump Kudu client version to 16dd6e4 .. Bump Kudu client version

[Impala-ASF-CR] IMPALA-5079: Bump timeout for TestKuduOperations

2017-03-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6453 Change subject: IMPALA-5079: Bump timeout for TestKuduOperations .. IMPALA-5079: Bump timeout for TestKuduOperations Tests seem to be t

[Impala-ASF-CR] Bump Kudu client version to 16dd6e4

2017-03-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/6423 Change subject: Bump Kudu client version to 16dd6e4 .. Bump Kudu client version to 16dd6e4 Also sets the Java client version to 1.4.0-c

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/6261/7/fe/src/main

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-sender.cc File b

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6261/6/tests/query_test/test_kud

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-16 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/6037/8/be/src/runtime/data-stream-partitioner.h F

[Impala-ASF-CR] IMPALA-4996: Single-threaded KuduScanNode

2017-03-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4996: Single-threaded KuduScanNode .. Patch Set 3: (1 comment) haven't had a chance to look at most of the new code yet, but one quick comment before I

[Impala-ASF-CR] Remove some dead code.

2017-03-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Remove some dead code. .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6377/1//COMMIT_MSG Commit Message: Line 7: Remove some de

[Impala-ASF-CR] IMPALA-4631: avoid DCHECK in PlanFragementExecutor::Close().

2017-03-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4631: avoid DCHECK in PlanFragementExecutor::Close(). .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6375/1/be/src/runtim

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6372 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/6261/6/fe/src/main/java/org/apa

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6372/2/source/glog/glog-0.3.4-patches/0

[native-toolchain-CR] IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2)

2017-03-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5057: Upgrade gflags (2.2.0) and glog (0.3.4-p2) .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6372/2/source/gflags/build.sh File sou

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/6037/7/be/src/runtime/data-stream-partitioner.cc

[Impala-ASF-CR] IMPALA-4996: Single-threaded KuduScanNode

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4996: Single-threaded KuduScanNode .. Patch Set 2: (5 comments) I started reviewing this and realized there are maybe some more changes you're still wo

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6344/1/be/src/schedul

[Impala-ASF-CR] IMPALA-4041: Limit catalog and admission control updates to coordinators

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6344/1/be/src/schedul

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: > Even better - because the partition function definition would be a > template (and therefore ava

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6037/6/be/src/runtime/data-stream-sender.cc File b

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-10 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6037/6/be/src/runtime/data-stream-sender.cc File

[Impala-ASF-CR] IMPALA-3742: partitions DMLs for Kudu tables

2017-03-09 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: partitions DMLs for Kudu tables .. Patch Set 6: (13 comments) http://gerrit.cloudera.org:8080/#/c/6037/6/be/src/runtime/data-stream-sender.cc File

[native-toolchain-CR](cdh5.11.0) IMPALA-5025: upgrade to binutils 2.26.1

2017-03-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5025: upgrade to binutils 2.26.1 .. Patch Set 1: Code-Review+2 Have you tested this builds correctly on this branch (as opposed to master) ? -- To view

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/6025/13/be/src/exprs/aggregate-functions-ir.

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6261/1/fe/src/main/java/org/apa

[Impala-ASF-CR] IMPALA-5033: infra: update Hadoop ecosystem components

2017-03-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5033: infra: update Hadoop ecosystem components .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6268 To unsubscribe, vis

[native-toolchain-CR] Add historical version for breakpad

2017-03-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Add historical version for breakpad .. Patch Set 1: Is this needed? I had talked to Tim recently about removing HISTORICAL given we never build with it and all

[Impala-ASF-CR] IMPALA-4593,IMPALA-4635: fix some python build issues

2017-03-06 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4593,IMPALA-4635: fix some python build issues .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6218/3/infra/python/bootstrap_virtualenv.

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-03-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 12: (7 comments) http://gerrit.cloudera.org:8080/#/c/6025/12/be/src/exprs/aggregate-functions-ir.

[Impala-ASF-CR] Add min / max to histograms

2017-03-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Add min / max to histograms .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6257 To unsubscribe, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT

2017-03-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4318: Kudu support for CREATE EXTERNAL TABLE AS SELECT .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6261/1/fe/src/main/cup/sql-pars

[Impala-ASF-CR] IMPALA-4593,IMPALA-4635: fix some python build issues

2017-03-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4593,IMPALA-4635: fix some python build issues .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6218 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-4593,IMPALA-4635: fix some python build issues

2017-03-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4593,IMPALA-4635: fix some python build issues .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6218/2/infra/python/bootstrap_virtualenv

[Impala-ASF-CR] IMPALA-4593,IMPALA-4635: fix some python build issues

2017-03-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4593,IMPALA-4635: fix some python build issues .. Patch Set 2: (3 comments) nice! did you try running this on a system where kudu is not supported, or

[Impala-ASF-CR] IMPALA-5027: make udf headers buildable externally

2017-03-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5027: make udf headers buildable externally .. Patch Set 1: Code-Review+1 seems like a reasonable first step, thanks for driving this -- To view, visit

[native-toolchain-CR] Fix setup / download order in build scripts

2017-03-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Fix setup / download order in build scripts .. Patch Set 3: Code-Review+1 (1 comment) lgtm, let's see if Tim had any other thoughts http://gerrit.cloudera.org

[native-toolchain-CR] Fix setup / download order in build scripts

2017-03-03 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Fix setup / download order in build scripts .. Patch Set 1: (1 comment) thanks for doing this - 1 question about 'footer' now http://gerrit.cloudera.org:8080/

<    2   3   4   5   6   7   8   9   10   11   >