[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. Patch Set 7: Thanks for the contribution! -- To view, visit

[Impala-ASF-CR] IMPALA-2235: Fix current db when shell auto-reconnects

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8368 ) Change subject: IMPALA-2235: Fix current db when shell auto-reconnects .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-2235: Fix current db when shell auto-reconnects

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8368 ) Change subject: IMPALA-2235: Fix current db when shell auto-reconnects .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow .. Patch Set 2: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow .. Patch Set 2: (1 comment) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow .. Patch Set 2: (1 comment) Added Mike Yoder since he

[Impala-ASF-CR] IMPALA-5052: Read and write signed integer logical types in Parquet

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8548 ) Change subject: IMPALA-5052: Read and write signed integer logical types in Parquet .. Patch Set 1: (4 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 10: Code-Review+2 Rebased onto the ConditionVariable cha

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-15 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8408 to look at the new patch set (#10). Change subject: IMPALA-6121: remove I/O mgr request context cache .

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-15 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8408 to look at the new patch set (#9). Change subject: IMPALA-6121: remove I/O mgr request context cache ..

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/840

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. Patch Set 5: (2 comments) I had one nit but just fixed it mys

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6) to the change originally created by Kim Jin Chul. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. IMPALA-6084: Avo

[Impala-ASF-CR] IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C

2017-11-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8549 ) Change subject: IMPALA-1144: Fix exception when cancelling query in Impala-shell with CTRL-C .. Patch Set 3: (4 comments) http://gerr

[Impala-ASF-CR] IMPALA-3436: Return a decimal when rounding a double

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8398 ) Change subject: IMPALA-3436: Return a decimal when rounding a double .. Patch Set 3: (3 comments) Didn't look at the frontend part. h

[Impala-ASF-CR] IMPALA-2235: Fix current db when shell auto-reconnects

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8368 ) Change subject: IMPALA-2235: Fix current db when shell auto-reconnects .. Patch Set 3: Phil, did you want to take another look at this?

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. Patch Set 4: I'm ok with using llvm:: in those files, but was

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 ) Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction .. Patch Set 4: (4 comments) Looks c

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-09 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Tianyi Wang, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8408 to look at the new patch set (#8). Change subject: IMPALA-6121: remove I/O mgr request context cache ..

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/840

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 7: (3 comments) I kept on pulling at the error propagation

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 2: I also don't want to block progress on making t

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-5237: support custom string in date/time format

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: support custom string in date/time format .. Patch Set 1: (9 comments) This is cool! http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/8408

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. Patch Set 3: @Bikram I think that would be convenient, except

[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8496 ) Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8414/4/

[Impala-ASF-CR] IMPALA-6170: Remove broken backend test from llvm-codegen-test

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8505 ) Change subject: IMPALA-6170: Remove broken backend test from llvm-codegen-test .. Patch Set 1: We should definitely merge this to unblo

[Impala-ASF-CR] IMPALA-6170: Remove broken backend test from llvm-codegen-test

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8505 ) Change subject: IMPALA-6170: Remove broken backend test from llvm-codegen-test .. Patch Set 1: Code-Review+2 It's unfortunately that we

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8414/4/

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8414/4/

[Impala-ASF-CR] IMPALA-6084: Avoid using of global namespace for llvm

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8489 ) Change subject: IMPALA-6084: Avoid using of global namespace for llvm .. Patch Set 3: (1 comment) I started looking through the first

[Impala-ASF-CR] Expose $IMPALA MAVEN OPTIONS for configuring Maven.

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8496 ) Change subject: Expose $IMPALA_MAVEN_OPTIONS for configuring Maven. .. Patch Set 1: We call mvn in a few other places, e.g. testdata/bi

[Impala-ASF-CR] IMPALA-6171: Revert "IMPALA-1575: part 2: yield admission control resources"

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8499 Change subject: IMPALA-6171: Revert "IMPALA-1575: part 2: yield admission control resources" .. IMPALA-6171: Revert "IMPALA-1575: part 2

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs

2017-11-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8294 ) Change subject: IMPALA-6067: Enable s3 access via IAM roles for EC2 VMs .. Patch Set 2: Code-Review-1 (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 16: Code-Review+2 Forgot that this needed a coordi

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-07 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8172 to look at the new patch set (#16). Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq ..

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 15: Code-Review+2 carry -- To view, visit http:/

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-07 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8172 to look at the new patch set (#14). Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 4: Looks like it hit IMPALA-6092 plus some

[Impala-ASF-CR] IMPALA-5999: Fix LLVM linkage errors due LibCache sync issues

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8487 ) Change subject: IMPALA-5999: Fix LLVM linkage errors due LibCache sync issues .. Patch Set 2: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/840

[Impala-ASF-CR] IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query.

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 ) Change subject: IMPALA-6155: Allow tests to pass when ORDER BY does not cover the query. .. Patch Set 3: Code-Review+2 Thanks Tim W.

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-07 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8172 to look at the new patch set (#13). Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-07 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8424 to look at the new patch set (#7). Change subject: IMPALA-4835 (prep only): create io subfolder and namespace ...

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 14: Code-Review+1 Rebased, carry Lars' +1. L

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-11-07 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8267 to look at the new patch set (#14). Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8267 ) Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding

2017-11-07 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8267 to look at the new patch set (#13). Change subject: IMPALA-4177,IMPALA-6039: batched bit reading and rle decoding .

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 4: Code-Review+2 Thanks Zoltan - I really a

[native-toolchain-CR] Bump Kudu version to 1520b39

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8491 ) Change subject: Bump Kudu version to 1520b39 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8491 To u

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 8: It's still technically accurate in that the quer

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 6: Code-Review+2 Carry +2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: (1 comment) Also added it to test_metrics_are_z

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Mostafa Mokhtar, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8461 to look at the new patch set (#5). Change subject: IMPALA-6151: add query-level fragment/backend counters ..

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 7: I took a brief look at how much work it would be

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 7: Code-Review+2 Carry +2 -- To view, visit http:

[Impala-ASF-CR] IMPALA-6155: Ensure TPC-DS result orders can't vary.

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8484 ) Change subject: IMPALA-6155: Ensure TPC-DS result orders can't vary. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8

[Impala-ASF-CR] IMPALA-5999: Fix LLVM linkage errors due LibCache sync issues

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8487 ) Change subject: IMPALA-5999: Fix LLVM linkage errors due LibCache sync issues .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 4: That's a good point, will make that change. Canc

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 6: Code-Review+1 carry +1 -- To view, visit http:

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-06 Thread Tim Armstrong (Code Review)
Hello anujphadke, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8323 to look at the new patch set (#6). Change subject: IMPALA-1575: part 2: yield admission control resources ...

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8172 to look at the new patch set (#12). Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .

[Impala-ASF-CR] IMPALA-6105: Clarify argument order in single node perf run

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8470 ) Change subject: IMPALA-6105: Clarify argument order in single_node_perf_run .. Patch Set 1: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8418 ) Change subject: IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness .. Patch Set 2: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Mostafa Mokhtar, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8461 to look at the new patch set (#4). Change subject: IMPALA-6151: add query-level fragment/backend counters .

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8414 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. Patch Set 4: (3 comments) Testing found one subtle bug. http://gerr

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#7). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. IMPALA-4835: Par

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#6). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. IMPALA-4835: Par

[Impala-ASF-CR] IMPALA-5307: Part 4: copy out uncompressed text and seq

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 ) Change subject: IMPALA-5307: Part 4: copy out uncompressed text and seq .. Patch Set 11: Code-Review+1 rebased to pick up IMPALA-6137 f

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 6: rebased -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 7: Code-Review+1 rebased -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-4835: Part 1: simplify I/O mgr mem mgmt

2017-11-06 Thread Tim Armstrong (Code Review)
Hello Tianyi Wang, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8414 to look at the new patch set (#5). Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt .. IMPALA-4835: Par

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-11-06 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 2: Code-Review+1 (5 comments) http://gerri

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8461 ) Change subject: IMPALA-6151: add query-level fragment/backend counters .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6151: add query-level fragment/backend counters

2017-11-03 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Mostafa Mokhtar, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8461 to look at the new patch set (#3). Change subject: IMPALA-6151: add query-level fragment/backend counters .

[Impala-ASF-CR] IMPALA-2494: Support for byte array encoded decimals in Parquet scanner

2017-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7822 ) Change subject: IMPALA-2494: Support for byte array encoded decimals in Parquet scanner .. Patch Set 9: Code-Review+2 LGTM. Probably b

[Impala-ASF-CR] IMPALA-2281: Replace FNV with FastHash in exchange nodes

2017-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8417 ) Change subject: IMPALA-2281: Replace FNV with FastHash in exchange nodes .. Patch Set 2: (12 comments) Did a first pass over it. http

[Impala-ASF-CR] IMPALA-4591: Bound Kudu client error mem usage

2017-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8464 ) Change subject: IMPALA-4591: Bound Kudu client error mem usage .. Patch Set 1: (8 comments) This is a nice improvement. Had some quest

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 5: Rebased since some things changed underneath

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-03 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8424 to look at the new patch set (#5). Change subject: IMPALA-4835 (prep only): create io subfolder and namespace ...

[Impala-ASF-CR] IMPALA-5017: Error on decimal overflow

2017-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8404 ) Change subject: IMPALA-5017: Error on decimal overflow .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8404/1//COMMIT

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 15: (8 comments) Pretty close, have some f

[Impala-ASF-CR] IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness

2017-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8418 ) Change subject: IMPALA-4539: [DOCS] Add known issue for uncompressed Parquet correctness .. Patch Set 2: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-6144: PublishFilter() continues to run after query failure/cancellation

2017-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8455 ) Change subject: IMPALA-6144: PublishFilter() continues to run after query failure/cancellation .. Patch Set 2: Code-Review+2 -- To vi

[Impala-ASF-CR] IMPALA-6121: remove I/O mgr request context cache

2017-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8408 ) Change subject: IMPALA-6121: remove I/O mgr request context cache .. Patch Set 6: Code-Review+1 Rebased since some of the patches under

[Impala-ASF-CR] IMPALA-6134: Update code base to use impala::ConditionVariable

2017-11-03 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8428 ) Change subject: IMPALA-6134: Update code base to use impala::ConditionVariable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:

  1   2   3   4   5   6   7   8   9   10   >