[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-11-01 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 5: I will certainly get back to this change. Neede

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-28 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. Patch Set 1: Code-Review+1 Great analysis. -- To view, visit http://gerrit.cloudera.org:8080/7521 To u

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-27 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7521/1/fe/src/main/java/org/apache/impala/

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-07-20 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7009/5/be/src/runtime/timestamp-parse-ut

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNSAFE SPILLS=1

2017-07-11 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 .. Patch Set 5: Done. -- To view, visit http://gerrit.cloudera.org:8080/7219 To unsubscribe

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNSAFE SPILLS=1

2017-07-11 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#4). Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 .. IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 This change will avoid a

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNFASE SPILLS=1

2017-06-30 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNFASE_SPILLS=1 .. Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/7219/2/fe/src/main/java/or

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNFASE SPILLS=1

2017-06-30 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#3). Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNFASE_SPILLS=1 .. IMPALA-5524: Fixes NPE during planning with DISABLE_UNFASE_SPILLS=1 This change will avoid a

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-06-26 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6991/6/be/src/exprs/expr-test.cc File be/src/exprs/expr-tes

[Impala-ASF-CR] IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.

2017-06-22 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos. .. Patch Set 2: Added default option as None. Sti

[Impala-ASF-CR] IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.

2017-06-22 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos. .. IMPALA-2782: Allow impala-shell to connect direct

[Impala-ASF-CR] IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.

2017-06-20 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos. .. Patch Set 1: I'm not sure how to write a test

[Impala-ASF-CR] IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.

2017-06-20 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/7241 Change subject: IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos. .. IMPALA

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNSAFE SPILLS=1

2017-06-18 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7219/1//COMMIT_MSG Commit Me

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNSAFE SPILLS=1

2017-06-18 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 .. IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 This change will avoid a

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNFASE SPILLS=1

2017-06-17 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/7219 Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNFASE_SPILLS=1 .. IMPALA-5524: Fixes NPE during planning with DISABL

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-06-17 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 5: Fixed some nits. -- To view, visit http://gerrit.cloudera.org:8080/7009 To unsubscribe,

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-06-17 Thread Vincent Tran (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#5). Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. IMPAL

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-17 Thread Vincent Tran (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7009 to look at the new patch set (#4). Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. IMPALA

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-17 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7009/3/be/src/exprs/expr-test.cc File be/

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-16 Thread Vincent Tran (Code Review)
Hello Impala Public Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7168 to look at the new patch set (#8). Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-16 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. Patch Set 7: One query plan in kudu-selectivity.test had a NOT IN predicate. The actual scan node card

[Impala-ASF-CR] IMPALA-4418: Fixes extra blank lines in query result

2017-06-15 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#4). Change subject: IMPALA-4418: Fixes extra blank lines in query result .. IMPALA-4418: Fixes extra blank lines in query result This change avoids printing blank lines when the Impala

[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result

2017-06-15 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-4418: Extra blank lines in query result .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/7055/3//COMMIT_MSG Commit Message: Line 11: that

[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result

2017-06-14 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#3). Change subject: IMPALA-4418: Extra blank lines in query result .. IMPALA-4418: Extra blank lines in query result This change will remove the blank lines resulting from impala-shell

[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result

2017-06-14 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-4418: Extra blank lines in query result .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7055/2/shell/impala_shell.py File shell/impala_sh

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-14 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#7). Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. IMPALA-5494: Fixes the selectivity of NOT IN predicates This change modifies the logic of NOT IN predicat

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-14 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/7168/6/fe/src/test/java/org/apache/impal

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#6). Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. IMPALA-5494: Fixes the selectivity of NOT IN predicates This change modifies the logic of NOT IN predicat

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#5). Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. IMPALA-5494: Fixes the selectivity of NOT IN predicates This change modifies the logic of NOT IN predicat

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#4). Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. IMPALA-5494: Fixes the selectivity of NOT IN predicates This change modifies the logic of NOT IN predicat

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7168/3/tests/metadata/test_explain.py Fi

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7168/2//COMMIT_MSG Commit Message: PS2,

[Impala-ASF-CR] IMPALA-5494: Fixes the selectivity of NOT IN predicates

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#3). Change subject: IMPALA-5494: Fixes the selectivity of NOT IN predicates .. IMPALA-5494: Fixes the selectivity of NOT IN predicates This change modifies the logic of NOT IN predicat

[Impala-ASF-CR] IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate.

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate. .. Patch Set 2: removed extraneous space characters. -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate.

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate. .. IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate. This chang

[Impala-ASF-CR] IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate.

2017-06-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/7168 Change subject: IMPALA-5494: NOT IN predicate shares the same selectivity as IN predicate. .. IMPALA-5494: NOT IN predicate shares the sa

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-08 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7009/3/be/src/exprs/expr-test.cc File be/

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-06 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#3). Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. IMPALA-5315 Cast to timestamp fails for -M-D format This change allows casting of a string in 'lazy'

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-06 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7009/2/be/src/exprs/expr-test.cc File be

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-06-06 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#5). Change subject: IMPALA-5316: Adds last_day() function .. IMPALA-5316: Adds last_day() function This change adds last_day() function. The function takes exactly one TIMESTAMP argume

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-06-06 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6991/4/be/src/exprs/timestamp-functions.h File be/src/exprs

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-06 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. IMPALA-5315 Cast to timestamp fails for -M-D format This change allows casting of a string in 'lazy'

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-06 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7009/1/be/src/exprs/expr-test.cc File be

[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result

2017-06-01 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-4418: Extra blank lines in query result .. IMPALA-4418: Extra blank lines in query result This change will remove the blank lines resulting from the impala-s

[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result

2017-06-01 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/7055 Change subject: IMPALA-4418: Extra blank lines in query result .. IMPALA-4418: Extra blank lines in query result This change will remove

[Impala-ASF-CR] IMPALA-5030: [TESTS] Adds support for NVL2() function

2017-06-01 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#5). Change subject: IMPALA-5030: [TESTS] Adds support for NVL2() function .. IMPALA-5030: [TESTS] Adds support for NVL2() function This change adds value tests to expr-test.cc to ensur

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-06-01 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7000/3/be/src/exprs/expr-test.cc File be/src/exprs

[Impala-ASF-CR] IMPALA-5030: [TESTS] Adds support for NVL2() function

2017-06-01 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#4). Change subject: IMPALA-5030: [TESTS] Adds support for NVL2() function .. IMPALA-5030: [TESTS] Adds support for NVL2() function This change adds value tests to expr-test.cc to ensur

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-05-27 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/7009 Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. IMPALA-5315 Cast to timestamp fails for -M-D format This c

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-05-26 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6991/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-te

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-05-26 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#4). Change subject: IMPALA-5316: Adds last_day() function .. IMPALA-5316: Adds last_day() function This change adds last_day() function. The function takes exactly one TIMESTAMP argume

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-26 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#3). Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds value tests to expr-test.cc to ensure that NVL2() fu

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-26 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds value and null tests to expr-test.cc for IMPALA-5030

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-26 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/7000 Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds support t

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-05-25 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#3). Change subject: IMPALA-5316: Adds last_day() function .. IMPALA-5316: Adds last_day() function This change adds last_day() function. The function takes exactly one DATE/TIMESTAMP a

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-05-25 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/6991/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-te

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-25 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 5: I can make that happen. Can I just push the patch again as normal? -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-05-25 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-5316: Adds last_day() function .. IMPALA-5316: Adds last_day() function This change adds last_day(TIMESTAMP) function. The function takes exactly one TIMESTA

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-05-25 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/6991 Change subject: IMPALA-5316: Adds last_day() function .. IMPALA-5316: Adds last_day() function This change adds last_day(TIMESTAMP) funct

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#4). Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds support to the function NVL2(expr1, expr2, expr3). T

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6962/3/fe/src/main/java/org/apache/impala/analysis

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#3). Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds support to the function NVL2(expr1, expr2, expr3). T

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-24 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Patch Set 2: (16 comments) http://gerrit.cloudera.org:8080/#/c/6962/1//COMMIT_MSG Commit Message: Line 17 > Cle

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-23 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#2). Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds support to the function NVL2(expr1, expr2, expr3). T

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-23 Thread Vincent Tran (Code Review)
Vincent Tran has abandoned this change. Change subject: IMPALA-5030: Adds support for NVL2() function .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6972 To unsubscribe, visit http://gerrit.cloudera.org:8080/se

[Impala-ASF-CR] IMPALA-5030: Adds support for NVL2() function

2017-05-23 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/6972 Change subject: IMPALA-5030: Adds support for NVL2() function .. IMPALA-5030: Adds support for NVL2() function This change adds support t

[Impala-ASF-CR] IMPALA-5030: Add support to NVL2() function

2017-05-22 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new change for review. http://gerrit.cloudera.org:8080/6962 Change subject: IMPALA-5030: Add support to NVL2() function .. IMPALA-5030: Add support to NVL2() function This change adds support to th