[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-11-01 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8430 ) Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. Patch Set 3: > Please update the comment as

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-11-01 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8430 ) Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-11-01 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8430 to look at the new patch set (#3). Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-11-01 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-11-01 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8430 ) Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-11-01 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8430 to look at the new patch set (#2). Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative.

[Impala-ASF-CR] IMPALA-6136: Part 1: Query duration should not be normally negative.

2017-10-31 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8430 Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. .. IMPALA-6136: Part 1: Query duration should not

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-24 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 10: Fixed the clang tidy warnings.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#10). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#9). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 8: (2 comments) Please check the latest

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-23 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#8). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-20 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#7). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-20 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 5: (3 comments) > (3 comments) Uploading a

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-20 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#6). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-19 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#5). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-19 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 4: > What about common-metrics.cc? > > And

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-19 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#4). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-18 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#3). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-18 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. .. Patch Set 2: > (1 comment) > > Code change looks

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src.

2017-10-18 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8305 to look at the new patch set (#2). Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src.

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src/service.

2017-10-18 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 ) Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src/service. .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-5599: Clean up references to TimestampValue in be/src/service.

2017-10-17 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8305 Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src/service. .. IMPALA-5599: Clean up references to

[Impala-ASF-CR] IMPALA-4682: Remove Preconditions check from analyzeAggregation().

2017-10-09 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dimitris Tsirogiannis, anujphadke, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8143 to look at the new patch set (#4). Change subject: IMPALA-4682: Remove Preconditions check from analyzeAggregation().

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException thrown by aggregate function.

2017-10-09 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682 Fix IllegalStateException thrown by aggregate function. .. Patch Set 3: (2 comments) Please see the

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException thrown by aggregate function.

2017-10-05 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682 Fix IllegalStateException thrown by aggregate function. .. Patch Set 2: (1 comment) Condensed new test

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException thrown by aggregate function.

2017-10-05 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dimitris Tsirogiannis, anujphadke, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8143 to look at the new patch set (#3). Change subject: IMPALA-4682 Fix IllegalStateException thrown by aggregate function.

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException issue

2017-10-04 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682 Fix IllegalStateException issue .. Patch Set 1: (2 comments) > Zoram, let's try to move this forward. We

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException thrown by aggregate function.

2017-10-04 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dimitris Tsirogiannis, anujphadke, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8143 to look at the new patch set (#2). Change subject: IMPALA-4682 Fix IllegalStateException thrown by aggregate function.

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException issue

2017-09-26 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8143 Change subject: IMPALA-4682 Fix IllegalStateException issue .. IMPALA-4682 Fix IllegalStateException issue When one runs a query like

[Impala-ASF-CR] IMPALA-5599: Fix for mis-use of TimestampValue

2017-09-22 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8084 ) Change subject: IMPALA-5599: Fix for mis-use of TimestampValue .. Patch Set 6: (1 comment) Changed to C++ static_cast.

[Impala-ASF-CR] IMPALA-5599: Fix for mis-use of TimestampValue

2017-09-22 Thread Zoram Thanga (Code Review)
Hello Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8084 to look at the new patch set (#7). Change subject: IMPALA-5599: Fix for mis-use of TimestampValue ..

[Impala-ASF-CR] IMPALA-5599: Fix for mis-use of TimestampValue

2017-09-22 Thread Zoram Thanga (Code Review)
Hello Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8084 to look at the new patch set (#6). Change subject: IMPALA-5599: Fix for mis-use of TimestampValue ..

[Impala-ASF-CR] IMPALA-5599: Fix for mis-use of TimestampValue

2017-09-22 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8084 ) Change subject: IMPALA-5599: Fix for mis-use of TimestampValue .. Patch Set 5: (1 comment) Fixed the test code as suggested. Please

[Impala-ASF-CR] IMPALA-5599: Fix for mis-use of TimestampValue

2017-09-22 Thread Zoram Thanga (Code Review)
Hello Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8084 to look at the new patch set (#5). Change subject: IMPALA-5599: Fix for mis-use of TimestampValue ..

[Impala-ASF-CR] IMPALA-5599: Fix for mis-use of TimestampValue

2017-09-22 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8084 ) Change subject: IMPALA-5599: Fix for mis-use of TimestampValue .. Patch Set 4: (1 comment) Made the last suggested change.

[Impala-ASF-CR] IMPALA-5599: Fix for mis-use of TimestampValue

2017-09-21 Thread Zoram Thanga (Code Review)
Hello Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8084 to look at the new patch set (#4). Change subject: IMPALA-5599: Fix for mis-use of TimestampValue ..

[Impala-ASF-CR] IMPALA-5599: Fix for mis-use of TimestampValue

2017-09-19 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded a new patch set (#3). Change subject: IMPALA-5599: Fix for mis-use of TimestampValue .. IMPALA-5599: Fix for mis-use of TimestampValue The TimestampValue class is being used for non-database purposes

[Impala-ASF-CR] IMPALA-5599: Fix for mis-use of TimestampValue

2017-09-19 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. Change subject: IMPALA-5599: Fix for mis-use of TimestampValue .. Patch Set 2: (15 comments) > (15 comments) > > Do you plan to take care of the other cases noted in the