Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4863
Change subject: IMPALA_2523: Make HdfsTableSink aware of clustered input
..
IMPALA_2523: Make HdfsTableSink aware of clustered input
IMPAL
Lars Volker has posted comments on this change.
Change subject: IMPALA_2523: Make HdfsTableSink aware of clustered input
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4863/1/be/src/exec/hdfs-table-sink.cc
Fil
Tim Armstrong has posted comments on this change.
Change subject: IMPALA_2523: Make HdfsTableSink aware of clustered input
..
Patch Set 1:
(2 comments)
I didn't do a full pass but had thoughts on testing.
http://gerrit.cloude
Lars Volker has uploaded a new patch set (#3).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced clustering for insert sta
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced clustering for insert sta
Lars Volker has uploaded a new patch set (#4).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced clustering for insert sta
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 4:
(2 comments)
Thanks Tim for having a look. Please see PS4.
http://gerrit.cloudera.org:80
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 4:
(17 comments)
Thanks for adding the tests, this is looking pretty good - I think it cou
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 4:
(17 comments)
http://gerrit.cloudera.org:8080/#/c/4863/4/be/src/exec/hdfs-table-sink.cc
F
Lars Volker has uploaded a new patch set (#5).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced clustering for insert sta
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4863/5/be/src/exec/hdfs-table-sink.cc
Lars Volker has uploaded a new patch set (#6).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced clustering for insert sta
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 5:
(4 comments)
Thanks for the review, please see PS6.
http://gerrit.cloudera.org:8080/#/c/
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4863
To unsubscribe, vi
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 6:
LGTM but I think it's a big enough change that we should have another pair of
eyes on i
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#7).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMP
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 7:
(1 comment)
Thanks Tim, for the review. I pushed PS7, removing a DCHECK I had added -
th
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4863/6/be/src/exec/hdfs-table-sink.cc
Alex Behm has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 7:
(12 comments)
Be changes look pretty good to me.
http://gerrit.cloudera.org:8080/#/c/4863/
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#8).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMP
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 8:
(14 comments)
Thanks for the reviews, please see PS8. I will update again once the privat
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 8: Code-Review+1
(3 comments)
+1 on the backend part.
http://gerrit.cloudera.org:8080/#/c
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 8:
i'll pick this up once it has an overall +1
--
To view, visit http://gerrit.clouder
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#9).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMP
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4863/7/tests/query_test/test_insert_behav
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 7:
S3 private build failed b/c of stale testdata snapshot. I will rebase next and
try again.
Alex Behm has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 7:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4863/6/testdata/workloads/functional-query
Alex Behm has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 9:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4863/9/tests/query_test/test_insert_behavi
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#10).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IM
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#11).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IM
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 9:
(3 comments)
Thanks for the reviews. I'm running another private job to test the change o
Alex Behm has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 11: Code-Review+1
Assuming the S3 run passes.
--
To view, visit http://gerrit.cloudera.org:80
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 11:
Passed private S3 run with only query_tests enabled here.
Relevant lines for S3:
02:22:4
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 11:
Marcel, can you have a look for a +2? Thanks.
--
To view, visit http://gerrit.cloudera.
Hello Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#12).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
...
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 12: Code-Review+1
Rebased, carry +1 from Alex.
--
To view, visit http://gerrit.cloudera.org
Hello Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#13).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
...
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 12:
Rebased and added tests in AnalyzeStmtsTest as suggested by Alex in
https://gerrit.cloud
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 13:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/4863/13/be/src/exec/hdfs-table-si
Hello Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#14).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
...
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 13:
(10 comments)
Thanks for the review. Please see PS14.
http://gerrit.cloudera.org:8080/#
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4863/13/be/src/exec/hdfs-table-sink
Hello Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#15).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
...
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 13:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4863/13/be/src/exec/hdfs-table-sink.cc
F
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 15:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4863/15/be/src/exec/hdfs-table-sink.c
Hello Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#16).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
...
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 15:
(5 comments)
Thanks for the comments, please see PS16.
http://gerrit.cloudera.org:8080/
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 16: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4863
To unsubscribe, v
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 16: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4863/15/be/src/exec/
Hello Marcel Kornacker, Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#17).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 16:
(3 comments)
Thanks for the review. I addressed the comments in PS17 and will rebase the
Hello Marcel Kornacker, Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#18).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 18: Code-Review+1
Rebased and ran the relevant tests locally, carry +1.
--
To view, visit h
Hello Marcel Kornacker, Alex Behm, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4863
to look at the new patch set (#19).
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
.
Lars Volker has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19: Code-Review+1
Replaced NULL with nullptr as discussed in previous comments. Carry +1. Now
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19: Code-Review+2
Carry the +2
--
To view, visit http://gerrit.cloudera.org:8080/4863
To
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19: Verified-1
Build failed:
http://sandbox.jenkins.cloudera.com/job/impala-external-ge
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19:
Build failed:
http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19:
Build failed:
http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19:
Build failed:
http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
Patch Set 19: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4863
To unsubscribe, v
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input
..
IMPALA-2523: Make HdfsTableSink aware of clustered input
IMPALA-2521 introduced clusterin
62 matches
Mail list logo
