Re: [PR] [DRAFT] Split MemChunk if row number exceeded the avgSeriesPointNumberThreshold [iotdb]

2024-09-28 Thread via GitHub
sonarcloud[bot] commented on PR #13653: URL: https://github.com/apache/iotdb/pull/13653#issuecomment-2381077947 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [I] [Bug] [iotdb]

2024-09-28 Thread via GitHub
CritasWang commented on issue #13379: URL: https://github.com/apache/iotdb/issues/13379#issuecomment-2381078928 当前版本下,建议安装好后第一时间使用 sql 更新密码 ``` ALTER USER SET PASSWORD ; eg: ALTER USER tempuser SET PASSWORD 'newpwd'; ``` -- This is an automated message from the Apache Git Serv

Re: [PR] [DRAFT] Split MemChunk if row number exceeded the avgSeriesPointNumberThreshold [iotdb]

2024-09-28 Thread via GitHub
HTHou closed pull request #13653: [DRAFT] Split MemChunk if row number exceeded the avgSeriesPointNumberThreshold URL: https://github.com/apache/iotdb/pull/13653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[PR] [DRAFT] Split MemChunk if row number exceeded the avgSeriesPointNumberThreshold [iotdb]

2024-09-28 Thread via GitHub
HTHou opened a new pull request, #13653: URL: https://github.com/apache/iotdb/pull/13653 ## Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[PR] [Config-properties] Change iot_consensus_throttle_threshold_in_byte = wal_throttle_threshold_in_byte for compatibility [iotdb]

2024-09-28 Thread via GitHub
133tosakarin opened a new pull request, #13652: URL: https://github.com/apache/iotdb/pull/13652 Change iot_consensus_throttle_threshold_in_byte = wal_throttle_threshold_in_byte for compatibility -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Support global-aggregation in TableModel [iotdb]

2024-09-28 Thread via GitHub
JackieTien97 merged PR #13651: URL: https://github.com/apache/iotdb/pull/13651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb

Re: [PR] Support global-aggregation in TableModel [iotdb]

2024-09-28 Thread via GitHub
Beyyes commented on code in PR #13651: URL: https://github.com/apache/iotdb/pull/13651#discussion_r1779857682 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/aggregation/AggregationOperator.java: ## @@ -0,0 +1,158 @@ +/*

Re: [PR] [IOTDB-3162]Split large target files in cross space compaction [iotdb]

2024-09-27 Thread via GitHub
HTHou closed pull request #6425: [IOTDB-3162]Split large target files in cross space compaction URL: https://github.com/apache/iotdb/pull/6425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] Support global-aggregation in TableModel [iotdb]

2024-09-27 Thread via GitHub
Wei-hao-Li opened a new pull request, #13651: URL: https://github.com/apache/iotdb/pull/13651 1. Now only support count, avg aggregation function; 2. ITs are not added now, we will do this work after all aggregation operator developed. https://github.com/user-attachments/assets/9d9

Re: [PR] Support Fill in Table Model [iotdb]

2024-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #13650: URL: https://github.com/apache/iotdb/pull/13650#issuecomment-2379293186 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

[PR] Support Fill in Table Model [iotdb]

2024-09-27 Thread via GitHub
JackieTien97 opened a new pull request, #13650: URL: https://github.com/apache/iotdb/pull/13650 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Product Introduction [iotdb-docs]

2024-09-27 Thread via GitHub
StefanieZhao7 commented on code in PR #369: URL: https://github.com/apache/iotdb-docs/pull/369#discussion_r1778382737 ## src/.vuepress/sidebar_timecho/V1.3.x/en.ts: ## @@ -29,7 +29,7 @@ export const enSidebar = { prefix: 'IoTDB-Introduction/', // children: 'structu

Re: [PR] Problem fixing [iotdb-docs]

2024-09-27 Thread via GitHub
HTHou merged PR #370: URL: https://github.com/apache/iotdb-docs/pull/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apach

[PR] Feature/move SBOM check into separate profile [iotdb]

2024-09-27 Thread via GitHub
chrisdutz opened a new pull request, #13649: URL: https://github.com/apache/iotdb/pull/13649 Moves the sbom check into a dedicated profile, which needs to be enabled explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778309124 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java: ## @@ -38,82 +40,89 @@ import java.io.IOExcepti

Re: [PR] PipeConsensus: Support deletion operation for PipeConsensus [iotdb]

2024-09-27 Thread via GitHub
OneSizeFitsQuorum commented on code in PR #13016: URL: https://github.com/apache/iotdb/pull/13016#discussion_r1776647658 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/PipeConsensusAsyncConnector.java: ## @@ -400,13 +401,16 @@ publ

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778273748 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/ServerCommandLine.java: ## @@ -39,10 +41,10 @@ public abstract class ServerCommandLine { Opti

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778264977 ## iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.sh: ## @@ -19,21 +19,35 @@ # if [ "$#" -eq 1 ] && [ "$1" == "--help" ]; then -echo "The scr

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778263046 ## iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.sh: ## @@ -19,21 +19,35 @@ # if [ "$#" -eq 1 ] && [ "$1" == "--help" ]; then -echo "The scr

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778260047 ## iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.sh: ## @@ -19,21 +19,35 @@ # if [ "$#" -eq 1 ] && [ "$1" == "--help" ]; then -echo "The scr

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778252884 ## iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedureTest.java: ## @@ -29,21 +30,28 @@ import java.io.DataO

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778230749 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java: ## @@ -144,19 +145,26 @@ protected void start() throws IoTDBException {

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778229388 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java: ## @@ -212,22 +249,54 @@ protected RemoveDataNod

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778213794 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java: ## @@ -123,8 +132,10 @@ protected Flow executeFr

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778204427 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java: ## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Remove datanode optimization [iotdb]

2024-09-27 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778188629 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java: ## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Softw

[PR] Adjust procedure's default clean interval [iotdb]

2024-09-26 Thread via GitHub
liyuheng5 opened a new pull request, #13648: URL: https://github.com/apache/iotdb/pull/13648 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Pipe: add IoTDBConnector sender port configuration [iotdb]

2024-09-26 Thread via GitHub
luoluoyuyu commented on code in PR #13593: URL: https://github.com/apache/iotdb/pull/13593#discussion_r1778067504 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/connector/protocol/IoTDBConnector.java: ## @@ -175,6 +203,100 @@ public void validate(final Pi

Re: [PR] Pipe: add IoTDBConnector sender port configuration [iotdb]

2024-09-26 Thread via GitHub
Caideyipi commented on code in PR #13593: URL: https://github.com/apache/iotdb/pull/13593#discussion_r1778061442 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/connector/protocol/IoTDBConnector.java: ## @@ -175,6 +203,100 @@ public void validate(final Pip

Re: [PR] Pipe: add IoTDBConnector sender port configuration [iotdb]

2024-09-26 Thread via GitHub
Caideyipi commented on code in PR #13593: URL: https://github.com/apache/iotdb/pull/13593#discussion_r1778061442 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/connector/protocol/IoTDBConnector.java: ## @@ -175,6 +203,100 @@ public void validate(final Pip

Re: [PR] [to rc/1.3.3] Enhance repair compaction & exception handle with full disks [iotdb]

2024-09-26 Thread via GitHub
jt2594838 merged PR #13613: URL: https://github.com/apache/iotdb/pull/13613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.ap

[PR] Problem fixing [iotdb-docs]

2024-09-26 Thread via GitHub
W1y1r opened a new pull request, #370: URL: https://github.com/apache/iotdb-docs/pull/370 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Add full outer time join for table model [iotdb]

2024-09-26 Thread via GitHub
JackieTien97 merged PR #13608: URL: https://github.com/apache/iotdb/pull/13608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb

[PR] Add small compaction task queue [iotdb]

2024-09-26 Thread via GitHub
shuwenwei opened a new pull request, #13647: URL: https://github.com/apache/iotdb/pull/13647 ## Description Add small compaction task queue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Yr 15 supplementary content for data synchronization [iotdb-docs]

2024-09-26 Thread via GitHub
W1y1r closed pull request #352: Yr 15 supplementary content for data synchronization URL: https://github.com/apache/iotdb-docs/pull/352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Pipe: exclude raw tablet events with `needToReport` set to false when calculating commit rate to avoid extremely low remaining time [iotdb]

2024-09-26 Thread via GitHub
VGalaxies commented on code in PR #13640: URL: https://github.com/apache/iotdb/pull/13640#discussion_r1777283235 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/SubscriptionBlockingPendingQueue.java: ## @@ -40,4 +42,9 @@ public int size() { public

Re: [PR] Bump net.minidev:json-smart from 2.5.0 to 2.5.1 [iotdb]

2024-09-26 Thread via GitHub
HTHou commented on PR #13369: URL: https://github.com/apache/iotdb/pull/13369#issuecomment-2377236875 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Pipe: add IoTDBConnector sender port configuration [iotdb]

2024-09-26 Thread via GitHub
Caideyipi commented on code in PR #13593: URL: https://github.com/apache/iotdb/pull/13593#discussion_r1777007761 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/connector/protocol/IoTDBConnector.java: ## @@ -175,6 +203,100 @@ public void validate(final Pip

Re: [PR] [To rc/1.3.3] Make each execution acquire a schema read lock only once [iotdb]

2024-09-26 Thread via GitHub
JackieTien97 merged PR #13641: URL: https://github.com/apache/iotdb/pull/13641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb

Re: [PR] [To rc/1.3.3] Pipe: Fix the problem of missing precision when converting String type to Int32 and int64 types (#13643) [iotdb]

2024-09-26 Thread via GitHub
SteveYurongSu merged PR #13645: URL: https://github.com/apache/iotdb/pull/13645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

[PR] Active Load: Fix load tsfile failed when system is read only [iotdb]

2024-09-26 Thread via GitHub
YC27 opened a new pull request, #13646: URL: https://github.com/apache/iotdb/pull/13646 as title -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: rev

[PR] [To rc/1.3.3] Pipe: Fix the problem of missing precision when converting String type to Int32 and int64 types (#13643) [iotdb]

2024-09-26 Thread via GitHub
luoluoyuyu opened a new pull request, #13645: URL: https://github.com/apache/iotdb/pull/13645 ## Description As the title said This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

Re: [PR] [To rc/1.3.3] PipePlugin: Add pipe consensus related plugins to blackList (#13642) [iotdb]

2024-09-26 Thread via GitHub
SteveYurongSu merged PR #13644: URL: https://github.com/apache/iotdb/pull/13644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] Pipe: Fix the problem of missing precision when converting String type to Int32 and int64 types [iotdb]

2024-09-26 Thread via GitHub
SteveYurongSu merged PR #13643: URL: https://github.com/apache/iotdb/pull/13643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

[PR] [To rc/1.3.3] PipePlugin: Add pipe consensus related plugins to blackList (#13642) [iotdb]

2024-09-26 Thread via GitHub
luoluoyuyu opened a new pull request, #13644: URL: https://github.com/apache/iotdb/pull/13644 ## Description As the title said This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

[PR] Pipe: Fix the problem of missing precision when converting String type to Int32 and int64 types [iotdb]

2024-09-26 Thread via GitHub
luoluoyuyu opened a new pull request, #13643: URL: https://github.com/apache/iotdb/pull/13643 ## Description As the title said This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

Re: [PR] PipePlugin: Add pipe consensus related plugins to blackList [iotdb]

2024-09-26 Thread via GitHub
SteveYurongSu merged PR #13642: URL: https://github.com/apache/iotdb/pull/13642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

[PR] PipePlugin: Add pipe consensus related plugins to blackList [iotdb]

2024-09-26 Thread via GitHub
luoluoyuyu opened a new pull request, #13642: URL: https://github.com/apache/iotdb/pull/13642 ## Description As the title said This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

[PR] [To rc/1.3.3] Make each execution acquire a schema read lock only once [iotdb]

2024-09-26 Thread via GitHub
Caideyipi opened a new pull request, #13641: URL: https://github.com/apache/iotdb/pull/13641 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

Re: [PR] Support table model insert redirection [iotdb]

2024-09-26 Thread via GitHub
jt2594838 merged PR #13550: URL: https://github.com/apache/iotdb/pull/13550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.ap

Re: [PR] [to rc/1.3.3] Fix NodeInfo processLoadSnapshot method (avoid compatibility issues caused by ainode serialization) (CP 13622) [iotdb]

2024-09-26 Thread via GitHub
OneSizeFitsQuorum merged PR #13637: URL: https://github.com/apache/iotdb/pull/13637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] [to rc/1.3.3] Use CountDownLatch to replace Semaphore in IoTConsensus log dispatcher closing (CP 13517) [iotdb]

2024-09-26 Thread via GitHub
OneSizeFitsQuorum merged PR #13638: URL: https://github.com/apache/iotdb/pull/13638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

[PR] Pipe: exclude raw tablet events with `needToReport` set to false when calculating commit rate to avoid extremely low remaining time [iotdb]

2024-09-26 Thread via GitHub
VGalaxies opened a new pull request, #13640: URL: https://github.com/apache/iotdb/pull/13640 TBD. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: re

Re: [PR] [To rc/1.3.3] AINode: Correcting the Omissions and Redundancies [iotdb]

2024-09-26 Thread via GitHub
SteveYurongSu merged PR #13636: URL: https://github.com/apache/iotdb/pull/13636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] [To rc/1.3.3]Change the error infomation when insert a timestamp over Long.MaxValue && Fix potential NPE when write FileTimeIndexCache [iotdb]

2024-09-26 Thread via GitHub
jt2594838 merged PR #13633: URL: https://github.com/apache/iotdb/pull/13633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.ap

[PR] Product Introduction [iotdb-docs]

2024-09-26 Thread via GitHub
W1y1r opened a new pull request, #369: URL: https://github.com/apache/iotdb-docs/pull/369 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] [to rc/1.3.3] Use CountDownLatch to replace Semaphore in IoTConsensus log dispatcher closing (CP 13517) [iotdb]

2024-09-26 Thread via GitHub
liyuheng5 opened a new pull request, #13638: URL: https://github.com/apache/iotdb/pull/13638 Cherry-picking PR #13517 into CP/13517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Product Introduction [iotdb-docs]

2024-09-26 Thread via GitHub
StefanieZhao7 commented on code in PR #369: URL: https://github.com/apache/iotdb-docs/pull/369#discussion_r1776639740 ## src/UserGuide/Master/IoTDB-Introduction/IoTDB-Introduction_apache.md: ## @@ -0,0 +1,60 @@ + + +# Product Introduction + +Apache IoTDB is a low-cost, high-perf

Re: [PR] Make each execution acquire a schema read lock only once [iotdb]

2024-09-26 Thread via GitHub
JackieTien97 merged PR #13634: URL: https://github.com/apache/iotdb/pull/13634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb

Re: [PR] [To rc/1.3.3] AINode: Correcting the Omissions and Redundancies [iotdb]

2024-09-26 Thread via GitHub
codecov[bot] commented on PR #13636: URL: https://github.com/apache/iotdb/pull/13636#issuecomment-2376304761 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13636?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

Re: [PR] Fix NodeInfo processLoadSnapshot method (avoid compatibility issues caused by ainode serialization) [iotdb]

2024-09-26 Thread via GitHub
OneSizeFitsQuorum merged PR #13622: URL: https://github.com/apache/iotdb/pull/13622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

[PR] [to rc/1.3.3] Fix NodeInfo processLoadSnapshot method (avoid compatibility issues caused by ainode serialization) (CP 13622) [iotdb]

2024-09-26 Thread via GitHub
liyuheng5 opened a new pull request, #13637: URL: https://github.com/apache/iotdb/pull/13637 Cherry-picking PR #13622 into CP/13622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [To rc/1.3.3] AINode: Correcting the Omissions and Redundancies [iotdb]

2024-09-26 Thread via GitHub
codecov[bot] commented on PR #13635: URL: https://github.com/apache/iotdb/pull/13635#issuecomment-2376273653 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13635?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

Re: [PR] [To rc/1.3.3] AINode: Correcting the Omissions and Redundancies [iotdb]

2024-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #13636: URL: https://github.com/apache/iotdb/pull/13636#issuecomment-2376188383 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[PR] Naigai 926 v1.3.3 [iotdb-docs]

2024-09-26 Thread via GitHub
mal117 opened a new pull request, #368: URL: https://github.com/apache/iotdb-docs/pull/368 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [To rc/1.3.3] Tolerate ser/de call for configPhysicalReadPlan [iotdb]

2024-09-26 Thread via GitHub
OneSizeFitsQuorum merged PR #13628: URL: https://github.com/apache/iotdb/pull/13628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] [To rc/1.3.3] AINode: Correcting the Omissions and Redundancies [iotdb]

2024-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #13635: URL: https://github.com/apache/iotdb/pull/13635#issuecomment-2376159970 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

Re: [PR] [To rc/1.3.3] AINode: Correcting the Omissions and Redundancies [iotdb]

2024-09-26 Thread via GitHub
ycycse closed pull request #13635: [To rc/1.3.3] AINode: Correcting the Omissions and Redundancies URL: https://github.com/apache/iotdb/pull/13635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [To rc/1.3.3] [RatisConsensus] Bump ratis version to 3.1.1 [iotdb]

2024-09-26 Thread via GitHub
OneSizeFitsQuorum merged PR #13630: URL: https://github.com/apache/iotdb/pull/13630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] [RatisConsensus] Bump ratis version to 3.1.1 [iotdb]

2024-09-26 Thread via GitHub
OneSizeFitsQuorum merged PR #13629: URL: https://github.com/apache/iotdb/pull/13629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@

Re: [PR] [To rc/1.3.3] Pipe: Fixed the bug that different types in schema snapshot transfer may cause transfer failure (#13627) [iotdb]

2024-09-26 Thread via GitHub
SteveYurongSu merged PR #13631: URL: https://github.com/apache/iotdb/pull/13631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] [To rc/1.3.3] Pipe: Fixed the bug that alter source will not alter the reference co… [iotdb]

2024-09-26 Thread via GitHub
SteveYurongSu merged PR #13632: URL: https://github.com/apache/iotdb/pull/13632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] [To rc/1.3.3]Change the error infomation when insert a timestamp over Long.MaxValue && Fix potential NPE when write FileTimeIndexCache [iotdb]

2024-09-26 Thread via GitHub
codecov[bot] commented on PR #13633: URL: https://github.com/apache/iotdb/pull/13633#issuecomment-2376116042 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/13633?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_te

[PR] Make each execution acquire a schema read lock only once [iotdb]

2024-09-26 Thread via GitHub
Caideyipi opened a new pull request, #13634: URL: https://github.com/apache/iotdb/pull/13634 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

Re: [PR] Add full outer time join for table model [iotdb]

2024-09-25 Thread via GitHub
sonarcloud[bot] commented on PR #13608: URL: https://github.com/apache/iotdb/pull/13608#issuecomment-2376061439 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] [To rc/1.3.3]Change the error infomation when insert a timestamp over Long.MaxValue && Fix potential NPE when write FileTimeIndexCache [iotdb]

2024-09-25 Thread via GitHub
sonarcloud[bot] commented on PR #13633: URL: https://github.com/apache/iotdb/pull/13633#issuecomment-2376048039 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarclo

[PR] Change the error infomation when insert a timestamp over Long.MaxValue && Fix potential NPE when write FileTimeIndexCache [iotdb]

2024-09-25 Thread via GitHub
HTHou opened a new pull request, #13633: URL: https://github.com/apache/iotdb/pull/13633 ## Description cp 24d1191a8e7c7e05cf92c5261a6a8f44ed67d45a & 3c1eace43f0403cffa3916986638db8baa751034 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Support table model insert redirection [iotdb]

2024-09-25 Thread via GitHub
HTHou commented on code in PR #13550: URL: https://github.com/apache/iotdb/pull/13550#discussion_r1776336165 ## iotdb-client/isession/src/main/java/org/apache/iotdb/isession/IPooledSession.java: ## @@ -28,6 +28,7 @@ import org.apache.thrift.TException; import org.apache.tsfile

Re: [PR] Support table model insert redirection [iotdb]

2024-09-25 Thread via GitHub
sonarcloud[bot] commented on PR #13550: URL: https://github.com/apache/iotdb/pull/13550#issuecomment-2375845579 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Support table model insert redirection [iotdb]

2024-09-25 Thread via GitHub
HTHou commented on code in PR #13550: URL: https://github.com/apache/iotdb/pull/13550#discussion_r1776336165 ## iotdb-client/isession/src/main/java/org/apache/iotdb/isession/IPooledSession.java: ## @@ -28,6 +28,7 @@ import org.apache.thrift.TException; import org.apache.tsfile

[PR] [To rc/1.3.3] Pipe: Fixed the bug that alter source will not alter the reference co… [iotdb]

2024-09-25 Thread via GitHub
Caideyipi opened a new pull request, #13632: URL: https://github.com/apache/iotdb/pull/13632 …unt of ConfigRegionListeningQueue (#13626) ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concur

Re: [PR] Modify error messages [iotdb-docs]

2024-09-25 Thread via GitHub
Beyyes merged PR #365: URL: https://github.com/apache/iotdb-docs/pull/365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

Re: [PR] Update data synchronization document [iotdb-docs]

2024-09-25 Thread via GitHub
Beyyes merged PR #364: URL: https://github.com/apache/iotdb-docs/pull/364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

Re: [PR] AINode analysis [iotdb-docs]

2024-09-25 Thread via GitHub
Beyyes merged PR #367: URL: https://github.com/apache/iotdb-docs/pull/367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

Re: [PR] Support table model insert redirection [iotdb]

2024-09-25 Thread via GitHub
HTHou commented on code in PR #13550: URL: https://github.com/apache/iotdb/pull/13550#discussion_r1776330734 ## iotdb-client/session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java: ## @@ -703,7 +709,16 @@ private ISession getSession() throws IoTDBConnectionExcepti

Re: [PR] Pipe: Fixed the bug that alter source will not alter the reference count of ConfigRegionListeningQueue [iotdb]

2024-09-25 Thread via GitHub
SteveYurongSu merged PR #13626: URL: https://github.com/apache/iotdb/pull/13626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] Pipe: Fixed the bug that different types in schema snapshot transfer may cause transfer failure [iotdb]

2024-09-25 Thread via GitHub
SteveYurongSu merged PR #13627: URL: https://github.com/apache/iotdb/pull/13627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotd

Re: [PR] Support table model insert redirection [iotdb]

2024-09-25 Thread via GitHub
HTHou commented on code in PR #13550: URL: https://github.com/apache/iotdb/pull/13550#discussion_r1776324075 ## iotdb-client/session/src/test/java/org/apache/iotdb/session/SessionCacheLeaderTest.java: ## @@ -931,6 +1025,161 @@ public void testInsertTabletsWithSessionBroken() thr

[PR] [To rc/1.3.3] [RatisConsensus] Bump ratis version to 3.1.1 [iotdb]

2024-09-25 Thread via GitHub
133tosakarin opened a new pull request, #13630: URL: https://github.com/apache/iotdb/pull/13630 cp from -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Remove datanode optimization [iotdb]

2024-09-25 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776315538 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java: ## @@ -38,82 +40,89 @@ import java.io.IOExcepti

[PR] [RatisConsensus] Bump ratis version to 3.1.1 [iotdb]

2024-09-25 Thread via GitHub
133tosakarin opened a new pull request, #13629: URL: https://github.com/apache/iotdb/pull/13629 Bump ratis version to 3.1.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Remove datanode optimization [iotdb]

2024-09-25 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776311802 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java: ## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Add full outer time join for table model [iotdb]

2024-09-25 Thread via GitHub
sonarcloud[bot] commented on PR #13608: URL: https://github.com/apache/iotdb/pull/13608#issuecomment-2375800304 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarclo

Re: [PR] Remove datanode optimization [iotdb]

2024-09-25 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776302707 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java: ## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Remove datanode optimization [iotdb]

2024-09-25 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776300910 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/node/NodeManager.java: ## @@ -371,51 +370,58 @@ public TDataNodeRestartResp updateDataNode

Re: [PR] Remove datanode optimization [iotdb]

2024-09-25 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776299547 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/node/NodeManager.java: ## @@ -371,51 +370,58 @@ public TDataNodeRestartResp updateDataNode

Re: [PR] Remove datanode optimization [iotdb]

2024-09-25 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776299361 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -695,69 +842,79 @@ private TSStatus checkRegionMigrate( }

Re: [PR] Remove datanode optimization [iotdb]

2024-09-25 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776299039 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -598,14 +607,109 @@ public boolean removeAINode(RemoveAINodePl

Re: [PR] Remove datanode optimization [iotdb]

2024-09-25 Thread via GitHub
HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776297567 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -598,14 +607,109 @@ public boolean removeAINode(RemoveAINodePl

Re: [PR] Support table model insert redirection [iotdb]

2024-09-25 Thread via GitHub
HTHou commented on code in PR #13550: URL: https://github.com/apache/iotdb/pull/13550#discussion_r1776295219 ## iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java: ## @@ -2697,6 +2790,111 @@ public void insertRelationalTablet(Tablet tablet) insertRelat

  1   2   3   4   5   6   7   8   9   10   >