Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778309124 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java: ## @@ -38,82 +40,89 @@ import java.io.IOExcepti

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778273748 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/ServerCommandLine.java: ## @@ -39,10 +41,10 @@ public abstract class ServerCommandLine { Opti

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778264977 ## iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.sh: ## @@ -19,21 +19,35 @@ # if [ "$#" -eq 1 ] && [ "$1" == "--help" ]; then -echo "The scr

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778263046 ## iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.sh: ## @@ -19,21 +19,35 @@ # if [ "$#" -eq 1 ] && [ "$1" == "--help" ]; then -echo "The scr

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778260047 ## iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.sh: ## @@ -19,21 +19,35 @@ # if [ "$#" -eq 1 ] && [ "$1" == "--help" ]; then -echo "The scr

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778252884 ## iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedureTest.java: ## @@ -29,21 +30,28 @@ import java.io.DataO

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778230749 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/service/ConfigNode.java: ## @@ -144,19 +145,26 @@ protected void start() throws IoTDBException {

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778229388 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java: ## @@ -212,22 +249,54 @@ protected RemoveDataNod

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778213794 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java: ## @@ -123,8 +132,10 @@ protected Flow executeFr

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778204427 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java: ## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1778188629 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java: ## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776315538 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedure.java: ## @@ -38,82 +40,89 @@ import java.io.IOExcepti

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776311802 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java: ## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776302707 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeManager.java: ## @@ -0,0 +1,457 @@ +/* + * Licensed to the Apache Softw

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776300910 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/node/NodeManager.java: ## @@ -371,51 +370,58 @@ public TDataNodeRestartResp updateDataNode

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776299547 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/node/NodeManager.java: ## @@ -371,51 +370,58 @@ public TDataNodeRestartResp updateDataNode

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776299361 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -695,69 +842,79 @@ private TSStatus checkRegionMigrate( }

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776299039 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -598,14 +607,109 @@ public boolean removeAINode(RemoveAINodePl

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776297567 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -598,14 +607,109 @@ public boolean removeAINode(RemoveAINodePl

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776281744 ## integration-test/src/test/java/org/apache/iotdb/confignode/it/removedatanode/IoTDBRemoveDataNodeNormalIT.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache S

Re: [PR] Remove datanode optimization [iotdb]

HxpSerein commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1776293327 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -577,17 +580,23 @@ public void removeConfigNode(RemoveConfigNo

Re: [PR] Remove datanode optimization [iotdb]

OneSizeFitsQuorum commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1774756266 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -598,14 +607,109 @@ public boolean removeAINode(Remove

Re: [PR] Remove datanode optimization [iotdb]

liyuheng5 commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1774837824 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -598,14 +607,109 @@ public boolean removeAINode(RemoveAINo

Re: [PR] Remove datanode optimization [iotdb]

liyuheng5 commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1774837824 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java: ## @@ -598,14 +607,109 @@ public boolean removeAINode(RemoveAINo

Re: [PR] Remove datanode optimization [iotdb]

liyuheng5 commented on code in PR #13559: URL: https://github.com/apache/iotdb/pull/13559#discussion_r1774808840 ## iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/procedure/impl/node/RemoveDataNodesProcedureTest.java: ## @@ -29,21 +30,28 @@ import java.io.D

[PR] Remove datanode optimization [iotdb]

HxpSerein opened a new pull request, #13559: URL: https://github.com/apache/iotdb/pull/13559 ## Description ConfigNode - Task management and conflict checking - Procedure enhancement -- This is an automated message from the Apache Git Service. To respond to the messa