[kudu-CR] docs: design for handling permanent master failures

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: design for handling permanent master failures .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3393/3/docs/design-docs/master-perm-failure-1.

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: remote_bootstrap_client: mild API changes .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2709/ -- To view, visit http://gerrit.cloudera.org

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3811 to look at the new patch set (#4). Change subject: remote_bootstrap_client: mild API changes .. remote_bootstrap_cl

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3809/3/src/kudu/client/client-internal.cc File src/kudu/client

[kudu-CR] [util] fixed build on MacOS X

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] fixed build on MacOS X .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt

[kudu-CR] [util] fixed build on MacOS X

2016-08-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util] fixed build on MacOS X .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.

[kudu-CR] [util] fixed build on MacOS X

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util] fixed build on MacOS X .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt File src/kudu/util

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2708/ -- To view, visit http://gerrit.cloud

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-02 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3834 to look at the new patch set (#2). Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. [KuduScanBat

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 1: (3 comments) Thank you for review. Will post an updated version soon. http://gerrit.cloudera.

[kudu-CR] [util] fixed build on MacOS X

2016-08-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [util] fixed build on MacOS X .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2707/ -- To view, visit http://gerrit.cloudera.org:8080/3836 T

[kudu-CR] [util] fixed build on MacOS X

2016-08-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3836 Change subject: [util] fixed build on MacOS X .. [util] fixed build on MacOS X This is a follow-up for a9265d92424dc305c480d6c44d006b854

[kudu-CR] docs: design for handling permanent master failures

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: design for handling permanent master failures .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3393/3/docs/design-docs/master-perm-failure-1

[kudu-CR] Add docs for non-covering range partitioning

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add docs for non-covering range partitioning .. Patch Set 1: Dan, do you have time to look at this before the 0.10 release? -- To view, visit http://gerrit.cloud

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/3809/3/src/kudu/client/client-internal.cc Fil

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: remote_bootstrap_client: mild API changes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3811/3//COMMIT_MSG Commit Message: Line 15:logging,

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3834/1/src/kudu/client/scan_batch.h File src/kud

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: Thinking about this more, the 20s clamp is probably OK. It means we could theoretically not make pro

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2706/ -- To view, visit http://gerrit.cloud

[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up

2016-08-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3834 Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. [KuduScanBatch::const_iterator] a minor clean-up More 'standardized'

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: remote_bootstrap_client: mild API changes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3811/3//COMMIT_MSG Commit Message: Line 15:logging,

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3828/1//COMMIT_MSG Commit Message: Line 7: make elec

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: remote_bootstrap_client: mild API changes .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3811/3//COMMIT_MSG Commit Message: Line 15:logging,

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3809/2/src/kudu/client/client-internal.cc File src/kudu/client/

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3809 to look at the new patch set (#3). Change subject: c++ client: remove unnecessary code .. c++ client:

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2704/ -- To view, visit http:

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3811 to look at the new patch set (#3). Change subject: remote_bootstrap_client: mild API changes .. remote_bootstrap_cl

[kudu-CR] master: additional leader lock assertions in catalog manager

2016-08-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master: additional leader lock assertions in catalog manager .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2705/ -- To view, visit http://

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2703/ -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] master: additional leader lock assertions in catalog manager

2016-08-02 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3684 to look at the new patch set (#5). Change subject: master: additional leader lock assertions in catalog manager ..

[kudu-CR] remote bootstrap client: mild API changes

2016-08-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: remote_bootstrap_client: mild API changes .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2702/ -- To view, visit http://gerrit.cloudera.org

[kudu-CR] external mini cluster: adjust single master data directory

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: external_mini_cluster: adjust single master data directory .. external_mini_cluster: adjust single master data directory If we stored single master data in

[kudu-CR] Fix block manager-test running in some builds

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: Fix block_manager-test running in some builds .. Fix block_manager-test running in some builds Even though the patch for KUDU-1538 passed pre-commit, it fa

[kudu-CR] external mini cluster: adjust single master data directory

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: external_mini_cluster: adjust single master data directory .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3810 To unsubscribe, vi

[kudu-CR] Fix block manager-test running in some builds

2016-08-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix block_manager-test running in some builds .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3733 To unsubscribe, visit http://ger

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3828/1//COMMIT_MSG Commit Message: Line 7: make elect

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3828/1//COMMIT_MSG Commit Message: Line 7: make elec

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3809 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] c++ client: remove unnecessary code

2016-08-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: c++ client: remove unnecessary code .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3809/2/src/kudu/client/client-internal.cc File src/kudu/client

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3828/1//COMMIT_MSG Commit Message: Line 7: make elec

[kudu-CR] make election timeout jitter more aggressive

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: make election timeout jitter more aggressive .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3828/1//COMMIT_MSG Commit Message: Line 7: make elec

[kudu-CR] Fix block manager-test running in some builds

2016-08-02 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3733 to look at the new patch set (#4). Change subject: Fix block_manager-test running in some builds .. Fix block_manag

[kudu-CR] Fix block manager-test running in some builds

2016-08-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix block_manager-test running in some builds .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2701/ -- To view, visit http://gerrit.cloudera

[kudu-CR] Fix block manager-test running in some builds

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix block_manager-test running in some builds .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3733/3/src/kudu/util/CMakeLists.txt File src/kudu/u

[kudu-CR] ksck-test: fix failure on OSX

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck-test: fix failure on OSX .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3734 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR] ksck-test: fix failure on OSX

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: ksck-test: fix failure on OSX .. ksck-test: fix failure on OSX We previously relied on deleting the 'first' element of an unordered_map to set up a test c

[kudu-CR] Fix ksck-test reliance on unordered map iteration order

2016-08-02 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. Change subject: Fix ksck-test reliance on unordered map iteration order .. Abandoned whoops...already a review out for this -- To view, visit http://gerrit.cloudera.org:8080/3831 To un

[kudu-CR] Fix ksck-test reliance on unordered map iteration order

2016-08-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix ksck-test reliance on unordered map iteration order .. Patch Set 1: Hey Will. I actually put a patch up already for this here https://gerrit.cloudera.org/#/c/