[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4180/3/src/kudu/tools/tool_action_cluster.cc File

[kudu-CR] ts tablet manager: set status message after failed tablet copy

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ts_tablet_manager: set status message after failed tablet copy .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3182/ -- To view, visit

[kudu-CR] ts tablet manager: set status message after failed tablet copy

2016-08-31 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4194 to look at the new patch set (#3). Change subject: ts_tablet_manager: set status message after failed tablet copy

[kudu-CR] tracing: gzip the trace JSON ajax response

2016-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tracing: gzip the trace JSON ajax response .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4154/1//COMMIT_MSG Commit Message: Line 18: version

[kudu-CR] Inlined dispatch for predicate evaluation

2016-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4164/2/src/kudu/common/column_predicate.h File

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/4134/7/src/kudu/tools/kudu-ts-cli-test.cc

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 7: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3180/ -- To view, visit

[kudu-CR] ksck: add --checksum scan concurrency to optional flags

2016-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ksck: add --checksum_scan_concurrency to optional flags .. Patch Set 1: (1 comment)

[kudu-CR] ksck: add --checksum scan concurrency to optional flags

2016-08-31 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4183 to look at the new patch set (#2). Change subject: ksck: add --checksum_scan_concurrency to optional flags ..

[kudu-CR] tablet peer: clean up TabletStatusListener interface

2016-08-31 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tablet_peer: clean up TabletStatusListener interface .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4193/1/src/kudu/tablet/tablet_peer.h File

[kudu-CR] ts tablet manager: set status message after failed tablet copy

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ts_tablet_manager: set status message after failed tablet copy .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3177/ -- To view, visit

[kudu-CR] tablet peer: clean up TabletStatusListener interface

2016-08-31 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4193 to look at the new patch set (#2). Change subject: tablet_peer: clean up TabletStatusListener interface

[kudu-CR] tool: port log-dump

2016-08-31 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 3: (4 comments) Hi Adar, sorry I missed the train here, but these are more of curious questions than review comments as such so

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-08-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4173 To unsubscribe,

[kudu-CR] c++ client: expose private GetTablet API

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: c++ client: expose private GetTablet API .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3174/ -- To view, visit

[kudu-CR] tablet peer: clean up TabletStatusListener interface

2016-08-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tablet_peer: clean up TabletStatusListener interface .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4193/1/src/kudu/tablet/tablet_peer.h File

[kudu-CR] tablet peer: clean up TabletStatusListener interface

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tablet_peer: clean up TabletStatusListener interface .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3173/ -- To view, visit

[kudu-CR] compaction policy: avoid O(n^2) calls to EstimateOnDiskSize

2016-08-31 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: compaction_policy: avoid O(n^2) calls to EstimateOnDiskSize .. Patch Set 1: LGTM but could you add the numbers you obtained to the commit message -- To

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-08-31 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 2: Code-Review+2 Leaving open in case MJ has more comments. -- To view, visit

[kudu-CR] compaction policy: avoid O(n^2) calls to EstimateOnDiskSize

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: compaction_policy: avoid O(n^2) calls to EstimateOnDiskSize .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3172/ -- To view, visit

[kudu-CR](gh-pages) jekyll: Use GitHub-flavored markdown and GitHub style highlighting

2016-08-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: jekyll: Use GitHub-flavored markdown and GitHub style highlighting .. jekyll: Use GitHub-flavored markdown and GitHub style highlighting The default

[kudu-CR](gh-pages) blog: Minor tweaks to flume article

2016-08-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: blog: Minor tweaks to flume article .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4190 To unsubscribe, visit

[kudu-CR](gh-pages) jekyll: Use GitHub-flavored markdown and GitHub style highlighting

2016-08-31 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: jekyll: Use GitHub-flavored markdown and GitHub style highlighting .. Patch Set 1: Code-Review+2 Verified+1 I am pushing this myself to un-break the site. -- To

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-08-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4173/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR](gh-pages) jekyll: Use GitHub-flavored markdown and GitHub style highlighting

2016-08-31 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/4189 Change subject: jekyll: Use GitHub-flavored markdown and GitHub style highlighting .. jekyll: Use GitHub-flavored markdown and GitHub

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3171/ -- To view, visit

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-08-31 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 4: (17 comments)

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-08-31 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4180 to look at the new patch set (#3). Change subject: tool: port kudu-admin to 'kudu cluster' .. tool: port

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3170/ -- To view, visit

[kudu-CR] [java-client] Add ScanToken.stringifySerializedToken

2016-08-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [java-client] Add ScanToken.stringifySerializedToken .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4173/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] tracing: gzip the trace JSON ajax response

2016-08-31 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: tracing: gzip the trace JSON ajax response .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4154/1//COMMIT_MSG Commit Message: Line 16:

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-08-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4180/1/src/kudu/tools/kudu-admin-test.cc File

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-08-31 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4180 to look at the new patch set (#2). Change subject: tool: port kudu-admin to 'kudu cluster' .. tool: port

[kudu-CR] tool: port kudu-admin to 'kudu cluster'

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-admin to 'kudu cluster' .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3169/ -- To view, visit

[kudu-CR] ksck: add --checksum scan concurrency to optional flags

2016-08-31 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: ksck: add --checksum_scan_concurrency to optional flags .. Patch Set 1: (1 comment)

[kudu-CR] ksck: add --checksum scan concurrency to optional flags

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ksck: add --checksum_scan_concurrency to optional flags .. Patch Set 1: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3168/ -- To view, visit

[kudu-CR](gh-pages) kudu flume sink blog post

2016-08-31 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: kudu flume sink blog post .. kudu flume sink blog post Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed Reviewed-on:

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 25: Build Started http://104.196.14.100/job/kudu-gerrit/3167/ -- To view, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-31 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#25). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode ..

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-31 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#24). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode ..

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 24: Build Started http://104.196.14.100/job/kudu-gerrit/3166/ -- To view, visit

[kudu-CR] ksck: add --checksum scan concurrency to optional flags

2016-08-31 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ksck: add --checksum_scan_concurrency to optional flags .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3164/ -- To view, visit

[kudu-CR] consensus: improve log messages for lagging or tablet-copying peers

2016-08-31 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4184 to review the following change. Change subject: consensus: improve log messages for lagging or tablet-copying peers