[kudu-CR] KuduRPC integration with OpenSSL

2016-10-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/util/net/ssl_socket.cc File

[kudu-CR] Fix SASL mechanism negotiation on the server side

2016-10-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix SASL mechanism negotiation on the server side .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4875/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] block manager: cosmetic changes to the LBM

2016-10-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: block_manager: cosmetic changes to the LBM .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4847 To unsubscribe, visit

[kudu-CR] rpc: support GSSAPI authentication

2016-10-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: support GSSAPI authentication .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4763 To unsubscribe, visit

[kudu-CR] rpc: improve error messages and logging for bad authentication

2016-10-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: improve error messages and logging for bad authentication .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4764 To

[kudu-CR] Remove unused code for checking PLAIN authentication

2016-10-27 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4874 to review the following change. Change subject: Remove unused code for checking PLAIN authentication ..

[kudu-CR] Fix SASL mechanism negotiation on the server side

2016-10-27 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4875 to review the following change. Change subject: Fix SASL mechanism negotiation on the server side ..

[kudu-CR] Enable GSSAPI for servers and ExternalMiniCluster

2016-10-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Enable GSSAPI for servers and ExternalMiniCluster .. Patch Set 4: this one needs a bit more work, it turns out. -- To view, visit

[kudu-CR] Enable GSSAPI for servers and ExternalMiniCluster

2016-10-27 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4765 to look at the new patch set (#6). Change subject: Enable GSSAPI for servers and ExternalMiniCluster

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 4: (4 comments) Some more comments. http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/util/net/socket.cc File

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Remove timeouts when joining in the sync client .. Patch Set 3: Code-Review+2 Looks good to me, but maybe Todd has some more comments? -- To view,

[kudu-CR] block manager: various changes to disk space reservation checking

2016-10-27 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4831 to look at the new patch set (#4). Change subject: block_manager: various changes to disk space reservation checking

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Remove timeouts when joining in the sync client .. Patch Set 2: (1 comment)

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4871 to look at the new patch set (#3). Change subject: [java client] Remove timeouts when joining in the sync client ..

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Remove timeouts when joining in the sync client .. Patch Set 2: (1 comment)

[kudu-CR] rpc: support GSSAPI authentication

2016-10-27 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4763 to look at the new patch set (#5). Change subject: rpc: support GSSAPI authentication .. rpc:

[kudu-CR] Enable GSSAPI for servers and ExternalMiniCluster

2016-10-27 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4765 to look at the new patch set (#5). Change subject: Enable GSSAPI for servers and ExternalMiniCluster

[kudu-CR] rpc: improve error messages and logging for bad authentication

2016-10-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: improve error messages and logging for bad authentication .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/4764/4/src/kudu/rpc/sasl_client.h

[kudu-CR] rpc: improve error messages and logging for bad authentication

2016-10-27 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4764 to look at the new patch set (#5). Change subject: rpc: improve error messages and logging for bad authentication

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4871 to look at the new patch set (#2). Change subject: [java client] Remove timeouts when joining in the sync client ..

[kudu-CR] [java client] KuduRpc.deserialize should throw KuduException

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] KuduRpc.deserialize should throw KuduException .. [java client] KuduRpc.deserialize should throw KuduException A vestige of our use

[kudu-CR] rpc: support GSSAPI authentication

2016-10-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: support GSSAPI authentication .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4763/4/src/kudu/security/mini_kdc-test.cc File

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/tools/kudu-tool-test.cc File

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 3: (16 comments) Would be nice to understand whether there's a perf impact to this, to decide whether we

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-27 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 2: > didn't look at any of this code, but just wanted to drop a note > saying I used the local_replica delete

[kudu-CR] [java client] KuduRpc.deserialize should throw KuduException

2016-10-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] KuduRpc.deserialize should throw KuduException .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4872 To unsubscribe,

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Remove timeouts when joining in the sync client .. Patch Set 1: (1 comment)

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 2: didn't look at any of this code, but just wanted to drop a note saying I used the local_replica delete

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Remove timeouts when joining in the sync client .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4871/1//COMMIT_MSG Commit

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java client] Remove timeouts when joining in the sync client .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4871/1//COMMIT_MSG Commit Message:

[kudu-CR] [java client] KuduRpc.deserialize should throw KuduException

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4872 to review the following change. Change subject: [java client] KuduRpc.deserialize should throw KuduException

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4871 to review the following change. Change subject: [java client] Remove timeouts when joining in the sync client

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#3). Change subject: [java client] Implement RPC tracing, part 1

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. KUDU-1715. Add a way to set ReplicaSelection to the java client This patch adds

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. Patch Set 4: > Patch Set 4: Code-Review+2 Carrying David's +2. -- To view, visit

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 4: (1 comment)

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 4: (1 comment)

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 4: (1 comment)

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 4: (1 comment)

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Refactor all server info into a single class, add locality .. [java client] Refactor all server info into a single class, add

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 3: (4 comments)

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-27 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 1: (38 comments) http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/integration-tests/cluster_itest_util.cc

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-10-27 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#2). Change subject: [tools] Manual recovery tools (part 1)

[kudu-CR] KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc

2016-10-27 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc .. Patch Set 2: (1 comment)

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4836 to look at the new patch set (#4). Change subject: [java client] Refactor all server info into a single class, add locality

[kudu-CR] Redirect krb5 stdout to SLF4j

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Redirect krb5 stdout to SLF4j .. Redirect krb5 stdout to SLF4j Change-Id: Iaf49340cbe5f0630f2e0674274b94c853c4ccfc3 Reviewed-on:

[kudu-CR] Redirect krb5 stdout to SLF4j

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Redirect krb5 stdout to SLF4j .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4843 To unsubscribe, visit

[kudu-CR] KUDU-1680 - [python] Improve PartialRow Usability

2016-10-27 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KUDU-1680 - [python] Improve PartialRow Usability .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4760/3/python/kudu/client.pyx File

[kudu-CR] KUDU-1680 - [python] Improve PartialRow Usability

2016-10-27 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4760 to look at the new patch set (#4). Change subject: KUDU-1680 - [python] Improve PartialRow Usability .. KUDU-1680

[kudu-CR] KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc

2016-10-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions

2016-10-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4795/2//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1680 - [python] Improve PartialRow Usability

2016-10-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1680 - [python] Improve PartialRow Usability .. Patch Set 3: -Code-Review -- To view, visit http://gerrit.cloudera.org:8080/4760 To unsubscribe, visit

[kudu-CR] KUDU-1680 - [python] Improve PartialRow Usability

2016-10-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1680 - [python] Improve PartialRow Usability .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4760/3/python/kudu/client.pyx

[kudu-CR] WIP: enable GSSAPI for servers

2016-10-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: WIP: enable GSSAPI for servers .. Patch Set 4: Code-Review+1 (3 comments) Just trying to follow along with security stuff a bit...feel free to disregard

[kudu-CR] KUDU-1690 - [python] Enable setting of default values

2016-10-27 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1690 - [python] Enable setting of default values .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4818 To unsubscribe,