Hello Mike Percy, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4834
to look at the new patch set (#11).
Change subject: [tools] Manual recovery tools (part 1)
.
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4992
to review the following change.
Change subject: rpc: fix too-long memcmp for HTTP methods
..
rpc: fix too-long memcmp
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4990
to look at the new patch set (#2).
Change subject: WIP: workarounds for el6/krb5 1.10
..
WIP: workarou
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4991
Change subject: Enforce that REINSERTs are not supported in DeltaMemStores
..
Enforce that REINSERTs are not supported in DeltaMemS
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4990
to review the following change.
Change subject: WIP: workarounds for el6/krb5 1.10
..
WIP: workarounds for el6/krb5 1.
David Ribeiro Alves has posted comments on this change.
Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take
a RowChangeListEncoder as an out param
..
Patch Set 5: Verified+1
Unrelated flake
--
To
Dinesh Bhat has posted comments on this change.
Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime()
..
Patch Set 2: Code-Review+1
Nit: Is there a reason to keep the same naming convention for
HybridClock::
David Ribeiro Alves has posted comments on this change.
Change subject: Improve debuggability of the delta/compaction path
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4930/2/src/kudu/tablet/delta_store.cc
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4930
to look at the new patch set (#3).
Change subject: Improve debuggability of the delta/compaction path
..
Improve de
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4988
to look at the new patch set (#2).
Change subject: Consolidate Row/CompactionInputRow printing on compaction
..
Con
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4989
Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime()
..
Rename LogicalClock::NowForMetrics() to GetCurrentTime(
Dinesh Bhat has posted comments on this change.
Change subject: Avoid extra fsyncs of tombstoned tablets during startup
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4915
To unsubscribe, visit
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4988
Change subject: Consolidate Row/CompactionInputRow printing on compaction
..
Consolidate Row/CompactionInputRow printing on compact
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4927
to look at the new patch set (#4).
Change subject: Add a macro to LOG and return on a non-OK status
..
Add a macro
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4927
to look at the new patch set (#3).
Change subject: Add a macro to LOG and return on a non-OK status
..
Add a macro
David Ribeiro Alves has posted comments on this change.
Change subject: Add a macro to LOG and return on a non-OK status
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4927/2//COMMIT_MSG
Commit Message:
> Ni
Jordan Birdsell has posted comments on this change.
Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
..
Patch Set 9:
This will need a good rebasing, the writeop api has since changed on the python
side.
--
T
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4987
Change subject: [python] - Sync version with main
..
[python] - Sync version with main
Now that the python client is pretty much at pa
Mike Percy has posted comments on this change.
Change subject: KUDU-1735. Fix crash when aborting a skipped config change round
..
Patch Set 3: Code-Review+2
(1 comment)
Added a nit but the change looks good
http://gerrit.clo
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation
..
KUDU-1599. Reject invalid type/encoding pairs on table creation
Change-Id: Ib508dbfbfd5
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1677. Scanners can return out-of-order rows during a
compaction
..
KUDU-1677. Scanners can return out-of-order rows during a compaction
This fixes a
Mike Percy has posted comments on this change.
Change subject: KUDU-1735. Fix crash when aborting a skipped config change round
..
Patch Set 3:
This looks pretty good to me. I want to do one more pass on it tomorrow.
--
To vi
Adar Dembo has posted comments on this change.
Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4984
To unsubscribe
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4984/1/src/kudu/client/client-tes
Todd Lipcon has uploaded a new patch set (#2).
Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation
..
KUDU-1599. Reject invalid type/encoding pairs on table creation
Change-Id: Ib508dbfbfd574c7c8ccc90
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4984/1/src/kudu/client/client-test
Adar Dembo has posted comments on this change.
Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4984/1/src/kudu/client/client-test
Adar Dembo has posted comments on this change.
Change subject: KUDU-1677. Scanners can return out-of-order rows during a
compaction
..
Patch Set 3: Code-Review+2
Oops, meant to +2.
--
To view, visit http://gerrit.cloudera.or
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1677. Scanners can return out-of-order rows during a
compaction
..
Patch Set 3:
Yea, it did.
--
To view, visit http://gerrit.cloudera.org:8080/4983
To unsu
Adar Dembo has posted comments on this change.
Change subject: KUDU-1677. Scanners can return out-of-order rows during a
compaction
..
Patch Set 3:
I presume the new test failed without the fix?
--
To view, visit http://gerr
Todd Lipcon has submitted this change and it was merged.
Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec
..
Workaround KUDU-1580: bump negotiation timeout to 15sec
KUDU-1580 is a bug where RPC negotiatio
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1677. Scanners can return out-of-order rows during a
compaction
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4983/3/src/kudu/tablet/table
Hello Jean-Daniel Cryans, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4984
to review the following change.
Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation
Alexey Serbin has posted comments on this change.
Change subject: [c++ client] implemented session operations stats
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/client.h
File src/kudu
Hello David Ribeiro Alves, Anonymous Coward #80, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4983
to look at the new patch set (#3).
Change subject: KUDU-1677. Scanners can return out-of-order rows during a
compaction
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1677. Scanners can return out-of-order rows during a
compaction
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4983/1/src/kudu/tablet/disk
Hello David Ribeiro Alves, Anonymous Coward #80, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4983
to look at the new patch set (#2).
Change subject: KUDU-1677. Scanners can return out-of-order rows during a
compaction
Alexey Serbin has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 4:
> The gssapi implementation on macOS uses the system heimdal library.
oh, I see. Thanks for the
Hello David Ribeiro Alves, Anonymous Coward #80,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4983
to review the following change.
Change subject: KUDU-1677. Scanners can return out-of-order rows during a
compaction
...
Dan Burkert has submitted this change and it was merged.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Misc. fixes for Kerberos compatibility on OS X
This commit makes a few changes in order to have better c
Dan Burkert has submitted this change and it was merged.
Change subject: installation.adoc: Add openssl and Kerberos dependencies
..
installation.adoc: Add openssl and Kerberos dependencies
This adds openssl header and kerberos
Dan Burkert has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4978/3/src/kudu/rpc/sasl_common.cc
File src/kudu/rp
Dan Burkert has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 3:
The gssapi implementation on macOS uses the system heimdal library.
--
To view, visit http://gerri
Alexey Serbin has posted comments on this change.
Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4977
To unsubscribe, vis
Alexey Serbin has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 3:
Why do we need to work with Heimdal implementation at all? I though we are
about to use MIT impl
Alexey Serbin has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4978/3/src/kudu/rpc/sasl_common.cc
File src/kudu/
Alexey Serbin has submitted this change and it was merged.
Change subject: [ssl] disable SSL/TLS compression
..
[ssl] disable SSL/TLS compression
As for the best recommended practices for SSL/TLS deployment,
disable compression
Adar Dembo has posted comments on this change.
Change subject: installation.adoc: Add openssl and Kerberos dependencies
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4981
To unsubscribe, visit
Adar Dembo has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4978
To unsubscribe, visit http://ge
Dan Burkert has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4978/1/src/kudu/rpc/sasl_rpc-test.cc
File src/kudu
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4978
to look at the new patch set (#3).
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
M
Dan Burkert has posted comments on this change.
Change subject: [ssl] disable SSL/TLS compression
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4962
To unsubscribe, visit http://gerrit.clouder
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4981
to review the following change.
Change subject: installation.adoc: Add openssl and Kerberos dependencies
..
installatio
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4978
to look at the new patch set (#2).
Change subject: Misc. fixes for Kerberos compatibility on OS X
.
Adar Dembo has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4978/1/src/kudu/rpc/sasl_rpc-test.cc
File src/kudu/
Dan Burkert has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4978/1//COMMIT_MSG
Commit Message:
PS1, Line 14:
Adar Dembo has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4978/1//COMMIT_MSG
Commit Message:
PS1, Line 14: 2.
Todd Lipcon has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4978/1//COMMIT_MSG
Commit Message:
PS1, Line 14: 2
Adar Dembo has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4978/1//COMMIT_MSG
Commit Message:
PS1, Line 14: 2
Todd Lipcon has posted comments on this change.
Change subject: Avoid extra fsyncs of tombstoned tablets during startup
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4915/3/src/kudu/tablet/tablet_metadata.cc
Todd Lipcon has posted comments on this change.
Change subject: [OpenSSL] require at least 1.0.0 version
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4937
To unsubscribe, visit http://gerrit.
Todd Lipcon has submitted this change and it was merged.
Change subject: [OpenSSL] require at least 1.0.0 version
..
[OpenSSL] require at least 1.0.0 version
To build the project, it's necessary to have OpenSSL version 1.0.0
or
Todd Lipcon has posted comments on this change.
Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec
..
Patch Set 1:
yea, it would make it take longer if it's down and not responding with
'connection refused
Todd Lipcon has posted comments on this change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4978
To unsubscribe, visit http://g
Adar Dembo has posted comments on this change.
Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec
..
Patch Set 1: Code-Review+2
This doesn't mean all "the other end is down and has been down for a while"
s
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4978
to review the following change.
Change subject: Misc. fixes for Kerberos compatibility on OS X
..
Misc. fixes for Kerb
Adar Dembo has submitted this change and it was merged.
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
..
[java client] Redirect KuduExceptions to RowError in KuduSession
Currently the only Row
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4977
to review the following change.
Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec
..
Workaroun
Adar Dembo has posted comments on this change.
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4949
To unsubscrib
Adar Dembo has submitted this change and it was merged.
Change subject: rpc: Add min / max negotiation threads
..
rpc: Add min / max negotiation threads
Since we use a thread pool for connection negotiation, it would be
helpful
Adar Dembo has posted comments on this change.
Change subject: rpc: Add min / max negotiation threads
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4574
To unsubscribe, visit http://gerrit.clo
Adar Dembo has posted comments on this change.
Change subject: [c++ client] implemented session operations stats
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/client.h
File src/kudu/cl
Mike Percy has abandoned this change.
Change subject: Bump up min negotiation threads in disk_reservation-itest
..
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4575
To unsubscribe, visit http://gerrit.cloudera.o
Mike Percy has posted comments on this change.
Change subject: rpc: Add min / max negotiation threads
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4574/1//COMMIT_MSG
Commit Message:
PS1, Line 9: it would b
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4574
to look at the new patch set (#2).
Change subject: rpc: Add min / max negotiation threads
..
rpc: Add min / max neg
Alexey Serbin has posted comments on this change.
Change subject: [c++ client] implemented session operations stats
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/write_op_stats.h
File
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: [python] - Expand KuduError capabilities
..
[python] - Expand KuduError capabilities
The Python client currently doesn't support the full error rep
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1690 - [python] Enable setting of default values
..
KUDU-1690 - [python] Enable setting of default values
This patch enables the python client
Jean-Daniel Cryans has posted comments on this change.
Change subject: [python] - Expand KuduError capabilities
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4885
To unsubscribe, visit http://
Dinesh Bhat has posted comments on this change.
Change subject: [c++ client] implemented session operations stats
..
Patch Set 2: Code-Review+1
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/write_op_s
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4885
to look at the new patch set (#2).
Change subject: [python] - Expand KuduError capabilities
..
[python] - Expand Ku
Jordan Birdsell has posted comments on this change.
Change subject: [python] - Expand KuduError capabilities
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4885/1/python/kudu/tests/test_client.py
File python/k
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1690 - [python] Enable setting of default values
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4818
To unsubscribe,
Alexey Serbin has posted comments on this change.
Change subject: [c++ client] implemented session operations stats
..
Patch Set 2:
> Alexey, thanks for doing this. As we discussed, one of the issues
> Impala faces is that the
Alexey Serbin has posted comments on this change.
Change subject: [c++ client] implemented session operations stats
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4974/2//COMMIT_MSG
Commit Message:
PS2, Line
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions
..
KUDU-1648 - [python] Expose Setting of Range Partitions
Currently, the Python client doe
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4795
To unsubscribe
Jean-Daniel Cryans has posted comments on this change.
Change subject: [python] - Expose additional scanner methods
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4888
To unsubscribe, visit htt
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: [python] - Expose additional scanner methods
..
[python] - Expose additional scanner methods
This patch exposes a few remaining scanner methods fro
Jean-Daniel Cryans has posted comments on this change.
Change subject: [python] - Expand KuduError capabilities
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4885/1/python/kudu/tests/test_client.py
File pytho
Dinesh Bhat has posted comments on this change.
Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown
..
Patch Set 2:
(2 comments)
TFTR Mike.
http://gerrit.cloudera.org:8080/#/c/4958/1/src/kudu/rpc/acc
Hello Dan Burkert, Mike Percy, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4958
to look at the new patch set (#2).
Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown
.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4949
to look at the new patch set (#4).
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
Alexey Serbin has posted comments on this change.
Change subject: Reject CREATE TABLE ops with even replication factor
..
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4945/4/src/kudu/integration-tests/delete_t
Matthew Jacobs has posted comments on this change.
Change subject: [c++ client] implemented session operations stats
..
Patch Set 2:
Alexey, thanks for doing this. As we discussed, one of the issues Impala faces
is that the er
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4949/3/java/kudu-client/sr
Alexey Serbin has posted comments on this change.
Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4949/3/java/kudu-client/src/ma
Jean-Daniel Cryans has posted comments on this change.
Change subject: [c++ client] implemented session operations stats
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4974/2//COMMIT_MSG
Commit Message:
PS2,
Alexey Serbin has posted comments on this change.
Change subject: [c++ client] implemented session operations stats
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4974/2//COMMIT_MSG
Commit Message:
PS2, Line
Mike Percy has posted comments on this change.
Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown
..
Patch Set 1: Code-Review+1
(2 comments)
lgtm
http://gerrit.cloudera.org:8080/#/c/4958/1/src/kudu/
1 - 100 of 101 matches
Mail list logo