[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-07 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#11). Change subject: [tools] Manual recovery tools (part 1) .

[kudu-CR] rpc: fix too-long memcmp for HTTP methods

2016-11-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4992 to review the following change. Change subject: rpc: fix too-long memcmp for HTTP methods .. rpc: fix too-long memcmp

[kudu-CR] WIP: workarounds for el6/krb5 1.10

2016-11-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4990 to look at the new patch set (#2). Change subject: WIP: workarounds for el6/krb5 1.10 .. WIP: workarou

[kudu-CR] Enforce that REINSERTs are not supported in DeltaMemStores

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4991 Change subject: Enforce that REINSERTs are not supported in DeltaMemStores .. Enforce that REINSERTs are not supported in DeltaMemS

[kudu-CR] WIP: workarounds for el6/krb5 1.10

2016-11-07 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4990 to review the following change. Change subject: WIP: workarounds for el6/krb5 1.10 .. WIP: workarounds for el6/krb5 1.

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 5: Verified+1 Unrelated flake -- To

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() .. Patch Set 2: Code-Review+1 Nit: Is there a reason to keep the same naming convention for HybridClock::

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4930/2/src/kudu/tablet/delta_store.cc

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4930 to look at the new patch set (#3). Change subject: Improve debuggability of the delta/compaction path .. Improve de

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4988 to look at the new patch set (#2). Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Con

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4989 Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() .. Rename LogicalClock::NowForMetrics() to GetCurrentTime(

[kudu-CR] Avoid extra fsyncs of tombstoned tablets during startup

2016-11-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Avoid extra fsyncs of tombstoned tablets during startup .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4915 To unsubscribe, visit

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4988 Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Consolidate Row/CompactionInputRow printing on compact

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4927 to look at the new patch set (#4). Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4927 to look at the new patch set (#3). Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4927/2//COMMIT_MSG Commit Message: > Ni

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

2016-11-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: [python] KUDU-1563. Add support for INSERT IGNORE .. Patch Set 9: This will need a good rebasing, the writeop api has since changed on the python side. -- T

[kudu-CR] [python] - Sync version with main

2016-11-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4987 Change subject: [python] - Sync version with main .. [python] - Sync version with main Now that the python client is pretty much at pa

[kudu-CR] KUDU-1735. Fix crash when aborting a skipped config change round

2016-11-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1735. Fix crash when aborting a skipped config change round .. Patch Set 3: Code-Review+2 (1 comment) Added a nit but the change looks good http://gerrit.clo

[kudu-CR] KUDU-1599. Reject invalid type/encoding pairs on table creation

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation .. KUDU-1599. Reject invalid type/encoding pairs on table creation Change-Id: Ib508dbfbfd5

[kudu-CR] KUDU-1677. Scanners can return out-of-order rows during a compaction

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1677. Scanners can return out-of-order rows during a compaction .. KUDU-1677. Scanners can return out-of-order rows during a compaction This fixes a

[kudu-CR] KUDU-1735. Fix crash when aborting a skipped config change round

2016-11-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1735. Fix crash when aborting a skipped config change round .. Patch Set 3: This looks pretty good to me. I want to do one more pass on it tomorrow. -- To vi

[kudu-CR] KUDU-1599. Reject invalid type/encoding pairs on table creation

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4984 To unsubscribe

[kudu-CR] KUDU-1599. Reject invalid type/encoding pairs on table creation

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4984/1/src/kudu/client/client-tes

[kudu-CR] KUDU-1599. Reject invalid type/encoding pairs on table creation

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation .. KUDU-1599. Reject invalid type/encoding pairs on table creation Change-Id: Ib508dbfbfd574c7c8ccc90

[kudu-CR] KUDU-1599. Reject invalid type/encoding pairs on table creation

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4984/1/src/kudu/client/client-test

[kudu-CR] KUDU-1599. Reject invalid type/encoding pairs on table creation

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4984/1/src/kudu/client/client-test

[kudu-CR] KUDU-1677. Scanners can return out-of-order rows during a compaction

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1677. Scanners can return out-of-order rows during a compaction .. Patch Set 3: Code-Review+2 Oops, meant to +2. -- To view, visit http://gerrit.cloudera.or

[kudu-CR] KUDU-1677. Scanners can return out-of-order rows during a compaction

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1677. Scanners can return out-of-order rows during a compaction .. Patch Set 3: Yea, it did. -- To view, visit http://gerrit.cloudera.org:8080/4983 To unsu

[kudu-CR] KUDU-1677. Scanners can return out-of-order rows during a compaction

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1677. Scanners can return out-of-order rows during a compaction .. Patch Set 3: I presume the new test failed without the fix? -- To view, visit http://gerr

[kudu-CR] Workaround KUDU-1580: bump negotiation timeout to 15sec

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec .. Workaround KUDU-1580: bump negotiation timeout to 15sec KUDU-1580 is a bug where RPC negotiatio

[kudu-CR] KUDU-1677. Scanners can return out-of-order rows during a compaction

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1677. Scanners can return out-of-order rows during a compaction .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4983/3/src/kudu/tablet/table

[kudu-CR] KUDU-1599. Reject invalid type/encoding pairs on table creation

2016-11-07 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4984 to review the following change. Change subject: KUDU-1599. Reject invalid type/encoding pairs on table creation

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/client.h File src/kudu

[kudu-CR] KUDU-1677. Scanners can return out-of-order rows during a compaction

2016-11-07 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Anonymous Coward #80, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4983 to look at the new patch set (#3). Change subject: KUDU-1677. Scanners can return out-of-order rows during a compaction

[kudu-CR] KUDU-1677. Scanners can return out-of-order rows during a compaction

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1677. Scanners can return out-of-order rows during a compaction .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4983/1/src/kudu/tablet/disk

[kudu-CR] KUDU-1677. Scanners can return out-of-order rows during a compaction

2016-11-07 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Anonymous Coward #80, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4983 to look at the new patch set (#2). Change subject: KUDU-1677. Scanners can return out-of-order rows during a compaction

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 4: > The gssapi implementation on macOS uses the system heimdal library. oh, I see. Thanks for the

[kudu-CR] KUDU-1677. Scanners can return out-of-order rows during a compaction

2016-11-07 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Anonymous Coward #80, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4983 to review the following change. Change subject: KUDU-1677. Scanners can return out-of-order rows during a compaction ...

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Misc. fixes for Kerberos compatibility on OS X This commit makes a few changes in order to have better c

[kudu-CR] installation.adoc: Add openssl and Kerberos dependencies

2016-11-07 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: installation.adoc: Add openssl and Kerberos dependencies .. installation.adoc: Add openssl and Kerberos dependencies This adds openssl header and kerberos

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4978/3/src/kudu/rpc/sasl_common.cc File src/kudu/rp

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 3: The gssapi implementation on macOS uses the system heimdal library. -- To view, visit http://gerri

[kudu-CR] Workaround KUDU-1580: bump negotiation timeout to 15sec

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4977 To unsubscribe, vis

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 3: Why do we need to work with Heimdal implementation at all? I though we are about to use MIT impl

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4978/3/src/kudu/rpc/sasl_common.cc File src/kudu/

[kudu-CR] [ssl] disable SSL/TLS compression

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [ssl] disable SSL/TLS compression .. [ssl] disable SSL/TLS compression As for the best recommended practices for SSL/TLS deployment, disable compression

[kudu-CR] installation.adoc: Add openssl and Kerberos dependencies

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: installation.adoc: Add openssl and Kerberos dependencies .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4981 To unsubscribe, visit

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4978 To unsubscribe, visit http://ge

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4978/1/src/kudu/rpc/sasl_rpc-test.cc File src/kudu

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4978 to look at the new patch set (#3). Change subject: Misc. fixes for Kerberos compatibility on OS X .. M

[kudu-CR] [ssl] disable SSL/TLS compression

2016-11-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [ssl] disable SSL/TLS compression .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4962 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] installation.adoc: Add openssl and Kerberos dependencies

2016-11-07 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4981 to review the following change. Change subject: installation.adoc: Add openssl and Kerberos dependencies .. installatio

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4978 to look at the new patch set (#2). Change subject: Misc. fixes for Kerberos compatibility on OS X .

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4978/1/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4978/1//COMMIT_MSG Commit Message: PS1, Line 14:

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4978/1//COMMIT_MSG Commit Message: PS1, Line 14: 2.

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4978/1//COMMIT_MSG Commit Message: PS1, Line 14: 2

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4978/1//COMMIT_MSG Commit Message: PS1, Line 14: 2

[kudu-CR] Avoid extra fsyncs of tombstoned tablets during startup

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid extra fsyncs of tombstoned tablets during startup .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4915/3/src/kudu/tablet/tablet_metadata.cc

[kudu-CR] [OpenSSL] require at least 1.0.0 version

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [OpenSSL] require at least 1.0.0 version .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4937 To unsubscribe, visit http://gerrit.

[kudu-CR] [OpenSSL] require at least 1.0.0 version

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [OpenSSL] require at least 1.0.0 version .. [OpenSSL] require at least 1.0.0 version To build the project, it's necessary to have OpenSSL version 1.0.0 or

[kudu-CR] Workaround KUDU-1580: bump negotiation timeout to 15sec

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec .. Patch Set 1: yea, it would make it take longer if it's down and not responding with 'connection refused

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4978 To unsubscribe, visit http://g

[kudu-CR] Workaround KUDU-1580: bump negotiation timeout to 15sec

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec .. Patch Set 1: Code-Review+2 This doesn't mean all "the other end is down and has been down for a while" s

[kudu-CR] Misc. fixes for Kerberos compatibility on OS X

2016-11-07 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4978 to review the following change. Change subject: Misc. fixes for Kerberos compatibility on OS X .. Misc. fixes for Kerb

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession .. [java client] Redirect KuduExceptions to RowError in KuduSession Currently the only Row

[kudu-CR] Workaround KUDU-1580: bump negotiation timeout to 15sec

2016-11-07 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4977 to review the following change. Change subject: Workaround KUDU-1580: bump negotiation timeout to 15sec .. Workaroun

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4949 To unsubscrib

[kudu-CR] rpc: Add min / max negotiation threads

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: rpc: Add min / max negotiation threads .. rpc: Add min / max negotiation threads Since we use a thread pool for connection negotiation, it would be helpful

[kudu-CR] rpc: Add min / max negotiation threads

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rpc: Add min / max negotiation threads .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4574 To unsubscribe, visit http://gerrit.clo

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/client.h File src/kudu/cl

[kudu-CR] Bump up min negotiation threads in disk reservation-itest

2016-11-07 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Bump up min negotiation threads in disk_reservation-itest .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4575 To unsubscribe, visit http://gerrit.cloudera.o

[kudu-CR] rpc: Add min / max negotiation threads

2016-11-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: rpc: Add min / max negotiation threads .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4574/1//COMMIT_MSG Commit Message: PS1, Line 9: it would b

[kudu-CR] rpc: Add min / max negotiation threads

2016-11-07 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4574 to look at the new patch set (#2). Change subject: rpc: Add min / max negotiation threads .. rpc: Add min / max neg

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/write_op_stats.h File

[kudu-CR] [python] - Expand KuduError capabilities

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [python] - Expand KuduError capabilities .. [python] - Expand KuduError capabilities The Python client currently doesn't support the full error rep

[kudu-CR] KUDU-1690 - [python] Enable setting of default values

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1690 - [python] Enable setting of default values .. KUDU-1690 - [python] Enable setting of default values This patch enables the python client

[kudu-CR] [python] - Expand KuduError capabilities

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [python] - Expand KuduError capabilities .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4885 To unsubscribe, visit http://

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/4974/2/src/kudu/client/write_op_s

[kudu-CR] [python] - Expand KuduError capabilities

2016-11-07 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4885 to look at the new patch set (#2). Change subject: [python] - Expand KuduError capabilities .. [python] - Expand Ku

[kudu-CR] [python] - Expand KuduError capabilities

2016-11-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: [python] - Expand KuduError capabilities .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4885/1/python/kudu/tests/test_client.py File python/k

[kudu-CR] KUDU-1690 - [python] Enable setting of default values

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1690 - [python] Enable setting of default values .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4818 To unsubscribe,

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: > Alexey, thanks for doing this. As we discussed, one of the issues > Impala faces is that the

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4974/2//COMMIT_MSG Commit Message: PS2, Line

[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions .. KUDU-1648 - [python] Expose Setting of Range Partitions Currently, the Python client doe

[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4795 To unsubscribe

[kudu-CR] [python] - Expose additional scanner methods

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [python] - Expose additional scanner methods .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4888 To unsubscribe, visit htt

[kudu-CR] [python] - Expose additional scanner methods

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [python] - Expose additional scanner methods .. [python] - Expose additional scanner methods This patch exposes a few remaining scanner methods fro

[kudu-CR] [python] - Expand KuduError capabilities

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [python] - Expand KuduError capabilities .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4885/1/python/kudu/tests/test_client.py File pytho

[kudu-CR] [rpc] Close socket on non-linux platforms during RPC shutdown

2016-11-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown .. Patch Set 2: (2 comments) TFTR Mike. http://gerrit.cloudera.org:8080/#/c/4958/1/src/kudu/rpc/acc

[kudu-CR] [rpc] Close socket on non-linux platforms during RPC shutdown

2016-11-07 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4958 to look at the new patch set (#2). Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown .

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4949 to look at the new patch set (#4). Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession

[kudu-CR] Reject CREATE TABLE ops with even replication factor

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Reject CREATE TABLE ops with even replication factor .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4945/4/src/kudu/integration-tests/delete_t

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: Alexey, thanks for doing this. As we discussed, one of the issues Impala faces is that the er

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4949/3/java/kudu-client/sr

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4949/3/java/kudu-client/src/ma

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4974/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4974/2//COMMIT_MSG Commit Message: PS2, Line

[kudu-CR] [rpc] Close socket on non-linux platforms during RPC shutdown

2016-11-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown .. Patch Set 1: Code-Review+1 (2 comments) lgtm http://gerrit.cloudera.org:8080/#/c/4958/1/src/kudu/

  1   2   >