[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [doc] 1.1.0 release notes for tools .. [doc] 1.1.0 release notes for tools Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a Reviewed-on: http://gerrit.

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5012/3/docs/release_notes.adoc File docs/release_

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4988/3/src/kudu/tablet/com

[kudu-CR] [java] Add checkstyle coverage to Java build

2016-11-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [java] Add checkstyle coverage to Java build .. Patch Set 1: > Build Failed > > http://104.196.14.100/job/kudu-gerrit/4416/ : FAILURE Failure looks like a fl

[kudu-CR] [java] Add checkstyle coverage to Java build

2016-11-08 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/5016 Change subject: [java] Add checkstyle coverage to Java build .. [java] Add checkstyle coverage to Java build This patch introduces the M

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() .. Patch Set 3: > Dinesh: Yeah I saw that and I pondered what you are suggesting. > Ended up not doing it

[kudu-CR] Reject CREATE TABLE ops with even replication factor

2016-11-08 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4945 to look at the new patch set (#5). Change subject: Reject CREATE TABLE ops with even replication factor .. Reject C

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4930/3//COMMIT_MSG Commit Message: PS

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4930 to look at the new patch set (#4). Change subject: Improve debuggability of the delta/compaction path .. Improve de

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4988 to look at the new patch set (#3). Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Con

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4927 to look at the new patch set (#5). Change subject: Add a macro to LOG and return on a non-OK status .. Add a macro

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5012 to look at the new patch set (#4). Change subject: [doc] 1.1.0 release notes for tools .

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5012/3/docs/release_notes.adoc File docs/release_notes.adoc:

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 .. Patch Set 5: > > But now we're stretching ourselves to accommodate el6's libkrb5. > Does libkrb5 also receiv

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4988/2/src/kudu/tablet/compactio

[kudu-CR] [doc] updated release notes for Kudu C++ client

2016-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [doc] updated release notes for Kudu C++ client .. [doc] updated release notes for Kudu C++ client Change-Id: If4667dc7bb90fdf910c06a9107ce41f1ac3d7037

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 .. Patch Set 5: > But now we're stretching ourselves to accommodate el6's libkrb5. Does libkrb5 > also receive

[kudu-CR] Allow binaries built on el6.6+ to run on el6.4

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Allow binaries built on el6.6+ to run on el6.4 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5011/1/thirdparty/download-thirdparty.sh File third

[kudu-CR] [doc] updated release notes for Kudu C++ client

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [doc] updated release notes for Kudu C++ client .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5006 To unsubscribe, visit http://g

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4927/4/src/kudu/util/status.h File src/ku

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 .. Patch Set 5: (6 comments) It makes sense to stretch ourselves to accommodate various openssl versions, beca

[kudu-CR] Allow binaries built on el6.6+ to run on el6.4

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow binaries built on el6.6+ to run on el6.4 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5011/1/thirdparty/download-thirdparty.sh File thir

[kudu-CR] webserver: improve SSL certificate handling

2016-11-08 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5015 to review the following change. Change subject: webserver: improve SSL certificate handling .. webserver: improve SSL

[kudu-CR] [doc] updated release notes for Kudu C++ client

2016-11-08 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5006 to look at the new patch set (#4). Change subject: [doc] updated release notes for Kudu C++ client .. [doc] updated

[kudu-CR] [doc] updated release notes for Kudu C++ client

2016-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [doc] updated release notes for Kudu C++ client .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5006/3/docs/release_notes.adoc File docs/release

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type() .. Unbreak the build: Pull RowChangelistEncoder::get_type() Misordered push of 3c68deacc0

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4990/5/src/kudu/security/init.cc File src/k

[kudu-CR] Allow binaries built on el6.6+ to run on el6.4

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Allow binaries built on el6.6+ to run on el6.4 .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5011/1/thirdparty/download-thirdparty.sh File third

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5012/3/docs/release_notes.adoc File docs/release_notes.adoc:

[kudu-CR] [doc] updated release notes for Kudu C++ client

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [doc] updated release notes for Kudu C++ client .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5006/3/docs/release_notes.adoc File docs/release_no

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5012/2/docs/release_notes.adoc File docs/release_notes.adoc:

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Release notes for the Java client in 1.1 .. Patch Set 3: Code-Review+2 Leaving unmerged in case David wants to take another look. -- To view, visit http://gerrit.

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5012 to look at the new patch set (#3). Change subject: [doc] 1.1.0 release notes for tools .. [doc]

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5013 To unsubscrib

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type() .. Unbreak the build: Pull RowChangelistEncoder::get_type() Misordered push of 3c68deacc05f6b5a9b825

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5012/2/docs/release_notes.adoc File docs/release_notes

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5013 Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type() .. Unbreak the build: Pull RowChangelistEncoder::get_type(

[kudu-CR] ubsan: use our own libstdcxx

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: ubsan: use our own libstdcxx .. Abandoned ok, let's not worry about it then. abandoning. -- To view, visit http://gerrit.cloudera.org:8080/2904 To unsubscribe, visit http

[kudu-CR] ubsan: use our own libstdcxx

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: ubsan: use our own libstdcxx .. Patch Set 2: > I don't think we need this anymore, right? Or if we want to do it, > we should probably just use the libc++ that we

[kudu-CR] [doc] updated release notes for Kudu C++ client

2016-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [doc] updated release notes for Kudu C++ client .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5006/2/docs/release_notes.adoc File docs/releas

[kudu-CR] [doc] updated release notes for Kudu C++ client

2016-11-08 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5006 to look at the new patch set (#3). Change subject: [doc] updated release notes for Kudu C++ client .. [doc] updated

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5012 to look at the new patch set (#2). Change subject: [doc] 1.1.0 release notes for tools .. [doc]

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 1: (2 comments) I also added couple of more tools which got pushed few minutes ago. http://gerrit.cloudera.org:8

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 5: (1 comment) http://gerrit.cloudera.

[kudu-CR] Rename LogicalClock::NowForMetrics() to GetCurrentTime()

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Rename LogicalClock::NowForMetrics() to GetCurrentTime() .. Patch Set 2: Dinesh: Yeah I saw that and I pondered what you are suggesting. Ended up not doin

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4930/3//COMMIT_MSG Commit Message: PS3

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4988/2/src/kudu/tablet/compaction

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4993/2/src/kudu

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4990/5/src/kudu/security/init.cc File src/kudu

[kudu-CR] Add a macro to LOG and return on a non-OK status

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a macro to LOG and return on a non-OK status .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4927/4/src/kudu/util/status.h File src/kudu/util/

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, John Russell, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5002 to look at the new patch set (#3). Change subject: Release notes for the Java client in 1.1 ..

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [tools] Manual recovery tools (part 1) .. [tools] Manual recovery tools (part 1) This change introduces two recovery tools: 1) 'kudu remote_replica copy

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Release notes for the Java client in 1.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc File docs/release_n

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Release notes for the Java client in 1.1 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc File docs/release_notes.ad

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4990/5/src/kudu/security/init.cc File src/ku

[kudu-CR] ubsan: use our own libstdcxx

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ubsan: use our own libstdcxx .. Patch Set 2: I don't think we need this anymore, right? Or if we want to do it, we should probably just use the libc++ that we are

[kudu-CR] Account for REINSERTs in delta stats

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Account for REINSERTs in delta stats .. Account for REINSERTs in delta stats This makes DeltaStats also account for REINSERTs. This is not actuall

[kudu-CR] Add IN LIST release notes

2016-11-08 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Add IN LIST release notes .. Add IN LIST release notes Change-Id: I61a6a1871098a3252e09556ab510ca9693d14d74 Reviewed-on: http://gerrit.cloudera.org:8080/5

[kudu-CR] Enforce that REINSERTs are not supported in DeltaMemStores

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Enforce that REINSERTs are not supported in DeltaMemStores .. Enforce that REINSERTs are not supported in DeltaMemStores We never really supported

[kudu-CR] Add IN LIST release notes

2016-11-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add IN LIST release notes .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5010 To unsubscribe, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Add IN LIST release notes

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add IN LIST release notes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5010 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] Account for REINSERTs in delta stats

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Account for REINSERTs in delta stats .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4932 To unsubscribe, visit http://gerr

[kudu-CR] Add IN LIST release notes

2016-11-08 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#2). Change subject: Add IN LIST release notes .. Add IN LIST release notes Change-Id: I61a6a1871098a3252e09556ab510ca9693d14d74 --- M docs/release_notes.adoc 1 file changed, 4 insertion

[kudu-CR] [rpc] fixed misprint in RegisterConnection

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [rpc] fixed misprint in RegisterConnection .. [rpc] fixed misprint in RegisterConnection Fixed misprint in ReactorThread::RegisterConnection: do not put a

[kudu-CR] Add IN LIST release notes

2016-11-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add IN LIST release notes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5010/1/docs/release_notes.adoc File docs/release_notes.adoc: PS1, Line

[kudu-CR] Enforce that REINSERTs are not supported in DeltaMemStores

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Enforce that REINSERTs are not supported in DeltaMemStores .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4991 To unsubscr

[kudu-CR] [rpc] fixed misprint in RegisterConnection

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [rpc] fixed misprint in RegisterConnection .. Patch Set 1: Code-Review+2 nah, that's OK. I missed that it is ref-counted and thus it doesn't cause a crash (and he

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4834 To unsubscribe, visit http://gerrit.cl

[kudu-CR] Add IN LIST release notes

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add IN LIST release notes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5010/1/docs/release_notes.adoc File docs/release_notes.adoc: PS1

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4990 To unsubscribe, visit htt

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5012/1/docs/release_notes.adoc File docs/release_notes

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Workaround test failures running with MIT krb5 1.10 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4990/4/src/kudu/security/test/krb5_realm_overr

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: macOS: fix compile error introduced by 141de3377e6bdd .. macOS: fix compile error introduced by 141de3377e6bdd Change-Id: Id2a9556810feeb3128b97d60afb18a2

[kudu-CR] Workaround test failures running with MIT krb5 1.10

2016-11-08 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4990 to look at the new patch set (#5). Change subject: Workaround test failures running with MIT krb5 1.10 .. Workaroun

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, John Russell, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5002 to look at the new patch set (#2). Change subject: Release notes for the Java client in 1.1 ..

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Release notes for the Java client in 1.1 .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc File docs/release_

[kudu-CR] Allow binaries built on el6.6+ to run on el6.4

2016-11-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Allow binaries built on el6.6+ to run on el6.4 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5011 To unsubscribe, visit http://g

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5012 to review the following change. Change subject: [doc] 1.1.0 release notes for tools .. [doc] 1.1.0 release note

[kudu-CR] Allow binaries built on el6.6+ to run on el6.4

2016-11-08 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5011 to review the following change. Change subject: Allow binaries built on el6.6+ to run on el6.4 .. Allow binaries built

[kudu-CR] [doc] updated release notes for Kudu C++ client

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [doc] updated release notes for Kudu C++ client .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5006/2/docs/release_notes.adoc File docs/release_n

[kudu-CR] Add IN LIST release notes

2016-11-08 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5010 to review the following change. Change subject: Add IN LIST release notes .. Add IN LIST release notes Change-

[kudu-CR] WIP: workarounds for el6/krb5 1.10

2016-11-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP: workarounds for el6/krb5 1.10 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4990/4/src/kudu/security/test/krb5_realm_override.cc File src/k

[kudu-CR] [doc] updated release notes for Kudu C++ client

2016-11-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [doc] updated release notes for Kudu C++ client .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5006/1/docs/release_notes.adoc File docs/releas

[kudu-CR] [doc] updated release notes for Kudu C++ client

2016-11-08 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5006 to look at the new patch set (#2). Change subject: [doc] updated release notes for Kudu C++ client .. [doc] updated

[kudu-CR] [c++ client] implemented session operations stats

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4974/3//COMMIT_MSG Commit Message: PS3

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Release notes for the Java client in 1.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc File docs/release_

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: macOS: fix compile error introduced by 141de3377e6bdd .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5009 To unsubscribe, visit h

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

2016-11-08 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5009 to look at the new patch set (#2). Change subject: macOS: fix compile error introduced by 141de3377e6bdd .. macOS: f

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

2016-11-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: macOS: fix compile error introduced by 141de3377e6bdd .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5009/1/src/kudu/integration-tests/external_m

[kudu-CR] macOS: fix Kerberos tests where possible

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: macOS: fix Kerberos tests where possible .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5005/1/src/kudu/rpc/sasl_rpc-test.cc File src/kudu/rpc/sa

[kudu-CR] WIP: workarounds for el6/krb5 1.10

2016-11-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP: workarounds for el6/krb5 1.10 .. Patch Set 3: Awesome, this is looking a lot better. CI linker issues look legit. -- To view, visit http://gerrit.cloudera.

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

2016-11-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 11: (3 comments) only nits and one possible patch split. Could you address the tidy bot nits? Thank

[kudu-CR] WIP: workarounds for el6/krb5 1.10

2016-11-08 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4990 to look at the new patch set (#4). Change subject: WIP: workarounds for el6/krb5 1.10 .. WIP: workarounds for el6/k

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: macOS: fix compile error introduced by 141de3377e6bdd .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5009 To unsubscribe, visit h

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

2016-11-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: macOS: fix compile error introduced by 141de3377e6bdd .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5009/1/src/kudu/integration-tests/external_m

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: macOS: fix compile error introduced by 141de3377e6bdd .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5009/1/src/kudu/integration-tests/external_mi

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#4). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. K

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-08 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4996 to look at the new patch set (#3). Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to fuzz-i

[kudu-CR] KUDU-1634. TS and MS should delete tmp metadata files on startup

2016-11-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1634. TS and MS should delete tmp metadata files on startup .. Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/5007/1//COMMIT_MSG Commit Messag

[kudu-CR] macOS: fix compile error introduced by 141de3377e6bdd

2016-11-08 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5009 to review the following change. Change subject: macOS: fix compile error introduced by 141de3377e6bdd .. m

  1   2   >