[kudu-CR] KUDU-1753 [delete table-test] deleted-while-scanned test

Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5345/1//COMMIT_MSG Commit Message: PS1

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-scanned test

Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test .. Patch Set 1: (10 comments) Thank you for the review. http://gerrit.cloudera.org:8080/#/c/5345/1/src

[kudu-CR] [i-tests] TestWorkload::set num tablets() accepts 1

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5347 Change subject: [i-tests] TestWorkload::set_num_tablets() accepts 1 .. [i-tests] TestWorkload::set_num_tablets() accepts 1 Fixed typo in

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-scanned test

Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5345/2/src/kudu/integration-tests/delet

[kudu-CR] KUDU-1753 [tablet service] continue scan request on deleted tablet

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [tablet_service] continue scan request on deleted tablet .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5346/2/src/kudu/tserve

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-scanned test

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test .. Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/5345/1/src/kudu/integration-tes

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-scanned test

Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5345/2/src/kudu/integration-tests/dele

[kudu-CR] KUDU-1753 [tablet service] continue scan request on deleted tablet

Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [tablet_service] continue scan request on deleted tablet .. Patch Set 2: > Alexey, just thinking out loud here: Tablet not found in the JIRA > corre

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-scanned test

Dinesh Bhat has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5345/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] KUDU-1753 [tablet service] continue scan request on deleted tablet

Dinesh Bhat has posted comments on this change. Change subject: KUDU-1753 [tablet_service] continue scan request on deleted tablet .. Patch Set 2: Alexey, just thinking out loud here: Tablet not found in the JIRA corresponds

[kudu-CR] KUDU-1753 [tablet service] continue scan request on deleted tablet

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5346 to look at the new patch set (#2). Change subject: KUDU-1753 [tablet_service] continue scan request on deleted tablet .

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-scanned test

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5345 to look at the new patch set (#3). Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test .. KUDU

[kudu-CR] KUDU-1753 [tablet service] continue scan request on deleted tablet

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5346 Change subject: KUDU-1753 [tablet_service] continue scan request on deleted tablet .. KUDU-1753 [tablet_service] continue scan request o

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-scanned test

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5345 Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test .. KUDU-1753 [delete_table-test] deleted-while-scanned test Add

[kudu-CR] WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement

Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-798 (part 4) Add a TimeManager to manage safe time advancement .. Patch Set 7: (20 comments) http://gerrit.cloudera.org:8080/#/c/5300/7/src/kudu/consen

[kudu-CR] WIP: KUDU-798 (part 3) Replica transactions must start/abort on the consensus update thread

David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-798 (part 3) Replica transactions must start/abort on the consensus update thread .. Patch Set 12: no, I'll clean this up and run the dist-tests

[kudu-CR] raft consensus: avoid some unecessary allocations in hot path

Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5344 to review the following change. Change subject: raft_consensus: avoid some unecessary allocations in hot path .. raft_c

[kudu-CR] WIP: KUDU-798 (part 3) Replica transactions must start/abort on the consensus update thread

Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-798 (part 3) Replica transactions must start/abort on the consensus update thread .. Patch Set 13: (1 comment) k, i like this approach more. BTW is the

[kudu-CR] raft consensus-itest: add a test for a potential deadlock

David Ribeiro Alves has submitted this change and it was merged. Change subject: raft_consensus-itest: add a test for a potential deadlock .. raft_consensus-itest: add a test for a potential deadlock This adds a test case where

[kudu-CR] raft consensus-itest: add a test for a potential deadlock

David Ribeiro Alves has posted comments on this change. Change subject: raft_consensus-itest: add a test for a potential deadlock .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5341 To unsubscr

[kudu-CR] WIP: KUDU-798 (part 3) Replica transactions must start/abort on the consensus update thread

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5294 to look at the new patch set (#13). Change subject: WIP: KUDU-798 (part 3) Replica transactions must start/abort on the consensus update thread ...

[kudu-CR] Add file globbing to Env

Adar Dembo has posted comments on this change. Change subject: Add file globbing to Env .. Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/5338/1/src/kudu/integration-tests/external_mini_cluster_fs_

[kudu-CR] KUDU-766: limit number of glog files

Adar Dembo has posted comments on this change. Change subject: KUDU-766: limit number of glog files .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/5340/1/src/kudu/integration-tests/external_mini_cluster.cc F

[kudu-CR] Add file globbing to Env

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5338 to look at the new patch set (#2). Change subject: Add file globbing to Env .. Add file globbing to Env Change-Id:

[kudu-CR] KUDU-766: limit number of glog files

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5340 to look at the new patch set (#2). Change subject: KUDU-766: limit number of glog files .. KUDU-766: limit number o

[kudu-CR] Add file modified time to Env

Adar Dembo has posted comments on this change. Change subject: Add file modified time to Env .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5339/1/src/kudu/util/env-test.cc File src/kudu/util/env-test.cc: PS

[kudu-CR] Add file globbing to Env

Adar Dembo has posted comments on this change. Change subject: Add file globbing to Env .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5338/1/src/kudu/integration-tests/external_mini_cluster_fs_inspector.cc F

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-625 - Make write transactions abort in mvcc, by default .. KUDU-625 - Make write transactions abort in mvcc, by default This patch addresses

[kudu-CR] Allow to get a MonoDelta from two Timestamps

David Ribeiro Alves has submitted this change and it was merged. Change subject: Allow to get a MonoDelta from two Timestamps .. Allow to get a MonoDelta from two Timestamps This adds a new method to Clock: MonoDelta GetPhysica

[kudu-CR] KUDU-798 (part 3) Replica transactions must start/abort on the consensus update thread

Todd Lipcon has posted comments on this change. Change subject: KUDU-798 (part 3) Replica transactions must start/abort on the consensus update thread .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/5294/12/s

[kudu-CR] raft consensus-itest: add a test for a potential deadlock

Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5341 to review the following change. Change subject: raft_consensus-itest: add a test for a potential deadlock .. r

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

Todd Lipcon has posted comments on this change. Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5321/4/src/kudu/util

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

Adar Dembo has posted comments on this change. Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/5321/4/src/kudu/util

[kudu-CR] Add file modified time to Env

Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5339 to review the following change. Change subject: Add file modified time to Env .. Add file modified time to

[kudu-CR] KUDU-766: limit number of glog files

Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5340 to review the following change. Change subject: KUDU-766: limit number of glog files .. KUDU-766: limit nu

[kudu-CR] Add file globbing to Env

Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5338 to review the following change. Change subject: Add file globbing to Env .. Add file globbing to Env Chan

[kudu-CR] KUDU-798 (part 3) Replica transactions must start/abort on the consensus update thread

Todd Lipcon has posted comments on this change. Change subject: KUDU-798 (part 3) Replica transactions must start/abort on the consensus update thread .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/5294/12/s

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

Todd Lipcon has posted comments on this change. Change subject: KUDU-625 - Make write transactions abort in mvcc, by default .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5320 To unsubscribe,

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Todd Lipcon has posted comments on this change. Change subject: Allow to get a MonoDelta from two Timestamps .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5304 To unsubscribe, visit http://ger

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5321 to look at the new patch set (#5). Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads ...

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

Todd Lipcon has posted comments on this change. Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads .. Patch Set 4: (32 comments) http://gerrit.cloudera.org:8080/#/c/5321/4/src/kudu/ut

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

Alexey Serbin has posted comments on this change. Change subject: KUDU-625 - Make write transactions abort in mvcc, by default .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5320 To unsubscribe

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Alexey Serbin has posted comments on this change. Change subject: Allow to get a MonoDelta from two Timestamps .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5304 To unsubscribe, visit http://g

[kudu-CR] Allow to get a MonoDelta from two Timestamps

David Ribeiro Alves has posted comments on this change. Change subject: Allow to get a MonoDelta from two Timestamps .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5304/8/src/kudu/server/hybrid_clock-test.cc

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5304 to look at the new patch set (#9). Change subject: Allow to get a MonoDelta from two Timestamps .. Allow to get a M

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5320 to look at the new patch set (#7). Change subject: KUDU-625 - Make write transactions abort in mvcc, by default .

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Alexey Serbin has posted comments on this change. Change subject: Allow to get a MonoDelta from two Timestamps .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5304/8/src/kudu/server/hybrid_clock-test.cc File s

[kudu-CR] Remove the clock from MvccManager

Alexey Serbin has posted comments on this change. Change subject: Remove the clock from MvccManager .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5326/2/src/kudu/tablet/mvcc-test.cc File src/kudu/tablet/mvcc

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-625 - Make write transactions abort in mvcc, by default .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5320/5//COMMIT_MSG Commit Me

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-625 - Make write transactions abort in mvcc, by default .. Patch Set 5: fixed typos, keeping the +1 -- To view, visit http://gerrit.cloudera.org:808

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5304 to look at the new patch set (#8). Change subject: Allow to get a MonoDelta from two Timestamps .. Allow to get a M

[kudu-CR] Allow to get a MonoDelta from two Timestamps

David Ribeiro Alves has posted comments on this change. Change subject: Allow to get a MonoDelta from two Timestamps .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5304/3/src/kudu/server/hybrid_clock-test.cc

[kudu-CR] WIP: KUDU-798 (part 5) Safe time advancement in the absense of writes

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#21). Change subject: WIP: KUDU-798 (part 5) Safe time advancement in the absense of writes .

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5304 to look at the new patch set (#7). Change subject: Allow to get a MonoDelta from two Timestamps .. Allow to get a M

[kudu-CR] KUDU-625 - Make write transactions abort in mvcc, by default

Alexey Serbin has posted comments on this change. Change subject: KUDU-625 - Make write transactions abort in mvcc, by default .. Patch Set 5: Code-Review+1 (2 comments) Just a couple of nits in the commit message, otherwise l

[kudu-CR] [flaky tests] Fix "Already present" failures on raft consensus-itest

David Ribeiro Alves has submitted this change and it was merged. Change subject: [flaky tests] Fix "Already present" failures on raft_consensus-itest .. [flaky tests] Fix "Already present" failures on raft_consensus-itest In t

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Alexey Serbin has posted comments on this change. Change subject: Allow to get a MonoDelta from two Timestamps .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5304/3/src/kudu/server/hybrid_clock-test.cc File s

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

Alexey Serbin has posted comments on this change. Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/5321/4/src/kudu/u

[kudu-CR] [flaky tests] Fix "Already present" failures on raft consensus-itest

David Ribeiro Alves has posted comments on this change. Change subject: [flaky tests] Fix "Already present" failures on raft_consensus-itest .. Patch Set 4: Code-Review+2 (5 comments) keeping Todd's +2 http://gerrit.cloudera

[kudu-CR] [flaky tests] Fix "Already present" failures on raft consensus-itest

Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5319 to look at the new patch set (#4). Change subject: [flaky tests] Fix "Already present" failures on raft_consensus-itest ..

[kudu-CR] client: throttle some warning messages when lookup RPCs fail

Adar Dembo has posted comments on this change. Change subject: client: throttle some warning messages when lookup RPCs fail .. Patch Set 1: (2 comments) There are some similar LOG() calls in SyncLeaderMasterRpc that you may wa

[kudu-CR] Allow to get a MonoDelta from two Timestamps

David Ribeiro Alves has posted comments on this change. Change subject: Allow to get a MonoDelta from two Timestamps .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5304/4/src/kudu/server/hybrid_clock-test.cc F

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5304 to look at the new patch set (#6). Change subject: Allow to get a MonoDelta from two Timestamps .. Allow to get a M

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5304 to look at the new patch set (#5). Change subject: Allow to get a MonoDelta from two Timestamps .. Allow to get a M

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

Adar Dembo has posted comments on this change. Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads .. Patch Set 4: (29 comments) http://gerrit.cloudera.org:8080/#/c/5321/4/src/kudu/uti

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Todd Lipcon has posted comments on this change. Change subject: Allow to get a MonoDelta from two Timestamps .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5304/4/src/kudu/server/hybrid_clock-test.cc File src/

[kudu-CR] [flaky tests] Fix "Already present" failures on raft consensus-itest

Todd Lipcon has posted comments on this change. Change subject: [flaky tests] Fix "Already present" failures on raft_consensus-itest .. Patch Set 3: Code-Review+2 (2 comments) lgtm modulo typos http://gerrit.cloudera.org:808

[kudu-CR] Allow to build a MonoTime from a MonoDelta

David Ribeiro Alves has abandoned this change. Change subject: Allow to build a MonoTime from a MonoDelta .. Abandoned abandoning this for a better solution -- To view, visit http://gerrit.cloudera.org:8080/5325 To unsubscrib

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

David Ribeiro Alves has restored this change. Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. Restored oops abandoned wrong patch -- To view, visit http://gerrit.cloudera.org:8080/5305 To uns

[kudu-CR] client: throttle some warning messages when lookup RPCs fail

Hello Matthew Jacobs, Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5332 to review the following change. Change subject: client: throttle some warning messages when lookup RPCs fail

[kudu-CR] Allow to get a MonoDelta from two Timestamps

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5304 to look at the new patch set (#4). Change subject: Allow to get a MonoDelta from two Timestamps .. Allow to get a M

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

David Ribeiro Alves has abandoned this change. Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. Abandoned decided to go another way -- To view, visit http://gerrit.cloudera.org:8080/5305 To un

[kudu-CR] Allow to build a MonoTime from a MonoDelta

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5325 to look at the new patch set (#4). Change subject: Allow to build a MonoTime from a MonoDelta .. Allow to build a M

[kudu-CR] Allow to build a MonoTime from a MonoDelta

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5325 to look at the new patch set (#3). Change subject: Allow to build a MonoTime from a MonoDelta .. Allow to build a M

[kudu-CR] util: add file cache

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5146 to look at the new patch set (#8). Change subject: util: add file cache .. util: add file cache This commit introd

[kudu-CR] Allow to build a MonoTime from a MonoDelta

Alexey Serbin has posted comments on this change. Change subject: Allow to build a MonoTime from a MonoDelta .. Patch Set 2: > the point is to be able to get a monotime from the hybrid clock > like in here: > https://gerrit.

[kudu-CR] util: add file cache

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5146 to look at the new patch set (#7). Change subject: util: add file cache .. util: add file cache This commit introd

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

Alexey Serbin has posted comments on this change. Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5305/3/src/kudu/consensus/time_ma

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1752 C++ client error memory should be bounded .. KUDU-1752 C++ client error memory should be bounded Added KuduSession::SetErrorBufferSpace() method

[kudu-CR] KUDU-1752 C++ client error memory should be bounded

Adar Dembo has posted comments on this change. Change subject: KUDU-1752 C++ client error memory should be bounded .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5308 To unsubscribe, visit http

[kudu-CR] WIP KUDU-1127 Don't hang scanner threads waiting for safe time

Alexey Serbin has posted comments on this change. Change subject: WIP KUDU-1127 Don't hang scanner threads waiting for safe time .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5305/3/src/kudu/consensus/time_m

[kudu-CR] [catalog manager] removed unused variable

Adar Dembo has posted comments on this change. Change subject: [catalog_manager] removed unused variable .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5331 To unsubscribe, visit http://gerrit.

[kudu-CR] [catalog manager] removed unused variable

Adar Dembo has submitted this change and it was merged. Change subject: [catalog_manager] removed unused variable .. [catalog_manager] removed unused variable This patch does not contain any functional changes. Change-Id: I6df

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5321 to look at the new patch set (#4). Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads ...

[kudu-CR] KUDU-695. Avoid glog contention by deferring log writes to dedicated threads

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5321 to look at the new patch set (#3). Change subject: KUDU-695. Avoid glog contention by deferring log writes to dedicated threads ...

[kudu-CR] [flaky tests] Fix "Already present" failures on raft consensus-itest

Alexey Serbin has posted comments on this change. Change subject: [flaky tests] Fix "Already present" failures on raft_consensus-itest .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5319/3//COMMIT_MSG Commit

[kudu-CR] [flaky tests] Fix "Already present" failures on raft consensus-itest

Alexey Serbin has posted comments on this change. Change subject: [flaky tests] Fix "Already present" failures on raft_consensus-itest .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5319/3//COMMIT_MSG Commit

[kudu-CR] [catalog manager] removed unused variable

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5331 Change subject: [catalog_manager] removed unused variable .. [catalog_manager] removed unused variable This patch does not contain any f

[kudu-CR] Allow to build a MonoTime from a MonoDelta

David Ribeiro Alves has posted comments on this change. Change subject: Allow to build a MonoTime from a MonoDelta .. Patch Set 2: the point is to be able to get a monotime from the hybrid clock like in here: https://gerrit.cl

[kudu-CR] KUDU-1778. Fix LMP mismatch behavior after a replica restarts

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1778. Fix LMP mismatch behavior after a replica restarts .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5309/4/src/kudu/consensus/co

[kudu-CR] KUDU-1778. Fix LMP mismatch behavior after a replica restarts

Todd Lipcon has posted comments on this change. Change subject: KUDU-1778. Fix LMP mismatch behavior after a replica restarts .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5309/4/src/kudu/consensus/consensus_

[kudu-CR] Allow to build a MonoTime from a MonoDelta

Alexey Serbin has posted comments on this change. Change subject: Allow to build a MonoTime from a MonoDelta .. Patch Set 2: > so that we can build a monotime from a timestamp (like the physical > part of a timestamp) and use

[kudu-CR] KUDU-1778. Fix LMP mismatch behavior after a replica restarts

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1778. Fix LMP mismatch behavior after a replica restarts .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5309/4/src/kudu/consensus/co

[kudu-CR] java tests: Also search for build bindir from cwd

Dan Burkert has posted comments on this change. Change subject: java tests: Also search for build bindir from cwd .. Patch Set 1: No, the concern is that developers will unwittingly run tests against a version of kudu-client i

[kudu-CR] KUDU-1778. Fix LMP mismatch behavior after a replica restarts

Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1778. Fix LMP mismatch behavior after a replica restarts .. KUDU-1778. Fix LMP mismatch behavior after a replica restarts This fixes an issue seen in

[kudu-CR] flume sink: Fix jar shading

Mike Percy has posted comments on this change. Change subject: flume sink: Fix jar shading .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5327/1/java/kudu-flume-sink/pom.xml File java/kudu-flume-sink/pom.xml:

[kudu-CR] java tests: Also search for build bindir from cwd

Mike Percy has posted comments on this change. Change subject: java tests: Also search for build bindir from cwd .. Patch Set 1: Is the concern w/ this patch that we will somehow merge something broken? If so, doesn't jenkins

[kudu-CR] java tests: Also search for build bindir from cwd

Mike Percy has posted comments on this change. Change subject: java tests: Also search for build bindir from cwd .. Patch Set 1: This patch allows the following pattern: $ mvn clean install -pl kudu-flume-sink -am -DskipTests

[kudu-CR] java tests: Remove duplicate "Starting masters" message

Mike Percy has submitted this change and it was merged. Change subject: java tests: Remove duplicate "Starting masters" message .. java tests: Remove duplicate "Starting masters" message This message is printed twice when tests

[kudu-CR] flume sink: Fix jar shading

Dan Burkert has posted comments on this change. Change subject: flume sink: Fix jar shading .. Patch Set 1: woops - sorry I didn't realize this was merged already. None of my comments are critical -- To view, visit http://g

  1   2   >