[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-07 Thread Yanlong Zheng (Code Review)
Yanlong Zheng has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/523

[kudu-CR] KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set

2016-12-07 Thread Yanlong Zheng (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5237 to look at the new patch set (#4). Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set .

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5403 to look at the new patch set (#4). Change subject: KUDU-1508: enforce block limit on lbm containers .. KUDU-1508: e

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5403/3/src/kudu/fs/log_block_manager.cc File src/

[kudu-CR] KUDU-1524. Add a workaround for unflushable large cells

2016-12-07 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5282 to look at the new patch set (#2). Change subject: KUDU-1524. Add a workaround for unflushable large cells .. KUDU-

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798 (part 5) Correct safe time advancement This patch fixes safe time advancement in gener

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 34: Verified+1 overriding jenkins, all tests passed but debug build failed due to: 05:06:31 A

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5403/3/src/kudu/fs/log_block_manager.cc File src

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 34: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5240 To unsubscribe, visit http:/

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#34). Change subject: KUDU-798 (part 5) Correct safe time advancement ..

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5403 to look at the new patch set (#3). Change subject: KUDU-1508: enforce block limit on lbm containers .. KUDU-1508: e

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5403/2/src/kudu/fs/data_dirs.cc File src/kudu/fs/

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 33: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5240 To unsubscribe, visit http:/

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#33). Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798 (pa

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 32: (35 comments) http://gerrit.cloudera.org:8080/#/c/5240/32//COMMIT_MSG Commit Message: PS

[kudu-CR] [docs] Add missing krb deps to the SLES12 and Ubuntu instructions

2016-12-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [docs] Add missing krb deps to the SLES12 and Ubuntu instructions .. [docs] Add missing krb deps to the SLES12 and Ubuntu instructions Change-Id:

[kudu-CR] [docs] - Fix python development section location

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [docs] - Fix python development section location .. [docs] - Fix python development section location The Python Client section on the development is wedge

[kudu-CR] [docs] - Fix python development section location

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [docs] - Fix python development section location .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5414 To unsubscribe, visit http:/

[kudu-CR] [docs] - Fix python development section location

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [docs] - Fix python development section location .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5414 To unsubscribe, visit http://ge

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5399 To unsubscribe, v

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1793: only update lbm container bookkeeping on success .. KUDU-1793: only update lbm container bookkeeping on success This patch reverts part of comm

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success .. Patch Set 4: Verified+1 Overriding Jenkins, failure was in leaving behind a tmp directory, most likel

[kudu-CR] [docs] - Fix python development section location

2016-12-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5414 Change subject: [docs] - Fix python development section location .. [docs] - Fix python development section location The Python Client

[kudu-CR] KUDU-1776: Fix "kudu remote replica copy" connecting to wildcard address

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1776: Fix "kudu remote_replica copy" connecting to wildcard address .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5378/2/src/kudu/integra

[kudu-CR] [python] - Add timeouts to Python unit tests

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [python] - Add timeouts to Python unit tests .. [python] - Add timeouts to Python unit tests This patch adds a global 100 second timeout to all python uni

[kudu-CR] [python] - Add timeouts to Python unit tests

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [python] - Add timeouts to Python unit tests .. Patch Set 4: Code-Review+2 Verified+1 tested on el6, seems to work -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5045 To unsubscribe,

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5399 to look at the new patch set (#4). Change subject: KUDU-1793: only update lbm container bookkeeping on success .. K

[kudu-CR] [python] - Add timeouts to Python unit tests

2016-12-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: [python] - Add timeouts to Python unit tests .. Patch Set 4: No, i just wanted to make sure it didnt hate the SIGALRM -- To view, visit http://gerrit.clouder

[kudu-CR] KUDU-921. tablet copy: Make the StartTabletCopy() RPC async

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-921. tablet copy: Make the StartTabletCopy() RPC async .. KUDU-921. tablet copy: Make the StartTabletCopy() RPC async This patch changes tablet copy

[kudu-CR] python: fix py2.6 incompatibility in unixtime micros support

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: python: fix py2.6 incompatibility in unixtime_micros support .. python: fix py2.6 incompatibility in unixtime_micros support Python 2.6 doesn't have the t

[kudu-CR] python: fix py2.6 incompatibility in unixtime micros support

2016-12-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: python: fix py2.6 incompatibility in unixtime_micros support .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5409 To unsubscri

[kudu-CR] python: add workaround for multiprocessing atexit hook on py2.6

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: python: add workaround for multiprocessing atexit hook on py2.6 .. python: add workaround for multiprocessing atexit hook on py2.6 23cbc63387c066eff513a5a

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 32: (35 comments) http://gerrit.cloudera.org:8080/#/c/5240/32//COMMIT_MSG Commit Message: PS32, Line

[kudu-CR] python: add workaround for multiprocessing atexit hook on py2.6

2016-12-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: python: add workaround for multiprocessing atexit hook on py2.6 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5410 To unsubs

[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1780: Unshaded classes in kudu-client jar .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5413 To unsubscribe, visit http://g

[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1780: Unshaded classes in kudu-client jar .. Patch Set 3: Verified+1 build failed from pypi issues, java seemed find -- To view, visit http://gerrit.clouder

[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1780: Unshaded classes in kudu-client jar .. KUDU-1780: Unshaded classes in kudu-client jar * shade plugin relocates com.google.thirdparty to org.apa

[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar

2016-12-07 Thread Matt Dailey (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5413 to look at the new patch set (#3). Change subject: KUDU-1780: Unshaded classes in kudu-client jar .. K

[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar

2016-12-07 Thread Matt Dailey (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5413 to look at the new patch set (#2). Change subject: KUDU-1780: Unshaded classes in kudu-client jar .. KUDU-1780: Unsh

[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1780: Unshaded classes in kudu-client jar .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5413 To unsubscribe, visit http://g

[kudu-CR] KUDU-1780: Unshaded classes in kudu-client jar

2016-12-07 Thread Matt Dailey (Code Review)
Matt Dailey has uploaded a new change for review. http://gerrit.cloudera.org:8080/5413 Change subject: KUDU-1780: Unshaded classes in kudu-client jar .. KUDU-1780: Unshaded classes in kudu-client jar * shade plugin relocates

[kudu-CR] python: add workaround for multiprocessing atexit hook on py2.6

2016-12-07 Thread Todd Lipcon (Code Review)
Hello Jordan Birdsell, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5410 to look at the new patch set (#2). Change subject: python: add workaround for multiprocessing atexit hook on py2.6

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/5399/3/src/kudu/fs/block_manager-test.

[kudu-CR] python: add back multiprocessing as a test dependency

2016-12-07 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: python: add back multiprocessing as a test dependency .. Patch Set 1: Yea, I'd do a conditional. -- To view, visit http://gerrit.cloudera.org:8080/5410 To un

[kudu-CR] python: add back multiprocessing as a test dependency

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: python: add back multiprocessing as a test dependency .. Patch Set 1: hrm, apparently this breaks py3. Jordan, any thoughts? I guess we could conditionally add it

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1508: enforce block limit on lbm containers .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5403/2/src/kudu/fs/data_dirs.cc File src/kudu/fs

[kudu-CR] Enable rhel6 krb5 realm workaround for Java tests

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Enable rhel6 krb5 realm workaround for Java tests .. Enable rhel6 krb5 realm workaround for Java tests See b1d02ee1a6b45745df9668af52 for details. Change

[kudu-CR] KUDU-861 Support changing default, storage attributes

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-861 Support changing default, storage attributes .. KUDU-861 Support changing default, storage attributes This patch adds support for adding, changin

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 30: I won't address any more tidy bot nits that aren't part of the changes in this patch. Its

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#32). Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798 (pa

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 30: (1 comment) http://gerrit.cloudera.org:8080/#/c/5240/30/src/kudu/tserver/tablet_service.c

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#31). Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798 (pa

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/5399/3/src/kudu/fs/block_manager-test

[kudu-CR] log-rolling-itest: wait for the master on first start

2016-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: log-rolling-itest: wait for the master on first start .. log-rolling-itest: wait for the master on first start This should deflake the test completely. Ch

[kudu-CR] KUDU-1785. Fix potential crash in TabletCopySourceSession

2016-12-07 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession .. KUDU-1785. Fix potential crash in TabletCopySourceSession This patch fixes a crash in TabletCo

[kudu-CR] python: fix py2.6 incompatibility in unixtime micros support

2016-12-07 Thread Todd Lipcon (Code Review)
Hello Jordan Birdsell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5409 to review the following change. Change subject: python: fix py2.6 incompatibility in unixtime_micros support .. py

[kudu-CR] python: add back multiprocessing as a test dependency

2016-12-07 Thread Todd Lipcon (Code Review)
Hello Jordan Birdsell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5410 to review the following change. Change subject: python: add back multiprocessing as a test dependency .. python: a

[kudu-CR] KUDU-1785. Fix potential crash in TabletCopySourceSession

2016-12-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1785. Fix potential crash in TabletCopySourceSession .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5363/6/src/kudu/integration-tests/tablet_

[kudu-CR] [consensus] KUDU-1613: Fix replica eviction failure for WRONG SERVER UUID

2016-12-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [consensus] KUDU-1613: Fix replica eviction failure for WRONG_SERVER_UUID .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/5111/7/src/kudu/consens

[kudu-CR] Enable rhel6 krb5 realm workaround for Java tests

2016-12-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Enable rhel6 krb5 realm workaround for Java tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5408 To unsubscribe, visit http:

[kudu-CR] Enable rhel6 krb5 realm workaround for Java tests

2016-12-07 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5408 to review the following change. Change subject: Enable rhel6 krb5 realm workaround for Java tests .

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 28: (12 comments) http://gerrit.cloudera.org:8080/#/c/5240/27//COMMIT_MSG Commit Message: PS

[kudu-CR] log-rolling-itest: wait for the master on first start

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: log-rolling-itest: wait for the master on first start .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5407 To unsubscribe, visit h

[kudu-CR] log-rolling-itest: wait for the master on first start

2016-12-07 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5407 to review the following change. Change subject: log-rolling-itest: wait for the master on first start .. l

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#30). Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798 (pa

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5403 to look at the new patch set (#2). Change subject: KUDU-1508: enforce block limit on lbm containers .. KUDU-1508: e

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-in-scan test

2016-12-07 Thread Alexey Serbin (Code Review)
Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5345 to look at the new patch set (#7). Change subject: KUDU-1753 [delete_table-test] deleted-while-in-scan test ...

[kudu-CR] KUDU-1508: enforce block limit on lbm containers

2016-12-07 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5403 to review the following change. Change subject: KUDU-1508: enforce block limit on lbm containers .. KUDU-

[kudu-CR] KUDU-1753 [delete table-test] deleted-while-scanned test

2016-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [delete_table-test] deleted-while-scanned test .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/5345/6/src/kudu/integration-tests/dele

[kudu-CR] block manager: start using the file cache

2016-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: block manager: start using the file cache .. block manager: start using the file cache This commit integrates the file cache into both the file and log blo

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5240 to look at the new patch set (#29). Change subject: KUDU-798 (part 5) Correct safe time advancement .. KUDU-798 (pa

[kudu-CR] KUDU-1753 continue scan if tablet is being deleted

2016-12-07 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5346 to look at the new patch set (#6). Change subject: KUDU-1753 continue scan if tablet is being deleted .. KUDU-1753

[kudu-CR] KUDU-1753 [tablet service] continue scan request on deleted tablet

2016-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1753 [tablet_service] continue scan request on deleted tablet .. Patch Set 5: > > > Alexey, just thinking out loud here: Tablet not found in the > > JIRA

[kudu-CR] block manager: start using the file cache

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: block manager: start using the file cache .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5147 To unsubscribe, visit http://gerri

[kudu-CR] block manager: start using the file cache

2016-12-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5147 to look at the new patch set (#10). Change subject: block manager: start using the file cache .. block manager: sta

[kudu-CR] util: add file cache

2016-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: util: add file cache .. util: add file cache This commit introduces a new kind of cache: the file cache. Its purpose is to enforce an upper bound on the pr

[kudu-CR] block manager: start using the file cache

2016-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: block manager: start using the file cache .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/5147/9/src/kudu/fs/block_manager.cc File src/kudu/fs/blo

[kudu-CR] KUDU-1524. Add a workaround for unflushable large cells

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1524. Add a workaround for unflushable large cells .. Patch Set 1: ping -- To view, visit http://gerrit.cloudera.org:8080/5282 To unsubscribe, visit http://

[kudu-CR] block manager: start using the file cache

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: block manager: start using the file cache .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/5147/9/src/kudu/fs/block_manager.cc File src/kudu/fs/bl

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5399/1/src/kudu/fs/log_block_manager.c

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5399/1/src/kudu/fs/log_block_manager.

[kudu-CR] util: add file cache

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: util: add file cache .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5146 To unsubscribe, visit http://gerrit.cloudera.org:8080/s

[kudu-CR] KUDU-861 Support changing default, storage attributes

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-861 Support changing default, storage attributes .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4310 To unsubscribe, visit

[kudu-CR] KUDU-861 Support changing default, storage attributes

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-861 Support changing default, storage attributes .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/4310/17/src/kudu/cfile/rle_block.h File src

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5399 to look at the new patch set (#2). Change subject: KUDU-1793: only update lbm container bookkeeping on success .. K

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5399/1/src/kudu/fs/log_block_manager.c

[kudu-CR] KUDU-1753 [tablet service] continue scan request on deleted tablet

2016-12-07 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1753 [tablet_service] continue scan request on deleted tablet .. Patch Set 5: > > Alexey, just thinking out loud here: Tablet not found in the > JIRA > >

[kudu-CR] block manager: start using the file cache

2016-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: block manager: start using the file cache .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5147/4/src/kudu/fs/block_manager.cc File src/kudu/fs/blo

[kudu-CR] util: add file cache

2016-12-07 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5146 to look at the new patch set (#11). Change subject: util: add file cache .. util: add file cache This

[kudu-CR] block manager: start using the file cache

2016-12-07 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5147 to look at the new patch set (#9). Change subject: block manager: start using the file cache .. block manager: star

[kudu-CR] KUDU-1792 It is possible to overwrite range partitions

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1792 It is possible to overwrite range partitions .. KUDU-1792 It is possible to overwrite range partitions This fixes another bug (see KUDU-1750) in

[kudu-CR] Reduce default client tablet locations cache TTL

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Reduce default client tablet locations cache TTL .. Reduce default client tablet locations cache TTL This reduces the default client tablet locations cach

[kudu-CR] Reduce default client tablet locations cache TTL

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Reduce default client tablet locations cache TTL .. Patch Set 2: Code-Review+2 carrying over JD's +2 -- To view, visit http://gerrit.cloudera.org:8080/5397 To un

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5399/1/src/kudu/fs/log_block_manager.c

[kudu-CR] util: add file cache

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: util: add file cache .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/5146/10/src/kudu/util/file_cache-test.cc File src/kudu/util/file_cache-test

[kudu-CR] KUDU-1793: only update lbm container bookkeeping on success

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1793: only update lbm container bookkeeping on success .. Patch Set 1: (3 comments) This one is a little over my head, since I didn't follow the discussion a

[kudu-CR] util: add file cache

2016-12-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: util: add file cache .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/5146/10/src/kudu/util/file_cache-test.cc File src/kudu/util/file_cache-test.

[kudu-CR] KUDU-798 (part 5) Correct safe time advancement

2016-12-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-798 (part 5) Correct safe time advancement .. Patch Set 28: (2 comments) http://gerrit.cloudera.org:8080/#/c/5240/27//COMMIT_MSG Commit Message: PS27, Lin

[kudu-CR] block manager: start using the file cache

2016-12-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: block manager: start using the file cache .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5147/4/src/kudu/fs/block_manager.cc File src/kudu/fs/bl

  1   2   >