[kudu-CR] Create ConsensusMetadataManager

Mike Percy has posted comments on this change. Change subject: Create ConsensusMetadataManager .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7191/7/src/kudu/consensus/consensus_meta_manager.cc File src/kudu/c

[kudu-CR] Make ConsensusMetadata thread-safe

Hello David Ribeiro Alves, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6958 to look at the new patch set (#8). Change subject: Make ConsensusMetadata thread-safe .. Make C

[kudu-CR] Make ConsensusMetadata thread-safe

Hello David Ribeiro Alves, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6958 to look at the new patch set (#7). Change subject: Make ConsensusMetadata thread-safe .. Make C

[kudu-CR] Make ConsensusMetadata thread-safe

Mike Percy has posted comments on this change. Change subject: Make ConsensusMetadata thread-safe .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/6958/6/src/kudu/consensus/consensus_meta.h File src/kudu/consen

[kudu-CR] [java] KUDU-2013 re-acquire authn token if expired

Alexey Serbin has posted comments on this change. Change subject: [java] KUDU-2013 re-acquire authn token if expired .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7250/1/java/kudu-client/src/main/java/org/apa

[kudu-CR] [java] KUDU-2013 re-acquire authn token if expired

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7250 to look at the new patch set (#3). Change subject: [java] KUDU-2013 re-acquire authn token if expired .. [java] KUD

[kudu-CR] Use dynamic bind address for internal + external mini clusters

Hello Adar Dembo, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7274 to look at the new patch set (#6). Change subject: Use dynamic bind address for internal + external mini clusters ..

[kudu-CR] Use dynamic bind address for internal + external mini clusters

Mike Percy has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/7274/5/src/kudu/master/mini_master.

[kudu-CR] log block manager: do not fail block creation if truncate fails

Adar Dembo has posted comments on this change. Change subject: log block manager: do not fail block creation if truncate fails .. Patch Set 1: > seems reasonable. did you hit this in real life somehow? Nah, noticed it while re

[kudu-CR] Rename MiniClusterBase to MiniCluster

Mike Percy has submitted this change and it was merged. Change subject: Rename MiniClusterBase to MiniCluster .. Rename MiniClusterBase to MiniCluster Change-Id: I40273d6ca7ac5fdc4cf2a6de374d374fe86cbf36 Reviewed-on: http://ger

[kudu-CR] [java] KUDU-2013 re-acquire authn token if expired

Alexey Serbin has posted comments on this change. Change subject: [java] KUDU-2013 re-acquire authn token if expired .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7250/1/java/kudu-client/src/main/java/org/apa

[kudu-CR] log block manager: do not fail block creation if truncate fails

Todd Lipcon has posted comments on this change. Change subject: log block manager: do not fail block creation if truncate fails .. Patch Set 1: Code-Review+2 seems reasonable. did you hit this in real life somehow? -- To view

[kudu-CR] Create ConsensusMetadataManager

Todd Lipcon has posted comments on this change. Change subject: Create ConsensusMetadataManager .. Patch Set 7: (1 comment) just looked at the manager impl for starters http://gerrit.cloudera.org:8080/#/c/7191/7/src/kudu/cons

[kudu-CR] log block manager: do not fail block creation if truncate fails

Hello Anonymous Coward #314, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7312 to review the following change. Change subject: log block manager: do not fail block creation if truncate fails

[kudu-CR] Use dynamic bind address for internal + external mini clusters

Todd Lipcon has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/7274/5/src/kudu/master/mini_master

[kudu-CR] Rename MiniClusterBase to MiniCluster

Todd Lipcon has posted comments on this change. Change subject: Rename MiniClusterBase to MiniCluster .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7273 To unsubscribe, visit http://gerrit.clo

[kudu-CR] Simplify OpId/Timestamp assignment and make it atomic

Todd Lipcon has posted comments on this change. Change subject: Simplify OpId/Timestamp assignment and make it atomic .. Patch Set 8: (2 comments) need to look in more detail at the changes in consensus/ but some quicker ques

[kudu-CR] WIP KUDU-1943: Add BlockTransaction to Block Manager

Adar Dembo has posted comments on this change. Change subject: WIP KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 8: (33 comments) I reviewed everything outside the LBM, and then began reviewing the LBM changes

[kudu-CR] [java] separating Connection

Alexey Serbin has posted comments on this change. Change subject: [java] separating Connection .. Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/7146/13//COMMIT_MSG Commit Message: Line 11: The updated TabletC

[kudu-CR] [java] separating Connection

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7146 to look at the new patch set (#16). Change subject: [java] separating Connection .. [java] separating Connection T

[kudu-CR] Make ConsensusMetadata thread-safe

Todd Lipcon has posted comments on this change. Change subject: Make ConsensusMetadata thread-safe .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/6958/6/src/kudu/consensus/consensus_meta.h File src/kudu/conse

[kudu-CR] Make ConsensusMetadata thread-safe

Todd Lipcon has posted comments on this change. Change subject: Make ConsensusMetadata thread-safe .. Patch Set 6: Code-Review-1 -- To view, visit http://gerrit.cloudera.org:8080/6958 To unsubscribe, visit http://gerrit.cloude

[kudu-CR] Rename MiniClusterOptions to InternalMiniClusterOptions

Alexey Serbin has posted comments on this change. Change subject: Rename MiniClusterOptions to InternalMiniClusterOptions .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7287 To unsubscribe, vis

[kudu-CR] Rename MiniCluster to InternalMiniCluster

Mike Percy has submitted this change and it was merged. Change subject: Rename MiniCluster to InternalMiniCluster .. Rename MiniCluster to InternalMiniCluster Since we have ExternalMiniCluster, using InternalMiniCluster as a cl

[kudu-CR] server: consolidate tablet prepare pools

Todd Lipcon has submitted this change and it was merged. Change subject: server: consolidate tablet prepare pools .. server: consolidate tablet prepare pools Using the new serial token functionality available in ThreadPool, we

[kudu-CR] server: consolidate tablet prepare pools

Todd Lipcon has posted comments on this change. Change subject: server: consolidate tablet prepare pools .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7150 To unsubscribe, visit http://gerrit.

[kudu-CR] threadpool: per-token metrics

Todd Lipcon has submitted this change and it was merged. Change subject: threadpool: per-token metrics .. threadpool: per-token metrics This patch makes thread pool metrics configurable on a token by token basis. The idea is si

[kudu-CR] threadpool: per-token metrics

Todd Lipcon has posted comments on this change. Change subject: threadpool: per-token metrics .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7149 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR] consensus: consolidate Raft thread pools

Todd Lipcon has submitted this change and it was merged. Change subject: consensus: consolidate Raft thread pools .. consensus: consolidate Raft thread pools This patch consolidates the two thread pools used in Raft consensus:

[kudu-CR] consensus: consolidate Raft thread pools

Todd Lipcon has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6946 To unsubscribe, visit http://gerrit

[kudu-CR] [java] separating Connection

Dan Burkert has posted comments on this change. Change subject: [java] separating Connection .. Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/7146/13//COMMIT_MSG Commit Message: Line 11: The updated TabletCli

[kudu-CR] threadpool: new test for pools with no max threads

Todd Lipcon has posted comments on this change. Change subject: threadpool: new test for pools with no max_threads .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6945 To unsubscribe, visit htt

[kudu-CR] threadpool: token-based task sequencing

Todd Lipcon has submitted this change and it was merged. Change subject: threadpool: token-based task sequencing .. threadpool: token-based task sequencing This patch adds task sequencing to util/threadpool. Task sequencing all

[kudu-CR] threadpool: new test for pools with no max threads

Todd Lipcon has submitted this change and it was merged. Change subject: threadpool: new test for pools with no max_threads .. threadpool: new test for pools with no max_threads This test ensures that a pool created with effect

[kudu-CR] threadpool: token-based task sequencing

Todd Lipcon has posted comments on this change. Change subject: threadpool: token-based task sequencing .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6874 To unsubscribe, visit http://gerrit.

[kudu-CR] server: move apply pool into KuduServer

Todd Lipcon has submitted this change and it was merged. Change subject: server: move apply_pool into KuduServer .. server: move apply_pool into KuduServer The server-wide apply_pool was instantiated in two places: SysCatalogTa

[kudu-CR] KUDU-1863: improve overall safety of graceful server shutdown

Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1863: improve overall safety of graceful server shutdown .. KUDU-1863: improve overall safety of graceful server shutdown What exactly is a "safe" gr

[kudu-CR] server: move apply pool into KuduServer

Todd Lipcon has posted comments on this change. Change subject: server: move apply_pool into KuduServer .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6984 To unsubscribe, visit http://gerrit.

[kudu-CR] KUDU-1863: improve overall safety of graceful server shutdown

Todd Lipcon has posted comments on this change. Change subject: KUDU-1863: improve overall safety of graceful server shutdown .. Patch Set 4: Code-Review+2 I'll be amazed if this doesn't introduce test flakiness, but given we'r

[kudu-CR] kserver: introduce KuduServer class

Todd Lipcon has submitted this change and it was merged. Change subject: kserver: introduce KuduServer class .. kserver: introduce KuduServer class The kserver module (with the KuduServer class) is an abstraction that sits betw

[kudu-CR] [java] separating Connection

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7146 to look at the new patch set (#15). Change subject: [java] separating Connection .. [java] separating Connection T

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS .. KUDU-1929: [rpc] Allow using encrypted private keys for TLS * This patch adds a new flag fo

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

Sailesh Mukil has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS .. Patch Set 9: Code-Review+2 > Build Successful > > http://jenkins.kudu.apache.org/job/kudu-gerri

[kudu-CR] TabletReplica: Move Init() logic to Start()

Alexey Serbin has posted comments on this change. Change subject: TabletReplica: Move Init() logic to Start() .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7194 To unsubscribe, visit http://ge

[kudu-CR] Use dynamic bind address for internal + external mini clusters

Alexey Serbin has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7274 To unsubscri

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

Sailesh Mukil has uploaded a new patch set (#9). Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS .. KUDU-1929: [rpc] Allow using encrypted private keys for TLS * This patch adds a new flag for a "pass

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6635 to look at the new patch set (#9). Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7276 to look at the new patch set (#7). Change subject: [java] update dependencies and clean up some deprecate method usage ...

[kudu-CR] mini cluster: Test infrastructure improvements

Alexey Serbin has posted comments on this change. Change subject: mini cluster: Test infrastructure improvements .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6959/4/src/kudu/integration-tests/delete_tablet-i

[kudu-CR] mini cluster: Test infrastructure improvements

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6959 to look at the new patch set (#5). Change subject: mini cluster: Test infrastructure improvements .. mini cluster:

[kudu-CR] Create ConsensusMetadataManager

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7191 to look at the new patch set (#7). Change subject: Create ConsensusMetadataManager .. Create ConsensusMetadataManag

[kudu-CR] Rename MiniCluster to InternalMiniCluster

Mike Percy has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7272/2/src/kudu/integration-tests/internal_mini_cluster.h

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

Dan Burkert has posted comments on this change. Change subject: [java] update dependencies and clean up some deprecate method usage .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7276 To unsub

[kudu-CR] [java] Ensure the shaded packages are always in the same location

Dan Burkert has submitted this change and it was merged. Change subject: [java] Ensure the shaded packages are always in the same location .. [java] Ensure the shaded packages are always in the same location Currently when a m

[kudu-CR] Create ConsensusMetadataManager

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7191 to look at the new patch set (#6). Change subject: Create ConsensusMetadataManager .. Create ConsensusMetadataManag

[kudu-CR] Make ConsensusMetadata thread-safe

Mike Percy has posted comments on this change. Change subject: Make ConsensusMetadata thread-safe .. Patch Set 6: Verified+1 overriding flaky test -- To view, visit http://gerrit.cloudera.org:8080/6958 To unsubscribe, visit h

[kudu-CR] [java] Ensure the shaded packages are always in the same location

Dan Burkert has posted comments on this change. Change subject: [java] Ensure the shaded packages are always in the same location .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7305 To unsubsc

[kudu-CR] [java] remove unused scalamock dependency

Dan Burkert has posted comments on this change. Change subject: [java] remove unused scalamock dependency .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7292 To unsubscribe, visit http://gerrit

[kudu-CR] [java] remove unused scalamock dependency

Dan Burkert has submitted this change and it was merged. Change subject: [java] remove unused scalamock dependency .. [java] remove unused scalamock dependency Change-Id: I97005bd5211abd0b119373ec265b8e9d01b385cf Reviewed-on: h

[kudu-CR] [java] Ensure the shaded packages are always in the same location

Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7305 Change subject: [java] Ensure the shaded packages are always in the same location .. [java] Ensure the shaded packages are always in the s

[kudu-CR] [java] Ensure the shaded packages are always in the same location

Grant Henke has abandoned this change. Change subject: [java] Ensure the shaded packages are always in the same location .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7304 To unsubscribe, visit http://gerrit.

[kudu-CR] [java] Ensure the shaded packages are alway in the same location

Grant Henke has abandoned this change. Change subject: [java] Ensure the shaded packages are alway in the same location .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7302 To unsubscribe, visit http://gerrit.cl

[kudu-CR] [java] Ensure the shaded packages are always in the same location

Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7304 Change subject: [java] Ensure the shaded packages are always in the same location .. [java] Ensure the shaded packages are always in the s

[kudu-CR] [java] Ensure the shaded packages are alway in the same location

Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7302 Change subject: [java] Ensure the shaded packages are alway in the same location .. [java] Ensure the shaded packages are alway in the same

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

Grant Henke has posted comments on this change. Change subject: [java] update dependencies and clean up some deprecate method usage .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7276/5/java/kudu-client/src/

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7276 to look at the new patch set (#6). Change subject: [java] update dependencies and clean up some deprecate method usage

[kudu-CR] Make ConsensusMetadata thread-safe

David Ribeiro Alves has posted comments on this change. Change subject: Make ConsensusMetadata thread-safe .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6958 To unsubscribe, visit http://gerri

[kudu-CR] ConsensusMetadata::Create() should not overwrite an existing file

David Ribeiro Alves has posted comments on this change. Change subject: ConsensusMetadata::Create() should not overwrite an existing file .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7190 To

[kudu-CR] Rename MiniCluster to InternalMiniCluster

David Ribeiro Alves has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7272/2/src/kudu/integration-tests/internal_mini_

[kudu-CR] TabletReplica: Move Init() logic to Start()

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7194 to look at the new patch set (#4). Change subject: TabletReplica: Move Init() logic to Start() .. TabletReplica: Mo

[kudu-CR] Rename MiniClusterBase to MiniCluster

Alexey Serbin has posted comments on this change. Change subject: Rename MiniClusterBase to MiniCluster .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7273 To unsubscribe, visit http://gerrit.c

[kudu-CR] Rename MiniCluster to InternalMiniCluster

Alexey Serbin has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7272 To unsubscribe, visit http://gerr