[kudu-CR] WIP [consensus] adding/removing NON VOTER members

Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8138 to look at the new patch set (#3). Change subject: WIP [consensus] adding/removing NON_VOTER members

[kudu-CR] [webui] Allow custom response codes and headers

Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8141 to look at the new patch set (#5). Change subject: [webui] Allow custom response codes and headers ..

[kudu-CR] [webui] Allow custom response codes and headers

Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8141 ) Change subject: [webui] Allow custom response codes and headers .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/8141/

[kudu-CR] KUDU-2132 Error dropping columns renamed to old key column names

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8188 Change subject: KUDU-2132 Error dropping columns renamed to old key column names .. KUDU-2132 Error dropping columns renamed to old key c

[kudu-CR] [catalog manager] introduce replica selector

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8161 ) Change subject: [catalog manager] introduce replica selector .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8161/2/s

[kudu-CR] [catalog manager] introduce replica selector

Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8161 to look at the new patch set (#3). Change subject: [catalog manager] introduce replica selector ..

[kudu-CR] KUDU-2055 [part 4]: Coalesce hole punch for LBM

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8162 ) Change subject: KUDU-2055 [part 4]: Coalesce hole punch for LBM .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/8162/2/src/

[kudu-CR] KUDU-2055 [part 4]: Coalesce hole punch for LBM

Hello Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8162 to look at the new patch set (#3). Change subject: KUDU-2055 [part 4]: Coalesce hole punch for LBM .

[kudu-CR] mvcc: allow tablet shutdown without completing txs

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 15: > Patch Set 15: > > (1 comment) The behavior I saw b

[kudu-CR] mini-cluster: new module for the mini cluster implementations

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8173 ) Change subject: mini-cluster: new module for the mini cluster implementations .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cl

[kudu-CR] KUDU-2159 Add metric for upserts converted to updates

Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8177 to look at the new patch set (#2). Change subject: KUDU-2159 Add metric for upserts converted to updates ...

[kudu-CR] env-test: add NO FATALS to create file and create dir calls

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8178 ) Change subject: env-test: add NO_FATALS to create_file and create_dir calls .. env-test: add NO_FATALS to create_file and create_di

[kudu-CR] tool: add cluster shell action

Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7853 to look at the new patch set (#6). Change subject: tool: add cluster shell action

[kudu-CR] tool: add cluster shell action

Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7853 to look at the new patch set (#5). Change subject: tool: add cluster shell action

[kudu-CR] periodic: prevent runaway callback loops

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8116 ) Change subject: periodic: prevent runaway callback loops .. periodic: prevent runaway callback loops One of the key semantics of P

[kudu-CR] external mini cluster: don't pipe daemon subprocess stdout

Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8187 to review the following change. Change subject: external_mini_cluster: don't pipe daemon subprocess stdout ...

[kudu-CR] subprocess: some cosmetic changes

Hello Mike Percy, Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8157 to look at the new patch set (#4). Change subject: subprocess: some cosmetic changes ...

[kudu-CR] mini-cluster: new module for the mini cluster implementations

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8173 ) Change subject: mini-cluster: new module for the mini cluster implementations .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:808

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 3: (1 comment) http://gerrit.cl

[kudu-CR](branch-1.4.x) rpc: move ConnectionId to its own file

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8184 Change subject: rpc: move ConnectionId to its own file .. rpc: move ConnectionId to its own file This class was previously implemented i

[kudu-CR](branch-1.4.x) KUDU-2032 (part 2): propagate master hostnames into client

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8186 Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. KUDU-2032 (part 2): propagate master hostnames into client

[kudu-CR](branch-1.4.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8185 Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. KUDU-2032 (part 1): pass pre-resolution hostname in

[kudu-CR](branch-1.3.x) rpc: move ConnectionId to its own file

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8181 Change subject: rpc: move ConnectionId to its own file .. rpc: move ConnectionId to its own file This class was previously implemented i

[kudu-CR](branch-1.3.x) KUDU-2032 (part 2): propagate master hostnames into client

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8183 Change subject: KUDU-2032 (part 2): propagate master hostnames into client .. KUDU-2032 (part 2): propagate master hostnames into client

[kudu-CR](branch-1.3.x) KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8182 Change subject: KUDU-2032 (part 1): pass pre-resolution hostname into RPC proxies .. KUDU-2032 (part 1): pass pre-resolution hostname in

[kudu-CR] KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 ) Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction .. Patch Set 4: (1 comment) http://gerri

[kudu-CR] mini-cluster: new module for the mini cluster implementations

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8173 ) Change subject: mini-cluster: new module for the mini cluster implementations .. Patch Set 1: Code-Review+1 -- To view, visit http://ger

[kudu-CR] KUDU-2159 Add metric for upserts converted to updates

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8177 ) Change subject: KUDU-2159 Add metric for upserts converted to updates .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] env-test: add NO FATALS to create file and create dir calls

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8178 ) Change subject: env-test: add NO_FATALS to create_file and create_dir calls .. Patch Set 1: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] env-test: add NO FATALS to create file and create dir calls

Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8178 to review the following change. Change subject: env-test: add NO_FATALS to create_file and create_dir calls .. env-tes

[kudu-CR] env posix: add more failure cases to Walk

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8171 ) Change subject: env_posix: add more failure cases to Walk .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8171/3/src/kudu

[kudu-CR] periodic: add one-shot timers

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8130 ) Change subject: periodic: add one-shot timers .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8130/2/src/kudu/rpc/period

[kudu-CR] KUDU-2055 [part 4]: Coalesce hole punch for LBM

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8162 ) Change subject: KUDU-2055 [part 4]: Coalesce hole punch for LBM .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/8162/2/

[kudu-CR] KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8144 ) Change subject: KUDU-2055 [part 3]: Refactor BlockCreationTransaction and BlockDeletionTransaction .. Patch Set 4: (1 comment) http://g

[kudu-CR] periodic: prevent runaway callback loops

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8116 ) Change subject: periodic: prevent runaway callback loops .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080

[kudu-CR] KUDU-2159 Add metric for upserts converted to updates

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8177 Change subject: KUDU-2159 Add metric for upserts converted to updates .. KUDU-2159 Add metric for upserts converted to updates This adds

[kudu-CR] env posix: add more failure cases to Walk

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8171 ) Change subject: env_posix: add more failure cases to Walk .. Patch Set 3: > Patch Set 3: > > (1 comment) oh, just noticed this was alrea

[kudu-CR] env posix: add more failure cases to Walk

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8171 ) Change subject: env_posix: add more failure cases to Walk .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8171/3/src/kud

[kudu-CR] KUDU-1125: issue one catalog write per tablet report

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8090 ) Change subject: KUDU-1125: issue one catalog write per tablet report .. Patch Set 6: (10 comments) http://gerrit.cloudera.org:8080/#/c/8

[kudu-CR] [webui] Allow custom response codes and headers

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8141 ) Change subject: [webui] Allow custom response codes and headers .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/8141/4/

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 2: (1 comment) http://gerrit.c

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. catalog_manager: make ScopedTabletInfoCommitter generic

[kudu-CR] env posix: add more failure cases to Walk

Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8171 ) Change subject: env_posix: add more failure cases to Walk .. env_posix: add more failure cases to Walk The manpage for fts_read ha

[kudu-CR] [tests] de-flaking catalog manager tsk-itest

Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/8017 ) Change subject: [tests] de-flaking catalog_manager_tsk-itest .. Abandoned Since the fix for KUDU-2149 has been committed, this test became stabl

[kudu-CR] catalog manager: make ScopedTabletInfoCommitter generic

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8089 ) Change subject: catalog_manager: make ScopedTabletInfoCommitter generic .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] [catalog manager] introduce replica selector

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8161 ) Change subject: [catalog manager] introduce replica selector .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8161/2//COM

[kudu-CR] env posix: add more failure cases to Walk

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8171 ) Change subject: env_posix: add more failure cases to Walk .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/

[kudu-CR] mini-cluster: new module for the mini cluster implementations

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8173 ) Change subject: mini-cluster: new module for the mini cluster implementations .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:80

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 3: (1 comment) http://gerrit.c

[kudu-CR](branch-1.4.x) python: pin to cython 0.26.1

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8175 ) Change subject: python: pin to cython 0.26.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8175 To uns

[kudu-CR](branch-1.3.x) python: pin to cython 0.26.1

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8176 ) Change subject: python: pin to cython 0.26.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8176 To uns

[kudu-CR](branch-1.5.x) python: pin to cython 0.26.1

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8174 ) Change subject: python: pin to cython 0.26.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8174 To uns

[kudu-CR](branch-1.4.x) python: pin to cython 0.26.1

Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8175 Change subject: python: pin to cython 0.26.1 .. python: pin to cython 0.26.1 Some of our el6-based builds are running into an installation

[kudu-CR](branch-1.3.x) python: pin to cython 0.26.1

Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8176 Change subject: python: pin to cython 0.26.1 .. python: pin to cython 0.26.1 Some of our el6-based builds are running into an installation

[kudu-CR] python: pin to cython 0.26.1

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 ) Change subject: python: pin to cython 0.26.1 .. Patch Set 2: > Patch Set 2: > > Perhaps 1.3.x, 1.4.x, and 1.5.x, assuming they all cherry-

[kudu-CR](branch-1.5.x) python: pin to cython 0.26.1

Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8174 Change subject: python: pin to cython 0.26.1 .. python: pin to cython 0.26.1 Some of our el6-based builds are running into an installation

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 3: (1 comment) > I don't disagr

[kudu-CR] env posix: add more failure cases to Walk

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8171 ) Change subject: env_posix: add more failure cases to Walk .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8171/1/src/kudu

[kudu-CR] env posix: add more failure cases to Walk

Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8171 to look at the new patch set (#2). Change subject: env_posix: add more failure cases to Walk

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 2: (1 comment) http://gerrit.c

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 3: > Patch Set 2: > > (1 commen

[kudu-CR] python: pin to cython 0.26.1

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 ) Change subject: python: pin to cython 0.26.1 .. Patch Set 2: Perhaps 1.3.x, 1.4.x, and 1.5.x, assuming they all cherry-pick cleanly? we

[kudu-CR] mini-cluster: new module for the mini cluster implementations

Hello Mike Percy, Alexey Serbin, Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8173 to review the following change. Change subject: mini-cluster: new module for the mini cluster implementations ..

[kudu-CR] python: pin to cython 0.26.1

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 ) Change subject: python: pin to cython 0.26.1 .. Patch Set 2: > Patch Set 2: > > Should we backport this to past branches so that we can bu

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 2: (1 comment) http://gerrit.cl

[kudu-CR] WIP: Support non-voter in leader election

Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/8142 ) Change subject: WIP: Support non-voter in leader election .. Abandoned ok, marking this one abandoned -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] python: pin to cython 0.26.1

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 ) Change subject: python: pin to cython 0.26.1 .. Patch Set 2: Should we backport this to past branches so that we can build older python

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 2: (1 comment) http://gerrit.c

[kudu-CR] WIP: Pull StatusOr and related tests from protobuf

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8127 ) Change subject: WIP: Pull StatusOr and related tests from protobuf .. Patch Set 1: agreed we'd use pair or tuple for multi-out-param use