[kudu-CR] De-flake sentry tests

2018-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 ) Change subject: De-flake sentry tests .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11961/4/src/kudu/util/net/net_uti

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-12 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12075 to look at the new patch set (#2). Change subject: KUDU-2636: LBM supports deleting dead and full containers ...

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-12 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 1: (3 comments) Thanks for your comments.@adar http:

[kudu-CR] KUDU-683: unify C++ client-to-master retry logic

2018-12-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12002 ) Change subject: KUDU-683: unify C++ client-to-master retry logic .. Patch Set 5: (6 comments) just nits at this point from me http:/

[kudu-CR] De-flake sentry tests

2018-12-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 ) Change subject: De-flake sentry tests .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/mini-cluster/extern

[kudu-CR] De-flake sentry tests

2018-12-12 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11961 to look at the new patch set (#4). Change subject: De-flake sentry tests .. De-flake sentr

[kudu-CR] [sentry] add mini Sentry to the external mini cluster

2018-12-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11956 ) Change subject: [sentry] add mini Sentry to the external mini cluster .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/11956

[kudu-CR] KUDU-683: unify C++ client-to-master retry logic

2018-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12002 ) Change subject: KUDU-683: unify C++ client-to-master retry logic .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/12002/

[kudu-CR] [sentry] add mini Sentry to the external mini cluster

2018-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11956 ) Change subject: [sentry] add mini Sentry to the external mini cluster .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/11

[kudu-CR] [sentry] add mini Sentry to the external mini cluster

2018-12-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11956 ) Change subject: [sentry] add mini Sentry to the external mini cluster .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/1195

[kudu-CR] [sentry] add mini Sentry to the external mini cluster

2018-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11956 ) Change subject: [sentry] add mini Sentry to the external mini cluster .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] [Java] Add a Schema and Data Generator

2018-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12061 ) Change subject: [Java] Add a Schema and Data Generator .. [Java] Add a Schema and Data Generator This patch adds schema and data

[kudu-CR] [Java] Add a Schema and Data Generator

2018-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12061 ) Change subject: [Java] Add a Schema and Data Generator .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/1

[kudu-CR] [sentry] add mini Sentry to the external mini cluster

2018-12-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11956 ) Change subject: [sentry] add mini Sentry to the external mini cluster .. Patch Set 9: (17 comments) http://gerrit.cloudera.org:8080/#/c/119

[kudu-CR] [sentry] add mini Sentry to the external mini cluster

2018-12-12 Thread Hao Hao (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11956 to look at the new patch set (#9). Change subject: [sentry] add mini Sentry to the external mini cluster

[kudu-CR] [Java] Add a Schema and Data Generator

2018-12-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12061 ) Change subject: [Java] Add a Schema and Data Generator .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/12061/1//COMMIT

[kudu-CR] [Java] Upgrade dependencies

2018-12-12 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12076 ) Change subject: [Java] Upgrade dependencies .. [Java] Upgrade dependencies Upgrades the Java dependencies and Gradle versions.

[kudu-CR] [Java] Add a Schema and Data Generator

2018-12-12 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12061 to look at the new patch set (#2). Change subject: [Java] Add a Schema and Data Generator .. [Java] Add

[kudu-CR] [Java] Upgrade dependencies

2018-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12076 ) Change subject: [Java] Upgrade dependencies .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12076/1//COMMI

[kudu-CR] De-flake sentry tests

2018-12-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11961 ) Change subject: De-flake sentry tests .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11961/3/src/kudu/util/test_util.

[kudu-CR] java: add log4j.properties file to kudu-test-utils module

2018-12-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12040 ) Change subject: java: add log4j.properties file to kudu-test-utils module .. Patch Set 3: I am okay to have a single change adding the m

[kudu-CR] [sentry] Integrate AuthzProvider into CatalogManager

2018-12-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11797 ) Change subject: [sentry] Integrate AuthzProvider into CatalogManager .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] [Java] Upgrade dependencies

2018-12-12 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12076 Change subject: [Java] Upgrade dependencies .. [Java] Upgrade dependencies Upgrades the Java dependencies and Gradle versions. This patc

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR](gh-pages) Update libv8 version in Gemfile.lock

2018-12-12 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12072 ) Change subject: Update libv8 version in Gemfile.lock .. Patch Set 1: > Patch Set 1: > > Would be good to get some verification that thi

[kudu-CR](gh-pages) Update libv8 version in Gemfile.lock

2018-12-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12072 ) Change subject: Update libv8 version in Gemfile.lock .. Patch Set 1: Would be good to get some verification that this works on older ver

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

2018-12-12 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12075 Change subject: KUDU-2636: LBM supports deleting dead and full containers .. KUDU-2636: LBM supports deleting dead and full containers LBM sup