[kudu-CR] [java] Deflake TestKuduScanner.testDiffScan

2019-06-02 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13495 ) Change subject: [java] Deflake TestKuduScanner.testDiffScan .. [java] Deflake TestKuduScanner.testDiffScan I noticed a funny f

[kudu-CR] [java] Deflake TestKuduScanner.testDiffScan

2019-06-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13495 ) Change subject: [java] Deflake TestKuduScanner.testDiffScan .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[kudu-CR] [java] Fix ordering bug in AsyncKuduSession

2019-06-02 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13496 Change subject: [java] Fix ordering bug in AsyncKuduSession .. [java] Fix ordering bug in AsyncKuduSession AsyncKuduSession.testBatchEr

[kudu-CR] [java] Deflake TestKuduScanner.testDiffScan

2019-06-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13495 ) Change subject: [java] Deflake TestKuduScanner.testDiffScan .. Patch Set 2: Verified+1 When will the flakes end :'( -- To view, visi

[kudu-CR] [java] Deflake TestKuduScanner.testDiffScan

2019-06-02 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: [java] Deflake TestKuduScanner.testDiffScan .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13495 To unsubscribe, vis

[kudu-CR] [java] Deflake TestKuduScanner.testDiffScan

2019-06-02 Thread Will Berkeley (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13495 to look at the new patch set (#2). Change subject: [java] Deflake TestKuduScanner.testDiffScan .

[kudu-CR] [java] Deflake TestKuduScanner.testDiffScan

2019-06-02 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13495 Change subject: [java] Deflake TestKuduScanner.testDiffScan .. [java] Deflake TestKuduScanner.testDiffScan I noticed a funny failure in

[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)

2019-06-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 ) Change subject: KUDU-2791: TTL cache in DNS resolver (part 2) .. Patch Set 6: > Should we now remove the recommendation to use nscd fr

[kudu-CR] sentry: don't send requests for DATABASE/SERVER privileges

2019-06-02 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13494 ) Change subject: sentry: don't send requests for DATABASE/SERVER privileges .. Patch Set 2: Code-Review+1 (2 comments) LGTM, just one minor

[kudu-CR] sentry: add trace points

2019-06-02 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13493 ) Change subject: sentry: add trace points .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13493/1//COMMIT_MSG Commit Messag

[kudu-CR] [hms] Support repairing entries with invalid IDs

2019-06-02 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13492 ) Change subject: [hms] Support repairing entries with invalid IDs .. Patch Set 2: Code-Review+1 (1 comment) LGTM, just one minor issue. Than

[kudu-CR] sentry: don't send requests for DATABASE/SERVER privileges

2019-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13494 ) Change subject: sentry: don't send requests for DATABASE/SERVER privileges .. Patch Set 2: (1 comment) Just passing through. http://ger

[kudu-CR] [tablet] Support accurate count of rows

2019-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT_

[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)

2019-06-02 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 ) Change subject: KUDU-2791: TTL cache in DNS resolver (part 2) .. Patch Set 6: Should we now remove the recommendation to use nscd from t

[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)

2019-06-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13469 ) Change subject: KUDU-2791: TTL cache in DNS resolver (part 2) .. KUDU-2791: TTL cache in DNS resolver (part 2) This changelist

[kudu-CR] metrics: Add table name filter to JSON metrics

2019-06-02 Thread Yifan Zhang (Code Review)
Yifan Zhang has abandoned this change. ( http://gerrit.cloudera.org:8080/12467 ) Change subject: metrics: Add table name filter to JSON metrics .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/12467 To unsubscribe,

[kudu-CR] sentry: don't send requests for DATABASE/SERVER privileges

2019-06-02 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13494 to look at the new patch set (#2). Change subject: sentry: don't send requests for DATABASE/SERVER privileges ..

[kudu-CR] sentry: don't send requests for DATABASE/SERVER privileges

2019-06-02 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13494 to review the following change. Change subject: sentry: don't send requests for DATABASE/SERVER privileges

[kudu-CR] sentry: add trace points

2019-06-02 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13493 to review the following change. Change subject: sentry: add trace points .. sentry: add trace points Adds

[kudu-CR] [tablet] Support accurate count of rows

2019-06-02 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/13456/4//COMMIT_MSG

[kudu-CR] [tablet] Support accurate count of rows

2019-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 ) Change subject: [tablet] Support accurate count of rows .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT

[kudu-CR] KUDU-2829: Apply gcc 9x patch to lss dependency

2019-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13448 ) Change subject: KUDU-2829: Apply gcc 9x patch to lss dependency .. Patch Set 2: (1 comment) > I believe I still need to updated breakpad

[kudu-CR] KUDU-2770: Upgrade bison to 3.0.5

2019-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13446 ) Change subject: KUDU-2770: Upgrade bison to 3.0.5 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13446/2/thirdparty/do

[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)

2019-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 ) Change subject: KUDU-2791: TTL cache in DNS resolver (part 2) .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)

2019-06-02 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13469 to look at the new patch set (#5). Change subject: KUDU-2791: TTL cache in DNS resolver (part 2) .

[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)

2019-06-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 ) Change subject: KUDU-2791: TTL cache in DNS resolver (part 2) .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/13469/

[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)

2019-06-02 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13469 to look at the new patch set (#4). Change subject: KUDU-2791: TTL cache in DNS resolver (part 2) .

[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)

2019-06-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 ) Change subject: KUDU-2791: TTL cache in DNS resolver (part 2) .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/13469/

[kudu-CR] KUDU-2791: TTL cache in DNS resolver (part 2)

2019-06-02 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13469 to look at the new patch set (#3). Change subject: KUDU-2791: TTL cache in DNS resolver (part 2) .. KUD