[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-06-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 7: Code-Review+2 (1 comment) http://gerr

[kudu-CR](branch-1.17.x) [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN

2024-06-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21524 Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN .. [client-test] make ClearCacheAndConcurrentWor

[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN

2024-06-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21523 ) Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN .. [client-test] make ClearCacheAndConc

[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN

2024-06-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN

2024-06-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21523 ) Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN .. Patch Set 1: Verified+1 unrelated Java test

[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN

2024-06-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21523 ) Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN .. Patch Set 1: (1 comment) http://gerrit.clo

[kudu-CR] [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN

2024-06-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21523 Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN .. [client-test] make ClearCacheAndConcurrentWor

[kudu-CR] [fs] remove chromium Atomics from FS

2024-06-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21521 ) Change subject: [fs] remove chromium Atomics from FS .. [fs] remove chromium Atomics from FS Change-Id: Ie7ef778fd816ffa929166

[kudu-CR] [gitignore] ignore .qt, .qtc clangd, .vscode dirs

2024-06-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21522 Change subject: [gitignore] ignore .qt, .qtc_clangd, .vscode dirs .. [gitignore] ignore .qt, .qtc_clangd, .vscode dirs Change-Id: Ie263

[kudu-CR] [fs] remove chromium Atomics from FS

2024-06-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21521 Change subject: [fs] remove chromium Atomics from FS .. [fs] remove chromium Atomics from FS Change-Id: Ie7ef778fd816ffa929166c9621f31b

[kudu-CR] [rpc] remove last vestiges of chromium Atomics from RPC

2024-06-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21513 ) Change subject: [rpc] remove last vestiges of chromium Atomics from RPC .. [rpc] remove last vestiges of chromium Atomics from

[kudu-CR] [rpc] remove last vestiges of chromium Atomics from RPC

2024-06-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21513 ) Change subject: [rpc] remove last vestiges of chromium Atomics from RPC .. Patch Set 1: > Ah sorry for the noise then, thanks for the

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-06-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 8: > > Patch Set 8: Verified-1 > > > > Build Failed > > > > http://j

[kudu-CR] KUDU-613: Add SLRU Cache metrics

2024-06-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 8: (1 comment) > > Patch Set 8: Verified-1 > > > > Build Failed > >

[kudu-CR] Fix cache cleaning in dense node-itest

2024-06-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21509 ) Change subject: Fix cache cleaning in dense_node-itest .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/21509/1/src/k

[kudu-CR] KUDU-3567 Fix reource leak in AsyncKuduScanner

2024-06-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21512 ) Change subject: KUDU-3567 Fix reource leak in AsyncKuduScanner .. Patch Set 1: Verified+1 Unrelated test failures (TSAN) due to know f

[kudu-CR] [rpc] remove last vestiges of chromium Atomics from RPC

2024-06-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21513 Change subject: [rpc] remove last vestiges of chromium Atomics from RPC .. [rpc] remove last vestiges of chromium Atomics from RPC Chan

[kudu-CR] KUDU-3567 Fix reource leak in AsyncKuduScanner

2024-06-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3567 Fix reource leak in AsyncKuduScanner .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21512 To unsubscribe,

[kudu-CR] KUDU-3567 Fix reource leak in AsyncKuduScanner

2024-06-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21512 ) Change subject: KUDU-3567 Fix reource leak in AsyncKuduScanner .. KUDU-3567 Fix reource leak in AsyncKuduScanner To avoid reso

[kudu-CR] KUDU-3567 Fix reource leak in AsyncKuduScanner

2024-06-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21512 ) Change subject: KUDU-3567 Fix reource leak in AsyncKuduScanner .. Patch Set 1: Code-Review+2 Thanks a lot for the fix, Yifan! -- To

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 7: > (1 comment) It seems LogBlockManage

[kudu-CR] KUDU-3584 fix flakiness in TableKeyRangeTest

2024-06-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21506 ) Change subject: KUDU-3584 fix flakiness in TableKeyRangeTest .. KUDU-3584 fix flakiness in TableKeyRangeTest When running clie

[kudu-CR] KUDU-3584 fix flakiness in TableKeyRangeTest

2024-06-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21506 ) Change subject: KUDU-3584 fix flakiness in TableKeyRangeTest .. Patch Set 1: > Just to verify, I also ran the problematic test through

[kudu-CR] [util] remove last vestiges of chromium Atomics from metrics

2024-06-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21505 ) Change subject: [util] remove last vestiges of chromium Atomics from metrics .. [util] remove last vestiges of chromium Atomics

[kudu-CR] [util] remove last vestiges of chromium Atomics from metrics

2024-06-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21505 ) Change subject: [util] remove last vestiges of chromium Atomics from metrics .. Patch Set 1: (1 comment) Thank you for review! http:

[kudu-CR](branch-1.17.x) [ARM] Concurrent binary tree memory barriers fixed.

2024-06-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21499 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. [ARM] Concurrent binary tree memory barriers fixed. Tes

[kudu-CR] KUDU-3584 fix flakiness in TableKeyRangeTest

2024-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21506 Change subject: KUDU-3584 fix flakiness in TableKeyRangeTest .. KUDU-3584 fix flakiness in TableKeyRangeTest When running client-test i

[kudu-CR] [util] remove last vestiges of chromium Atomics from metrics

2024-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [util] remove last vestiges of chromium Atomics from metrics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21505 To

[kudu-CR] [util] remove last vestiges of chromium Atomics from metrics

2024-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21505 ) Change subject: [util] remove last vestiges of chromium Atomics from metrics .. Patch Set 1: Verified+1 unrelated test failures -- T

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. KUDU-613: Introduce SLRU cache This patch introduces the SLRU cache that has

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 22: Code-Review+2 > (4 comments) > > Created new SLRUHandle to mimic RLH

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 22: Verified+1 unrelated test failure in Java tests -- To view, visit ht

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-613: Introduce SLRU cache .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20607 To unsubscribe, visit http://ger

[kudu-CR] [util] remove last vestiges of chromium Atomics from metrics

2024-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21505 Change subject: [util] remove last vestiges of chromium Atomics from metrics .. [util] remove last vestiges of chromium Atomics from met

[kudu-CR] Include table UUID when using --show table info

2024-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21496 ) Change subject: Include table UUID when using --show_table_info .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21496

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 5: (2 comments) http://gerrit.cloudera.o

[kudu-CR](branch-1.17.x) [ARM] Concurrent binary tree memory barriers fixed.

2024-06-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21499 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 1: Verified+1 I verified the build is successful and

[kudu-CR](branch-1.17.x) [ARM] Concurrent binary tree memory barriers fixed.

2024-06-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21499 Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. [ARM] Concurrent binary tree memory barriers fixed. TestCBTree.T

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. [ARM] Concurrent binary tree memory barriers fixed. Tes

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR](branch-1.17.x) KUDU-3577 fix altering tables with custom hash schemas

2024-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21495 ) Change subject: KUDU-3577 fix altering tables with custom hash schemas .. Patch Set 1: Verified+1 Pre-commit check test failures are u

[kudu-CR](branch-1.17.x) KUDU-3577 fix altering tables with custom hash schemas

2024-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21495 ) Change subject: KUDU-3577 fix altering tables with custom hash schemas .. KUDU-3577 fix altering tables with custom hash schema

[kudu-CR] KUDU-3577 fix altering tables with custom hash schemas

2024-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21486 ) Change subject: KUDU-3577 fix altering tables with custom hash schemas .. KUDU-3577 fix altering tables with custom hash schema

[kudu-CR] KUDU-3577 fix altering tables with custom hash schemas

2024-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3577 fix altering tables with custom hash schemas .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21486 To unsub

[kudu-CR] KUDU-3577 fix altering tables with custom hash schemas

2024-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21486 ) Change subject: KUDU-3577 fix altering tables with custom hash schemas .. Patch Set 3: Verified+1 unrelated test failures -- To view

[kudu-CR] KUDU-3577 fix altering tables with custom hash schemas

2024-06-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21486 ) Change subject: KUDU-3577 fix altering tables with custom hash schemas .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#

[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21356 ) Change subject: [metrics] Add metrics for tablet copy op time .. [metrics] Add metrics for tablet copy op time Add server-leve

[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [metrics] Add metrics for tablet copy op time .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21356 To unsubscribe, v

[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-06-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21356 ) Change subject: [metrics] Add metrics for tablet copy op time .. Patch Set 14: Verified+1 unrelated test failures -- To view, visit

[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-06-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21356 ) Change subject: [metrics] Add metrics for tablet copy op time .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-06-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 20: Code-Review+1 (4 comments) Almost there. Just a few nits. http://ge

[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-06-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21356 ) Change subject: [metrics] Add metrics for tablet copy op time .. Patch Set 13: Code-Review+1 (2 comments) Just one tiny need and the

[kudu-CR] [build] bootstrap-dev-env.sh fix for ubuntu 22.04+

2024-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20559 ) Change subject: [build] bootstrap-dev-env.sh fix for ubuntu 22.04+ .. [build] bootstrap-dev-env.sh fix for ubuntu 22.04+ On Ub

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21447 ) Change subject: Add a benchmark for CBTree concurrent writes. .. Add a benchmark for CBTree concurrent writes. Before updating

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: Add a benchmark for CBTree concurrent writes. .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21447 To unsubscribe, v

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 ) Change subject: Add a benchmark for CBTree concurrent writes. .. Patch Set 8: Verified+1 unrelated test failures -- To view, visit h

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-06-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 ) Change subject: Add a benchmark for CBTree concurrent writes. .. Patch Set 8: > (2 comments) > > I think it is cleaner to add it to

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-06-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/20607/19/src/kudu/uti

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-05-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080/#/c/20607/19/src/kudu/ut

[kudu-CR] KUDU-613: Introduce SLRU cache

2024-05-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20607 ) Change subject: KUDU-613: Introduce SLRU cache .. Patch Set 19: (11 comments) First portion of comments: I'm going to post the second

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-05-31 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 3: (1 comment) http://gerrit.cloudera.or

[kudu-CR] KUDU-1261 Java client complex type introduction

2024-05-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20749 ) Change subject: KUDU-1261 Java client complex type introduction .. Patch Set 4: (6 comments) Just a few high-level comments after tak

[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-05-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21356 ) Change subject: [metrics] Add metrics for tablet copy op time .. Patch Set 11: (7 comments) It seems the measured tablet copy duratio

[kudu-CR] KUDU-1261 Java client complex type introduction

2024-05-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20749 ) Change subject: KUDU-1261 Java client complex type introduction .. Patch Set 4: (1 comment) Just a first quick look; I'm going to tak

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-05-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 14: > (7 comments) > > I updated the review. No mor

[kudu-CR] [ARM] Concurrent binary tree memory barriers fixed.

2024-05-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 ) Change subject: [ARM] Concurrent binary tree memory barriers fixed. .. Patch Set 14: Code-Review+1 Overall looks good to me! Maybe ju

[kudu-CR] [metrics] Add metrics for tablet copy op time

2024-05-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21356 ) Change subject: [metrics] Add metrics for tablet copy op time .. Patch Set 10: (7 comments) Almost there! Just a few nits. http://g

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

2024-05-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 1: (1 comment) http://gerrit.cloudera.or

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

2024-05-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 4: Code-Review+1 -- To view, visit http:

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 ) Change subject: Add a benchmark for CBTree concurrent writes. .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:80

[kudu-CR](branch-1.17.x) KUDU-3581: upgrade Netty to 4.1.110.Final

2024-05-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21465 ) Change subject: KUDU-3581: upgrade Netty to 4.1.110.Final .. Patch Set 2: Verified+1 Unrelated test failures, where ASAN reported warn

[kudu-CR](branch-1.17.x) KUDU-3581: upgrade Netty to 4.1.110.Final

2024-05-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21465 ) Change subject: KUDU-3581: upgrade Netty to 4.1.110.Final .. KUDU-3581: upgrade Netty to 4.1.110.Final Even if Kudu doesn't us

[kudu-CR](branch-1.17.x) KUDU-3581: upgrade Netty to 4.1.110.Final

2024-05-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21465 Change subject: KUDU-3581: upgrade Netty to 4.1.110.Final .. KUDU-3581: upgrade Netty to 4.1.110.Final Even if Kudu doesn't use anythin

[kudu-CR] KUDU-3581: upgrade Netty to 4.1.110.Final

2024-05-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21464 ) Change subject: KUDU-3581: upgrade Netty to 4.1.110.Final .. KUDU-3581: upgrade Netty to 4.1.110.Final Even if Kudu doesn't us

[kudu-CR] KUDU-3581: upgrade Netty to 4.1.110.Final

2024-05-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21464 ) Change subject: KUDU-3581: upgrade Netty to 4.1.110.Final .. Patch Set 1: Verified+1 unrelated test failure (TSAN): org.apache.kudu.cl

[kudu-CR] KUDU-3581: upgrade Netty to 4.1.110.Final

2024-05-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21464 Change subject: KUDU-3581: upgrade Netty to 4.1.110.Final .. KUDU-3581: upgrade Netty to 4.1.110.Final Even if Kudu doesn't use anythin

[kudu-CR] KUDU-2671: Update upstream docs

2024-05-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21108 ) Change subject: KUDU-2671: Update upstream docs .. KUDU-2671: Update upstream docs This patch updates the upstream docs to inc

[kudu-CR] KUDU-2671: Update upstream docs

2024-05-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21108 ) Change subject: KUDU-2671: Update upstream docs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21108

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-28 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 ) Change subject: Add a benchmark for CBTree concurrent writes. .. Patch Set 6: It seems IWYU isn't happy yet: >>> Fixing #includes in

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 ) Change subject: Add a benchmark for CBTree concurrent writes. .. Patch Set 4: Code-Review+1 (4 comments) Almost there, just a few nit

[kudu-CR] [metrics] Add tablet level metrics for scans op time

2024-05-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21291 ) Change subject: [metrics] Add tablet level metrics for scans op time .. [metrics] Add tablet level metrics for scans op time W

[kudu-CR] [metrics] Add tablet level metrics for scans op time

2024-05-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21291 ) Change subject: [metrics] Add tablet level metrics for scans op time .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] [metrics] Add tablet level metrics for scans op time

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21291 ) Change subject: [metrics] Add tablet level metrics for scans op time .. Patch Set 5: Code-Review+1 (12 comments) Almost there, just a

[kudu-CR](branch-1.17.x) Fix row project codegen params noalias overflow

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21448 ) Change subject: Fix row_project codegen params noalias overflow .. Fix row_project codegen params noalias overflow function->a

[kudu-CR](branch-1.17.x) Fix row project codegen params noalias overflow

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21448 ) Change subject: Fix row_project codegen params noalias overflow .. Patch Set 2: > By the way, I think kudu codegen sometimes not flexi

[kudu-CR](branch-1.17.x) Fix row project codegen params noalias overflow

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: Fix row_project codegen params noalias overflow .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21448 To unsubscribe,

[kudu-CR](branch-1.17.x) Fix row project codegen params noalias overflow

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21448 ) Change subject: Fix row_project codegen params noalias overflow .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR](branch-1.17.x) Fix row project codegen params noalias overflow

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21448 ) Change subject: Fix row_project codegen params noalias overflow .. Patch Set 2: Verified+1 unrelated test failures -- To view, visit

[kudu-CR] Add a benchmark for CBTree concurrent writes.

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21447 ) Change subject: Add a benchmark for CBTree concurrent writes. .. Patch Set 1: Code-Review+1 (15 comments) http://gerrit.cloudera.org:

[kudu-CR](branch-1.17.x) Fix deadlock on fail for CBTree-test

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21451 ) Change subject: Fix deadlock on fail for CBTree-test .. Fix deadlock on fail for CBTree-test When TestConcurrentIterateAndInse

[kudu-CR](branch-1.17.x) Fix deadlock on fail for CBTree-test

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: Fix deadlock on fail for CBTree-test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21451 To unsubscribe, visit http

[kudu-CR](branch-1.17.x) Fix deadlock on fail for CBTree-test

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21451 ) Change subject: Fix deadlock on fail for CBTree-test .. Patch Set 1: Verified+1 unrelated test failures due to: * somewhat polluted

[kudu-CR](branch-1.17.x) Fix deadlock on fail for CBTree-test

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21451 Change subject: Fix deadlock on fail for CBTree-test .. Fix deadlock on fail for CBTree-test When TestConcurrentIterateAndInsert, TestC

[kudu-CR] Fix deadlock on fail for CBTree-test

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21446 ) Change subject: Fix deadlock on fail for CBTree-test .. Fix deadlock on fail for CBTree-test When TestConcurrentIterateAndInse

[kudu-CR] Fix deadlock on fail for CBTree-test

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21446 ) Change subject: Fix deadlock on fail for CBTree-test .. Patch Set 4: Verified+1 unrelated test failures -- To view, visit http://ger

[kudu-CR] Fix deadlock on fail for CBTree-test

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21446 ) Change subject: Fix deadlock on fail for CBTree-test .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Fix deadlock on fail for CBTree-test

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: Fix deadlock on fail for CBTree-test .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21446 To unsubscribe, visit http

[kudu-CR] Fix row project codegen params noalias overflow

2024-05-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19952 ) Change subject: Fix row_project codegen params noalias overflow .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/19952

[kudu-CR](branch-1.17.x) Fix row project codegen params noalias overflow

2024-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21448 Change subject: Fix row_project codegen params noalias overflow .. Fix row_project codegen params noalias overflow function->addParamAt

[kudu-CR] Fix row project codegen params noalias overflow

2024-05-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19952 ) Change subject: Fix row_project codegen params noalias overflow .. Patch Set 4: Code-Review+2 Thanks a lot for the patch! I was clean

<    1   2   3   4   5   6   7   8   9   10   >